https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159 --- Comment #1 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 77487 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77487&action=edit Bug 21159 - Implementing 2 sysprefs to enable blanking location This patch introduces two new system preferences: BlankingShelvingLocationOnIssue and BlankingShelvingLocationOnReturn. By default both are off. If BlankingShelvingLocationOnIssue is enabled then when an item is issued it's shelving location 952$c field will be set to '' in C4::Items->BlankShelvingLocation() If BlankingShelvingLocationOnReturn is enabled then when an item is returned it's shelving location field will be set to '' in C4::Items->BlankShelvingLocation(). t/db_dependent/Circulation/issue.t contains tests for BlankShelvingLocationOnIssue t/db_dependen/Circulation/Returns.t contains tests for BlankShelvingLocationOnReturn Test plan: 1. Create a new biblio and associated item and set the value of the shelving location for the item to 'CART' 2. Checkout the item to a user and notice that the status does not change 3. Apply patch, and run ./updatedatabase.pl inside the koha shell 4. Now return the checked out item (when you updated the database you added two new sysprefs: BlankShelvingLocationOnIssue and BlankShelvingLocationOnReturn both of which are off by default) 5. Notice the shelving location has not changed, showing with the BlankShelvingLocationOnReturn syspref not enabled the shelving location is not changed upon return 6. Check the item out again and notice the shelving location is not changed, showing that when the BlankShelvingLocationOnIssue is not enabled the shelving location is not changed upon issue. 7. Enable both aforementioned sysprefs in the Administration->Global system preferences->Circulation interface 8. Return the item and notice the Shelving location has changed from 'Cart' to no value, showing when the BlankShelvingLocationOnReturn syspref is enabled it blanks the shelving location value on the return of the item 9. Edit the item changing the shelving location back to 'Shelving Trolley'(CART) 10. Check out the item and notice the shelving location is changed to no value, showing when the BlankShelvingLocationOnIssue syspref is enabled it blanks the shelving location on the issue of an item. 11. Run t/db_dependent/Circulation/Returns.t 12. Run t/db_dependent/Circulation/issue.t Sponsored-By: Toi Ohomai Institute of Technology, New Zealand -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159 --- Comment #2 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 77549 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77549&action=edit Bug 21159 - Implementing 2 sysprefs to enable blanking location This patch introduces two new system preferences: BlankingShelvingLocationOnIssue and BlankingShelvingLocationOnReturn. By default both are off. If BlankingShelvingLocationOnIssue is enabled then when an item is issued it's shelving location 952$c field will be set to '' in C4::Items->BlankShelvingLocation() If BlankingShelvingLocationOnReturn is enabled then when an item is returned it's shelving location field will be set to '' in C4::Items->BlankShelvingLocation(). t/db_dependent/Circulation/issue.t contains tests for BlankShelvingLocationOnIssue t/db_dependen/Circulation/Returns.t contains tests for BlankShelvingLocationOnReturn Test plan: 1. Create a new biblio and associated item and set the value of the shelving location for the item to 'CART' 2. Checkout the item to a user and notice that the status does not change 3. Apply patch, and run ./updatedatabase.pl inside the koha shell 4. Now return the checked out item (when you updated the database you added two new sysprefs: BlankShelvingLocationOnIssue and BlankShelvingLocationOnReturn both of which are off by default) 5. Notice the shelving location has not changed, showing with the BlankShelvingLocationOnReturn syspref not enabled the shelving location is not changed upon return 6. Check the item out again and notice the shelving location is not changed, showing that when the BlankShelvingLocationOnIssue is not enabled the shelving location is not changed upon issue. 7. Enable both aforementioned sysprefs in the Administration->Global system preferences->Circulation interface 8. Return the item and notice the Shelving location has changed from 'Cart' to no value, showing when the BlankShelvingLocationOnReturn syspref is enabled it blanks the shelving location value on the return of the item 9. Edit the item changing the shelving location back to 'Shelving Trolley'(CART) 10. Check out the item and notice the shelving location is changed to no value, showing when the BlankShelvingLocationOnIssue syspref is enabled it blanks the shelving location on the issue of an item. 11. Run t/db_dependent/Circulation/Returns.t 12. Run t/db_dependent/Circulation/issue.t Sponsored-By: Toi Ohomai Institute of Technology, New Zealand -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Alex, I think this might be kind of a partial duplicate to bug 14576 that allows arbitrary updates on the location field on checkin. I think if that makes it in, it would make BlankingShelvingLocationOnReturn obsolete. Maybe you could take a look and see if it fits your use case? The code might be reusable for checkout too. I'd also be interesting if the use case is CART on how this works different to the existing features: NewItemsDefaultLocation, ReturnToShelvingCart, InProcessingToShelvingCart -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77549|0 |1 is obsolete| | --- Comment #4 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 77594 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77594&action=edit Bug 21159 - Implementing 2 sysprefs to enable blanking location This patch introduces two new system preferences: BlankingShelvingLocationOnIssue and BlankingShelvingLocationOnReturn. By default both are off. If BlankingShelvingLocationOnIssue is enabled then when an item is issued it's shelving location 952$c field will be set to '' in C4::Items->BlankShelvingLocation() If BlankingShelvingLocationOnReturn is enabled then when an item is returned it's shelving location field will be set to '' in C4::Items->BlankShelvingLocation(). t/db_dependent/Circulation/issue.t contains tests for BlankShelvingLocationOnIssue t/db_dependen/Circulation/Returns.t contains tests for BlankShelvingLocationOnReturn Test plan: 1. Create a new biblio and associated item and set the value of the shelving location for the item to 'CART' 2. Checkout the item to a user and notice that the status does not change 3. Apply patch, and run ./updatedatabase.pl inside the koha shell 4. Now return the checked out item (when you updated the database you added two new sysprefs: BlankShelvingLocationOnIssue and BlankShelvingLocationOnReturn both of which are off by default) 5. Notice the shelving location has not changed, showing with the BlankShelvingLocationOnReturn syspref not enabled the shelving location is not changed upon return 6. Check the item out again and notice the shelving location is not changed, showing that when the BlankShelvingLocationOnIssue is not enabled the shelving location is not changed upon issue. 7. Enable both aforementioned sysprefs in the Administration->Global system preferences->Circulation interface 8. Return the item and notice the Shelving location has changed from 'Cart' to no value, showing when the BlankShelvingLocationOnReturn syspref is enabled it blanks the shelving location value on the return of the item 9. Edit the item changing the shelving location back to 'Shelving Trolley'(CART) 10. Check out the item and notice the shelving location is changed to no value, showing when the BlankShelvingLocationOnIssue syspref is enabled it blanks the shelving location on the issue of an item. 11. Run t/db_dependent/Circulation/Returns.t 12. Run t/db_dependent/Circulation/issue.t Sponsored-By: Toi Ohomai Institute of Technology, New Zealand -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |alexbuckley@catalyst.net.nz |ity.org | --- Comment #6 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Yup thanks Katrin looking now. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77594|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Depends on| |14576 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576 [Bug 14576] Allow arbitrary automatic update of location on checkin -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159 --- Comment #9 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 77859 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77859&action=edit Bug 21159 - Implementing syspref to enable blanking of item shelving location on issue. This patch builds upon the functionality implemented in bug 14576, by allowing library staff to automatically change the item shelving location of items which are circulated. In the case of this patch it automatically blanks the item shelving locations of items when they are issued if the BlankItemLocationOnCheckout syspref is enabled. t/db_dependent/Circulation/issue.t contains tests for BlankItemLocationOnCheckout. Test plan: 1. Create a new biblio and associated item and set the value of the shelving location for the item to 'CART' 2. Checkout the item to a user and notice that the status does not change 3. Apply patches on bug report 14576, and this patch, and run ./updatedatabase.pl inside the koha shell 4. Now return the checked out item (when you updated the database you added one new syspref: UpdateItemLocationOnCheckout which is off by default) 5. Check the item out again and notice the shelving location is not changed, showing that when the UpdateItemLocationOnCheckout is not enabled and the shelving location is not changed upon issue. 6. Enable the aforementioned syspref in the Administration->Global system preferences->Circulation interface 7. Check out the item and notice the shelving location is changed to no value, showing when the UpdateItemLocationOnCheckout syspref is enabled it blanks the shelving location on the issue of an item. 8. Run t/db_dependent/Circulation/issue.t Sponsored-By: Toi Ohomai Institute of Technology, New Zealand -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159 --- Comment #10 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 77869 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77869&action=edit Bug 21159 - Implementing syspref to enable blanking of item shelving location on issue. This patch builds upon the functionality implemented in bug 14576, by allowing library staff to automatically change the item shelving location of items which are circulated. In the case of this patch it automatically blanks the item shelving locations of items when they are issued if the BlankItemLocationOnCheckout syspref is enabled. t/db_dependent/Circulation/issue.t contains tests for BlankItemLocationOnCheckout. Test plan: 1. Create a new biblio and associated item and set the value of the shelving location for the item to 'CART' 2. Checkout the item to a user and notice that the status does not change 3. Apply patches on bug report 14576, and this patch, and run ./updatedatabase.pl inside the koha shell 4. Now return the checked out item (when you updated the database you added one new syspref: UpdateItemLocationOnCheckout which is off by default) 5. Check the item out again and notice the shelving location is not changed, showing that when the UpdateItemLocationOnCheckout is not enabled and the shelving location is not changed upon issue. 6. Enable the aforementioned syspref in the Administration->Global system preferences->Circulation interface 7. Check out the item and notice the shelving location is changed to no value, showing when the UpdateItemLocationOnCheckout syspref is enabled it blanks the shelving location on the issue of an item. 8. Run t/db_dependent/Circulation/issue.t Sponsored-By: Toi Ohomai Institute of Technology, New Zealand -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159 --- Comment #11 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 77870 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77870&action=edit Bug 21159 - Implementing syspref to enable blanking of item shelving location on issue. This patch builds upon the functionality implemented in bug 14576, by allowing library staff to automatically change the item shelving location of items which are circulated. In the case of this patch it automatically blanks the item shelving locations of items when they are issued if the BlankItemLocationOnCheckout syspref is enabled. t/db_dependent/Circulation/issue.t contains tests for BlankItemLocationOnCheckout. Test plan: 1. Create a new biblio and associated item and set the value of the shelving location for the item to 'CART' 2. Checkout the item to a user and notice that the status does not change 3. Apply patches on bug report 14576, and this patch, and run ./updatedatabase.pl inside the koha shell 4. Now return the checked out item (when you updated the database you added one new syspref: UpdateItemLocationOnCheckout which is off by default) 5. Check the item out again and notice the shelving location is not changed, showing that when the UpdateItemLocationOnCheckout is not enabled and the shelving location is not changed upon issue. 6. Enable the aforementioned syspref in the Administration->Global system preferences->Circulation interface 7. Check out the item and notice the shelving location is changed to no value, showing when the UpdateItemLocationOnCheckout syspref is enabled it blanks the shelving location on the issue of an item. 8. Run t/db_dependent/Circulation/issue.t Sponsored-By: Toi Ohomai Institute of Technology, New Zealand -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159 --- Comment #13 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 77871 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77871&action=edit Bug 21159 - Corrected typo Same test plan as first patch. Sponsored-By: Toi Ohomai Institute of Technology, New Zealand -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21174 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20678 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23@gmail.com, | |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77870|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159 --- Comment #16 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 80893 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80893&action=edit Bug 21159 - Corrected typo Same test plan as first patch. Sponsored-By: Toi Ohomai Institute of Technology, New Zealand -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80892|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159 --- Comment #18 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 80895 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80895&action=edit Bug 21159: Corrected typo Same test plan as first patch. Sponsored-By: Toi Ohomai Institute of Technology, New Zealand -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159 Brian <bklein@dubuque.lib.ia.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bklein@dubuque.lib.ia.us --- Comment #20 from Brian <bklein@dubuque.lib.ia.us> --- Any updates on bug 21159? Carnegie team -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159 Hayley Mapley <hayleymapley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80894|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159 --- Comment #21 from Hayley Mapley <hayleymapley@catalyst.net.nz> --- Created attachment 87037 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87037&action=edit Bug 21159 - Implementing 2 sysprefs to enable blanking location This patch introduces two new system preferences: BlankingShelvingLocationOnIssue and BlankingShelvingLocationOnReturn. By default both are off. If BlankingShelvingLocationOnIssue is enabled then when an item is issued it's shelving location 952$c field will be set to '' in C4::Items->BlankShelvingLocation() If BlankingShelvingLocationOnReturn is enabled then when an item is returned it's shelving location field will be set to '' in C4::Items->BlankShelvingLocation(). t/db_dependent/Circulation/issue.t contains tests for BlankShelvingLocationOnIssue t/db_dependen/Circulation/Returns.t contains tests for BlankShelvingLocationOnReturn Test plan: 1. Create a new biblio and associated item and set the value of the shelving location for the item to 'CART' 2. Checkout the item to a user and notice that the status does not change 3. Apply patch, and run ./updatedatabase.pl inside the koha shell 4. Now return the checked out item (when you updated the database you added two new sysprefs: BlankShelvingLocationOnIssue and BlankShelvingLocationOnReturn both of which are off by default) 5. Notice the shelving location has not changed, showing with the BlankShelvingLocationOnReturn syspref not enabled the shelving location is not changed upon return 6. Check the item out again and notice the shelving location is not changed, showing that when the BlankShelvingLocationOnIssue is not enabled the shelving location is not changed upon issue. 7. Enable both aforementioned sysprefs in the Administration->Global system preferences->Circulation interface 8. Return the item and notice the Shelving location has changed from 'Cart' to no value, showing when the BlankShelvingLocationOnReturn syspref is enabled it blanks the shelving location value on the return of the item 9. Edit the item changing the shelving location back to 'Shelving Trolley'(CART) 10. Check out the item and notice the shelving location is changed to no value, showing when the BlankShelvingLocationOnIssue syspref is enabled it blanks the shelving location on the issue of an item. 11. Run t/db_dependent/Circulation/Returns.t 12. Run t/db_dependent/Circulation/issue.t Sponsored-By: Toi Ohomai Institute of Technology, New Zealand -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159 --- Comment #23 from Hayley Mapley <hayleymapley@catalyst.net.nz> --- Created attachment 87041 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87041&action=edit Bug 21159: (follow up) Fixed broken indentation in circulation. pref Test plan: Same as comment 21. Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159 --- Comment #26 from Liz Rea <wizzyrea@gmail.com> --- Hi Hayley, Cool, I"ll test it and if it looks all good will see if I can't get the right commit message into the patch. :) Thanks for clearing that up! Cheers, Liz -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159 --- Comment #28 from Liz Rea <wizzyrea@gmail.com> --- Created attachment 87694 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87694&action=edit Bug 21159 - Corrected typo Same test plan as first patch. Sponsored-By: Toi Ohomai Institute of Technology, New Zealand https://bugs.koha-community.org/show_bug.cgi?id=18888 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159 --- Comment #30 from Liz Rea <wizzyrea@gmail.com> --- Well that commit message is slightly closer anyway. I'll fix it again when I sign it off lol. Liz -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159 --- Comment #33 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Hayley and Alex, bug 14576 was pushed now and I think it would make sense to have a look and make both checkout and checkin features match in functionality. I am a little worried about the blanking. Usually when CART is used you don't want to blank, but to set back to 'permanent location' (that can be blank if none was assigned before). There seems to be some mismatch here, as we still have BlankShelvingLocation but then also UpdateItemLocationOnCheckout. I feel like this needs a bit more work. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159 Bug 21159 depends on bug 14576, which changed state. Bug 14576 Summary: Allow automatic update of location on checkin https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87693|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87695|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159 --- Comment #36 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 139098 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139098&action=edit Bug 21159: Template and yaml changes Sponsored-by: Toi Ohomai Institute of Technology, New Zealand -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139099|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159 --- Comment #38 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 139103 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139103&action=edit Bug 21159: Template and yaml changes Sponsored-by: Toi Ohomai Institute of Technology, New Zealand -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159 --- Comment #40 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 139105 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139105&action=edit Bug 21159: Update item location on checkout This patchset shifts the logic for changing the item location on checkin (controlled by the UpdateItemLocationOnCheckin system preference) to a new subroutine in Koha/Items.pm That subroutine logic is shared with the UpdateItemLocationOnCheckout system preference. Test plan: 1. Apply patches, update databases and restart services 2. Set the following system preferences: - UpdateItemLocationOnCheckin: FIC: PROC - UpdateItemLocationOnCheckout: PROC: FIC 3. Checkout an an item with items.location = 'PROC'. Observe it's location is changed to 'FIC' 4. Return the item. Observe it's location is changed to 'PROC' 5. Change UpdateItemLocationOnCheckout to: PROC: _BLANK_ 6. Issue the item with items.location = 'PROC' and confirm it's location is blanked on checkout 7. Issue and return an item with a different location e.g. 'CART'. Observe the location does not change on issue or return. Sponsored-by: Toi Ohomai Institute of Technology, New Zealand -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159 --- Comment #41 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 139106 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139106&action=edit Bug 21159: Update item location on checkout This patchset shifts the logic for changing the item location on checkin (controlled by the UpdateItemLocationOnCheckin system preference) to a new subroutine in Koha/Items.pm That subroutine logic is shared with the UpdateItemLocationOnCheckout system preference. Test plan: 1. Apply patches, update databases and restart services 2. Set the following system preferences: - UpdateItemLocationOnCheckin: FIC: PROC - UpdateItemLocationOnCheckout: PROC: FIC 3. Checkout an an item with items.location = 'PROC'. Observe it's location is changed to 'FIC' 4. Return the item. Observe it's location is changed to 'PROC' 5. Change UpdateItemLocationOnCheckout to: PROC: _BLANK_ 6. Issue the item with items.location = 'PROC' and confirm it's location is blanked on checkout 7. Issue and return an item with a different location e.g. 'CART'. Observe the location does not change on issue or return. Sponsored-by: Toi Ohomai Institute of Technology, New Zealand -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139106|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159 --- Comment #42 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 139107 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139107&action=edit Bug 21159: Template and yaml changes Sponsored-By: Toi Ohomai Institute of Technology, New Zealand -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored Status|ASSIGNED |Needs Signoff --- Comment #44 from Alex Buckley <alexbuckley@catalyst.net.nz> --- The amended patches add a new system preference UpdateItemLocationOnCheckout. This syspref shares the same logic with UpdateItemLocationOnCheckin. This logic has been moved to a shared subroutine Koha::Item->update_item_location() This means rather than being limited to blanking shelving locations on checkout, librarians can now alter shelving locations in the same way on check-in and checkout. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159 --- Comment #45 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 139109 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139109&action=edit Bug 21159: Update item location on checkout This patchset shifts the logic for changing the item location on checkin (controlled by the UpdateItemLocationOnCheckin system preference) to a new subroutine in Koha/Items.pm That subroutine logic is shared with the UpdateItemLocationOnCheckout system preference. Test plan: 1. Apply patches, update databases and restart services 2. Set the following system preferences: - UpdateItemLocationOnCheckin: FIC: PROC - UpdateItemLocationOnCheckout: PROC: FIC 3. Checkout an an item with items.location = 'PROC'. Observe it's location is changed to 'FIC' 4. Return the item. Observe it's location is changed to 'PROC' 5. Change UpdateItemLocationOnCheckout to: PROC: _BLANK_ 6. Issue the item with items.location = 'PROC' and confirm it's location is blanked on checkout 7. Issue and return an item with a different location e.g. 'CART'. Observe the location does not change on issue or return. 8. Run unit tests sudo koha-shell kohadev prove t/db_dependent/Circulation/issue.t Sponsored-by: Toi Ohomai Institute of Technology, New Zealand -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159 --- Comment #46 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 139220 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139220&action=edit Bug 21159: (follow-up) Removing tab spaces Sponsored-by: Toi Ohomai Institute of Technology, New Zealand -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139220|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139107|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159 --- Comment #48 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 146602 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146602&action=edit Bug 21159: Database changes Sponsored-by: Toi Ohomai Institute of Technology, New Zealand -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159 --- Comment #50 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 146604 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146604&action=edit Bug 21159: Update item location on checkout This patchset shifts the logic for changing the item location on checkin (controlled by the UpdateItemLocationOnCheckin system preference) to a new subroutine in Koha/Items.pm That subroutine logic is shared with the UpdateItemLocationOnCheckout system preference. Test plan: 1. Apply patches, update databases and restart services 2. Set the following system preferences: - UpdateItemLocationOnCheckin: FIC: PROC - UpdateItemLocationOnCheckout: PROC: FIC 3. Checkout an an item with items.location = 'PROC'. Observe it's location is changed to 'FIC' 4. Return the item. Observe it's location is changed to 'PROC' 5. Change UpdateItemLocationOnCheckout to: PROC: _BLANK_ 6. Issue the item with items.location = 'PROC' and confirm it's location is blanked on checkout 7. Issue and return an item with a different location e.g. 'CART'. Observe the location does not change on issue or return. 8. Run unit tests sudo koha-shell kohadev prove t/db_dependent/Circulation/issue.t Sponsored-by: Toi Ohomai Institute of Technology, New Zealand -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146603|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159 --- Comment #51 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 146605 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146605&action=edit Bug 21159: Database changes Sponsored-by: Toi Ohomai Institute of Technology, New Zealand -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159 --- Comment #53 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 146607 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146607&action=edit Bug 21159: Update item location on checkout This patchset shifts the logic for changing the item location on checkin (controlled by the UpdateItemLocationOnCheckin system preference) to a new subroutine in Koha/Items.pm That subroutine logic is shared with the UpdateItemLocationOnCheckout system preference. Test plan: 1. Apply patches, update databases and restart services 2. Set the following system preferences: - UpdateItemLocationOnCheckin: FIC: PROC - UpdateItemLocationOnCheckout: PROC: FIC 3. Checkout an an item with items.location = 'PROC'. Observe it's location is changed to 'FIC' 4. Return the item. Observe it's location is changed to 'PROC' 5. Change UpdateItemLocationOnCheckout to: PROC: _BLANK_ 6. Issue the item with items.location = 'PROC' and confirm it's location is blanked on checkout 7. Issue and return an item with a different location e.g. 'CART'. Observe the location does not change on issue or return. 8. Run unit tests sudo koha-shell kohadev prove t/db_dependent/Circulation/issue.t Sponsored-by: Toi Ohomai Institute of Technology, New Zealand -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #55 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Rebased against master and ready to test again -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146608|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146606|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159 --- Comment #57 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 154147 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154147&action=edit Bug 21159: Database changes Sponsored-by: Toi Ohomai Institute of Technology, New Zealand -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159 --- Comment #59 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 154149 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154149&action=edit Bug 21159: Update item location on checkout This patchset shifts the logic for changing the item location on checkin (controlled by the UpdateItemLocationOnCheckin system preference) to a new subroutine in Koha/Items.pm That subroutine logic is shared with the UpdateItemLocationOnCheckout system preference. Test plan: 1. Apply patches, update databases and restart services 2. Set the following system preferences: - UpdateItemLocationOnCheckin: FIC: PROC - UpdateItemLocationOnCheckout: PROC: FIC 3. Checkout an an item with items.location = 'PROC'. Observe it's location is changed to 'FIC' 4. Return the item. Observe it's location is changed to 'PROC' 5. Change UpdateItemLocationOnCheckout to: PROC: _BLANK_ 6. Issue the item with items.location = 'PROC' and confirm it's location is blanked on checkout 7. Issue and return an item with a different location e.g. 'CART'. Observe the location does not change on issue or return. 8. Run unit tests sudo koha-shell kohadev prove t/db_dependent/Circulation/issue.t Sponsored-by: Toi Ohomai Institute of Technology, New Zealand -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #61 from Alex Buckley <alexbuckley@catalyst.net.nz> --- (In reply to Laura Escamilla from comment #56)

Applying: Bug 21159: Database changes Using index info to reconstruct a base tree... M installer/data/mysql/mandatory/sysprefs.sql Falling back to patching base and 3-way merge... Auto-merging installer/data/mysql/mandatory/sysprefs.sql Applying: Bug 21159: Template and yaml changes Applying: Bug 21159: Update item location on checkout Using index info to reconstruct a base tree... M C4/Circulation.pm M Koha/Item.pm M t/db_dependent/Circulation/issue.t Falling back to patching base and 3-way merge... Auto-merging t/db_dependent/Circulation/issue.t CONFLICT (content): Merge conflict in t/db_dependent/Circulation/issue.t Auto-merging Koha/Item.pm CONFLICT (content): Merge conflict in Koha/Item.pm Auto-merging C4/Circulation.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 21159: Update item location on checkout hint: Use 'git am --show-current-patch=diff' to see the failed patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-21159-Update-item-location-on-checkout-TimIX1.patch

Thanks for trying to test Laura. I've rebased against master, these patches should now apply cleanly. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154149|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159 --- Comment #63 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 154152 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154152&action=edit Bug 21159: (follow-up) Remove tab space Sponsored-by: Toi Ohomai Institute of Technology, New Zealand -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159 Sam Lau <samalau@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154151|0 |1 is obsolete| | --- Comment #66 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 155284 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155284&action=edit Bug 21159: Update item location on checkout This patchset shifts the logic for changing the item location on checkin (controlled by the UpdateItemLocationOnCheckin system preference) to a new subroutine in Koha/Items.pm That subroutine logic is shared with the UpdateItemLocationOnCheckout system preference. Test plan: 1. Apply patches, update databases and restart services 2. Set the following system preferences: - UpdateItemLocationOnCheckin: FIC: PROC - UpdateItemLocationOnCheckout: PROC: FIC 3. Checkout an an item with items.location = 'PROC'. Observe it's location is changed to 'FIC' 4. Return the item. Observe it's location is changed to 'PROC' 5. Change UpdateItemLocationOnCheckout to: PROC: _BLANK_ 6. Issue the item with items.location = 'PROC' and confirm it's location is blanked on checkout 7. Issue and return an item with a different location e.g. 'CART'. Observe the location does not change on issue or return. 8. Run unit tests sudo koha-shell kohadev prove t/db_dependent/Circulation/issue.t Sponsored-by: Toi Ohomai Institute of Technology, New Zealand -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff CC| |aleisha@catalyst.net.nz --- Comment #68 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Have fixed how this was affecting some other return messages, please test again -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154147|0 |1 is obsolete| | --- Comment #69 from David Nind <david@davidnind.com> --- Created attachment 155771 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155771&action=edit Bug 21159: Database changes Sponsored-by: Toi Ohomai Institute of Technology, New Zealand Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155284|0 |1 is obsolete| | --- Comment #71 from David Nind <david@davidnind.com> --- Created attachment 155773 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155773&action=edit Bug 21159: Update item location on checkout This patchset shifts the logic for changing the item location on checkin (controlled by the UpdateItemLocationOnCheckin system preference) to a new subroutine in Koha/Items.pm That subroutine logic is shared with the UpdateItemLocationOnCheckout system preference. Test plan: 1. Apply patches, update databases and restart services 2. Set the following system preferences: - UpdateItemLocationOnCheckin: FIC: PROC - UpdateItemLocationOnCheckout: PROC: FIC 3. Checkout an an item with items.location = 'PROC'. Observe it's location is changed to 'FIC' 4. Return the item. Observe it's location is changed to 'PROC' 5. Change UpdateItemLocationOnCheckout to: PROC: _BLANK_ 6. Issue the item with items.location = 'PROC' and confirm it's location is blanked on checkout 7. Issue and return an item with a different location e.g. 'CART'. Observe the location does not change on issue or return. 8. Run unit tests sudo koha-shell kohadev prove t/db_dependent/Circulation/issue.t Sponsored-by: Toi Ohomai Institute of Technology, New Zealand Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155771|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155773|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159 --- Comment #74 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 158146 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158146&action=edit Bug 21159: Database changes Sponsored-by: Toi Ohomai Institute of Technology, New Zealand Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159 --- Comment #76 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 158149 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158149&action=edit Bug 21159: Update item location on checkout This patchset shifts the logic for changing the item location on checkin (controlled by the UpdateItemLocationOnCheckin system preference) to a new subroutine in Koha/Items.pm That subroutine logic is shared with the UpdateItemLocationOnCheckout system preference. Test plan: 1. Apply patches, update databases and restart services 2. Set the following system preferences: - UpdateItemLocationOnCheckin: FIC: PROC - UpdateItemLocationOnCheckout: PROC: FIC 3. Checkout an an item with items.location = 'PROC'. Observe it's location is changed to 'FIC' 4. Return the item. Observe it's location is changed to 'PROC' 5. Change UpdateItemLocationOnCheckout to: PROC: _BLANK_ 6. Issue the item with items.location = 'PROC' and confirm it's location is blanked on checkout 7. Issue and return an item with a different location e.g. 'REF' (don't use 'CART' as this is blanked by bug 14576 on checkout). Observe the location does not change on issue or return. 8. Run unit tests sudo koha-shell kohadev prove t/db_dependent/Circulation/issue.t Sponsored-by: Toi Ohomai Institute of Technology, New Zealand Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off --- Comment #78 from Alex Buckley <alexbuckley@catalyst.net.nz> --- (In reply to Katrin Fischer from comment #73)

The conflict in sysprefs.sql was easy, but I got stuck witht he conflict in Issues.t - can you please rebase?

Hi Katrin, Thank you for doing QA on this patchset, appreciate it. I've done the following: 1) I have rebased the patches against master. 2) You're right issue.t was rather tricky! but I've fixed that up 3) Run all unit tests in t/db_dependent/Circulation pass for me now 4) I've also run QA test tools - qa -c 4 -v 2 - and that passed for me. Please note: I made one tweak to step 7 of the test plan in the third patch to instruct testers to please use 'REF', not 'CART', because I noticed bug 14576 can blank items with location='CART'. Hopefully all of this is helpful! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158146|0 |1 is obsolete| | --- Comment #79 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 158169 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158169&action=edit Bug 21159: Database changes Sponsored-by: Toi Ohomai Institute of Technology, New Zealand Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158149|0 |1 is obsolete| | --- Comment #81 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 158171 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158171&action=edit Bug 21159: Update item location on checkout This patchset shifts the logic for changing the item location on checkin (controlled by the UpdateItemLocationOnCheckin system preference) to a new subroutine in Koha/Items.pm That subroutine logic is shared with the UpdateItemLocationOnCheckout system preference. Test plan: 1. Apply patches, update databases and restart services 2. Set the following system preferences: - UpdateItemLocationOnCheckin: FIC: PROC - UpdateItemLocationOnCheckout: PROC: FIC 3. Checkout an an item with items.location = 'PROC'. Observe it's location is changed to 'FIC' 4. Return the item. Observe it's location is changed to 'PROC' 5. Change UpdateItemLocationOnCheckout to: PROC: _BLANK_ 6. Issue the item with items.location = 'PROC' and confirm it's location is blanked on checkout 7. Issue and return an item with a different location e.g. 'REF' (don't use 'CART' as this is blanked by bug 14576 on checkout). Observe the location does not change on issue or return. 8. Run unit tests sudo koha-shell kohadev prove t/db_dependent/Circulation/issue.t Sponsored-by: Toi Ohomai Institute of Technology, New Zealand Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159 --- Comment #83 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 158173 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158173&action=edit Bug 21159: (QA follow-up) Add say to database update, perltidy, fix tests * Perltidies to pass the QA script * Adds missing say statement to the database update * Makes sure the tests pass on a database, where UpdateItemLocaton* system preferences are not empty Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159 --- Comment #85 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 158521 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158521&action=edit Bug 21159: Remove redundant mock Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com --- Comment #87 from Tomás Cohen Arazi <tomascohen@gmail.com> --- I'm pushing this one. I appreciate the effort to refactor things in a good way and thanks for that. I have some remarks, though. Those I feel deserve to be treated on their own bugs but I'll post here for now. 1. I think the method name should be changed to something like `location_update_trigger`. I hope it is clear the why the name change proposal. 2. I'm not sure this method should internally call ->store. Calling it triggers a series of things like logging, and maybe others. It feels like the caller should _do all the changes to the item they need and then finally save_. 3. I don't feel like the return value is cool or either documented enough. I recognize this is inherited from the original code in the C4 namespace. Moving to Koha:: should be part of cleaning and improving, so more thought is needed here. At a very first sight, I'd say this shouldn't be calling ->store implicitly, and should be returning $self for method chainability. If we need to return some messages for the caller to be aware of, we already have a standard way to do it, using the Koha::Object::Message class, which is encapsulated inside Koha::Object which Koha::Item inherits from (e.g. see Koha::Object->add_message). -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement enables release notes| |libraries to automatically | |update an item's shelving | |location on | |checkout,23.11.00, works as | |follows: | | | |It accepts pairs | |of shelving locations. On | |Checkout the item's | |location is compared to the | |location on the left and, | |like | |UpdateItemLocationOnCheckin | |, is updated to the | |location on the right. | | | |Special values for this | |system preference are: | |_ALL_ - used on left side | |only to affect all items, | |if it matches, but this is | |an easier to read option) | |_PERM_ - used on right side | |only to set items to their | |permanent location | | | |Syntax | |highlighting is used in the | |text area to make it easier | |to read., as is already | |possible when checking in | |items. | | | |The new system | |preference | |UpdateItemLocationOnCheckou | |t, and overrides all other | |rules | |_BLANK_ - used on | |either side to match on or | |set to blank (actual blanks | |will work Version(s)|This enhancement enables | released in|libraries to automatically | |update an item's shelving | |location on | |checkout,23.11.00, works as | |follows: | | | |It accepts pairs | |of shelving locations. On | |Checkout the item's | |location is compared to the | |location on the left and, | |like | |UpdateItemLocationOnCheckin | |, is updated to the | |location on the right. | | | |Special values for this | |system preference are: | |_ALL_ - used on left side | |only to affect all items, | |if it matches, but this is | |an easier to read option) | |_PERM_ - used on right side | |only to set items to their | |permanent location | | | |Syntax | |highlighting is used in the | |text area to make it easier | |to read., as is already | |possible when checking in | |items. | | | |The new system | |preference | |UpdateItemLocationOnCheckou | |t, and overrides all other | |rules | |_BLANK_ - used on | |either side to match on or | |set to blank (actual blanks | |will work | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35269 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35269 [Bug 35269] Koha::Item->update_item_location should be named `location_update_trigger` -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This enhancement enables |This enhancement enables release notes|libraries to automatically |libraries to automatically |update an item's shelving |update an item's shelving |location on |location on |checkout,23.11.00, works as |checkout,23.11.00, works as |follows: |follows: | | |It accepts pairs |It accepts pairs |of shelving locations. On |of shelving locations. On |Checkout the item's |Checkout the item's |location is compared to the |location is compared to the |location on the left and, |location on the left and, |like |like |UpdateItemLocationOnCheckin |`UpdateItemLocationOnChecki |, is updated to the |n`, is updated to the |location on the right. |location on the right. | | |Special values for this |Special values for this |system preference are: |system preference are: |_ALL_ - used on left side |*_ALL_* - used on left side |only to affect all items, |only to affect all items, |if it matches, but this is |if it matches, but this is |an easier to read option) |an easier to read option) |_PERM_ - used on right side |*_PERM_* - used on right |only to set items to their |side only to set items to |permanent location |their permanent location | | |Syntax |Syntax highlighting is used |highlighting is used in the |in the text area to make it |text area to make it easier |easier to read., as is |to read., as is already |already possible when |possible when checking in |checking in items. |items. | | |The |The new system |new system preference |preference |`UpdateItemLocationOnChecko |UpdateItemLocationOnCheckou |ut`, and overrides all |t, and overrides all other |other rules |rules |*_BLANK_* - |_BLANK_ - used on |used on either side to |either side to match on or |match on or set to blank |set to blank (actual blanks |(actual blanks will work |will work | CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This enhancement enables |This enhancement enables release notes|libraries to automatically |libraries to automatically |update an item's shelving |update an item's shelving |location on |location on checkout works |checkout,23.11.00, works as |as follows: |follows: | | |It accepts |It accepts pairs |pairs of shelving |of shelving locations. On |locations. On checkout the |Checkout the item's |item's location is compared |location is compared to the |to the location on the left |location on the left and, |and, like |like |`UpdateItemLocationOnChecki |`UpdateItemLocationOnChecki |n`, is updated to the |n`, is updated to the |location on the right. |location on the right. | | |Special values for this |Special values for this |system preference are: |system preference are: |* |* |*_ALL_* - used on left side |*_ALL_* - used on left side |only to affect all items, |only to affect all items, |if it matches, but this is |if it matches, but this is |an easier to read option) |an easier to read option) |* |* |*_PERM_* - used on right |*_PERM_* - used on right |side only to set items to |side only to set items to |their permanent location |their permanent location | | |Syntax highlighting is used |Syntax highlighting is used |in the text area to make it |in the text area to make it |easier to read, as is |easier to read., as is |already possible when |already possible when |checking in items. |checking in items. | | |The |The |new system preference |new system preference |`UpdateItemLocationOnChecko |`UpdateItemLocationOnChecko |ut`, and overrides all |ut`, and overrides all |other rules. |other rules. | | |*_BLANK_* - |*_BLANK_* - |used on either side to |used on either side to |match on or set to blank |match on or set to blank |(actual blanks will work |(actual blanks will work | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com Status|Needs documenting |RESOLVED Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/819 Documentation| |Caroline Cyr La Rose contact| | Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.