[Bug 35269] New: Koha::Item->update_item_location should be named `location_update_trigger`
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35269 Bug ID: 35269 Summary: Koha::Item->update_item_location should be named `location_update_trigger` Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: tomascohen@gmail.com QA Contact: testopia@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35269 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Depends on| |21159 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159 [Bug 21159] Update item shelving location (952$c) on checkout -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35269 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35270 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35270 [Bug 35270] Koha::Item->location_update_trigger should not call ->store -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35269 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Koha::Item->update_item_loc |Koha::Item->update_item_loc |ation should be named |ation should be named |`location_update_trigger` |`trigger_location_update` -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35269 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 158535 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158535&action=edit Bug 35269: Rename `update_item_location` to `trigger_location_update` This patch renames all occurences of the method. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35269 --- Comment #2 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 158536 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158536&action=edit Bug 35269: Improve POD Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35269 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35269 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158535|0 |1 is obsolete| | Attachment #158536|0 |1 is obsolete| | --- Comment #3 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 158540 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158540&action=edit Bug 35269: Rename `update_item_location` to `location_update_trigger` This patch renames all occurences of the method. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35269 --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 158541 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158541&action=edit Bug 35269: Improve POD Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35269 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35269 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158540|0 |1 is obsolete| | --- Comment #5 from David Nind <david@davidnind.com> --- Created attachment 158548 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158548&action=edit Bug 35269: Rename `update_item_location` to `location_update_trigger` This patch renames all occurences of the method. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35269 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158541|0 |1 is obsolete| | --- Comment #6 from David Nind <david@davidnind.com> --- Created attachment 158549 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158549&action=edit Bug 35269: Improve POD Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35269 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #7 from David Nind <david@davidnind.com> --- This is how I tested - hope this is sufficient! 1. Before applying the patch run git grep update_item_location - this was the result for me: kohadev-koha@kohadevbox:koha(bz35269)$ git grep update_item_location C4/Circulation.pm: $item_object->update_item_location( 'checkout' ); C4/Circulation.pm: my $loc_messages = $item->update_item_location( 'checkin' ); Koha/Item.pm:=head3 update_item_location Koha/Item.pm: $item->update_item_location( $action ); Koha/Item.pm:sub update_item_location { t/db_dependent/Koha/Item.t:subtest 'update_item_location() tests' => sub { t/db_dependent/Koha/Item.t: $item->update_item_location($action); t/db_dependent/Koha/Item.t: $item->update_item_location($action); t/db_dependent/Koha/Item.t: $item->update_item_location($action); t/db_dependent/Koha/Item.t: $item->update_item_location($action); t/db_dependent/Koha/Item.t: $item->update_item_location($action); 2. After applying the patch, run again - there should be no results. 3. Test updating the shelving location on check in: 3.1 Update the UpdateItemLocationOnCheckin system preference and add: _ALL_: FIC 3.2 Check in an item (doesn't need to be checked out) - message should be similar to: 39999000011418: Programming Perl / Not checked out. Item shelving location updated. Old value: General stacks New value: Fiction 3.3 Confirm that the shelving location was updated to Fiction. 4. Test updating the shelving location on check out: 4.1 Update the UpdateItemLocationOnCheckout system preference and add: _ALL_: FIC 4.2 Check out an item to a patron. 4.3 Confirm that the shelving location was changed to Fiction. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35269 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35269 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158548|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 158551 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158551&action=edit Bug 35269: Rename `update_item_location` to `location_update_trigger` This patch renames all occurences of the method. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35269 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158549|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 158552 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158552&action=edit Bug 35269: Improve POD Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35269 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35269 --- Comment #10 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35269 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED CC| |fridolin.somers@biblibre.co | |m Resolution|--- |FIXED --- Comment #11 from Fridolin Somers <fridolin.somers@biblibre.com> --- Depends on Bug 21159 not in 23.05.x -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35269 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alexbuckley@catalyst.net.nz --- Comment #12 from Alex Buckley <alexbuckley@catalyst.net.nz> --- *** Bug 35315 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35269 Bug 35269 depends on bug 21159, which changed state. Bug 21159 Summary: Update item shelving location (952$c) on checkout https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org