[Bug 41957] New: Hyperhold/hold group information should show on 'Hold found' modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41957 Bug ID: 41957 Summary: Hyperhold/hold group information should show on 'Hold found' modal Initiative type: --- Sponsorship --- status: Product: Koha Version: 25.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: sbrown@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: andrew@bywatersolutions.com, gmcharlt@gmail.com, lisette@bywatersolutions.com, tomascohen@gmail.com When a hold fills that is part of a hyperhold, the 'Hold filled' modal should have some indication that it's part of a hold group. This could be a link to the patron's Holds tab and/or the hold_group_id. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41957 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |42238 CC| |pedro.amorim@openfifth.co.u | |k Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42238 [Bug 42238] Navigating directly to a patron's holds tab does not work -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41957 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41957 --- Comment #1 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 196616 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196616&action=edit Bug 41957: Show hold group information on 'Hold found' modal Test plan: 1) Enable DisplayAddHoldGroups 2) Go to 'Henry' and click the 'Search to hold' button: <staff_url>/cgi-bin/koha/members/moremember.pl?borrowernumber=19 3) Search for keyword 'test'. Click the 'Search' button. 4) On the search results page, click the 'Select all' option at the top 5) Click the downward arrow in the 'Place hold' toolbar button. 6) Pick 'Place hold for Henry Acevedo' 7) Tick the 'Treat as hold group' checkbox. 8) Set a pickup location for each of the holds. 9) Click 'Place holds'. 10) Check-in one eligible item (from one of the 3 records we just placed holds on) e.g.: 39999000001310 11) Notice the 'Hold found' modal now shows 'Part of a hold group' with a link directly to the patron's holds. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41957 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Assignee|koha-bugs@lists.koha-commun |pedro.amorim@openfifth.co.u |ity.org |k Version|25.11 |Main -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41957 --- Comment #2 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- This works, but QA tools are cranky: [FAIL] koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt FAIL filters missing_filter at line 976 ( <a target="_blank" href="/cgi-bin/koha/circ/circulation.pl?borrowernumber=[% patron.borrowernumber %]#holds_panel"><i class="fa fa-fw fa-external-link-alt"></i> View patron's holds</a>) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41957 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41957 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196616|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41957 --- Comment #3 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 196634 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196634&action=edit Bug 41957: Show hold group information on 'Hold found' modal Test plan: 1) Enable DisplayAddHoldGroups 2) Go to 'Henry' and click the 'Search to hold' button: <staff_url>/cgi-bin/koha/members/moremember.pl?borrowernumber=19 3) Search for keyword 'test'. Click the 'Search' button. 4) On the search results page, click the 'Select all' option at the top 5) Click the downward arrow in the 'Place hold' toolbar button. 6) Pick 'Place hold for Henry Acevedo' 7) Tick the 'Treat as hold group' checkbox. 8) Set a pickup location for each of the holds. 9) Click 'Place holds'. 10) Check-in one eligible item (from one of the 3 records we just placed holds on) e.g.: 39999000001310 11) Notice the 'Hold found' modal now shows 'Part of a hold group' with a link directly to the patron's holds. Signed-off-by: Bob Bennhoff <bbennhoff@clicweb.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41957 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41957 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41957 --- Comment #4 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 196643 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196643&action=edit Bug 41957: (QA follow-up) Add tt filter to link variable Patch from commit 69028f9 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41957 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |41849 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41849 [Bug 41849] Cancelling filled hold from group does not cancel remaining pending holds from group or indicate that it's a hyperhold -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41957 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41957 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196634|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41957 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196643|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41957 --- Comment #5 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 196651 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196651&action=edit Bug 41957: Show hold group information on 'Hold found' modal Test plan: 1) Enable DisplayAddHoldGroups 2) Go to 'Henry' and click the 'Search to hold' button: <staff_url>/cgi-bin/koha/members/moremember.pl?borrowernumber=19 3) Search for keyword 'test'. Click the 'Search' button. 4) On the search results page, click the 'Select all' option at the top 5) Click the downward arrow in the 'Place hold' toolbar button. 6) Pick 'Place hold for Henry Acevedo' 7) Tick the 'Treat as hold group' checkbox. 8) Set a pickup location for each of the holds. 9) Click 'Place holds'. 10) Check-in one eligible item (from one of the 3 records we just placed holds on) e.g.: 39999000001310 11) Notice the 'Hold found' modal now shows 'Part of a hold group' with a link directly to the patron's holds. Signed-off-by: Bob Bennhoff <bbennhoff@clicweb.org> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41957 --- Comment #6 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 196652 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196652&action=edit Bug 41957: (QA follow-up) Add tt filter to link variable Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41957 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15516 See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15516 | CC| |emily.lamancusa@montgomeryc | |ountymd.gov Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 [Bug 15516] Allow to place a hold on first available item from a group of titles -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41957 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41957 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement adds a release notes| |notification to the hold | |found modal when the hold | |to be filled is part of a | |group. The modal will | |include the message "part | |of a hold group" and a link | |to the holds table in the | |patron's account. Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41957 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41957 --- Comment #7 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41957 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_25_11_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41957 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|26.05.00 |26.05.00,25.11.05 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41957 --- Comment #8 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Thanks all, pushed to 25.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41957 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz Status|Pushed to stable |Needs documenting --- Comment #9 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Enhancement - not backporting to 25.05 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org