http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6886 --- Comment #2 from Chris Cormack <chris@bigballofwax.co.nz> 2011-09-19 23:22:57 UTC --- Hmm actually opac-results.tt is respecting the systempreference already -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6886 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |nengard@gmail.com AssignedTo|gmcharlt@gmail.com |chris@bigballofwax.co.nz -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6886 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6886 --- Comment #6 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 11370 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11370&action=edit Bug 6886 Follow up for NORMARC -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6886 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11367|0 |1 is obsolete| | --- Comment #8 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 11501 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11501&action=edit [SIGNED-OFF] Bug 6886 - OPAC XSLT respecting single branch mode This is only for the MARC21 XSLT at this stage, follow up patch for UNIMARC will come Conflicts: C4/XSLT.pm koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6886 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11370|0 |1 is obsolete| | --- Comment #10 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 11504 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11504&action=edit [SIGNED-OFF] Bug 6886 Follow up for NORMARC Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6886 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |julian.maurice@biblibre.com --- Comment #11 from Julian Maurice <julian.maurice@biblibre.com> --- Tested the 3 XSLT on master with singleBranchMode ON, branches are displayed. Tested the 3 XSLT with the patch with singleBranchMode ON, branches are not displayed Tested with singleBranchMode OFF, with and without the patch, display doesn't change. Ok. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6886 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain@biblibre.com --- Comment #13 from Paul Poulain <paul.poulain@biblibre.com> --- Patch pushed to master -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6886 Melia Meggs <melia@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED CC| |melia@bywatersolutions.com Resolution|FIXED |--- --- Comment #15 from Melia Meggs <melia@bywatersolutions.com> --- Does this patch only work for available items? After applying the patch, we're seeing that the 'not for loan' items still show the branch name, but the 'available' items don't. I don't think we really need to see the branch name on ANY of the items when single branch mode is on. Before the patch, we had the branch name showing on all items in the search results. After the patch, we have the branch name showing only on not for loan items. It seems confusing to see it on some items and not on others. Can we make it hide the branch name regardless of status? -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6886 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11501|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6886 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11504|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6886 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris@bigballofwax.co.nz |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6886 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14434|0 |1 is obsolete| | --- Comment #17 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 15065 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15065&action=edit [SIGNED-OFF] Bug 6886 - Single branch mode should disable showing the branch name in front of all callnumbers Followup - Copies available for reference Test plan: Enable singleBranchMode and OPACXSLTResultsDisplay. Perform a search in the OPAC which returns results containing not-for-loan items. Before the patch these items will show their library in search results loan items. After the patch there will be not be a library listed, matching other items in results. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Works according to the test plan I invented. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6886 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |jonathan.druart@biblibre.co | |m --- Comment #18 from Jonathan Druart <jonathan.druart@biblibre.com> --- Patch does not apply. Caused by bug 5079 which removes the "Copies available for reference" block. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6886 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6886 --- Comment #21 from Paul Poulain <paul.poulain@biblibre.com> --- Patch tested with a sandbox, by Broust <jean-manuel.broust@univ-lyon2.fr> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6886 --- Comment #22 from Paul Poulain <paul.poulain@biblibre.com> --- Created attachment 16385 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16385&action=edit Bug 9744 - Add a column Fund name on the home page of acquisitions This patch offers an alternative option to fix Bug 9744. In this version the table of funds swaps positions with the suggestions block so that the table has the whole width of the screen. This eliminates the need to adjust its float property. Other changes: - Simplification of the column and row-hiding JavaScript - The addition of an "Active" column to be shown when all funds are shown (this helps indicate to the user which rows were hidden) - Linking the fund owner to their patron record - Linking the fund id, given the correct permissions, to the view of all funds for that budget (the best alternative to linking to a view of the fund details, which we do not have). - Correcting permission level required to add a budget To test, view the acquisitions home page. The layout should feel comfortable. The table of available funds thsould show the fund name. The checkbox to show all funds should work correctly. Signed-off-by: caroline very-mathieu <caroline.very-mathieu@nimes-ville.fr> Signed-off-by: Broust <jean-manuel.broust@univ-lyon2.fr> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6886 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16028|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6886 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16028|0 |1 is obsolete| | --- Comment #24 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 16391 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16391&action=edit Bug 6886 - Single branch mode should disable showing the branch name in front of all callnumbers Followup - Copies available for reference Test plan: Enable singleBranchMode and OPACXSLTResultsDisplay. Perform a search in the OPAC which returns results containing not-for-loan items. Before the patch these items will show their library in search results loan items. After the patch there will be not be a library listed, matching other items in results. Signed-off-by jmbroust <jean-manuel.broust@univ-lyon2.fr> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6886 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #26 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Why using a choose when an if would do? + <xsl:choose> + <xsl:when test="$singleBranchMode=0"> + <xsl:value-of select="items:homebranch"/> + </xsl:when> + </xsl:choose> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6886 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED --- Comment #27 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This can't be tested as on current master reference items (itemtype = not for loan) are no longer shown in the result list. I reported bug 9995 for that. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6886 --- Comment #29 from Nicole C. Engard <nengard@gmail.com> --- What does the status of 'BLOCKED' mean? -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6886 --- Comment #30 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- BLOCKED was added to help testers to notice dependencies. Like this bug couldn't be tested before 9995 was fixed. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6886 --- Comment #32 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Kyle, could you please take a look at my comment please? I am still torn if this is a fail, but it just doesn't look right to me :) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6886 --- Comment #33 from Kyle M Hall <kyle@bywatersolutions.com> --- I was just replicating what other parts of the xslt was already doing. If you think the if is better ( which I imagine it is ) that's fine by me. Would you like to add a qa followup, or shall I? (In reply to Katrin Fischer from comment #31)

This works, but I am a bit torn on the <choose> constructs:

+ <xsl:choose> + <xsl:when test="$singleBranchMode=0"> + <xsl:value-of select="items:homebranch"/> + </xsl:when> + </xsl:choose>

This could be:

<xsl:if test="$singleBranchMode=0"> <xsl:value-of select="items:homebranch"/> </xsl:if>

-- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6886 --- Comment #35 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 23304 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23304&action=edit Bug 6886 - Single branch mode should disable showing the branch name in front of all callnumbers - QA Followup -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6886 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|Trivial patch |Small patch -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6886 --- Comment #38 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 23746 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23746&action=edit [PASSED QA] Bug 6886 - Single branch mode should disable showing the branch name in front of all callnumbers - QA Followup Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes all tests and QA script. Switching SingleBranchMode: Tested with MARC21 and UNIMARC: - "Don't allow" - branch is not shown in result list - "Allow" - branch is shown for available items in result list Changes are consistent over all 3 MARC flavours. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6886 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolyn.somers@biblibre.co | |m --- Comment #40 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- 3 new patches pushed to 3.14.x, will be in 3.14.4. -- You are receiving this mail because: You are watching all bug changes.