[Bug 10429] New: branch filter not working in serial claims
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10429 Bug ID: 10429 Summary: branch filter not working in serial claims Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Serials Assignee: koha-bugs@lists.koha-community.org Reporter: fridolyn.somers@biblibre.com CC: colin.campbell@ptfs-europe.com In serial claims page, the branch code is displayed in table instead of branch name and branch filter does not work. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10429 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs@lists.koha-commun |fridolyn.somers@biblibre.co |ity.org |m --- Comment #1 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- Created attachment 18745 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18745&action=edit Proposed patch See commit message -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10429 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10430 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10429 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10429 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18745|0 |1 is obsolete| | CC| |dcook@prosentient.com.au --- Comment #2 from David Cook <dcook@prosentient.com.au> --- Created attachment 19747 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19747&action=edit [SIGNED OFF -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10429 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19747|0 |1 is obsolete| | --- Comment #3 from David Cook <dcook@prosentient.com.au> --- Created attachment 19748 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19748&action=edit [SIGNED OFF] Bug 10429 - branch filter not working in serial claims Patch works pretty much as described. Makes the branch filter look nicer and uses the branch names rather than codes. It's worth mentioning that the branch code is still used in the DataTables in "serials-collection.pl". I've opened the follow Bug 10609 in regards to that. (P.S. This patch replaces the one I goofed by accidentally hitting Enter. I miss git bz...) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10429 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10429 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 19839 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19839&action=edit screenshot of wrong result list Dependig on the sequence in which you change select the filters it's still possible that the result list does not match the selected filters. Could you take another look please? Here is my step by step for the result shown on the screenshot: 1) Open claims page 2) Select "Demo Library" - filters work correctly, 1 result is shown 3) Switch status to "Expected" - 2 results are shown, including the one from Centerville -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10429 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10429 --- Comment #5 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- (In reply to Katrin Fischer from comment #4)
Dependig on the sequence in which you change select the filters it's still possible that the result list does not match the selected filters.
Indeed, the filters are not cumulative. But i think this is another bug. Maybe claims page needs a JQuery datatable. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10429 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10914 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10429 --- Comment #6 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- (In reply to Fridolyn SOMERS from comment #5)
Indeed, the filters are not cumulative. But i think this is another bug. Maybe claims page needs a JQuery datatable. Created Bug 10914
-- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10429 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #7 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- I set back to signedoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10429 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19839|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10429 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m --- Comment #8 from Jonathan Druart <jonathan.druart@biblibre.com> --- For information: I removed these filters in one of my patches for bug 10855 (patch "Bug 10855: Search subscriptions by additional fields on the claim page"). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10429 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10429 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19748|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 23864 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23864&action=edit [PASSED QA] Bug 10429 - branch filter not working in serial claims In serial claims page, the branch code is displayed in table instead of branch name and branch filter does not work. This patch adds the display of branch name by using branches template plugin. It changes javascript branch filter to make it work. Also sets "all" filter in template (like status filter) to allow translation and sets "all" as selected by default. Librairian branch was selected by default, but the table was not filtered with it. Test plan : - Go to serials claim of a vendor with serials of multiple branches => You see branch filter with "(All)" and table shows libraries names - Check that branch filter does its work Signed-off-by: David Cook <dcook@prosentient.com.au> Works as described. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Table now shows the branch name instead of the branchcode. First option was named (All), matching the status pull down. When opening the claims page, (All) is preselected and the result list matches with the selection. Before the patch the library was preselected, but the result list did show late issues from all branches. This patch is an improvement, but there is still more work to do. - Filters are not cumulative, but when another filter is selected the first filter is not reset. - It's not possible to combine 2 or more filters. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10429 --- Comment #10 from Jonathan Druart <jonathan.druart@biblibre.com> ---
This patch is an improvement, but there is still more work to do.
- Filters are not cumulative, but when another filter is selected the first filter is not reset. - It's not possible to combine 2 or more filters.
Will be possible with bug 10855 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10429 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #11 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Fridolin! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10429 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #12 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Patch pushed to 3.14.x, will be in 3.14.4. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org