[Bug 37859] New: Tabs for record comments are in plain text (related to Bootstrap 5 update)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37859 Bug ID: 37859 Summary: Tabs for record comments are in plain text (related to Bootstrap 5 update) Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: david@davidnind.com QA Contact: testopia@bugs.koha-community.org When viewing patron comments on records, the tabs are plain text links instead of the standard tabbed style. To replicate: 1. Go to Tools > Patrons and circulation > Comments. 2. Note that tab headings are plain text links, instead of the standard tabbed style. I think this is similar to bug 37752 and bug 37753. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37859 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |35402 Patch complexity|--- |Trivial patch Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35402 [Bug 35402] Update the OPAC and staff interface to Bootstrap 5 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37859 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37859 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37859 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37859 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37859 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 171192 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171192&action=edit Bug 37859: Fix style of tabs on comment review page This patch corrects the tab markup on the comment review page. These tabs are just links styled as tabs -- there isn't any JS tab swapping. This kind of "static" tab markup wasn't handled by the tabs WRAPPER work. To test you should have some comments data in your system: - Go to Administration -> System preferences and enable the "OPACComments" preference. - Log in to the OPAC and search for a bibliographic record. - View the detail page for the record and click the "Comments" tab. - Click "Post your comments on this title." - Enter some text in the review box and submit. In the staff interface, go to Tools -> Comments. - You should see two tabs: "Approved comments" and "Comments awaiting moderation." - Confirm that the tabs look correct. - Approve one or more comments and confirm that the tabs work correctly to switch views. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37859 Sukhmandeep <sukhmandeep.benipal@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171192|0 |1 is obsolete| | --- Comment #2 from Sukhmandeep <sukhmandeep.benipal@inLibro.com> --- Created attachment 171203 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171203&action=edit Bug 37859: Fix style of tabs on comment review page This patch corrects the tab markup on the comment review page. These tabs are just links styled as tabs -- there isn't any JS tab swapping. This kind of "static" tab markup wasn't handled by the tabs WRAPPER work. To test you should have some comments data in your system: - Go to Administration -> System preferences and enable the "OPACComments" preference. - Log in to the OPAC and search for a bibliographic record. - View the detail page for the record and click the "Comments" tab. - Click "Post your comments on this title." - Enter some text in the review box and submit. In the staff interface, go to Tools -> Comments. - You should see two tabs: "Approved comments" and "Comments awaiting moderation." - Confirm that the tabs look correct. - Approve one or more comments and confirm that the tabs work correctly to switch views. Signed-off-by: Sukhmandeep Benipal <sukhmandeep.benipal@inLibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37859 Sukhmandeep <sukhmandeep.benipal@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sukhmandeep.benipal@inLibro | |.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37859 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes the tab headings release notes| |for patron comments (Tools | |> Patrons and circulation > | |Comments), so that they are | |now standard tabs instead | |of plain text links. (This | |is related to the OPAC and | |staff interface Bootstrap 5 | |upgrade in Koha 24.11.) --- Comment #3 from David Nind <david@davidnind.com> --- Thanks Owen and Sukhmandeep! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37859 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37859 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171203|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 171306 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171306&action=edit Bug 37859: Fix style of tabs on comment review page This patch corrects the tab markup on the comment review page. These tabs are just links styled as tabs -- there isn't any JS tab swapping. This kind of "static" tab markup wasn't handled by the tabs WRAPPER work. To test you should have some comments data in your system: - Go to Administration -> System preferences and enable the "OPACComments" preference. - Log in to the OPAC and search for a bibliographic record. - View the detail page for the record and click the "Comments" tab. - Click "Post your comments on this title." - Enter some text in the review box and submit. In the staff interface, go to Tools -> Comments. - You should see two tabs: "Approved comments" and "Comments awaiting moderation." - Confirm that the tabs look correct. - Approve one or more comments and confirm that the tabs work correctly to switch views. Signed-off-by: Sukhmandeep Benipal <sukhmandeep.benipal@inLibro.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37859 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37859 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37859 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to main |RESOLVED CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37859 Bug 37859 depends on bug 35402, which changed state. Bug 35402 Summary: Update the OPAC and staff interface to Bootstrap 5 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35402 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org