http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577 Cab Vinton <director@plaistowlibrary.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |director@plaistowlibrary.co | |m -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577 --- Comment #2 from Holger Meißner <h.meissner.82@web.de> --- Created attachment 28426 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28426&action=edit Bug 11577: Add "Automatic renewal" to the circulation and fine rules This patch adds a column "Automatic renewal" to the circulation and fine rules table. To test: 1) Add or edit some issuing rules. 2) Confirm that "Automatic Renewal" is set to "No" by default and can be switched to "Yes". Sponsored-by: Hochschule für Gesundheit (hsg), Germany -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577 --- Comment #4 from Holger Meißner <h.meissner.82@web.de> --- Created attachment 28428 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28428&action=edit Bug 11577: Add 'auto_renew' and 'auto_too_soon' to renewal page This patch adds the new renewal errors 'auto_renew' and 'auto_too_soon' to the renewal interface. To test: 1) Issue two items: - one with automatic renewal and no value for "No renewal before" - another with automatic renewal and a value for "No renewal before" 2) Try to renew: Home > Circulation > Renew 3) Confirm there are error messages explaining that the items have been sheduled for automatic renewal and that one of the renewals is also premature. 4) If global syspref AllowRenewalLimitOverride is set to "Allow" you should be given the option to override. Sponsored-by: Hochschule für Gesundheit (hsg), Germany -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577 --- Comment #6 from Holger Meißner <h.meissner.82@web.de> --- Created attachment 28430 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28430&action=edit Bug 11577: OPAC bootstrap theme changes This patch makes opac-user.pl and the bootstrap version of opac-user.tt handle the new renewal errors "auto_renew" and "auto_too_soon". To test: 1) Set global syspref "opacthemes" to bootstrap. 2) Set global syspref "OpacRenewalAllowed" to Allow. 3) Test the same things as in previous patch, this time for the OPAC summary page. Sponsored-by: Hochschule für Gesundheit (hsg), Germany -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577 --- Comment #8 from Holger Meißner <h.meissner.82@web.de> --- Created attachment 28432 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28432&action=edit Bug 11577: Add an automatic renewal cronjob This patch adds a new cron script automatic_renewals.pl and a new entry in crontab.example. To test: 1) You need a few issues, some with automatic renewal and some without. 2) Confirm that each time you run misc/cronjobs/automatic_renewals.pl those issues are renewed that meet all of the following criteria: - automatic renewal has been sheduled either by issuing rule or by checkbox on the checkout page - the number of allowed renewals isn't exceeded - renewal isn't premature (No renewal before) 3) Confirm that all other issues are not affected. Sponsored-by: Hochschule für Gesundheit (hsg), Germany -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577 --- Comment #10 from Holger Meißner <h.meissner.82@web.de> --- Created attachment 28434 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28434&action=edit Bug 11577: Add Hochschule für Gesundheit to contributing institutions Automatic renewal is the second feature sponsored by the hsg. Sponsored-by: Hochschule für Gesundheit (hsg), Germany -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577 Holger Meißner <h.meissner.82@web.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch Severity|enhancement |new feature -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577 --- Comment #12 from Holger Meißner <h.meissner.82@web.de> --- Only the first patch of this series broke with the transition from 3.15 to 3.17. I rebased and re-uploaded just this single patch. Or should I rather upload the whole series in correct order? -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577 Holger Meißner <h.meissner.82@web.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28426|0 |1 is obsolete| | --- Comment #14 from Holger Meißner <h.meissner.82@web.de> --- Created attachment 28596 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28596&action=edit Bug 11577: Add "Automatic renewal" to the circulation and fine rules This patch adds a column "Automatic renewal" to the circulation and fine rules table. To test: 1) Add or edit some issuing rules. 2) Confirm that "Automatic Renewal" is set to "No" by default and can be switched to "Yes". Sponsored-by: Hochschule für Gesundheit (hsg), Germany -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577 Holger Meißner <h.meissner.82@web.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28428|0 |1 is obsolete| | --- Comment #16 from Holger Meißner <h.meissner.82@web.de> --- Created attachment 28598 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28598&action=edit Bug 11577: Add 'auto_renew' and 'auto_too_soon' to renewal page This patch adds the new renewal errors 'auto_renew' and 'auto_too_soon' to the renewal interface. To test: 1) Issue two items: - one with automatic renewal and no value for "No renewal before" - another with automatic renewal and a value for "No renewal before" 2) Try to renew: Home > Circulation > Renew 3) Confirm there are error messages explaining that the items have been sheduled for automatic renewal and that one of the renewals is also premature. 4) If global syspref AllowRenewalLimitOverride is set to "Allow" you should be given the option to override. Sponsored-by: Hochschule für Gesundheit (hsg), Germany -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577 Holger Meißner <h.meissner.82@web.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28430|0 |1 is obsolete| | --- Comment #18 from Holger Meißner <h.meissner.82@web.de> --- Created attachment 28600 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28600&action=edit Bug 11577: OPAC bootstrap theme changes This patch makes opac-user.pl and the bootstrap version of opac-user.tt handle the new renewal errors "auto_renew" and "auto_too_soon". To test: 1) Set global syspref "opacthemes" to bootstrap. 2) Set global syspref "OpacRenewalAllowed" to Allow. 3) Test the same things as in previous patch, this time for the OPAC summary page. Sponsored-by: Hochschule für Gesundheit (hsg), Germany -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577 Holger Meißner <h.meissner.82@web.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28432|0 |1 is obsolete| | --- Comment #20 from Holger Meißner <h.meissner.82@web.de> --- Created attachment 28602 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28602&action=edit Bug 11577: Add an automatic renewal cronjob This patch adds a new cron script automatic_renewals.pl and a new entry in crontab.example. To test: 1) You need a few issues, some with automatic renewal and some without. 2) Confirm that each time you run misc/cronjobs/automatic_renewals.pl those issues are renewed that meet all of the following criteria: - automatic renewal has been sheduled either by issuing rule or by checkbox on the checkout page - the number of allowed renewals isn't exceeded - renewal isn't premature (No renewal before) 3) Confirm that all other issues are not affected. Sponsored-by: Hochschule für Gesundheit (hsg), Germany -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577 --- Comment #22 from Holger Meißner <h.meissner.82@web.de> --- Created attachment 28604 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28604&action=edit Bug 11577: Add Hochschule für Gesundheit to contributing institutions Automatic renewal is the second feature sponsored by the hsg. Sponsored-by: Hochschule für Gesundheit (hsg), Germany -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577 Holger Meißner <h.meissner.82@web.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28595|0 |1 is obsolete| | --- Comment #23 from Holger Meißner <h.meissner.82@web.de> --- Created attachment 29393 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29393&action=edit Bug 11577: Add auto_renew flags to the database - issues.auto_renew - old_issues.auto_renew - issuingrules.auto_renew Default value is zero. To test: 1) Run installer/data/mysql/updatedatabase.pl 2) Create SQL reports like: SELECT * FROM issues LIMIT 0,1 3) Confirm that a column auto_renew was added to each of the three tables. Sponsored-by: Hochschule für Gesundheit (hsg), Germany -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577 Holger Meißner <h.meissner.82@web.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28597|0 |1 is obsolete| | --- Comment #25 from Holger Meißner <h.meissner.82@web.de> --- Created attachment 29395 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29395&action=edit Bug 11577: Code and intranet template changes This patch adds a checkbox for "Automatic renewal" to the checkout page. CanBookBeRenewed is modified to include two new errors: - auto_renew (renewal shouldn't be done manually) - auto_too_soon (renewal is premature and shouldn't be done manually) To test: 1) Add or edit an issuing rule with "Automatic renewal" and another one without it. 2) Issue at least three items: - automatic renewal by issuing rule - automatic renewal by Checkbox on the checkout page - no automatic renewal 3) Test the following steps for both: Home > Circulation > Checkouts Home > Patrons > Patron details 4) Confirm that issues with automatic renewal cannot be renewed manually, even if there are still renewals left and it's not too soon to renew. 5) Confirm that "Automatic renewal" and the remaining renewals are displayed. If no renewals are left "Not renewable" should be displayed. 6) Confirm that issues without automatic renewal behave as usual. Sponsored-by: Hochschule für Gesundheit (hsg), Germany -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577 Holger Meißner <h.meissner.82@web.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28599|0 |1 is obsolete| | --- Comment #27 from Holger Meißner <h.meissner.82@web.de> --- Created attachment 29397 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29397&action=edit Bug 11577: Expand description of AllowRenewalLimitOverride With the introduction of the new automatic renewal feature global syspref AllowRenewalLimitOverride is expanded in meaning. It now gives the option to override blocks if: - the number of allowed renewals is exceeded - the renewal is premature (No renewal before) - the item is sheduled for automatic renewal - the renewal is premature and the item is sheduled for automatic renewal Sponsored-by: Hochschule für Gesundheit (hsg), Germany -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577 Holger Meißner <h.meissner.82@web.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28601|0 |1 is obsolete| | --- Comment #29 from Holger Meißner <h.meissner.82@web.de> --- Created attachment 29399 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29399&action=edit Bug 11577: OPAC prog theme changes This patch makes the prog version of opac-user.tt handle the new renewal errors "auto_renew" and "auto_too_soon". To test: 1) Set global syspref "opacthemes" to prog. 2) Test the same things as in previous patch. Sponsored-by: Hochschule für Gesundheit (hsg), Germany -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577 Holger Meißner <h.meissner.82@web.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28603|0 |1 is obsolete| | --- Comment #31 from Holger Meißner <h.meissner.82@web.de> --- Created attachment 29401 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29401&action=edit Bug 11577: Unit tests This patch fixes a few unit tests that broke because of the new feature. To test: 1) prove t/db_dependent/Circulation.t 2) prove t/db_dependent/Circulation_Issuingrule.t 3) prove t/db_dependent/Circulation_issue.t Sponsored-by: Hochschule für Gesundheit (hsg), Germany -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577 Holger Meißner <h.meissner.82@web.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28604|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577 Holger Meißner <h.meissner.82@web.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29394|0 |1 is obsolete| | --- Comment #35 from Holger Meißner <h.meissner.82@web.de> --- Created attachment 29967 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29967&action=edit Bug 11577: Add "Automatic renewal" to the circulation and fine rules This patch adds a column "Automatic renewal" to the circulation and fine rules table. To test: 1) Add or edit some issuing rules. 2) Confirm that "Automatic Renewal" is set to "No" by default and can be switched to "Yes". Sponsored-by: Hochschule für Gesundheit (hsg), Germany -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577 Holger Meißner <h.meissner.82@web.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29396|0 |1 is obsolete| | --- Comment #37 from Holger Meißner <h.meissner.82@web.de> --- Created attachment 29969 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29969&action=edit Bug 11577: Add 'auto_renew' and 'auto_too_soon' to renewal page This patch adds the new renewal errors 'auto_renew' and 'auto_too_soon' to the renewal interface. To test: 1) Issue two items: - one with automatic renewal and no value for "No renewal before" - another with automatic renewal and a value for "No renewal before" 2) Try to renew: Home > Circulation > Renew 3) Confirm there are error messages explaining that the items have been scheduled for automatic renewal and that one of the renewals is also premature. 4) If global syspref AllowRenewalLimitOverride is set to "Allow" you should be given the option to override. Sponsored-by: Hochschule für Gesundheit (hsg), Germany -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577 Holger Meißner <h.meissner.82@web.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29398|0 |1 is obsolete| | --- Comment #39 from Holger Meißner <h.meissner.82@web.de> --- Created attachment 29971 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29971&action=edit Bug 11577: OPAC bootstrap theme changes This patch makes opac-user.pl and the bootstrap version of opac-user.tt handle the new renewal errors "auto_renew" and "auto_too_soon". To test: 1) Set global syspref "opacthemes" to bootstrap. 2) Set global syspref "OpacRenewalAllowed" to Allow. 3) Test the same things as in previous patch, this time for the OPAC summary page. Sponsored-by: Hochschule für Gesundheit (hsg), Germany -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577 Holger Meißner <h.meissner.82@web.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29400|0 |1 is obsolete| | --- Comment #41 from Holger Meißner <h.meissner.82@web.de> --- Created attachment 29973 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29973&action=edit Bug 11577: Add an automatic renewal cronjob This patch adds a new cron script automatic_renewals.pl and a new entry in crontab.example. To test: 1) You need a few issues, some with automatic renewal and some without. 2) Confirm that each time you run misc/cronjobs/automatic_renewals.pl those issues are renewed that meet all of the following criteria: - automatic renewal has been scheduled either by issuing rule or by checkbox on the checkout page - the number of allowed renewals isn't exceeded - renewal isn't premature (No renewal before) 3) Confirm that all other issues are not affected. Sponsored-by: Hochschule für Gesundheit (hsg), Germany -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577 --- Comment #43 from Holger Meißner <h.meissner.82@web.de> --- Created attachment 29975 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29975&action=edit Bug 11577: Add Hochschule für Gesundheit to contributing institutions Automatic renewal is the second feature sponsored by the hsg. Sponsored-by: Hochschule für Gesundheit (hsg), Germany -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577 Holger Meißner <h.meissner.82@web.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29966|0 |1 is obsolete| | --- Comment #45 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 30248 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30248&action=edit Bug 11577: Add auto_renew flags to the database - issues.auto_renew - old_issues.auto_renew - issuingrules.auto_renew Default value is zero. To test: 1) Run installer/data/mysql/updatedatabase.pl 2) Create SQL reports like: SELECT * FROM issues LIMIT 0,1 3) Confirm that a column auto_renew was added to each of the three tables. Sponsored-by: Hochschule für Gesundheit (hsg), Germany Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29968|0 |1 is obsolete| | --- Comment #47 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 30250 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30250&action=edit Bug 11577: Code and intranet template changes This patch adds a checkbox for "Automatic renewal" to the checkout page. CanBookBeRenewed is modified to include two new errors: - auto_renew (renewal shouldn't be done manually) - auto_too_soon (renewal is premature and shouldn't be done manually) To test: 1) Add or edit an issuing rule with "Automatic renewal" and another one without it. 2) Issue at least three items: - automatic renewal by issuing rule - automatic renewal by Checkbox on the checkout page - no automatic renewal 3) Test the following steps for both: Home > Circulation > Checkouts Home > Patrons > Patron details 4) Confirm that issues with automatic renewal cannot be renewed manually, even if there are still renewals left and it's not too soon to renew. 5) Confirm that "Scheduled for automatic renewal" and the remaining renewals are displayed. If no renewals are left "Not renewable" should be displayed. 6) Confirm that issues without automatic renewal behave as usual. Sponsored-by: Hochschule für Gesundheit (hsg), Germany Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29970|0 |1 is obsolete| | --- Comment #49 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 30252 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30252&action=edit Bug 11577: Expand description of AllowRenewalLimitOverride With the introduction of the new automatic renewal feature global syspref AllowRenewalLimitOverride is expanded in meaning. It now gives the option to override blocks if: - the number of allowed renewals is exceeded - the renewal is premature (No renewal before) - the item is scheduled for automatic renewal - the renewal is premature and the item is scheduled for automatic renewal Sponsored-by: Hochschule für Gesundheit (hsg), Germany Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29972|0 |1 is obsolete| | --- Comment #51 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 30254 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30254&action=edit Bug 11577: OPAC prog theme changes This patch makes the prog version of opac-user.tt handle the new renewal errors "auto_renew" and "auto_too_soon". To test: 1) Set global syspref "opacthemes" to prog. 2) Test the same things as in previous patch. Sponsored-by: Hochschule für Gesundheit (hsg), Germany Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29974|0 |1 is obsolete| | --- Comment #53 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 30256 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30256&action=edit Bug 11577: Unit tests This patch fixes a few unit tests that broke because of the new feature. To test: 1) prove t/db_dependent/Circulation.t 2) prove t/db_dependent/Circulation_Issuingrule.t 3) prove t/db_dependent/Circulation_issue.t Sponsored-by: Hochschule für Gesundheit (hsg), Germany Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577 Holger Meißner <h.meissner.82@web.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29975|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577 Holger Meißner <h.meissner.82@web.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30249|0 |1 is obsolete| | --- Comment #57 from Holger Meißner <h.meissner.82@web.de> --- Created attachment 30693 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30693&action=edit Bug 11577: Add "Automatic renewal" to the circulation and fine rules This patch adds a column "Automatic renewal" to the circulation and fine rules table. To test: 1) Add or edit some issuing rules. 2) Confirm that "Automatic Renewal" is set to "No" by default and can be switched to "Yes". Sponsored-by: Hochschule für Gesundheit (hsg), Germany Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577 Holger Meißner <h.meissner.82@web.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30251|0 |1 is obsolete| | --- Comment #59 from Holger Meißner <h.meissner.82@web.de> --- Created attachment 30695 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30695&action=edit Bug 11577: Add 'auto_renew' and 'auto_too_soon' to renewal page This patch adds the new renewal errors 'auto_renew' and 'auto_too_soon' to the renewal interface. To test: 1) Issue two items: - one with automatic renewal and no value for "No renewal before" - another with automatic renewal and a value for "No renewal before" 2) Try to renew: Home > Circulation > Renew 3) Confirm there are error messages explaining that the items have been scheduled for automatic renewal and that one of the renewals is also premature. 4) If global syspref AllowRenewalLimitOverride is set to "Allow" you should be given the option to override. Sponsored-by: Hochschule für Gesundheit (hsg), Germany Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577 Holger Meißner <h.meissner.82@web.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30253|0 |1 is obsolete| | --- Comment #61 from Holger Meißner <h.meissner.82@web.de> --- Created attachment 30697 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30697&action=edit Bug 11577: OPAC bootstrap theme changes This patch makes opac-user.pl and the bootstrap version of opac-user.tt handle the new renewal errors "auto_renew" and "auto_too_soon". To test: 1) Set global syspref "opacthemes" to bootstrap. 2) Set global syspref "OpacRenewalAllowed" to Allow. 3) Test the same things as in previous patch, this time for the OPAC summary page. Sponsored-by: Hochschule für Gesundheit (hsg), Germany Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577 Holger Meißner <h.meissner.82@web.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30255|0 |1 is obsolete| | --- Comment #63 from Holger Meißner <h.meissner.82@web.de> --- Created attachment 30699 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30699&action=edit Bug 11577: Add an automatic renewal cronjob This patch adds a new cron script automatic_renewals.pl and a new entry in crontab.example. To test: 1) You need a few issues, some with automatic renewal and some without. 2) Confirm that each time you run misc/cronjobs/automatic_renewals.pl those issues are renewed that meet all of the following criteria: - automatic renewal has been scheduled either by issuing rule or by checkbox on the checkout page - the number of allowed renewals isn't exceeded - renewal isn't premature (No renewal before) 3) Confirm that all other issues are not affected. Sponsored-by: Hochschule für Gesundheit (hsg), Germany Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577 --- Comment #65 from Holger Meißner <h.meissner.82@web.de> --- Created attachment 30701 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30701&action=edit Bug 11577: Add Hochschule für Gesundheit to contributing institutions Automatic renewal is the second feature sponsored by the hsg. Sponsored-by: Hochschule für Gesundheit (hsg), Germany Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577 Holger Meißner <h.meissner.82@web.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30257|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577 --- Comment #69 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Comment on attachment 30699 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30699 Bug 11577: Add an automatic renewal cronjob Review of attachment 30699: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=11577&attachment=30699) ----------------------------------------------------------------- Could you also make this package safe by adding the relevant cron line to /debian/koha-common.cron.daily please -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #71 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Hi Holger, Great work so far, and a fantastic feature! I've given you some very minor follow-ups, hope that's ok. There's nothing major wrong and I'm happy that the code is all in good working order. I'm marking as Failed QA temporarily however whilst awaiting some QA feedback/follow-ups. I'm happy that these are minor enough that we need not go back to the Needs Signoff. Upon your submission, if you reset to Signed Off, I'll jump back in. Cheers for your efforts -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577 Holger Meißner <h.meissner.82@web.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30693|0 |1 is obsolete| | --- Comment #73 from Holger Meißner <h.meissner.82@web.de> --- Created attachment 31077 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31077&action=edit Bug 11577: Add "Automatic renewal" to the circulation and fine rules This patch adds a column "Automatic renewal" to the circulation and fine rules table. To test: 1) Add or edit some issuing rules. 2) Confirm that "Automatic Renewal" is set to "No" by default and can be switched to "Yes". Sponsored-by: Hochschule für Gesundheit (hsg), Germany Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577 Holger Meißner <h.meissner.82@web.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30695|0 |1 is obsolete| | --- Comment #75 from Holger Meißner <h.meissner.82@web.de> --- Created attachment 31079 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31079&action=edit Bug 11577: Add 'auto_renew' and 'auto_too_soon' to renewal page This patch adds the new renewal errors 'auto_renew' and 'auto_too_soon' to the renewal interface. To test: 1) Issue two items: - one with automatic renewal and no value for "No renewal before" - another with automatic renewal and a value for "No renewal before" 2) Try to renew: Home > Circulation > Renew 3) Confirm there are error messages explaining that the items have been scheduled for automatic renewal and that one of the renewals is also premature. 4) If global syspref AllowRenewalLimitOverride is set to "Allow" you should be given the option to override. Sponsored-by: Hochschule für Gesundheit (hsg), Germany Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577 Holger Meißner <h.meissner.82@web.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30697|0 |1 is obsolete| | --- Comment #77 from Holger Meißner <h.meissner.82@web.de> --- Created attachment 31081 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31081&action=edit Bug 11577: OPAC bootstrap theme changes This patch makes opac-user.pl and the bootstrap version of opac-user.tt handle the new renewal errors "auto_renew" and "auto_too_soon". To test: 1) Set global syspref "opacthemes" to bootstrap. 2) Set global syspref "OpacRenewalAllowed" to Allow. 3) Test the same things as in previous patch, this time for the OPAC summary page. Sponsored-by: Hochschule für Gesundheit (hsg), Germany Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577 Holger Meißner <h.meissner.82@web.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30699|0 |1 is obsolete| | --- Comment #79 from Holger Meißner <h.meissner.82@web.de> --- Created attachment 31083 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31083&action=edit Bug 11577: Add an automatic renewal cronjob This patch adds a new cron script automatic_renewals.pl and a new entry in crontab.example. To test: 1) You need a few issues, some with automatic renewal and some without. 2) Confirm that each time you run misc/cronjobs/automatic_renewals.pl those issues are renewed that meet all of the following criteria: - automatic renewal has been scheduled either by issuing rule or by checkbox on the checkout page - the number of allowed renewals isn't exceeded - renewal isn't premature (No renewal before) 3) Confirm that all other issues are not affected. Sponsored-by: Hochschule für Gesundheit (hsg), Germany Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577 --- Comment #81 from Holger Meißner <h.meissner.82@web.de> --- Created attachment 31085 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31085&action=edit Bug 11577: Add Hochschule für Gesundheit to contributing institutions Automatic renewal is the second feature sponsored by the hsg. Sponsored-by: Hochschule für Gesundheit (hsg), Germany Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577 Holger Meißner <h.meissner.82@web.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30701|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577 --- Comment #86 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 31199 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31199&action=edit [PASSED QA] Bug 11577: Add "Automatic renewal" to the circulation and fine rules This patch adds a column "Automatic renewal" to the circulation and fine rules table. To test: 1) Add or edit some issuing rules. 2) Confirm that "Automatic Renewal" is set to "No" by default and can be switched to "Yes". Sponsored-by: Hochschule für Gesundheit (hsg), Germany Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577 --- Comment #88 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 31201 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31201&action=edit [PASSED QA] Bug 11577: Add 'auto_renew' and 'auto_too_soon' to renewal page This patch adds the new renewal errors 'auto_renew' and 'auto_too_soon' to the renewal interface. To test: 1) Issue two items: - one with automatic renewal and no value for "No renewal before" - another with automatic renewal and a value for "No renewal before" 2) Try to renew: Home > Circulation > Renew 3) Confirm there are error messages explaining that the items have been scheduled for automatic renewal and that one of the renewals is also premature. 4) If global syspref AllowRenewalLimitOverride is set to "Allow" you should be given the option to override. Sponsored-by: Hochschule für Gesundheit (hsg), Germany Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577 --- Comment #90 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 31203 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31203&action=edit [PASSED QA] Bug 11577: OPAC bootstrap theme changes This patch makes opac-user.pl and the bootstrap version of opac-user.tt handle the new renewal errors "auto_renew" and "auto_too_soon". To test: 1) Set global syspref "opacthemes" to bootstrap. 2) Set global syspref "OpacRenewalAllowed" to Allow. 3) Test the same things as in previous patch, this time for the OPAC summary page. Sponsored-by: Hochschule für Gesundheit (hsg), Germany Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577 --- Comment #92 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 31205 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31205&action=edit [PASSED QA] Bug 11577: Add an automatic renewal cronjob This patch adds a new cron script automatic_renewals.pl and a new entry in crontab.example. To test: 1) You need a few issues, some with automatic renewal and some without. 2) Confirm that each time you run misc/cronjobs/automatic_renewals.pl those issues are renewed that meet all of the following criteria: - automatic renewal has been scheduled either by issuing rule or by checkbox on the checkout page - the number of allowed renewals isn't exceeded - renewal isn't premature (No renewal before) 3) Confirm that all other issues are not affected. Sponsored-by: Hochschule für Gesundheit (hsg), Germany Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577 --- Comment #94 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 31207 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31207&action=edit [PASSED QA] Bug 11577: Add Hochschule für Gesundheit to contributing institutions Automatic renewal is the second feature sponsored by the hsg. Sponsored-by: Hochschule für Gesundheit (hsg), Germany Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577 --- Comment #96 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 31209 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31209&action=edit [QA FOLLOWUP] Bug 11577 : Fixing a tiny copy/paste issue -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31077|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31079|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31081|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31083|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31085|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #97 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Thanks so much again for persevering with this Holger! I've done a minor QA Followup for you to correct that tiny copy/paste error in the unit tests patch, but I'm happy everything else passes and we're covered in the unit tests reasonably comprehensively. I've marked the opac prog theme patch as NOT REQUIRED as we're deprecating that theme, but as it's a completely independent patch, I'm happy it does not fail QA. To the RM: Holger has followed the general practices already present with Circulation.t regarding adding data for testing against. I'm not 100% sure how the roll-back stuff works when using C4 subs to add data within the test so may be sensible to take a glance over that to check I've not missed something obvious. As there's plenty already in that test that will make anything but the most basic of sample database fail, then I didn't see this as something I could reasonably fail QA on. I would like to re-factor this test script to use TestBuilder should that go in and I will happily do that as a follow-up in a separate bug when time permits. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577 --- Comment #99 from Holger Meißner <h.meissner.82@web.de> --- Created attachment 31640 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31640&action=edit Bug 11577: Add auto_renew flags to the database - issues.auto_renew - old_issues.auto_renew - issuingrules.auto_renew Default value is zero. To test: 1) Run installer/data/mysql/updatedatabase.pl 2) Create SQL reports like: SELECT * FROM issues LIMIT 0,1 3) Confirm that a column auto_renew was added to each of the three tables. Sponsored-by: Hochschule für Gesundheit (hsg), Germany Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577 --- Comment #101 from Holger Meißner <h.meissner.82@web.de> --- Created attachment 31642 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31642&action=edit Bug 11577: Code and intranet template changes This patch adds a checkbox for "Automatic renewal" to the checkout page. CanBookBeRenewed is modified to include two new errors: - auto_renew (renewal shouldn't be done manually) - auto_too_soon (renewal is premature and shouldn't be done manually) To test: 1) Add or edit an issuing rule with "Automatic renewal" and another one without it. 2) Issue at least three items: - automatic renewal by issuing rule - automatic renewal by Checkbox on the checkout page - no automatic renewal 3) Test the following steps for both: Home > Circulation > Checkouts Home > Patrons > Patron details 4) Confirm that issues with automatic renewal cannot be renewed manually, even if there are still renewals left and it's not too soon to renew. 5) Confirm that "Scheduled for automatic renewal" and the remaining renewals are displayed. If no renewals are left "Not renewable" should be displayed. 6) Confirm that issues without automatic renewal behave as usual. Sponsored-by: Hochschule für Gesundheit (hsg), Germany Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577 --- Comment #103 from Holger Meißner <h.meissner.82@web.de> --- Created attachment 31644 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31644&action=edit Bug 11577: Expand description of AllowRenewalLimitOverride With the introduction of the new automatic renewal feature global syspref AllowRenewalLimitOverride is expanded in meaning. It now gives the option to override blocks if: - the number of allowed renewals is exceeded - the renewal is premature (No renewal before) - the item is scheduled for automatic renewal - the renewal is premature and the item is scheduled for automatic renewal Sponsored-by: Hochschule für Gesundheit (hsg), Germany Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577 --- Comment #105 from Holger Meißner <h.meissner.82@web.de> --- Created attachment 31646 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31646&action=edit Bug 11577: OPAC prog theme changes This patch makes the prog version of opac-user.tt handle the new renewal errors "auto_renew" and "auto_too_soon". To test: 1) Set global syspref "opacthemes" to prog. 2) Test the same things as in previous patch. Sponsored-by: Hochschule für Gesundheit (hsg), Germany Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577 --- Comment #107 from Holger Meißner <h.meissner.82@web.de> --- Created attachment 31648 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31648&action=edit Bug 11577: Unit tests This patch fixes two unit tests that broke because of the new feature. Also adds some new test cases. To test: 1) prove t/db_dependent/Circulation.t 2) prove t/db_dependent/Circulation_Issuingrule.t Sponsored-by: Hochschule für Gesundheit (hsg), Germany Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577 --- Comment #109 from Holger Meißner <h.meissner.82@web.de> --- Created attachment 31650 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31650&action=edit Bug 11577 : Fixing a tiny typo Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577 Holger Meißner <h.meissner.82@web.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31198|0 |1 is obsolete| | --- Comment #111 from Holger Meißner <h.meissner.82@web.de> --- Created attachment 31652 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31652&action=edit [PASSED QA] Bug 11577: Add auto_renew flags to the database - issues.auto_renew - old_issues.auto_renew - issuingrules.auto_renew Default value is zero. To test: 1) Run installer/data/mysql/updatedatabase.pl 2) Create SQL reports like: SELECT * FROM issues LIMIT 0,1 3) Confirm that a column auto_renew was added to each of the three tables. Sponsored-by: Hochschule für Gesundheit (hsg), Germany Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577 Holger Meißner <h.meissner.82@web.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31200|0 |1 is obsolete| | --- Comment #113 from Holger Meißner <h.meissner.82@web.de> --- Created attachment 31654 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31654&action=edit [PASSED QA] Bug 11577: Code and intranet template changes This patch adds a checkbox for "Automatic renewal" to the checkout page. CanBookBeRenewed is modified to include two new errors: - auto_renew (renewal shouldn't be done manually) - auto_too_soon (renewal is premature and shouldn't be done manually) To test: 1) Add or edit an issuing rule with "Automatic renewal" and another one without it. 2) Issue at least three items: - automatic renewal by issuing rule - automatic renewal by Checkbox on the checkout page - no automatic renewal 3) Test the following steps for both: Home > Circulation > Checkouts Home > Patrons > Patron details 4) Confirm that issues with automatic renewal cannot be renewed manually, even if there are still renewals left and it's not too soon to renew. 5) Confirm that "Scheduled for automatic renewal" and the remaining renewals are displayed. If no renewals are left "Not renewable" should be displayed. 6) Confirm that issues without automatic renewal behave as usual. Sponsored-by: Hochschule für Gesundheit (hsg), Germany Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577 Holger Meißner <h.meissner.82@web.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31202|0 |1 is obsolete| | --- Comment #115 from Holger Meißner <h.meissner.82@web.de> --- Created attachment 31656 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31656&action=edit [PASSED QA] Bug 11577: Expand description of AllowRenewalLimitOverride With the introduction of the new automatic renewal feature global syspref AllowRenewalLimitOverride is expanded in meaning. It now gives the option to override blocks if: - the number of allowed renewals is exceeded - the renewal is premature (No renewal before) - the item is scheduled for automatic renewal - the renewal is premature and the item is scheduled for automatic renewal Sponsored-by: Hochschule für Gesundheit (hsg), Germany Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577 Holger Meißner <h.meissner.82@web.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31204|0 |1 is obsolete| | --- Comment #117 from Holger Meißner <h.meissner.82@web.de> --- Created attachment 31658 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31658&action=edit [NOT REQUIRED] Bug 11577: OPAC prog theme changes This patch makes the prog version of opac-user.tt handle the new renewal errors "auto_renew" and "auto_too_soon". To test: 1) Set global syspref "opacthemes" to prog. 2) Test the same things as in previous patch. Sponsored-by: Hochschule für Gesundheit (hsg), Germany Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577 Holger Meißner <h.meissner.82@web.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31206|0 |1 is obsolete| | --- Comment #119 from Holger Meißner <h.meissner.82@web.de> --- Created attachment 31660 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31660&action=edit [PASSED QA] Bug 11577: Unit tests This patch fixes two unit tests that broke because of the new feature. Also adds some new test cases. To test: 1) prove t/db_dependent/Circulation.t 2) prove t/db_dependent/Circulation_Issuingrule.t Sponsored-by: Hochschule für Gesundheit (hsg), Germany Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577 Holger Meißner <h.meissner.82@web.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31208|0 |1 is obsolete| | --- Comment #121 from Holger Meißner <h.meissner.82@web.de> --- Created attachment 31662 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31662&action=edit [PASSED QA] Bug 11577 : Fixing a tiny typo Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577 Holger Meißner <h.meissner.82@web.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31207|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577 Holger Meißner <h.meissner.82@web.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31641|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577 Holger Meißner <h.meissner.82@web.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31643|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577 Holger Meißner <h.meissner.82@web.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31645|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577 Holger Meißner <h.meissner.82@web.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31647|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577 Holger Meißner <h.meissner.82@web.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31649|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577 Holger Meißner <h.meissner.82@web.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31651|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #124 from Tomás Cohen Arazi <tomascohen@gmail.com> --- New feature pushed to master. Thanks Holger! -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Summary|[ENH] Automatic renewal |Automatic renewals |feature | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com --- Comment #126 from Mason James <mtj@kohaaloha.com> --- Skipping patch for 3.16.x series -- You are receiving this mail because: You are watching all bug changes.