[Bug 11625] New: Default to logged in library for circ rules and notices & slips
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11625 Bug ID: 11625 Summary: Default to logged in library for circ rules and notices & slips Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt@gmail.com Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org It has come to our attention that some librarians will accidentally change default circulation rules and notices be accident, assuming they are working on rules and notices for their library by default. If a librarian is logged in with a set branchcode, we should display that branches rules by default, and require them to choose the "All libraries" sections by hand. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11625 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11625 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11625 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 24845 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24845&action=edit Bug 11625 - Default to logged in library for circ rules and notices & slips This patch makes the default circ rules and notices/slips to edit the logged in branch, if one is set. Test Plan: 1) Apply this patch 2) Log into staff side, and set your library 3) Browse to Administration/Circulation and fines rules 4) Note the rule set selected is for your library 5) Select "All libraries" 6) Note the rule set selected is for "All libraries" 7) Browse to Toos/Notices & slips 8) Note the notice set selected is for your library 9) Select "All libraries" 10) Not the rule set selected is for "All libraries" 11) Click "New Notice" 12) Note the Library field is set to "All libraries" -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11625 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11625 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24845|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 24861 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24861&action=edit [SIGNED-OFF] Bug 11625 - Default to logged in library for circ rules and notices & slips This patch makes the default circ rules and notices/slips to edit the logged in branch, if one is set. Test Plan: 1) Apply this patch 2) Log into staff side, and set your library 3) Browse to Administration/Circulation and fines rules 4) Note the rule set selected is for your library 5) Select "All libraries" 6) Note the rule set selected is for "All libraries" 7) Browse to Toos/Notices & slips 8) Note the notice set selected is for your library 9) Select "All libraries" 10) Not the rule set selected is for "All libraries" 11) Click "New Notice" 12) Note the Library field is set to "All libraries" Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11625 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |katrin.fischer@bsz-bw.de --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm, I noticed that now when you log in as superlibrarian, there is a difference in behaviour. If you try to save a rule for "All libraries" without picking a library first, it won't save. Could it be this line here? -my $branch = $input->param('branch') || ( C4::Branch::onlymine() ? ( C4::Branch +my $branch = $input->param('branch') || C4::Branch::mybranch(); -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11625 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am not a fan of using the superlibrarian, but I think in this case it is a little bug that could be fixed by keeping a fallback? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11625 --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Katrin, do you mean *any* superlibrarian? Or just the database login superlibrarian? (In reply to Katrin Fischer from comment #3)
Hm, I noticed that now when you log in as superlibrarian, there is a difference in behaviour. If you try to save a rule for "All libraries" without picking a library first, it won't save.
Could it be this line here? -my $branch = $input->param('branch') || ( C4::Branch::onlymine() ? ( C4::Branch +my $branch = $input->param('branch') || C4::Branch::mybranch();
-- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11625 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Ah sorry Kyle, I meant the database user. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11625 --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 24941 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24941&action=edit Bug 11625 [QA Followup] - Default to logged in library for circ rules and notices & slips -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11625 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- Thanks! This followup should resolve the problem. As an aside, I wonder if you should rid ourselves of the 'database' user altogether, and just provide a command line script for creating users ( or at least superlibrarians ). It just seems to cause more issues than it solves. (In reply to Katrin Fischer from comment #6)
Ah sorry Kyle, I meant the database user.
-- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11625 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I agree with you, but you would also have to provide a way to create the branch and category code... and that complicates things a bit more. Also you would have to prevent people from using it after running the web installer with the database user. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11625 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11625 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24861|0 |1 is obsolete| | Attachment #24941|0 |1 is obsolete| | --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 24984 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24984&action=edit [PASSED QA] Bug 11625 - Default to logged in library for circ rules and notices & slips This patch makes the default circ rules and notices/slips to edit the logged in branch, if one is set. Test Plan: 1) Apply this patch 2) Log into staff side, and set your library 3) Browse to Administration/Circulation and fines rules 4) Note the rule set selected is for your library 5) Select "All libraries" 6) Note the rule set selected is for "All libraries" 7) Browse to Toos/Notices & slips 8) Note the notice set selected is for your library 9) Select "All libraries" 10) Not the rule set selected is for "All libraries" 11) Click "New Notice" 12) Note the Library field is set to "All libraries" Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes QA script and tests. Small ergonomic improvement, no regressions found. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11625 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 24985 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24985&action=edit [PASSED QA] Bug 11625 [QA Followup] - Default to logged in library for circ rules and notices & slips Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Fixes the case that someone logs in as database user and changes circulation rules without explicitly selecting a library first. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11625 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11747 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11625 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion CC| |gmcharlt@gmail.com Blocks| |11747 --- Comment #12 from Galen Charlton <gmcharlt@gmail.com> --- I very much agree that this is a usability improvement -- *if* more than one library is sharing the database. However, I'm not convinced that this is an improvement for single-branch libraries or library systems that have multiple branches but no variation in circulation policy. For such libraries, this patch means that going to circulation rules or notices & slips immediately requires them to make at least two more clicks. Setting to in discussion for feedback from such libraries and suggestions for ways to make this work well both for consortia and single-branch/single-system users. I'm also setting this bug as a blocker for bug 11747 since they cover the same underlying concept. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11625 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11625 --- Comment #13 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 25839 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25839&action=edit Bug 11625 [QA Followup 2] - Don't default to branch specific rules if only one branch exists -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11625 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25839|0 |1 is obsolete| | --- Comment #14 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 25840 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25840&action=edit Bug 11625 [QA Followup 2] - Don't default to branch specific rules if only one branch exists -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11625 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m --- Comment #15 from Jonathan Druart <jonathan.druart@biblibre.com> --- After some reflexion, I am not sure it is the right way to fix it. For instance, if there is no specific rules and all libraries use the same (default) rules, the librarian will be confused. Before this patch, the rules were displayed and after the table will be empty. Maybe should we check if rules are defined for the branch selected automatically? I need additional QA points of view. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11625 --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think this is a tricky one, it's hard to tell, what the expected behaviour is. We don't use the default rules much, even if there is only one librray we use the specific page for the rules - maybe a bad habit? Maybe there are just multiple ways? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11625 --- Comment #17 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Katrin Fischer from comment #16)
I think this is a tricky one, it's hard to tell, what the expected behaviour is. We don't use the default rules much, even if there is only one librray we use the specific page for the rules - maybe a bad habit? Maybe there are just multiple ways?
I can tell you that we always use only the default rules in the case of a single library. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11625 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion Severity|minor |enhancement --- Comment #18 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think we haven't been able to find consensus on how this should work so far. I'd suggest to try and get some more opinions from libraries on this. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11625 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@quecheelibrary.org --- Comment #19 from Nick Clemens <nick@quecheelibrary.org> --- Would it be reasonable to control this with user permissions? -If user has access to all circ rules they default to All Libraries -If user has access only to their circ rules it defaults to logged in library (or home library) The issue we have in seeking this enhancement is that we want to give all libraries the ability to control their own circ rules, but prevent them from altering defaults rules of the consortia This would apply to Bug 11747 in terms of overdue notice/status triggers as well and could be one permission for both, determining whether they are library admins or system admins -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11625 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24984|0 |1 is obsolete| | Attachment #24985|0 |1 is obsolete| | Attachment #25840|0 |1 is obsolete| | --- Comment #20 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 35460 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35460&action=edit Bug 11625 - Default to logged in library for circ rules and notices & slips This patch makes the default circ rules and notices/slips to edit the logged in branch, if one is set. Test Plan: 1) Apply this patch 2) Log into staff side, and set your library 3) Browse to Administration/Circulation and fines rules 4) Note the rule set selected is for your library 5) Select "All libraries" 6) Note the rule set selected is for "All libraries" 7) Browse to Toos/Notices & slips 8) Note the notice set selected is for your library 9) Select "All libraries" 10) Not the rule set selected is for "All libraries" 11) Click "New Notice" 12) Note the Library field is set to "All libraries" Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes QA script and tests. Small ergonomic improvement, no regressions found. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11625 --- Comment #21 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 35461 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35461&action=edit Bug 11625 [QA Followup] - Default to logged in library for circ rules and notices & slips Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Fixes the case that someone logs in as database user and changes circulation rules without explicitly selecting a library first. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11625 --- Comment #22 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 35462 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35462&action=edit Bug 11625 [QA Followup 2] - Don't default to branch specific rules if only one branch exists -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11625 --- Comment #23 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 35463 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35463&action=edit Bug 11625 [QA Followup 3] - Use system preferences to control behavior -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11625 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off --- Comment #24 from Kyle M Hall <kyle@bywatersolutions.com> --- I don't think we'll ever get consensus on this, so I think the best way to move forward is to make this behavior controlled via system preferences. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11625 --- Comment #25 from Jonathan Druart <jonathan.druart@biblibre.com> --- Kyle, do you think it's relevant to have 2 prefs for 11747 and this one? Maybe 1 generic pref could be used for the both places. Katrin, Nick: an opinion? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11625 --- Comment #26 from Nick Clemens <nick@quecheelibrary.org> --- I am in favor of one syspref but would accept two if someone has a strong preference to keep them separate -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11625 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion --- Comment #27 from Jonathan Druart <jonathan.druart@biblibre.com> --- Back to in discussion for the number of pref choice... -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11625 --- Comment #28 from Kyle M Hall <kyle@bywatersolutions.com> --- My opinion is that these two sections of Koha have little to do with each other. They aren't even in the same sections! One is in tools, the other in administration. As such, I feel that is more appropriate to keep the behaviors as two separate preferences. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11625 --- Comment #29 from Kyle M Hall <kyle@bywatersolutions.com> --- It's been a month with no more feedback, resetting the status. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11625 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11625 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35460|0 |1 is obsolete| | Attachment #35461|0 |1 is obsolete| | Attachment #35462|0 |1 is obsolete| | Attachment #35463|0 |1 is obsolete| | --- Comment #30 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 37055 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37055&action=edit Bug 11625 - Default to logged in library for circ rules and notices & slips This patch makes the default circ rules and notices/slips to edit the logged in branch, if one is set. Test Plan: 1) Apply this patch 2) Log into staff side, and set your library 3) Browse to Administration/Circulation and fines rules 4) Note the rule set selected is for your library 5) Select "All libraries" 6) Note the rule set selected is for "All libraries" 7) Browse to Toos/Notices & slips 8) Note the notice set selected is for your library 9) Select "All libraries" 10) Not the rule set selected is for "All libraries" 11) Click "New Notice" 12) Note the Library field is set to "All libraries" Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes QA script and tests. Small ergonomic improvement, no regressions found. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11625 --- Comment #31 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 37056 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37056&action=edit Bug 11625 [QA Followup] - Default to logged in library for circ rules and notices & slips Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Fixes the case that someone logs in as database user and changes circulation rules without explicitly selecting a library first. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11625 --- Comment #32 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 37057 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37057&action=edit Bug 11625 [QA Followup 2] - Don't default to branch specific rules if only one branch exists -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11625 --- Comment #33 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 37058 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37058&action=edit Bug 11625 [QA Followup 3] - Use system preferences to control behavior -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11625 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |jonathan.druart@biblibre.co |y.org |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11625 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #34 from Jonathan Druart <jonathan.druart@biblibre.com> --- Applying: Bug 11625 [QA Followup 3] - Use system preferences to control behavior fatal: sha1 information is lacking or useless (admin/smart-rules.pl). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11625 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11625 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37055|0 |1 is obsolete| | Attachment #37056|0 |1 is obsolete| | Attachment #37057|0 |1 is obsolete| | Attachment #37058|0 |1 is obsolete| | --- Comment #35 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 38093 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38093&action=edit Bug 11625 - Default to logged in library for circ rules and notices & slips This patch makes the default circ rules and notices/slips to edit the logged in branch, if one is set. Test Plan: 1) Apply this patch 2) Log into staff side, and set your library 3) Browse to Administration/Circulation and fines rules 4) Note the rule set selected is for your library 5) Select "All libraries" 6) Note the rule set selected is for "All libraries" 7) Browse to Toos/Notices & slips 8) Note the notice set selected is for your library 9) Select "All libraries" 10) Not the rule set selected is for "All libraries" 11) Click "New Notice" 12) Note the Library field is set to "All libraries" Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes QA script and tests. Small ergonomic improvement, no regressions found. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11625 --- Comment #36 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 38094 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38094&action=edit Bug 11625 [QA Followup] - Default to logged in library for circ rules and notices & slips Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Fixes the case that someone logs in as database user and changes circulation rules without explicitly selecting a library first. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11625 --- Comment #37 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 38095 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38095&action=edit Bug 11625 [QA Followup 2] - Don't default to branch specific rules if only one branch exists -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11625 --- Comment #38 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 38096 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38096&action=edit Bug 11625 [QA Followup 3] - Use system preferences to control behavior -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11625 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38093|0 |1 is obsolete| | Attachment #38094|0 |1 is obsolete| | Attachment #38095|0 |1 is obsolete| | Attachment #38096|0 |1 is obsolete| | --- Comment #39 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 38276 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38276&action=edit Bug 11625 - Add system preferences DefaultToLoggedInLibraryCircRules and DefaultToLoggedInLibraryNoticesSlips Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11625 --- Comment #40 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 38277 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38277&action=edit Bug 11625 - Implement DefaultToLoggedInLibraryNoticesSlips Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11625 --- Comment #41 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 38278 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38278&action=edit Bug 11625 - Implement DefaultToLoggedInLibraryCircRules This patch set makes the default circ rules and notices/slips to edit the logged in branch, if one is set. Test Plan: 1) Apply this patch 2) Log into staff side, and set your library 3) Browse to Administration/Circulation and fines rules 4) Note the rule set selected is for your library 5) Select "All libraries" 6) Note the rule set selected is for "All libraries" 7) Browse to Toos/Notices & slips 8) Note the notice set selected is for your library 9) Select "All libraries" 10) Not the rule set selected is for "All libraries" 11) Click "New Notice" 12) Note the Library field is set to "All libraries" Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes QA script and tests. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11625 --- Comment #42 from Jonathan Druart <jonathan.druart@biblibre.com> --- Comment on attachment 38277 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38277 Bug 11625 - Implement DefaultToLoggedInLibraryNoticesSlips Review of attachment 38277: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=11625&attachment=38277) ----------------------------------------------------------------- ::: tools/letter.pl @@ +85,5 @@
+ : $input->param('branchcode') ? $input->param('branchcode') + : $op ? $input->param('branchcode') + : GetBranchesCount() == 1 ? undef + : C4::Branch::mybranch(); +
Sorry but I am not confident enough with this part of code to pass qa on it today. This script is a house of cards and the branchcode variable is used at several place. You modify it at the beginning of the script, but it could introduce side effects. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11625 --- Comment #43 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 38422 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38422&action=edit Bug 11625: [COUNTER-PATCH] Implement DefaultToLoggedInLibraryNoticesSlips -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11625 --- Comment #44 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Jonathan Druart from comment #43)
Created attachment 38422 [details] [review] Bug 11625: [COUNTER-PATCH] Implement DefaultToLoggedInLibraryNoticesSlips
Kyle, either I missed something and this patch is wrong or it does the same as yours. It looks simpler. Could you please take a look? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11625 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38422|0 |1 is obsolete| | --- Comment #45 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 38424 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38424&action=edit Bug 11625: [COUNTER-PATCH] Implement DefaultToLoggedInLibraryNoticesSlips -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11625 --- Comment #46 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Jonathan Druart from comment #45)
Created attachment 38424 [details] [review] Bug 11625: [COUNTER-PATCH] Implement DefaultToLoggedInLibraryNoticesSlips
I tried to clean the branchcode value is this patch. It is the same idea as in your patch, if branchcode eq '*', the user has selected the 'all libraries' in the dropdown list. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11625 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|jonathan.druart@biblibre.co | |m | CC| |m.de.rooy@rijksmuseum.nl --- Comment #47 from Jonathan Druart <jonathan.druart@biblibre.com> --- I would like to get point of view from another QAer on this one and bug 11747. I don't know to be sure Kyle's patch won't introduce regression on the tools/letter.pl page. Moreover I am still concerned by the addition of 3 prefs to do the same thing. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11625 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com, | |paul.poulain@biblibre.com --- Comment #48 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Ccing some QAers since we are waiting for feedbacks for 3 months now. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11625 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #49 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- I put this patch in FQA now. I think first Kyle should comment on the counter patch before anyone else does anything else :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11625 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11625 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38276|0 |1 is obsolete| | Attachment #38277|0 |1 is obsolete| | Attachment #38278|0 |1 is obsolete| | Attachment #38424|0 |1 is obsolete| | --- Comment #50 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 41795 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41795&action=edit [SIGNED-OFF] Bug 11625 - Add system preferences DefaultToLoggedInLibraryCircRules and DefaultToLoggedInLibraryNoticesSlips Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11625 --- Comment #51 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 41796 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41796&action=edit [SIGNED-OFF] Bug 11625 - Implement DefaultToLoggedInLibraryCircRules This patch set makes the default circ rules and notices/slips to edit the logged in branch, if one is set. Test Plan: 1) Apply this patch 2) Log into staff side, and set your library 3) Browse to Administration/Circulation and fines rules 4) Note the rule set selected is for your library 5) Select "All libraries" 6) Note the rule set selected is for "All libraries" 7) Browse to Toos/Notices & slips 8) Note the notice set selected is for your library 9) Select "All libraries" 10) Not the rule set selected is for "All libraries" 11) Click "New Notice" 12) Note the Library field is set to "All libraries" Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes QA script and tests. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11625 --- Comment #52 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 41797 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41797&action=edit [SIGNED-OFF] Bug 11625: Implement DefaultToLoggedInLibraryNoticesSlips Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11625 --- Comment #53 from Kyle M Hall <kyle.m.hall@gmail.com> --- (In reply to Marcel de Rooy from comment #49)
I put this patch in FQA now. I think first Kyle should comment on the counter patch before anyone else does anything else :)
Looks good to me! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11625 Nicole Engard (ByWater) <nicole@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nicole@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11625 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan@bywatersolutions.co | |m --- Comment #54 from Brendan Gallagher <brendan@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #47)
I would like to get point of view from another QAer on this one and bug 11747. I don't know to be sure Kyle's patch won't introduce regression on the tools/letter.pl page. Moreover I am still concerned by the addition of 3 prefs to do the same thing.
I did not see a regression in the tools/letter.pl area - do you have an exact process - I test but not find problem with the letter I have already. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11625 --- Comment #55 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Brendan Gallagher from comment #54)
(In reply to Jonathan Druart from comment #47)
I would like to get point of view from another QAer on this one and bug 11747. I don't know to be sure Kyle's patch won't introduce regression on the tools/letter.pl page. Moreover I am still concerned by the addition of 3 prefs to do the same thing.
I did not see a regression in the tools/letter.pl area - do you have an exact process - I test but not find problem with the letter I have already.
This is no longer valid, Kyle validated my counter patch. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11625 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #56 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- For both 11625 and 11747 (I have squashed the patch, I don't which patch is guilty): 1) FAIL installer/data/mysql/updatedatabase.pl FAIL forbidden patterns forbidden pattern: Use INSERT IGNORE INTO on inserting a new syspref (see bug 9071) (line 11101) forbidden pattern: Use INSERT IGNORE INTO on inserting a new syspref (see bug 9071) (line 11116) and 11109 print "Upgrade to $DBversion done (Bug 13379 - Modify authorised_values.category to varchar(32))\n"; 11120 print "Upgrade to $DBversion done (Bug 13379 - Modify authorised_values.category to varchar(32))\n"; Wrong c/p. Please prefer to amend the original patch than submit another follow-up (to prevent future conflicts). Otherwise the code looks good. I am redoing some UI tests. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11625 --- Comment #57 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- It does not work: Try and delete a notice for a given library (not the default one). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11625 --- Comment #58 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #57)
It does not work: Try and delete a notice for a given library (not the default one).
It looks like a bug from master, if IndependentBranches is ON. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11625 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11625 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41795|0 |1 is obsolete| | Attachment #41796|0 |1 is obsolete| | Attachment #41797|0 |1 is obsolete| | --- Comment #59 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 43496 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43496&action=edit Bug 11625 - Add system preferences DefaultToLoggedInLibraryCircRules and DefaultToLoggedInLibraryNoticesSlips Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Amended patch: INSERT IGNORE INTO + msg -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11625 --- Comment #60 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 43497 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43497&action=edit Bug 11625 - Implement DefaultToLoggedInLibraryCircRules This patch set makes the default circ rules and notices/slips to edit the logged in branch, if one is set. Test Plan: 1) Apply this patch 2) Log into staff side, and set your library 3) Browse to Administration/Circulation and fines rules 4) Note the rule set selected is for your library 5) Select "All libraries" 6) Note the rule set selected is for "All libraries" 7) Browse to Toos/Notices & slips 8) Note the notice set selected is for your library 9) Select "All libraries" 10) Not the rule set selected is for "All libraries" 11) Click "New Notice" 12) Note the Library field is set to "All libraries" Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes QA script and tests. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11625 --- Comment #61 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 43498 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43498&action=edit Bug 11625: Implement DefaultToLoggedInLibraryNoticesSlips Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11625 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #62 from Kyle M Hall <kyle@bywatersolutions.com> --- Patches pushed to master! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11625 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15568 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15568 [Bug 15568] Circ rules are not displayed anymore -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org