[Bug 17965] New: TT syntax for notices - Prove that DUEGST is compatible
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17965 Bug ID: 17965 Summary: TT syntax for notices - Prove that DUEGST is compatible Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart@bugs.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17965 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|TT syntax for notices - |TT syntax for notices - |Prove that DUEGST is |Prove that DUEDGST is |compatible |compatible -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17965 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17970, 17964 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17964 [Bug 17964] TT syntax for notices - Prove that CHECKIN and CHECKOUT are compatible https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17970 [Bug 17970] GetPreparedLetter does not warn when expected -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17965 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17965 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 59439 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59439&action=edit Bug 17965: TT syntax for notices - Prove that DUEDGST is compatible This notice template have the particular feature of using <<count>>. This value is substitued during the process of the notice template. For the TT syntax, all what we need is to send the values to substitute to the template. Note that items.content can also be used in these template, you can have a look at bug 17967 to see a better alternative to this marker. Test plan: Generate DUEDGST and DUE notice messages. You should be able to generate the same messages with the TT syntax. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17965 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17966 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17966 [Bug 17966] TT syntax for notices - Prove that ISSUESLIP is compatible -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17965 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17975 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17975 [Bug 17975] TT syntax for notices - Prove that HOLD_SLIP is compatible -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17965 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|17966 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17966 [Bug 17966] TT syntax for notices - Prove that ISSUESLIP is compatible -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17965 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I forgot an important thing here: the items.fine value which was available in the historical syntax is no longer supported. It's of course a bug we will need to address. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17965 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #2)
I forgot an important thing here: the items.fine value which was available in the historical syntax is no longer supported. It's of course a bug we will need to address.
This is not for DUEDGST but ODUE, forget it :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17965 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17961 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17961 [Bug 17961] TT syntax for notices - Prove we have an equivalent for our historical custom syntax -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17965 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17965 --- Comment #4 from Marc Véron <veron@veron.ch> --- I tested this patch on top of 17979, 17963 and 17964 ( https://bugs.koha-community.org/bugzilla3/showdependencygraph.cgi?id=17965 ) DUEDGST notice is defined as: You have <<count>> items due, with TT syntax: [% count %] The message created (for a patron with 2 items due) is: You have 2 items due, with TT syntax: [% count %] Expected: You have 2 items due, with TT syntax: 2 Did I forget a dependency or is something wrong with the definition? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17965 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Marc Véron from comment #4)
I tested this patch on top of 17979, 17963 and 17964 ( https://bugs.koha-community.org/bugzilla3/showdependencygraph.cgi?id=17965 )
It works for me, could you confirm you apply 17970 and not 17979? You should use `yes|git bz apply 17965` to apply the correct dependencies (with the patched git-bz to apply dependencies) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17965 --- Comment #6 from Marc Véron <veron@veron.ch> --- Re-tested. Applied 17970, 17963, 17964, 17965. Changed DUEDGST to You have <<count>> items due, with TT syntax: [% count %] items due Run: koha-foreach --enabled --email /home/marc/koha/misc/cronjobs/advance_notices.pl -c Verify message(including time created...) in a patron's "Sent notices" Get: You have 2 items due, with TT syntax: [% count %] items due Running TemplateToolkit.t fails the very first time, if I run it again it passes OK. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17965 --- Comment #7 from Marc Véron <veron@veron.ch> --- ...and that are the two outputs of TemplateToolkit.t: --First run --------------------------- marc@debian8vm:~/koha$ prove t/db_dependent/Letters/TemplateToolkit.t t/db_dependent/Letters/TemplateToolkit.t .. 1/16 DBD::mysql::st execute failed: Duplicate entry '37' for key 'PRIMARY' [for Statement "INSERT INTO old_issues SELECT * FROM issues WHERE borrowernumber = ? AND itemnumber = ?" with ParamValues: 0='654336', 1='25'] at /home/marc/koha/C4/Circulation.pm line 2172. DBD::mysql::st execute failed: Duplicate entry '37' for key 'PRIMARY' [for Statement "INSERT INTO old_issues SELECT * FROM issues WHERE borrowernumber = ? AND itemnumber = ?" with ParamValues: 0='654336', 1='25'] at /home/marc/koha/C4/Circulation.pm line 2172. at t/db_dependent/Letters/TemplateToolkit.t line 463. # Failed test at t/db_dependent/Letters/TemplateToolkit.t line 470. # got: ' # The following items have been checked out: # Test Biblio 1 # Test Biblio 2 # Thank you for visiting YCIAZz. # ' # expected: ' # The following items have been checkin out: # Test Biblio 1 was due on 01.03.2017 # Thank you for visiting YCIAZz. # ' # Failed test at t/db_dependent/Letters/TemplateToolkit.t line 471. # got: ' # The following items have been checkin out: # Test Biblio 2 was due on 01.03.2017 # Thank you for visiting YCIAZz. # ' # expected: ' # The following items have been checkin out: # Test Biblio 1 was due on 01.03.2017 # Test Biblio 2 was due on 01.03.2017 # Thank you for visiting YCIAZz. # ' # Looks like you failed 2 tests of 4. # Failed test 'CHECKOUT+CHECKIN' # at t/db_dependent/Letters/TemplateToolkit.t line 473. # Looks like you failed 1 test of 4. t/db_dependent/Letters/TemplateToolkit.t .. 16/16 # Failed test 'regression tests' # at t/db_dependent/Letters/TemplateToolkit.t line 503. # Looks like you failed 1 test of 16. t/db_dependent/Letters/TemplateToolkit.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/16 subtests Test Summary Report ------------------- t/db_dependent/Letters/TemplateToolkit.t (Wstat: 256 Tests: 16 Failed: 1) Failed test: 16 Non-zero exit status: 1 Files=1, Tests=16, 3 wallclock secs ( 0.02 usr 0.02 sys + 2.28 cusr 0.36 csys = 2.68 CPU) Result: FAIL -Second run, immediately after first run----------------- marc@debian8vm:~/koha$ prove t/db_dependent/Letters/TemplateToolkit.t t/db_dependent/Letters/TemplateToolkit.t .. ok All tests successful. Files=1, Tests=16, 2 wallclock secs ( 0.03 usr 0.00 sys + 1.63 cusr 0.87 csys = 2.53 CPU) Result: PASS -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17965 --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Marc Véron from comment #6)
koha-foreach --enabled --email /home/marc/koha/misc/cronjobs/advance_notices.pl -c
Prefer koha-shell then execute the advance_notices.pl script. To make sure it will use the correct modules. (In reply to Marc Véron from comment #7)
...and that are the two outputs of TemplateToolkit.t:
--First run ---------------------------
marc@debian8vm:~/koha$ prove t/db_dependent/Letters/TemplateToolkit.t t/db_dependent/Letters/TemplateToolkit.t .. 1/16 DBD::mysql::st execute failed: Duplicate entry '37' for key 'PRIMARY' [for Statement "INSERT INTO old_issues SELECT * FROM issues
This happens if AI of old_issues is >= AI of issues, it does not come from this patch set. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17965 --- Comment #9 from Marc Véron <veron@veron.ch> --- (In reply to Jonathan Druart from comment #8)
(In reply to Marc Véron from comment #6)
koha-foreach --enabled --email /home/marc/koha/misc/cronjobs/advance_notices.pl -c
Prefer koha-shell then execute the advance_notices.pl script. To make sure it will use the correct modules. (...)
Thanks for the hint regarding koha-shell. The problem was related to PERL5LIB pointing to a wrong directory. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17965 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59439|0 |1 is obsolete| | --- Comment #10 from Marc Véron <veron@veron.ch> --- Created attachment 60625 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60625&action=edit Bug 17965: TT syntax for notices - Prove that DUEDGST is compatible This notice template have the particular feature of using <<count>>. This value is substitued during the process of the notice template. For the TT syntax, all what we need is to send the values to substitute to the template. Note that items.content can also be used in these template, you can have a look at bug 17967 to see a better alternative to this marker. Test plan: Generate DUEDGST and DUE notice messages. You should be able to generate the same messages with the TT syntax. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17965 --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Marc Véron from comment #9)
(In reply to Jonathan Druart from comment #8)
(In reply to Marc Véron from comment #6)
koha-foreach --enabled --email /home/marc/koha/misc/cronjobs/advance_notices.pl -c
Prefer koha-shell then execute the advance_notices.pl script. To make sure it will use the correct modules. (...)
Thanks for the hint regarding koha-shell. The problem was related to PERL5LIB pointing to a wrong directory.
FYI this is fixed in master, you should copy the debian files from the git repo to the one used by the system. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17965 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #12 from Marc Véron <veron@veron.ch> --- Forgot to switch status (see comment #10) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17965 Bug 17965 depends on bug 17970, which changed state. Bug 17970 Summary: GetPreparedLetter does not warn when expected https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17970 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17965 Bug 17965 depends on bug 17964, which changed state. Bug 17964 Summary: TT syntax for notices - Prove that CHECKIN and CHECKOUT are compatible https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17964 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17965 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60625|0 |1 is obsolete| | --- Comment #13 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 63967 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63967&action=edit Bug 17965: TT syntax for notices - Prove that DUEDGST is compatible This notice template have the particular feature of using <<count>>. This value is substitued during the process of the notice template. For the TT syntax, all what we need is to send the values to substitute to the template. Note that items.content can also be used in these template, you can have a look at bug 17967 to see a better alternative to this marker. Test plan: Generate DUEDGST and DUE notice messages. You should be able to generate the same messages with the TT syntax. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17965 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63967|0 |1 is obsolete| | --- Comment #14 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 63971 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63971&action=edit Bug 17965: TT syntax for notices - Prove that DUEDGST is compatible This notice template have the particular feature of using <<count>>. This value is substitued during the process of the notice template. For the TT syntax, all what we need is to send the values to substitute to the template. Note that items.content can also be used in these template, you can have a look at bug 17967 to see a better alternative to this marker. Test plan: Generate DUEDGST and DUE notice messages. You should be able to generate the same messages with the TT syntax. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17965 --- Comment #15 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Patch rebased! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17965 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63971|0 |1 is obsolete| | --- Comment #16 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 63972 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63972&action=edit Bug 17965: TT syntax for notices - Prove that DUEDGST is compatible This notice template have the particular feature of using <<count>>. This value is substitued during the process of the notice template. For the TT syntax, all what we need is to send the values to substitute to the template. Note that items.content can also be used in these template, you can have a look at bug 17967 to see a better alternative to this marker. Test plan: Generate DUEDGST and DUE notice messages. You should be able to generate the same messages with the TT syntax. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17965 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63972|0 |1 is obsolete| | CC| |kyle@bywatersolutions.com Status|Signed Off |Passed QA Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #17 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 64333 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64333&action=edit Bug 17965: TT syntax for notices - Prove that DUEDGST is compatible This notice template have the particular feature of using <<count>>. This value is substitued during the process of the notice template. For the TT syntax, all what we need is to send the values to substitute to the template. Note that items.content can also be used in these template, you can have a look at bug 17967 to see a better alternative to this marker. Test plan: Generate DUEDGST and DUE notice messages. You should be able to generate the same messages with the TT syntax. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> --- Comment #18 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17965 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED CC| |fridolin.somers@biblibre.co | |m --- Comment #19 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Enhancement not pushed to 17.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org