[Bug 18254] New: Remove C4::Items:: GetItemsByBiblioitemnumber call from additem.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18254 Bug ID: 18254 Summary: Remove C4::Items::GetItemsByBiblioitemnumber call from additem.pl Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart@bugs.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18254 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18253 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18253 [Bug 18253] Remove C4::Items::GetItemsByBiblioitemnumber -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18254 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18254 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 61041 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61041&action=edit Bug 18254: Remove call to GetItemsByBiblioitemnumber call from additem.pl The code from additem to delete all the items of a bibliographic record is very ackward. This patch simplifies the algorithm and make the code more readable. Test plan: Remove all the items of a bibliographic records If at least 1 item is checked out you should get an error. No change with the current behavior is expected. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18254 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18254 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61041|0 |1 is obsolete| | --- Comment #2 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 62207 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62207&action=edit Bug 18254: Remove call to GetItemsByBiblioitemnumber call from additem.pl The code from additem to delete all the items of a bibliographic record is very ackward. This patch simplifies the algorithm and make the code more readable. Test plan: Remove all the items of a bibliographic records If at least 1 item is checked out you should get an error. No change with the current behavior is expected. Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18254 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62207|0 |1 is obsolete| | CC| |kyle@bywatersolutions.com Status|Signed Off |Passed QA Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 64329 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64329&action=edit Bug 18254: Remove call to GetItemsByBiblioitemnumber call from additem.pl The code from additem to delete all the items of a bibliographic record is very ackward. This patch simplifies the algorithm and make the code more readable. Test plan: Remove all the items of a bibliographic records If at least 1 item is checked out you should get an error. No change with the current behavior is expected. Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18254 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |fridolin.somers@biblibre.co | |m Status|Pushed to Master |RESOLVED --- Comment #5 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Enhancement not pushed to 17.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org