[Bug 33454] New: Improve breadcrumbs for patron lists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33454 Bug ID: 33454 Summary: Improve breadcrumbs for patron lists Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Keywords: Academy Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Depends on: 33409 When looking at a patron list, the breadcrumbs look like this: Tools > Patron lists > Test > Add patrons When you click on "Test", the name of the list, you get to the same page as "Add patrons". As that are not different pages, I think we should combine the crumbs: Tools > Patron lists > Add patrons to Test Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33409 [Bug 33409] Use template wrapper for breadcrumbs: Patrons lists -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33454 Eric Garcia <cubingguy714@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33454 --- Comment #1 from Eric Garcia <cubingguy714@gmail.com> --- Created attachment 168615 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168615&action=edit Bug 33454: Improved breadcrumbs for patron lists To test: 1. Apply patch 2. Tools -> Patron lists 3. Create a new patron list 4. Click on the name of your new list 5. Notice the breadcrumbs are changed to "Add patron to 'LIST NAME'" 6. Return to Patron lists 7. In your patron list select Actions -> Add patrons 8. Notice the breadcrumbs are the same -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33454 Eric Garcia <cubingguy714@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |cubingguy714@gmail.com |ity.org | CC| |cubingguy714@gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33454 Michaela Sieber <michaela.sieber@kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |michaela.sieber@kit.edu See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=34769 --- Comment #2 from Michaela Sieber <michaela.sieber@kit.edu> --- This was already fixed in Main with bug Bug 34769 , see Github : https://github.com/Koha-Community/Koha/commit/486f81be1013a8389a620bd14d3a29... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33454 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168615|0 |1 is obsolete| | --- Comment #3 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 172023 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172023&action=edit Bug 33454: Improved breadcrumbs for patron lists To test: 1. Apply patch 2. Tools -> Patron lists 3. Create a new patron list 4. Click on the name of your new list 5. Notice the breadcrumbs are changed to "Add patron to 'LIST NAME'" 6. Return to Patron lists 7. In your patron list select Actions -> Add patrons 8. Notice the breadcrumbs are the same Signed-off-by: Fiona Borthwick <fiona.borthwick@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33454 Fiona Borthwick <fiona.borthwick@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |fiona.borthwick@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33454 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- We should use something similar to this structure here to improve translatability: [% tx("Modify patron list '{list_name}'", { list_name = list.name }) | html %] -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33454 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 175960 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175960&action=edit Bug 33454: (follow-up) Use tx() to improve translatability -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33454 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Wrote a follow-up for the noted translation issue. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33454 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33454 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33454 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33454 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Text to go in the| |This fixes the breadcrumbs release notes| |for patron lists (Tools > | |Patrons and circulation > | |Patron lists) so that they | |are now more consistent | |with other breadcrumbs, and | |improves their | |translatability (Tools > | |Patron lists > Add patrons | |to 'List name', instead of | |Tools > Patron lists > List | |name). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33454 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.05.00 |25.05.00,24.11.03 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33454 --- Comment #8 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 24.11.x for 24.11.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33454 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #9 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11.x as it wasn't backported to 24.05.x (or 23.XX) -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org