[Bug 39003] New: Cannot see suspend column in user's hold table on OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39003 Bug ID: 39003 Summary: Cannot see suspend column in user's hold table on OPAC Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com To recreate: 1. SuspendHoldsOpac to 'allow' 2. Make some holds for a patron 3. Log in as that patron and go to 'Summary' 4. Click the 'Holds' tab 5. No suspend column -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39003 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Circulation |OPAC Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39003 --- Comment #1 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- I don't see any reason to get the SuspendHoldsOpac value from the script, can check in the template. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39003 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39003 --- Comment #2 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 177357 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177357&action=edit Bug 39003: Move SuspendHoldsOpac check from script to template To test: 1. SuspendHoldsOpac to 'allow' 2. Make some holds for a patron 3. Log in as that patron and go to 'Summary' 4. Click the 'Holds' tab 5. No suspend column 6. APPLY PATCH, restart_all 7. Try again, the column should show. 8. Turn off SuspendHoldsOpac, the column should be hidden. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39003 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |lucas@bywatersolutions.com |y.org | Patch complexity|--- |Trivial patch Text to go in the| |Fixes a bug that was release notes| |causing the 'Suspend' | |column to not build in | |opac-user.tt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39003 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177357|0 |1 is obsolete| | --- Comment #3 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 177359 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177359&action=edit Bug 39003: Fix the tab template variable in opac-user.pl To test: 1. SuspendHoldsOpac to 'allow' 2. Make some holds for a patron 3. Log in as that patron and go to 'Summary' 4. Click the 'Holds' tab 5. No suspend column 6. APPLY PATCH, restart_all 7. Try again, the column should show. 8. Turn off SuspendHoldsOpac, the column should be hidden. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39003 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39003 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|lucas@bywatersolutions.com |testopia@bugs.koha-communit | |y.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39003 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |37972 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37972 [Bug 37972] Allow selection of tab in patron's summary table by query param -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39003 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Status|Needs Signoff |Patch doesn't apply --- Comment #4 from David Nind <david@davidnind.com> --- I'm getting the sha1/fake ancestor error. git bz apply 39003 Bug 39003 - Cannot see suspend column in user's hold table on OPAC 177359 - Bug 39003: Fix the tab template variable in opac-user.pl Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 39003: Fix the tab template variable in opac-user.pl error: sha1 information is lacking or useless (opac/opac-user.pl). error: could not build fake ancestor Patch failed at 0001 Bug 39003: Fix the tab template variable in opac-user.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39003 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39003 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177359|0 |1 is obsolete| | --- Comment #5 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 177366 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177366&action=edit Bug 39003: Fix the tab template variable in opac-user.pl To test: 1. SuspendHoldsOpac to 'allow' 2. Make some holds for a patron 3. Log in as that patron and go to 'Summary' 4. Click the 'Holds' tab 5. No suspend column 6. APPLY PATCH, restart_all 7. Try again, the column should show. 8. Turn off SuspendHoldsOpac, the column should be hidden. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39003 --- Comment #6 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- (In reply to David Nind from comment #4)
I'm getting the sha1/fake ancestor error.
git bz apply 39003
My fault, it should apply now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39003 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39003 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177366|0 |1 is obsolete| | --- Comment #7 from David Nind <david@davidnind.com> --- Created attachment 177367 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177367&action=edit Bug 39003: Fix the tab template variable in opac-user.pl To test: 1. SuspendHoldsOpac to 'allow' 2. Make some holds for a patron 3. Log in as that patron and go to 'Summary' 4. Click the 'Holds' tab 5. No suspend column 6. APPLY PATCH, restart_all 7. Try again, the column should show. 8. Turn off SuspendHoldsOpac, the column should be hidden. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39003 --- Comment #8 from David Nind <david@davidnind.com> --- (In reply to Lucas Gass (lukeg) from comment #6)
(In reply to David Nind from comment #4)
I'm getting the sha1/fake ancestor error.
git bz apply 39003
My fault, it should apply now.
Thanks Lucas! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39003 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39003 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177367|0 |1 is obsolete| | --- Comment #9 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 177377 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177377&action=edit Bug 39003: Fix the tab template variable in opac-user.pl To test: 1. SuspendHoldsOpac to 'allow' 2. Make some holds for a patron 3. Log in as that patron and go to 'Summary' 4. Click the 'Holds' tab 5. No suspend column 6. APPLY PATCH, restart_all 7. Try again, the column should show. 8. Turn off SuspendHoldsOpac, the column should be hidden. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39003 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39003 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39003 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39003 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_24_11_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39003 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|Fixes a bug that was |This fixes the OPAC > release notes|causing the 'Suspend' |Summary > Holds for a |column to not build in |logged in patron so that |opac-user.tt |the 'Suspend' column is now | |shown. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39003 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This fixes the OPAC > |This fixes the OPAC > release notes|Summary > Holds for a |Summary > Holds table for a |logged in patron so that |logged in patron - the |the 'Suspend' column is now |'Suspend' column is now |shown. |shown. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39003 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.05.00 |25.05.00,24.11.02 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39003 --- Comment #11 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 24.11.x for 24.11.02 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39003 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.derscheid@lmscloud.de Keywords|rel_24_11_candidate | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39003 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alexbuckley@catalyst.net.nz --- Comment #12 from Alex Buckley <alexbuckley@catalyst.net.nz> --- not backporting to 24.05.x unless requested - dependency not in 24.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39003 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #13 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Depends on bug not in 22.11.x Not backporting to 22.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org