https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24081 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |23442 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23442 [Bug 23442] Add a 'refund' process to accounts -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. You are on the CC list for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24081 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|13985 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985 [Bug 13985] Cash Management - Koha as 'Point of Sale' -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24081 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24081 --- Comment #2 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 97091 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97091&action=edit Bug 24081: Add DISCOUNT to the allowed 'reduce' types This patch adds the DISCOUNT type to the handled types list in the reduce method introduced in bug 23442 -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24081 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97090|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 100044 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100044&action=edit Bug 24081: Add credit_types, offset_types and permissions This patch adds the credit_type, offset_type and permissions required for the addition of a discounting workflow in the accounts system. -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24081 --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 100046 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100046&action=edit Bug 24081: Add discount action to boraccount This patch adds the ability to apply discounts to existing patron charges from the boraccount page. Test plan -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24081 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_20_05_target -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24081 --- Comment #7 from Michal Denar <black23@gmail.com> --- Test plan: -create manual invoice - go to Transaction a here is new button Appla discount, click - in modal, set discount and confirm - check if amount to pay is lower (minus discount) - pay amount -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24081 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100044|0 |1 is obsolete| | Attachment #100045|0 |1 is obsolete| | Attachment #100046|0 |1 is obsolete| | --- Comment #8 from Michal Denar <black23@gmail.com> --- Created attachment 100074 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100074&action=edit Bug 24081: Add credit_types, offset_types and permissions This patch adds the credit_type, offset_type and permissions required for the addition of a discounting workflow in the accounts system. Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24081 --- Comment #10 from Michal Denar <black23@gmail.com> --- Created attachment 100076 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100076&action=edit Bug 24081: Add discount action to boraccount This patch adds the ability to apply discounts to existing patron charges from the boraccount page. Test plan Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24081 --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to Michal Denar from comment #11)

Hi, I really like this feature. It's works. But itsn't "user friendly". I prefer to apply discout directly at "Pay an amount toward all fines" or "Pay an individual fine" window.

Thank you for opinions.

Thanks for the quick testing, and my apologies for the lack of test plan.. seems I forgot to paste it into the commit message after drafting it.. oops. As for the feedback, that's great. I wanted to get the foundation in with this bug and then build on top of them. I'll open some further bugs with your idea's as their foundation, as I have done for Tomas when he QA'd the parallel 'Refund' bug requesting similar options. I also intend to migrate some of the existing automated discounting functionality to using this model of record for auditability which has been sorely missed in the past. Thanks again, -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24081 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100075|0 |1 is obsolete| | --- Comment #14 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 100085 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100085&action=edit Bug 24081: Add DISCOUNT to the allowed 'reduce' types This patch adds the DISCOUNT type to the handled types list in the reduce method introduced in bug 23442 Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24081 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100084|0 |1 is obsolete| | --- Comment #16 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 100087 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100087&action=edit Bug 24081: Add credit_types, offset_types and permissions This patch adds the credit_type, offset_type and permissions required for the addition of a discounting workflow in the accounts system. Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24081 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100086|0 |1 is obsolete| | --- Comment #18 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 100089 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100089&action=edit Bug 24081: Add discount action to boraccount This patch adds the ability to apply discounts to existing patron charges from the boraccount page. Test plan 1/ Carry out some accounting actions that end up with debts on the patron record. (Add a manual invoice for example) 2/ Note a new 'Apply discount' action button on the unpaid debt 3/ Paid debts do not display the action button 4/ Click the button 5/ Enter an amount into the resulting modal and click confirm 6/ Confirm that the outstanding debt has been reduced by the amount you specified. 7/ Confirm that a new 'Discount' line appears on the patrons account 8/ Confirm that in the 'details' view of the debt that the discount line was used against the debt to create the reduction. 9/ Signoff Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24081 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24081 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100089|0 |1 is obsolete| | -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24081 --- Comment #20 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 100111 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100111&action=edit Bug 24081: Add credit_types, offset_types and permissions This patch adds the credit_type, offset_type and permissions required for the addition of a discounting workflow in the accounts system. Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24081 --- Comment #22 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 100113 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100113&action=edit Bug 24081: Add discount action to boraccount This patch adds the ability to apply discounts to existing patron charges from the boraccount page. Test plan 1/ Carry out some accounting actions that end up with debts on the patron record. (Add a manual invoice for example) 2/ Note a new 'Apply discount' action button on the unpaid debt 3/ Paid debts do not display the action button 4/ Click the button 5/ Enter an amount into the resulting modal and click confirm 6/ Confirm that the outstanding debt has been reduced by the amount you specified. 7/ Confirm that a new 'Discount' line appears on the patrons account 8/ Confirm that in the 'details' view of the debt that the discount line was used against the debt to create the reduction. 9/ Signoff Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24081 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24081 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24812 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24812 [Bug 24812] Add permission for 'discount' process -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24081 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24822 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24822 [Bug 24822] Add discount processing to paycollect -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24081 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #25 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- % git grep updatecharges|grep discount koha-tmpl/intranet-tmpl/prog/en/modules/members/boraccount.tt: [% IF CAN_user_updatecharges_discount && account.is_debit && ( account.amountoutstanding == account.amount ) && !(account.debit_type_code == 'PAYOUT') %] There is no check on the discount subperm, only hide/show a button. Without a test in the controller that can be forced. -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24081 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy@bywatersolutions.com --- Comment #26 from Joy Nelson <joy@bywatersolutions.com> --- not pushed to 19.11.x due to dependencies -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24081 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |Allows to specify and apply release notes| |a discount on a patron's | |charges. Staff will | |require the new permission | |'discount' to use this new | |functionality. -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24081 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24081 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26542 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26542 [Bug 26542] Apply Discount button appears when it can't be used. -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug.