[Bug 26541] New: Apply Discount Button Misleading
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26541 Bug ID: 26541 Summary: Apply Discount Button Misleading Change sponsored?: --- Product: Koha Version: 20.05 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Fines and fees Assignee: koha-bugs@lists.koha-community.org Reporter: kelly@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org In 20.05 there is a button that will allow libraries to apply a discount to a fine/charge. The image of the button shows a % percentage sign, however, this is not how the discount is applied in Koha, it is applied as a $ dollar amount. Can we have either the icon of the % removed or replaced - as to not confuse users? Thanks -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26541 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I had the same misunderstanding about the button the first time, I think a change would make sense. Please just avoid $ and similar for symbols as these don't apply to all countries. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26541 --- Comment #2 from Kelly McElligott <kelly@bywatersolutions.com> --- Oh yes Katrin - good point. So just removing of the % and keeping the Description works! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26541 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26541 --- Comment #3 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 110774 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110774&action=edit Bug 26541: Remove percent sign from discount button To test: 1 - go to borrower account, apply manual fee 2 - go to Transactions tab and see that fee has "% Apply discount" button 3 - apply patch, restart, reload page 4 - button just says "Apply discount" -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26541 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com --- Comment #4 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- I went with no icon as I really couldn't think of what might be helpful, but am certainly open to something else. There's a really nice Live Long and Prosper: https://fontawesome.com/v4.7.0/icons/ -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26541 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110774|0 |1 is obsolete| | --- Comment #5 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 110775 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110775&action=edit Bug 26541: Remove percent sign from discount button Realized I'd left a stray tag, fixed. To test: 1 - go to borrower account, apply manual fee 2 - go to Transactions tab and see that fee has "% Apply discount" button 3 - apply patch, restart, reload page 4 - button just says "Apply discount" -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26541 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26541 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110775|0 |1 is obsolete| | --- Comment #6 from David Nind <david@davidnind.com> --- Created attachment 110778 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110778&action=edit Bug 26541: Remove percent sign from discount button Realized I'd left a stray tag, fixed. To test: 1 - go to borrower account, apply manual fee 2 - go to Transactions tab and see that fee has "% Apply discount" button 3 - apply patch, restart, reload page 4 - button just says "Apply discount" Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26541 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26541 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110778|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 110782 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110782&action=edit Bug 26541: Remove percent sign from discount button Realized I'd left a stray tag, fixed. To test: 1 - go to borrower account, apply manual fee 2 - go to Transactions tab and see that fee has "% Apply discount" button 3 - apply patch, restart, reload page 4 - button just says "Apply discount" Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26541 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Apply Discount Button |Apply discount button |Misleading |misleading Assignee|koha-bugs@lists.koha-commun |andrew@bywatersolutions.com |ity.org | Version|20.05 |master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26541 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Depends on| |24081 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24081 [Bug 24081] Add a 'discount' process to accounts -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26541 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26541 --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26541 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Version(s)|20.11.00 |20.11.00, 20.05.05 released in| | --- Comment #9 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 20.05.x for 20.05.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26541 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha@catalyst.net.nz Status|Pushed to master |Pushed to stable --- Comment #10 from Aleisha Amohia <aleisha@catalyst.net.nz> --- missing dependencies, not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26541 Bug 26541 depends on bug 24081, which changed state. Bug 24081 Summary: Add a 'discount' process to accounts https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24081 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26541 Patrick Robitaille <patrick.robitaille@collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |patrick.robitaille@collecto | |.ca -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26541 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Blocks| |24821 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24821 [Bug 24821] Add percentage handling to discount process -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org