[Bug 31402] New: Update tools sidebar to match tools start page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31402 Bug ID: 31402 Summary: Update tools sidebar to match tools start page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org There are some discrepancies: * Tags vs. Tag moderation * Barcode image generator and Quick spine label creator are switched * Upload any file vs. Upload (maybe use Uploads on both?) * With no installed tool plugin, the entry shows in sidebar, but not on the tools start page (conditions should match) * Cash management section is missing completely -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31402 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31411 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31411 [Bug 31411] [Omnibus] Set focus to first input field of an add/entry form -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31402 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31625 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31625 [Bug 31625] Reindent tools home and tools sidebar -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31402 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31402 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 140995 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140995&action=edit Bug 31402: Update tools sidebar to match tools start page This patch updates the tools sidebar so that it better matches the tools home page: - Sidebar menu should say Tags instead of Tag moderation - Barcode image generator and Quick spine label creator links reversed. - Upload any file -> Uploads - Cash management section is added to sidebar using brief text This patch does not make changes to the way plugins are displayed in the sidebar. In order for the sidebar to correctly display according to the presence of tool plugins I think some kind of global variable would need to be set. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31402 Anke <anke.bruns@gwdg.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |anke.bruns@gwdg.de --- Comment #2 from Anke <anke.bruns@gwdg.de> --- I can confirm that the patch works in the sandbox except for one thing: "- Cash management section is added to sidebar using brief text" But then, I cannot see anything relating to a cash management section on the Tools home either - maybe there is a system preference that has to be set in order to see this? All the other points - Sidebar menu should say Tags instead of Tag moderation - Barcode image generator and Quick spine label creator links reversed. - Upload any file -> Uploads are there as expected. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31402 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- You probably need to set UseCashRegisters :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31402 --- Comment #4 from Anke <anke.bruns@gwdg.de> --- Thanks, Katrin. I now tried with UseCashRegisters activated, and there is indeed the Cash management section both in the Tools home and in the sidebar. In Tools home there shouldn't probably be the "for" after "Transaction history" (which makes it "Transaction history for" while in the sidebar it reads "Transaction history"). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31402 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think the 'for' appears when you haven't selected a cash register in your profile. Could certainly be improved in another bug. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31402 --- Comment #6 from Anke <anke.bruns@gwdg.de> --- I thought the names on the Tools home and the sidebar should be identical -? Anyhow, do you think the bug can be signed off now? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31402 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think that was meant by 'brief text'. After the 'for' the library should appear, when a cash register is selected, but we probably should not display the for when the library is not set and the sentence will be incomplete. Leaving the 'for ...' off in the toolbar to make it a little shorter might be ok. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31402 --- Comment #8 from Anke <anke.bruns@gwdg.de> --- OK, well, this feature isn't exactly relevant for us, so I don't really care all that much. The patch does what it should in the sandbox, as I described, so it should be OK. Please sign off if you think fit - Thanks :-) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31402 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Anke, hope that didn't come across wrong - I had stumbled on the lonely 'for' before as well. Do you not want to sign-off yourself? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31402 Anke <anke.bruns@gwdg.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #10 from Anke <anke.bruns@gwdg.de> --- Yes, I can do it, just wasn't too sure if this would be OK. Thanks for your help :-). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31402 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31402 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31402 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140995|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 141187 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141187&action=edit Bug 31402: Update tools sidebar to match tools start page This patch updates the tools sidebar so that it better matches the tools home page: - Sidebar menu should say Tags instead of Tag moderation - Barcode image generator and Quick spine label creator links reversed. - Upload any file -> Uploads - Cash management section is added to sidebar using brief text This patch does not make changes to the way plugins are displayed in the sidebar. In order for the sidebar to correctly display according to the presence of tool plugins I think some kind of global variable would need to be set. Signed-off-by: Anke Bruns <anke.bruns@gwdg.de> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31402 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31162 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 [Bug 31162] Add a clear cataloguing module home page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31402 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31402 --- Comment #12 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31402 Bug 31402 depends on bug 31625, which changed state. Bug 31625 Summary: Reindent tools home and tools sidebar https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31625 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31402 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org