[Bug 31625] New: Reindent tools home and tools sidebar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31625 Bug ID: 31625 Summary: Reindent tools home and tools sidebar Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: trivial Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: katrin.fischer@bsz-bw.de, testopia@bugs.koha-community.org Blocks: 31402 I propose to reformat the tools-home template and the tools-menu include file in the staff interface so that they have consistent spacing and indentation. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31402 [Bug 31402] Update tools sidebar to match tools start page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31625 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31625 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 140990 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140990&action=edit Bug 31625: Reindent tools home and tools sidebar This patch performs general template cleanup to the tools-home and tools-menu templates: Make indentation consistent, replace tabs with spaces, fix invalid HTML. To test, apply the patch and go to Tools. The page should look correct, with no visible changes from before the patch. Go to any tools page which shows the left-hand sidebar, e.g. Patron lists, Batch item deletion, Inventory, etc. The menu should look correct. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31625 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 140991 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140991&action=edit Bug 31625: (follow-up) Markup comments This patch adds comments to the templates to highlight the markup structure. This patch should have no effect on the pages' appearance or functionality. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31625 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140990|0 |1 is obsolete| | --- Comment #3 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 141002 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141002&action=edit Bug 31625: Reindent tools home and tools sidebar This patch performs general template cleanup to the tools-home and tools-menu templates: Make indentation consistent, replace tabs with spaces, fix invalid HTML. To test, apply the patch and go to Tools. The page should look correct, with no visible changes from before the patch. Go to any tools page which shows the left-hand sidebar, e.g. Patron lists, Batch item deletion, Inventory, etc. The menu should look correct. Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31625 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140991|0 |1 is obsolete| | --- Comment #4 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 141003 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141003&action=edit Bug 31625: (follow-up) Markup comments This patch adds comments to the templates to highlight the markup structure. This patch should have no effect on the pages' appearance or functionality. Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31625 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |andrewfh@dubcolib.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31625 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm, I wonder if this does not clash with 31162 and if we should push one or the other first? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31625 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31625 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141002|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 141185 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141185&action=edit Bug 31625: Reindent tools home and tools sidebar This patch performs general template cleanup to the tools-home and tools-menu templates: Make indentation consistent, replace tabs with spaces, fix invalid HTML. To test, apply the patch and go to Tools. The page should look correct, with no visible changes from before the patch. Go to any tools page which shows the left-hand sidebar, e.g. Patron lists, Batch item deletion, Inventory, etc. The menu should look correct. Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31625 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141003|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 141186 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141186&action=edit Bug 31625: (follow-up) Markup comments This patch adds comments to the templates to highlight the markup structure. This patch should have no effect on the pages' appearance or functionality. Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31625 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Katrin Fischer from comment #5)
Hm, I wonder if this does not clash with bug 31162 and if we should push one or the other first?
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31625 --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- It'll clash, but I'll have a quick look at rebasing the other ones upon this one.. hopefully it won't be too painful. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31625 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31625 --- Comment #10 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31625 --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Was about to say I rebased this morning so we're all good to push.. then I spotted Tomas already had.. hehe -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31625 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |lucas@bywatersolutions.com Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org