[Bug 25302] New: The indentations should be in accordance with the Coding guidelines.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25302 Bug ID: 25302 Summary: The indentations should be in accordance with the Coding guidelines. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: timothy_alexis.vass@ub.lu.se QA Contact: testopia@bugs.koha-community.org Simply put, the indentations are inconsistent. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25302 Timothy Alexis Vass <timothy_alexis.vass@ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Assignee|oleonard@myacpl.org |timothy_alexis.vass@ub.lu.s | |e Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25302 --- Comment #1 from Timothy Alexis Vass <timothy_alexis.vass@ub.lu.se> --- Created attachment 103863 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103863&action=edit === Indentations are now consistently 4 spaces and opening/closing tags are now aligned. === example: <div id="html5media"> [% FOREACH ... %] <p> ... </p> [% END %] </div> is now: <div id="html5media"> === Whitespaces are now consistent === 1. Occuring > < and ] [ changed to >< and ][ example: <li> <a href="... is now: <li><a href="... 2. Occuring \S%] changed to \S %] example: ELSE%] is now: ELSE %] 3. Occuring # /\S changed to # / \S example: [% # /IF is now [% # / IF 4. Sometimes empty lines between concurrent [% IF %] statements changed to always example: [% END %] [% IF ... is now: [% END %] [% IF ... 5. Occuring ,\S changed to , \S example: function(d,s,id) is now: function(d, s, id) 6. Occuring IF \(\S.+\S\) changed to IF \( \S.+\S\ ) example: IF (SeparateHoldings) is now: IF ( SeparateHoldings ) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25302 Timothy Alexis Vass <timothy_alexis.vass@ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|The indentations should be |The indentations should be |in accordance with the |in accordance with the |Coding guidelines. |Coding guidelines and | |whitespaces/linebreaks | |should be consistent. --- Comment #2 from Timothy Alexis Vass <timothy_alexis.vass@ub.lu.se> --- Seems like the first part of the comment was different from the commit message, it should be: === Indentations are now consistently 4 spaces and otherwise correct === example: <div id="html5media"> [% FOREACH ... %] <p> ... </p> [% END %] </div> is now: <div id="html5media"> [% FOREACH ... %] <p> ... </p> [% END %] </div> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25302 Timothy Alexis Vass <timothy_alexis.vass@ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25302 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- I'm marking this "Failed QA" so that this patch can wait for an amended commit message as we discussed on IRC. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25302 --- Comment #4 from Timothy Alexis Vass <timothy_alexis.vass@ub.lu.se> --- Created attachment 104010 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104010&action=edit Bug 25302: The indentations should be in accordance with the Coding guidelines and whitespaces/linebreaks should be consistent. To test: 1) Open an item in OPAC and see if it works. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25302 Timothy Alexis Vass <timothy_alexis.vass@ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103863|=== Indentations are now |=== Indentations are now description|consistently 4 spaces and |consistently 4 spaces and |opening/closing tags are |opening/closing tags are |now aligned. === example: |now aligned. === example: | <div id="html5media"> | <div id="html5media"> | [% FOREACH ... %] | [% FOREACH ... %] |<p> ... |<p> ... |</p> [% END %] |</p> [% END %] |</div> is now: <div |</div> is now: <div |id="html5media"> |id="html5media"> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25302 Timothy Alexis Vass <timothy_alexis.vass@ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103863|1 |0 is patch| | Attachment #103863|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25302 Timothy Alexis Vass <timothy_alexis.vass@ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104010|0 |1 is obsolete| | --- Comment #5 from Timothy Alexis Vass <timothy_alexis.vass@ub.lu.se> --- Created attachment 104029 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104029&action=edit Bug 25302: The indentations should be in accordance with the Coding guidelines and whitespaces/linebreaks should be consistent. To test: 1) Open an item in OPAC and see if it works. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25302 Timothy Alexis Vass <timothy_alexis.vass@ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104029|0 |1 is obsolete| | --- Comment #6 from Timothy Alexis Vass <timothy_alexis.vass@ub.lu.se> --- Created attachment 104036 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104036&action=edit Bug 25302: The indentations should be in accordance with the Coding guidelines and whitespaces/linebreaks should be consistent. To test: 1) Open an item in OPAC and see if it works. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25302 Timothy Alexis Vass <timothy_alexis.vass@ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25302 Timothy Alexis Vass <timothy_alexis.vass@ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104036|0 |1 is obsolete| | --- Comment #7 from Timothy Alexis Vass <timothy_alexis.vass@ub.lu.se> --- Created attachment 104299 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104299&action=edit Bug 25302: The indentations should be in accordance with the Coding guidelines and whitespaces/linebreaks should be consistent. To test: 1) Open an item in OPAC and see if it works. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25302 Timothy Alexis Vass <timothy_alexis.vass@ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104299|0 |1 is obsolete| | --- Comment #8 from Timothy Alexis Vass <timothy_alexis.vass@ub.lu.se> --- Created attachment 104301 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104301&action=edit Bug 25302: The indentations should be in accordance with the Coding guidelines and whitespaces/linebreaks should be consistent. To test: 1) Open an item in OPAC and see if it works. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25302 Timothy Alexis Vass <timothy_alexis.vass@ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |RESOLVED Resolution|--- |INVALID -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25302 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Timothy, what happened here? Keen on helping you to get a patch in, catch me on IRC if you need any help. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org