[Bug 9418] New: Some corrections and additions to about.tt
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9418 Bug ID: 9418 Summary: Some corrections and additions to about.tt Classification: Unclassified Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: About Assignee: nengard@gmail.com Reporter: vfernandes@keep.pt Companies to add: KEEP SOLUTIONS, Portugal C & P Bibliography Services, USA Companies to correct: Software Coop -> software.coop -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9418 Vitor Fernandes <vfernandes@keep.pt> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Change sponsored?|--- |Sponsored Assignee|nengard@gmail.com |vfernandes@keep.pt Severity|enhancement |trivial -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9418 --- Comment #1 from Vitor Fernandes <vfernandes@keep.pt> --- Created attachment 14672 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14672&action=edit Bug 9418: Some corrections and additions to about.tt Test plan: - Apply patch - See if KEEP SOLUTIONS and C & P Bibliography Services - Software Coop should be now software.coop -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9418 --- Comment #2 from Vitor Fernandes <vfernandes@keep.pt> --- Created attachment 14673 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14673&action=edit Bug 9418: Some corrections and additions to about.tt Test plan: - Apply patch - See if KEEP SOLUTIONS and C & P Bibliography Services - Software Coop should be now software.coop Sponsored-by: KEEP SOLUTIONS -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9418 Vitor Fernandes <vfernandes@keep.pt> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14672|1 |0 is patch| | Attachment #14672|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9418 Vitor Fernandes <vfernandes@keep.pt> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9418 MJ Ray (software.coop) <mjr@software.coop> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |mjr@software.coop --- Comment #3 from MJ Ray (software.coop) <mjr@software.coop> --- Sorry, the coding guideline "Templates are expected to be valid XHTML" http://wiki.koha-community.org/wiki/Coding_Guidelines means that should be & not & there. There's also a question of where C & P should be in the list - do we ignore & (so it's sorted as CPB, so it would be the last C entry now), regard & as its own letter (usually after z in English, I think, so it would be the last C entry now) or regard it as "and" (placing CandP between Cal.. and Cat..)? But for any of those, it wouldn't be the first C. I wouldn't have refused to sign for that alone, though. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9418 --- Comment #4 from Vitor Fernandes <vfernandes@keep.pt> --- I will correct the problem with the &. Let me know where to put C & P... -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9418 --- Comment #5 from Vitor Fernandes <vfernandes@keep.pt> --- Created attachment 14694 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14694&action=edit Bug 9418: Some corrections and additions to about.tt Replaced & with & according codelines. Sponsored-by: KEEP SOLUTIONS -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9418 Vitor Fernandes <vfernandes@keep.pt> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9418 --- Comment #6 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 14868 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14868&action=edit Bug 9418: Some corrections and additions to about.tt Test plan: - Apply patch - See if KEEP SOLUTIONS and C & P Bibliography Services - Software Coop should be now software.coop Bug 9418: Some corrections and additions to about.tt Replaced & with & according codelines. Sponsored-by: KEEP SOLUTIONS Combined to patches into one. Reorder C-entries as per sort order. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9418 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel@gmail.com --- Comment #7 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Vitor, I combined your 2 patches AND sorted C-entries. As MJ said, C & P comes last through sort. Regards -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9418 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14673|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9418 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14694|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9418 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9418 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14868|0 |1 is obsolete| | --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 14889 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14889&action=edit [SIGNED-OFF] Bug 9418: Some corrections and additions to about.tt Test plan: - Apply patch - See if KEEP SOLUTIONS and C & P Bibliography Services - Software Coop should be now software.coop Bug 9418: Some corrections and additions to about.tt Replaced & with & according codelines. Sponsored-by: KEEP SOLUTIONS Combined to patches into one. Reorder C-entries as per sort order. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9418 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9418 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14889|0 |1 is obsolete| | --- Comment #9 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 14999 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14999&action=edit Bug 9418: Some corrections and additions to about.tt Test plan: - Apply patch - See if KEEP SOLUTIONS and C & P Bibliography Services - Software Coop should be now software.coop Bug 9418: Some corrections and additions to about.tt Replaced & with & according codelines. Sponsored-by: KEEP SOLUTIONS Combined to patches into one. Reorder C-entries as per sort order. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9418 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9418 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact| |m.de.rooy@rijksmuseum.nl --- Comment #10 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Trivial change. Passing QA since Jared is RM and can answer now if he agrees with the addition of C&P in the list. (I assume you contacted him about that already..) From the comments of MJ Ray in the report I assume implicit agreement from his part on the other modification. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9418 --- Comment #11 from Vitor Fernandes <vfernandes@keep.pt> --- Hi Marcel, Yes it was Jared that told me in the Koha IRC, so there isn't any problem with that. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9418 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #12 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org