[Bug 9526] New: Patron statistics table is not pretty, the page needs the circ toolbar added
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9526 Bug ID: 9526 Summary: Patron statistics table is not pretty, the page needs the circ toolbar added Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: liz@catalyst.net.nz CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com The patron statistics page in circulation does not follow the styling of the rest of the pages, and doesn't include the circ/member toolbar. It needs to come into line with the rest of the interface. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9526 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9526 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 14988 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14988&action=edit Bug 9526 - Patron statistics table is not pretty, needs circ toolbar This patch adds the circ/members toolbar, corrects page title and breadcrumbs, and adds some handling for column names which are coming from the database. The table of statistics can display any items table column specified in the StatisticsFields preference, but we can at least embed the most obvious cases in the template for human readability: item type, collection code, location, home library, and holding library. To test, view the patron statistics page. For a patron with no statistics you should see a message saying so. For a patron with statistics you should see human-friendly labels for the columns referenced above. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9526 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9526 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14988|0 |1 is obsolete| | --- Comment #2 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 14989 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14989&action=edit [SIGNED-OFF] Bug 9526 - Patron statistics table is not pretty, needs circ toolbar This patch adds the circ/members toolbar, corrects page title and breadcrumbs, and adds some handling for column names which are coming from the database. The table of statistics can display any items table column specified in the StatisticsFields preference, but we can at least embed the most obvious cases in the template for human readability: item type, collection code, location, home library, and holding library. To test, view the patron statistics page. For a patron with no statistics you should see a message saying so. For a patron with statistics you should see human-friendly labels for the columns referenced above. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Works as described. No errors. Wouldn't be better with centered cell contents? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9526 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9526 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart@biblibre.co | |m Patch complexity|--- |Trivial patch QA Contact| |jonathan.druart@biblibre.co | |m --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- Thanks Owen of your patch. QA comment: This patch improves the ergonomic of the statistics patron page according to the others patron pages. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9526 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14989|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 14995 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14995&action=edit Bug 9526 - Patron statistics table is not pretty, needs circ toolbar This patch adds the circ/members toolbar, corrects page title and breadcrumbs, and adds some handling for column names which are coming from the database. The table of statistics can display any items table column specified in the StatisticsFields preference, but we can at least embed the most obvious cases in the template for human readability: item type, collection code, location, home library, and holding library. To test, view the patron statistics page. For a patron with no statistics you should see a message saying so. For a patron with statistics you should see human-friendly labels for the columns referenced above. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Works as described. No errors. Wouldn't be better with centered cell contents? Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> FIX a typo: - <h3>Statistcs for [% UNLESS ( I ) %][% title %] [% firstname %] [% END %] [% surname %] ([% cardnumber %])</h3> + <h3>Statistics for [% UNLESS ( I ) %][% title %] [% firstname %] [% END %] [% surname %] ([% cardnumber %])</h3> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9526 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org