[Bug 13712] New: Missing newline in DB update 3.19.00.010
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13712 Bug ID: 13712 Summary: Missing newline in DB update 3.19.00.010 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: trivial Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: magnus@enger.priv.no Reporter: magnus@enger.priv.no QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com The DB update in updatedatabase.pl looks like this: 9755 $DBversion = "3.19.00.010"; 9756 if ( CheckVersion($DBversion) ) { 9757 $dbh->do("INSERT INTO `systempreferences` (variable,value,explanation,options,type) VALUES('SessionRestrictionByIP','1','Check for Change in Remote IP address for Session Security. Disable when remote ip address changes frequently.','','YesNo')"); 9758 print "Upgrade to $DBversion done (Bug 5511 - SessionRestrictionByIP)"; 9759 SetVersion ($DBversion); 9760 } The missing newline at the end of line 9758 means that when you run the webinstaller, this update and the next one are displayed on one line/as one bullet point: * Upgrade to 3.19.00.009 done (Bug 13007 - Add new foreign key suggestions.budgetid) * Upgrade to 3.19.00.010 done (Bug 5511 - SessionRestrictionByIP)Upgrade to 3.19.00.011 done (Bug 13417: Add permission to delete public lists) Not a big deal, of course, but it would look better on two lines. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13712 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13712 --- Comment #1 from Magnus Enger <magnus@enger.priv.no> --- Created attachment 35925 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35925&action=edit Bug 13712 - Missing newline in DB update 3.19.00.010 To test: - Make sure your database is pre 3.19.00.010 (for example by loading in an older backup) - Run through the web-based database update (web installer, step 3) - Verify that updates 3.19.00.010 and 3.19.00.011 are squashed together on one line - Apply the patch - Reset the database and run the web-based database upgrade again - Verify that the two uupdates are noe displayed on separate lines (as separate bullet points) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13712 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13712 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35925|0 |1 is obsolete| | --- Comment #2 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 35988 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35988&action=edit [PASSED QA] Bug 13712 - Missing newline in DB update 3.19.00.010 To test: - Make sure your database is pre 3.19.00.010 (for example by loading in an older backup) - Run through the web-based database update (web installer, step 3) - Verify that updates 3.19.00.010 and 3.19.00.011 are squashed together on one line - Apply the patch - Reset the database and run the web-based database upgrade again - Verify that the two uupdates are noe displayed on separate lines (as separate bullet points) Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13712 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |tomascohen@gmail.com --- Comment #3 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Passing this trivial patch. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13712 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Magnus! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org