[Bug 22085] New: UNIMARC default XSLT broken by Bug 14716
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22085 Bug ID: 22085 Summary: UNIMARC default XSLT broken by Bug 14716 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: fridolin.somers@biblibre.com QA Contact: testopia@bugs.koha-community.org Target Milestone: --- Bug 14716 added a call to encode-uri() and namespace str. This namespace declaration is sometimes missing in UNIMARC default XSLT files. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22085 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|oleonard@myacpl.org |fridolin.somers@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22085 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14716 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 [Bug 14716] Correctly URI-encode URLs in XSLT result lists and detail pages -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22085 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22085 --- Comment #1 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Created attachment 83754 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83754&action=edit Bug 22085: fix UNIMARC default XSLT broken by Bug 14716 Bug 14716 added a call to encode-uri() and namespace str. This namespace declaration is sometimes missing in UNIMARC default XSLT files. This patch adds namespace declaration also where encode-uri is not used because it may be used in the future. And those files are the base for home made custom files. Test plan : 1) Use a UNIMARC DB 2) Use default in all XSLT sysprefs 3) Apply patch 4) Perform a search on OPAC 5) Check display is OK 6) Click on a record for detail page 7) Check display is OK 8) Perform a search on staff interface 9) Check display is OK 10) Click on a record for detail page 11) Check display is OK -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22085 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |critical CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22085 Serhij Dubyk <dubyk@ukr.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dubyk@ukr.net -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22085 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22085 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83754|0 |1 is obsolete| | --- Comment #2 from Frédéric Demians <frederic@tamil.fr> --- Created attachment 83862 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83862&action=edit Bug 22085: fix UNIMARC default XSLT broken by Bug 14716 Bug 14716 added a call to encode-uri() and namespace str. This namespace declaration is sometimes missing in UNIMARC default XSLT files. This patch adds namespace declaration also where encode-uri is not used because it may be used in the future. And those files are the base for home made custom files. Test plan : 1) Use a UNIMARC DB 2) Use default in all XSLT sysprefs 3) Apply patch 4) Perform a search on OPAC 5) Check display is OK 6) Click on a record for detail page 7) Check display is OK 8) Perform a search on staff interface 9) Check display is OK 10) Click on a record for detail page 11) Check display is OK Signed-off-by: Frédéric Demians <f.demians@tamil.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22085 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |julian.maurice@biblibre.com |y.org | CC| |julian.maurice@biblibre.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22085 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83862|0 |1 is obsolete| | --- Comment #3 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 84192 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84192&action=edit Bug 22085: fix UNIMARC default XSLT broken by Bug 14716 Bug 14716 added a call to encode-uri() and namespace str. This namespace declaration is sometimes missing in UNIMARC default XSLT files. This patch adds namespace declaration also where encode-uri is not used because it may be used in the future. And those files are the base for home made custom files. Test plan : 1) Use a UNIMARC DB 2) Use default in all XSLT sysprefs 3) Apply patch 4) Perform a search on OPAC 5) Check display is OK 6) Click on a record for detail page 7) Check display is OK 8) Perform a search on staff interface 9) Check display is OK 10) Click on a record for detail page 11) Check display is OK Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22085 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22085 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #4 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22085 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Pushed to Master |Pushed to Stable --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.11.x for 18.11.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22085 Jesse Maseto <jesse@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jesse@bywatersolutions.com --- Comment #6 from Jesse Maseto <jesse@bywatersolutions.com> --- Pushed to 18.05.x for 18.05.09 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22085 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED --- Comment #7 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Depends on Bug 14716 not in 17.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org