[Bug 22006] New: Koha::Account::Line->item should return undef if no item linked
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22006 Bug ID: 22006 Summary: Koha::Account::Line->item should return undef if no item linked Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart@bugs.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org Depends on: 12001 If there is no item linked to an account line, the ->item method should return undef. Now it explodes with: Carp::croak('DBIC result _type isn\'t of the _type Item') called at /home/vagrant/kohaclone/Koha/Object.pm line 102 Exists since the introduction of this method by bug 12001 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12001 [Bug 12001] GetMemberAccountRecords slows down display of patron details and checkout pages -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22006 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19489 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489 [Bug 19489] Development for fines and Fees Module - Detailed Description of charges in Patron Account Tab/Fines Tab -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22006 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22006 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 83240 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83240&action=edit Bug 22006: Add tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22006 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 83241 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83241&action=edit Bug 22006: Handle undefined itemnumber for Koha::Account::Line->item If there is no item linked to an account line, the ->item method should return undef. Without this patch it explodes with: Carp::croak('DBIC result _type isn\'t of the _type Item') called at /home/vagrant/kohaclone/Koha/Object.pm line 102 Exists since the introduction of this method by bug 12001 Reported on bug 19489 comment 18. Test plan: prove t/db_dependent/Koha/Account/Lines.t must return green -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22006 Pierre-Marc Thibault <pierre-marc.thibault@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83240|0 |1 is obsolete| | --- Comment #3 from Pierre-Marc Thibault <pierre-marc.thibault@inlibro.com> --- Created attachment 83246 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83246&action=edit Bug 22006: Add tests Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault@inLibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22006 Pierre-Marc Thibault <pierre-marc.thibault@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83241|0 |1 is obsolete| | --- Comment #4 from Pierre-Marc Thibault <pierre-marc.thibault@inlibro.com> --- Created attachment 83247 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83247&action=edit Bug 22006: Handle undefined itemnumber for Koha::Account::Line->item If there is no item linked to an account line, the ->item method should return undef. Without this patch it explodes with: Carp::croak('DBIC result _type isn\'t of the _type Item') called at /home/vagrant/kohaclone/Koha/Object.pm line 102 Exists since the introduction of this method by bug 12001 Reported on bug 19489 comment 18. Test plan: prove t/db_dependent/Koha/Account/Lines.t must return green Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault@inLibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22006 Pierre-Marc Thibault <pierre-marc.thibault@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pierre-marc.thibault@inlibr | |o.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22006 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22006 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83246|0 |1 is obsolete| | --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 84000 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84000&action=edit Bug 22006: Add tests Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault@inLibro.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22006 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83247|0 |1 is obsolete| | --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 84001 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84001&action=edit Bug 22006: Handle undefined itemnumber for Koha::Account::Line->item If there is no item linked to an account line, the ->item method should return undef. Without this patch it explodes with: Carp::croak('DBIC result _type isn\'t of the _type Item') called at /home/vagrant/kohaclone/Koha/Object.pm line 102 Exists since the introduction of this method by bug 12001 Reported on bug 19489 comment 18. Test plan: prove t/db_dependent/Koha/Account/Lines.t must return green Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault@inLibro.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22006 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |tomascohen@gmail.com |y.org | CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22006 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #7 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22006 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Pushed to Master |Pushed to Stable --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.11.x for 18.11.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22006 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #9 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 18.05 for 18.05.09 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22006 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED CC| |fridolin.somers@biblibre.co | |m --- Comment #10 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Depends on Bug 12001 not in 17.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org