[Bug 20120] New: Writeoffs for individual fees allows an amount to be written off more than the amount of the fee
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20120 Bug ID: 20120 Summary: Writeoffs for individual fees allows an amount to be written off more than the amount of the fee Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com In short, it is possible to 'over-writeoff' a fee such that the value of the fee is now a credit. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20120 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11210 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11210 [Bug 11210] Allow partial writeoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20120 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20120 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20120 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 71113 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71113&action=edit Bug 20120 - Writeoffs for individual fees allows an amount to be written off more than the amount of the fee In short, it is possible to 'over-writeoff' a fee such that the value of the fee is now a credit. Test Plan: 1) Attempt to writeoff a single fee, set the amount input to more than the amount of the fee. 2) Note the writeoff makes the fee go negative 3) Apply this patch 4) Attempt to repeat step 1, you should not be able to over-writeoff the fee -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20120 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20120 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20120 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sandboxes@biblibre.com Status|Needs Signoff |Signed Off --- Comment #2 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Patch tested with a sandbox, by George Williams <george@nekls.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20120 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71113|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20120 --- Comment #3 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 71152 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71152&action=edit Bug 20120 - Writeoffs for individual fees allows an amount to be written off more than the amount of the fee In short, it is possible to 'over-writeoff' a fee such that the value of the fee is now a credit. Test Plan: 1) Attempt to writeoff a single fee, set the amount input to more than the amount of the fee. 2) Note the writeoff makes the fee go negative 3) Apply this patch 4) Attempt to repeat step 1, you should not be able to over-writeoff the fee Signed-off-by: George Williams <george@nekls.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20120 George Williams (NEKLS) <george@nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |george@nekls.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20120 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20120 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71152|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 71176 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71176&action=edit Bug 20120: Writeoffs for individual fees allows an amount to be written off more than the amount of the fee In short, it is possible to 'over-writeoff' a fee such that the value of the fee is now a credit. Test Plan: 1) Attempt to writeoff a single fee, set the amount input to more than the amount of the fee. 2) Note the writeoff makes the fee go negative 3) Apply this patch 4) Attempt to repeat step 1, you should not be able to over-writeoff the fee Signed-off-by: George Williams <george@nekls.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20120 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71176|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 71177 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71177&action=edit Bug 20120: Prevent individual writeoffs to have an amount more than the amount of the fee In short, it is possible to 'over-writeoff' a fee such that the value of the fee is now a credit. Test Plan: 1) Attempt to writeoff a single fee, set the amount input to more than the amount of the fee. 2) Note the writeoff makes the fee go negative 3) Apply this patch 4) Attempt to repeat step 1, you should not be able to over-writeoff the fee Signed-off-by: George Williams <george@nekls.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20120 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Fixed commit message, please keep on mind: https://wiki.koha-community.org/wiki/Commit_messages -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20120 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Status|Passed QA |Failed QA --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- 1. How bad is that? 2. If it should lead to a credit, what would be the procedure? write off then credit, so 2 lines? 3. in pay.pl, maybe we should refuse instead of assuming it is what the user wanted. 4. Should use Price TT plugin instead of format -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20120 --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 71358 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71358&action=edit Bug 20120: Use the Price TT plugin to format amounts -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20120 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I don't think we should imply it's a credit, at least not silently. I think the change will avoid errors for now and is a bug fix. I'd treat an option to create a credit as a separate enhancement. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20120 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm, thinking about it: when you writeoff, you don't get any money from the customer, so even more reason NOT to assume a credit. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20120 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA --- Comment #11 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Katrin Fischer from comment #10)
Hm, thinking about it: when you writeoff, you don't get any money from the customer, so even more reason NOT to assume a credit.
Right. I think we've addressed everything sufficiently. If I'm wrong, please update the bug status of course! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20120 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #7)
3. in pay.pl, maybe we should refuse instead of assuming it is what the user wanted.
I think this is still valid. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20120 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20120 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71177|0 |1 is obsolete| | Attachment #71358|0 |1 is obsolete| | --- Comment #13 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 72598 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72598&action=edit Bug 20120: Writeoffs for individual fees allows an amount to be written off more than the amount of the fee -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20120 --- Comment #14 from Kyle M Hall <kyle@bywatersolutions.com> --- This version prevents over-writeoffs completely. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20120 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #15 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Patch tested with a sandbox, by George Williams <george@nekls.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20120 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72598|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20120 --- Comment #16 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 72984 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72984&action=edit Bug 20120: Writeoffs for individual fees allows an amount to be written off more than the amount of the fee Signed-off-by: George Williams <george@nekls.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20120 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Kyle, can you please add an updated test plan and description to the commit message? Thx! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20120 --- Comment #18 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Oh, and also change the subject to reflect what the patch does (and maybe bug title too?) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20120 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Writeoffs for individual |Prevent writeoffs of more |fees allows an amount to be |than the amount owed for a |written off more than the |fee |amount of the fee | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20120 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20120 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72984|0 |1 is obsolete| | --- Comment #19 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 74713 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74713&action=edit Bug 20120: Prevent writeoffs of more than the amount owed for a fee In short, it is possible to 'over-writeoff' a fee such that the value of the fee is now a credit. Test Plan: 1) Attempt to writeoff a single fee, set the amount input to more than the amount of the fee. 2) Note the writeoff makes the fee go negative. 3) Apply this patch 4) Attempt to repeat step 1, you should be unable to write-off an amount more than the amount outstanding for the fee! Signed-off-by: George Williams <george@nekls.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20120 --- Comment #20 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Patch tested with a sandbox, by George Williams <george@nekls.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20120 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74713|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20120 --- Comment #21 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 74732 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74732&action=edit Bug 20120: Prevent writeoffs of more than the amount owed for a fee In short, it is possible to 'over-writeoff' a fee such that the value of the fee is now a credit. Test Plan: 1) Attempt to writeoff a single fee, set the amount input to more than the amount of the fee. 2) Note the writeoff makes the fee go negative. 3) Apply this patch 4) Attempt to repeat step 1, you should be unable to write-off an amount more than the amount outstanding for the fee! Signed-off-by: George Williams <george@nekls.org> Signed-off-by: George Williams <george@nekls.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20120 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #22 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I don't think the use of the Price TT is correct here. If you change the CurrencyFormat to FR (comma separator) it will prefill the input field with something like 10,00 - which won't be accepted correctly by Koha yet. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20120 --- Comment #23 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- For inputs you have to set on_editing: [% your_amount | $Price on_editing => 1 %] -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20120 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20120 --- Comment #24 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 74910 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74910&action=edit Bug 20120 [QA Followup]: Pass on_editing parameter for Price plugin -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20120 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20120 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74732|0 |1 is obsolete| | Attachment #74910|0 |1 is obsolete| | --- Comment #25 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 74920 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74920&action=edit Bug 20120: Prevent writeoffs of more than the amount owed for a fee In short, it is possible to 'over-writeoff' a fee such that the value of the fee is now a credit. Test Plan: 1) Attempt to writeoff a single fee, set the amount input to more than the amount of the fee. 2) Note the writeoff makes the fee go negative. 3) Apply this patch 4) Attempt to repeat step 1, you should be unable to write-off an amount more than the amount outstanding for the fee! Signed-off-by: George Williams <george@nekls.org> Signed-off-by: George Williams <george@nekls.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20120 --- Comment #26 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 74921 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74921&action=edit Bug 20120: (QA follow-up) Pass on_editing parameter for Price plugin Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20120 --- Comment #27 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- How do we get the redirect? Sounds like impossible as we have the JS check. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20120 --- Comment #28 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 75016 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75016&action=edit Bug 20120: force scalar context for CGI->param -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20120 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20120 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Passed QA --- Comment #29 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #27)
How do we get the redirect? Sounds like impossible as we have the JS check.
Never rely on client side validation ; ) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20120 --- Comment #30 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Kyle M Hall from comment #29)
(In reply to Jonathan Druart from comment #27)
How do we get the redirect? Sounds like impossible as we have the JS check.
Never rely on client side validation ; )
Yes you are right, the problem is that it does not work. It's easy to get the redirect: 98 $amount=999; Then you see: https://screenshots.firefox.com/8sNfHqHqxHpnMt45/pro.kohadev.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20120 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20120 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA --- Comment #31 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #30)
(In reply to Kyle M Hall from comment #29)
(In reply to Jonathan Druart from comment #27)
How do we get the redirect? Sounds like impossible as we have the JS check.
Never rely on client side validation ; )
Yes you are right, the problem is that it does not work. It's easy to get the redirect: 98 $amount=999;
Then you see: https://screenshots.firefox.com/8sNfHqHqxHpnMt45/pro.kohadev.org
I don't get why you are failing qa for something that has nothing to do with my code. Did you even test it? If you fake a larger amount, then try to overpay the real amount, my code will prevent the payment from going though as expected. I seriously don't understand how you can say it doesn't work. Please post a video demonstration. Your screenshot gives no useful information. Setting back to PQA for now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20120 --- Comment #32 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I was testing the redirect, to make sure it worked. Changing the line (as noted in the comment) to bypass the JS check and the "999" appears on the table, I guess it's a variable name conflict. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20120 --- Comment #33 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 75917 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75917&action=edit Bug 20120: (QA follow-up) display correct amount in redirect -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20120 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #34 from Nick Clemens <nick@bywatersolutions.com> --- Pushed to master for 18.11, awesome work all! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20120 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |martin.renvoize@ptfs-europe | |.com --- Comment #35 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- This patch has been pushed to 18.05.x and will be in 18.05.01 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20120 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #36 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Patches does not apply on 17.11.x. Can you provide a rebase ? (maybe squash commits) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20120 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org