[Bug 20044] New: Switch single-column templates to Bootstrap grid: Cataloging
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20044 Bug ID: 20044 Summary: Switch single-column templates to Bootstrap grid: Cataloging Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Keywords: Academy Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: testopia@bugs.koha-community.org Blocks: 19980 There are several single-column cataloging templates which can be updated to use the Bootstrap grid. - cataloguing\addbiblio.tt - cataloguing\addbooks.tt - cataloguing\merge.tt - cataloguing\moveitem.tt Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19980 [Bug 19980] Omnibus: Update single-column templates to use Bootstrap grid -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20044 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20044 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 70751 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70751&action=edit Bug 20044: Switch single-column templates to Bootstrap grid: Cataloging This patch updates several cataloging module templates to use the Bootstrap grid. - cataloguing/addbooks.tt - Cataloging - The main page and the cataloging search results page should look correct. - cataloguing/addbiblio.tt - Cataloging -> New record - The record edit page should look correct. - cataloguing/merge.tt - Cataloging -> Search -> Select two records to merge. The merge reference selection page should look correct, as well as the source/destination selection page. - cataloguing/moveitem.tt - Catalog -> Search -> View record -> Edit -> Attach item. The barcode submit form and confirmation screens should look correct. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20044 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20044 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70751|0 |1 is obsolete| | --- Comment #2 from Claire Gravely <claire_gravely@hotmail.com> --- Created attachment 71707 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71707&action=edit Bug 20044: Switch single-column templates to Bootstrap grid: Cataloging This patch updates several cataloging module templates to use the Bootstrap grid. - cataloguing/addbooks.tt - Cataloging - The main page and the cataloging search results page should look correct. - cataloguing/addbiblio.tt - Cataloging -> New record - The record edit page should look correct. - cataloguing/merge.tt - Cataloging -> Search -> Select two records to merge. The merge reference selection page should look correct, as well as the source/destination selection page. - cataloguing/moveitem.tt - Catalog -> Search -> View record -> Edit -> Attach item. The barcode submit form and confirmation screens should look correct. Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20044 Maksim Sen <maksim.sen@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |maksim.sen@inlibro.com --- Comment #3 from Maksim Sen <maksim.sen@inlibro.com> --- Hey Owen, I'm having trouble seeing the difference of the before/after patch for the templates. Could you give an example of what kind of differences I should look for? Thank you, Maksim Sen -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20044 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Maksim, for these changes there is mostly no visible change at the moment - so not seeing a difference is ok :) I think things might get more interesting when Owen starts to change the multi-column templates. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20044 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 71909 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71909&action=edit Add record form - menu a bit out of place? Hi Owen, I noticed a visible difference on editing a record. It's a record from the sample database shown in the screenshot. The form visibly moved to the left while the menu on top got quite long. Can you check? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20044 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20044 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20044 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20044 --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 72741 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72741&action=edit Bug 20044 (follow-up) Improve responsive behavior of MARC editor This patch makes some changes to addbiblio.css in order to improve responsive changes to the MARC editor. Note: This patch does not make changes affecting narrow browser widths. The changes are focused on adapting to larger layouts affected by the switch to the Bootstrap grid. To test, apply the patch and clear your cache if necessary. Open an existing record for editing in the standard MARC editor. View the page at various browser widths and confirm that it looks correct. Note: Because of the way the floating toolbar is displayed it does not dynamically resize when you resize the browser. Reload the page after resizing the browser window to confirm that the toolbar adapts at different widths. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20044 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20044 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72741|0 |1 is obsolete| | --- Comment #7 from Claire Gravely <claire_gravely@hotmail.com> --- Created attachment 72743 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72743&action=edit Bug 20044 (follow-up) Improve responsive behavior of MARC editor This patch makes some changes to addbiblio.css in order to improve responsive changes to the MARC editor. Note: This patch does not make changes affecting narrow browser widths. The changes are focused on adapting to larger layouts affected by the switch to the Bootstrap grid. To test, apply the patch and clear your cache if necessary. Open an existing record for editing in the standard MARC editor. View the page at various browser widths and confirm that it looks correct. Note: Because of the way the floating toolbar is displayed it does not dynamically resize when you resize the browser. Reload the page after resizing the browser window to confirm that the toolbar adapts at different widths. Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20044 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Owen, the toolbar on 'edit title' behaves better now, but a long title won't wrap (as it did before). Could you please take another look? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20044 --- Comment #9 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Katrin Fischer from comment #8)
Hi Owen, the toolbar on 'edit title' behaves better now, but a long title won't wrap (as it did before). Could you please take another look?
I can't reproduce this problem. Could you try again? Share a screenshot? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20044 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 73489 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73489&action=edit Screenshot of cataloguing editor (with patch) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20044 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 73490 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73490&action=edit Screenshot of cataloguing editor (before patch) I like the slimmer display better as it seems easier to handle. What do you think? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20044 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |In Discussion -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20044 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71707|0 |1 is obsolete| | Attachment #72743|0 |1 is obsolete| | --- Comment #12 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 77216 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77216&action=edit Bug 20044: Switch single-column templates to Bootstrap grid: Cataloging This patch updates several cataloging module templates to use the Bootstrap grid. - cataloguing/addbooks.tt - Cataloging - The main page and the cataloging search results page should look correct. - cataloguing/addbiblio.tt - Cataloging -> New record - The record edit page should look correct. - cataloguing/merge.tt - Cataloging -> Search -> Select two records to merge. The merge reference selection page should look correct, as well as the source/destination selection page. - cataloguing/moveitem.tt - Catalog -> Search -> View record -> Edit -> Attach item. The barcode submit form and confirmation screens should look correct. Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20044 --- Comment #13 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 77217 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77217&action=edit Bug 20044 (follow-up) Improve responsive behavior of MARC editor This patch makes some changes to addbiblio.css in order to improve responsive changes to the MARC editor. Note: This patch does not make changes affecting narrow browser widths. The changes are focused on adapting to larger layouts affected by the switch to the Bootstrap grid. To test, apply the patch and clear your cache if necessary. Open an existing record for editing in the standard MARC editor. View the page at various browser widths and confirm that it looks correct. Note: Because of the way the floating toolbar is displayed it does not dynamically resize when you resize the browser. Reload the page after resizing the browser window to confirm that the toolbar adapts at different widths. Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20044 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off --- Comment #14 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Katrin Fischer from comment #11)
I like the slimmer display better as it seems easier to handle. What do you think?
No votes against the new design on the mailing list! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20044 --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- True that :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20044 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #16 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- https://lists.katipo.co.nz/pipermail/koha/2018-July/051113.html [Koha] Requesting opinions on proposed change to cataloging interface -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20044 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #17 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- There is something wrong with the select2: https://screenshots.firefox.com/LinttprCI59Mq0Jn/pro.kohadev.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20044 --- Comment #18 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Jonathan Druart from comment #17)
There is something wrong with the select2: https://screenshots.firefox.com/LinttprCI59Mq0Jn/pro.kohadev.org
I do not see this problem with Firefox on Windows 10. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20044 --- Comment #19 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I do on debian, both Firefox 61.0.1 (64-bit) and Chromium Version 67.0.3396.87 It comes from select2.inc: 8 width: function() { 9 var width = this.element.outerWidth(); After this line width is always = 0 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20044 --- Comment #20 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 77396 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77396&action=edit Bug 20044: Fix input_marceditor selectors -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20044 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20044 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77396|0 |1 is obsolete| | --- Comment #21 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 77451 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77451&action=edit Bug 20044: Fix input_marceditor selectors Signed-off-by: Owen Leonard <oleonard@myacpl.org> I can't reproduce the problem this patch is intended to fix, but the changes are sensible either way. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20044 --- Comment #22 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- https://screenshots.firefox.com/PJ3lgNSc6HEb5U4G/pro.kohadev.org Zoom in a bit: https://screenshots.firefox.com/KYNIlu5FRCjpqM39/pro.kohadev.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20044 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20044 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20044 --- Comment #23 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 77473 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77473&action=edit Bug 20044: (follow-up) Add min-width to .input_marceditor This patch adds a min-width property to the first .input_marceditor rule in order to prevent <selects> styled by Select2 from collapsing at narrower browser widths. To reproduce the bug, apply all patches on Bug 20044 except this one. Open the MARC editor and narrow the browser width to below 768 pixels. Reload the page and view a tab which contains a <select> styled by Select2 (942c is often an example). The <select> will have narrowed to be almost invisible. Apply the patch and reproduce the steps above. The <select>s should be fully visible. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20044 --- Comment #24 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Jonathan Druart from comment #22)
Zoom in a bit: https://screenshots.firefox.com/KYNIlu5FRCjpqM39/pro.kohadev.org
I agree that this isn't ideal, but I don't think it's an issue which should block these patches. There are still a lot of responsive improvements which should be made to this interface. The goal of this bug is to lay the groundwork for those improvements. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20044 --- Comment #25 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Tested all pages, but not sure about the changes on "edit record". The input fields are now much longer than before, which seems responsible for some of the awkwardness when making the window smaller. The text input fields are also much longer than the select fields. Not a blocker for me, but something that might be worth taking another shot at. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20044 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20044 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77216|0 |1 is obsolete| | --- Comment #26 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 77555 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77555&action=edit Bug 20044: Switch single-column templates to Bootstrap grid: Cataloging This patch updates several cataloging module templates to use the Bootstrap grid. - cataloguing/addbooks.tt - Cataloging - The main page and the cataloging search results page should look correct. - cataloguing/addbiblio.tt - Cataloging -> New record - The record edit page should look correct. - cataloguing/merge.tt - Cataloging -> Search -> Select two records to merge. The merge reference selection page should look correct, as well as the source/destination selection page. - cataloguing/moveitem.tt - Catalog -> Search -> View record -> Edit -> Attach item. The barcode submit form and confirmation screens should look correct. Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20044 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77217|0 |1 is obsolete| | --- Comment #27 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 77556 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77556&action=edit Bug 20044 (follow-up) Improve responsive behavior of MARC editor This patch makes some changes to addbiblio.css in order to improve responsive changes to the MARC editor. Note: This patch does not make changes affecting narrow browser widths. The changes are focused on adapting to larger layouts affected by the switch to the Bootstrap grid. To test, apply the patch and clear your cache if necessary. Open an existing record for editing in the standard MARC editor. View the page at various browser widths and confirm that it looks correct. Note: Because of the way the floating toolbar is displayed it does not dynamically resize when you resize the browser. Reload the page after resizing the browser window to confirm that the toolbar adapts at different widths. Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20044 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77451|0 |1 is obsolete| | --- Comment #28 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 77557 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77557&action=edit Bug 20044: Fix input_marceditor selectors Signed-off-by: Owen Leonard <oleonard@myacpl.org> I can't reproduce the problem this patch is intended to fix, but the changes are sensible either way. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20044 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77473|0 |1 is obsolete| | --- Comment #29 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 77558 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77558&action=edit Bug 20044: (follow-up) Add min-width to .input_marceditor This patch adds a min-width property to the first .input_marceditor rule in order to prevent <selects> styled by Select2 from collapsing at narrower browser widths. To reproduce the bug, apply all patches on Bug 20044 except this one. Open the MARC editor and narrow the browser width to below 768 pixels. Reload the page and view a tab which contains a <select> styled by Select2 (942c is often an example). The <select> will have narrowed to be almost invisible. Apply the patch and reproduce the steps above. The <select>s should be fully visible. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20044 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77555|0 |1 is obsolete| | Attachment #77556|0 |1 is obsolete| | Attachment #77557|0 |1 is obsolete| | Attachment #77558|0 |1 is obsolete| | --- Comment #30 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 78336 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78336&action=edit Bug 20044: Switch single-column templates to Bootstrap grid: Cataloging This patch updates several cataloging module templates to use the Bootstrap grid. - cataloguing/addbooks.tt - Cataloging - The main page and the cataloging search results page should look correct. - cataloguing/addbiblio.tt - Cataloging -> New record - The record edit page should look correct. - cataloguing/merge.tt - Cataloging -> Search -> Select two records to merge. The merge reference selection page should look correct, as well as the source/destination selection page. - cataloguing/moveitem.tt - Catalog -> Search -> View record -> Edit -> Attach item. The barcode submit form and confirmation screens should look correct. Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20044 --- Comment #31 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 78337 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78337&action=edit Bug 20044 (follow-up) Improve responsive behavior of MARC editor This patch makes some changes to addbiblio.css in order to improve responsive changes to the MARC editor. Note: This patch does not make changes affecting narrow browser widths. The changes are focused on adapting to larger layouts affected by the switch to the Bootstrap grid. To test, apply the patch and clear your cache if necessary. Open an existing record for editing in the standard MARC editor. View the page at various browser widths and confirm that it looks correct. Note: Because of the way the floating toolbar is displayed it does not dynamically resize when you resize the browser. Reload the page after resizing the browser window to confirm that the toolbar adapts at different widths. Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20044 --- Comment #32 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 78338 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78338&action=edit Bug 20044: Fix input_marceditor selectors Signed-off-by: Owen Leonard <oleonard@myacpl.org> I can't reproduce the problem this patch is intended to fix, but the changes are sensible either way. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20044 --- Comment #33 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 78339 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78339&action=edit Bug 20044: (follow-up) Add min-width to .input_marceditor This patch adds a min-width property to the first .input_marceditor rule in order to prevent <selects> styled by Select2 from collapsing at narrower browser widths. To reproduce the bug, apply all patches on Bug 20044 except this one. Open the MARC editor and narrow the browser width to below 768 pixels. Reload the page and view a tab which contains a <select> styled by Select2 (942c is often an example). The <select> will have narrowed to be almost invisible. Apply the patch and reproduce the steps above. The <select>s should be fully visible. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20044 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21307 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21307 [Bug 21307] Switch two-column templates to Bootstrap grid: Cataloging -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20044 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|21307 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21307 [Bug 21307] Switch two-column templates to Bootstrap grid: Cataloging -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20044 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |josef.moravec@gmail.com |y.org | CC| |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20044 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #34 from Josef Moravec <josef.moravec@gmail.com> --- Great job Owen, just few issues found: 1) Add biblio page: - There is a width where the link to value builder could end one line below the corresponding field input (width of body tag is about 1170 px, and about 960px): https://screenshots.firefox.com/JFdSbq58ROJYXeWo/localhost - On narrow screen (under cca 630 px of body width) the input are bigger then width of form/screen: https://screenshots.firefox.com/3iyYgLPkweX0Y1Vr/localhost 2) In koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/merge.tt, line 160, there is <div class="yui-g"> Tested on Ubuntu with Firefox 62 and Chromium 69 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20044 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #35 from Owen Leonard <oleonard@myacpl.org> --- I agree that the responsive behavior of the page isn't perfect, but this bug is intended to be an incremental change. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20044 --- Comment #36 from Josef Moravec <josef.moravec@gmail.com> --- (In reply to Owen Leonard from comment #35)
I agree that the responsive behavior of the page isn't perfect, but this bug is intended to be an incremental change.
I could live with this little issues, but what about my second point? Should be old-named yui-* classes be all removed? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20044 --- Comment #37 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I signed these - can someone else plz QA? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20044 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20044 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78336|0 |1 is obsolete| | --- Comment #38 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 80433 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80433&action=edit Bug 20044: Switch single-column templates to Bootstrap grid: Cataloging This patch updates several cataloging module templates to use the Bootstrap grid. - cataloguing/addbooks.tt - Cataloging - The main page and the cataloging search results page should look correct. - cataloguing/addbiblio.tt - Cataloging -> New record - The record edit page should look correct. - cataloguing/merge.tt - Cataloging -> Search -> Select two records to merge. The merge reference selection page should look correct, as well as the source/destination selection page. - cataloguing/moveitem.tt - Catalog -> Search -> View record -> Edit -> Attach item. The barcode submit form and confirmation screens should look correct. Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20044 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78337|0 |1 is obsolete| | --- Comment #39 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 80434 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80434&action=edit Bug 20044 (follow-up) Improve responsive behavior of MARC editor This patch makes some changes to addbiblio.css in order to improve responsive changes to the MARC editor. Note: This patch does not make changes affecting narrow browser widths. The changes are focused on adapting to larger layouts affected by the switch to the Bootstrap grid. To test, apply the patch and clear your cache if necessary. Open an existing record for editing in the standard MARC editor. View the page at various browser widths and confirm that it looks correct. Note: Because of the way the floating toolbar is displayed it does not dynamically resize when you resize the browser. Reload the page after resizing the browser window to confirm that the toolbar adapts at different widths. Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20044 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78338|0 |1 is obsolete| | --- Comment #40 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 80435 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80435&action=edit Bug 20044: Fix input_marceditor selectors Signed-off-by: Owen Leonard <oleonard@myacpl.org> I can't reproduce the problem this patch is intended to fix, but the changes are sensible either way. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20044 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78339|0 |1 is obsolete| | --- Comment #41 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 80436 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80436&action=edit Bug 20044: (follow-up) Add min-width to .input_marceditor This patch adds a min-width property to the first .input_marceditor rule in order to prevent <selects> styled by Select2 from collapsing at narrower browser widths. To reproduce the bug, apply all patches on Bug 20044 except this one. Open the MARC editor and narrow the browser width to below 768 pixels. Reload the page and view a tab which contains a <select> styled by Select2 (942c is often an example). The <select> will have narrowed to be almost invisible. Apply the patch and reproduce the steps above. The <select>s should be fully visible. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20044 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick@bywatersolutions.com --- Comment #42 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20044 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED CC| |martin.renvoize@ptfs-europe | |.com --- Comment #43 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- The enhancement will not be backported to 18.05.x series. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20044 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23147 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23147 [Bug 23147] changes made by bug 20044 to addbiblio.pl causing issues for some catalogers -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org