[Bug 21651] New: Force insert of notices related tables during the install process
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21651 Bug ID: 21651 Summary: Force insert of notices related tables during the install process Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: jonathan.druart@bugs.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com The 3 following files must be mandatory and insert during the install process: - message_transport_types.sql - sample_notices_message_attributes.sql - sample_notices_message_transports.sql They insert data for - message_transport_types - message_attributes - message_transport_type Otherwise the notice templates (table letter) will fail. Moreover these 3 files are identical and are put in several places (1 per language) to make the description translatable (using the related .txt file) I would suggest to move the 3 .sql files to installer/data/mysql/mandatory, remove all the others (as well as the .txt files) and insert them without asking during the install process. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21651 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21651 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 81088 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81088&action=edit Bug 21651: Remove language specific sql file for notice templates related tables This patch removes the 3 following files for the different languages - message_transport_types.sql - sample_notices_message_attributes.sql - sample_notices_message_transports.sql They were all identical, only one version is kept in installer/data/mysql/mandatory .txt files are removed as well They inserted data for - message_transport_types - message_attributes - message_transport_type -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21651 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 81089 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81089&action=edit Bug 21651: Always insert notice templates related tables The 3 following files must be mandatory and insert during the install process: - message_transport_types.sql - sample_notices_message_attributes.sql - sample_notices_message_transports.sql They insert data for - message_transport_types - message_attributes - message_transport_type Otherwise the notice templates (table letter) will fail. Moreover these 3 files are identical and are put in several places (1 per language) to make the description translatable (using the related .txt file) Test plan: - Install Koha in English and in another language - Select all the sample data => They all should be inserted correctly Note that you cannot select/unselect the checkbox for these 3 tables -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21651 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |21639 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21639 [Bug 21639] Phone notice transports do not exist for new installs -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21651 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81088|0 |1 is obsolete| | Attachment #81089|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 81174 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81174&action=edit Bug 21651: Remove language specific sql file for notice templates related tables This patch removes the 3 following files for the different languages - message_transport_types.sql - sample_notices_message_attributes.sql - sample_notices_message_transports.sql They were all identical, only one version is kept in installer/data/mysql/mandatory .txt files are removed as well They inserted data for - message_transport_types - message_attributes - message_transport_type -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21651 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 81175 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81175&action=edit Bug 21651: Always insert notice templates related tables The 3 following files must be mandatory and insert during the install process: - message_transport_types.sql - sample_notices_message_attributes.sql - sample_notices_message_transports.sql They insert data for - message_transport_types - message_attributes - message_transport_type Otherwise the notice templates (table letter) will fail. Moreover these 3 files are identical and are put in several places (1 per language) to make the description translatable (using the related .txt file) Test plan: - Install Koha in English and in another language - Select all the sample data => They all should be inserted correctly Note that you cannot select/unselect the checkbox for these 3 tables -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21651 Bug 21651 depends on bug 21639, which changed state. Bug 21639 Summary: Phone notice transports do not exist for new installs https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21639 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21651 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea@gmail.com Status|Needs Signoff |Failed QA --- Comment #5 from Liz Rea <wizzyrea@gmail.com> --- Hi Jonathan, Seems ok except for the "cannot select/unselect the checkbox for these 3 tables" - I was still able to uncheck them? Cheers, Liz -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21651 --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Hum yes, indeed. I have no idea why I added that to the commit message. Do you think we should disable the checkboxes? If we do, we certainly we want to disable all the mandatory ones. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21651 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #7 from Liz Rea <wizzyrea@gmail.com> --- This was a thing I wanted Alex to do along with the onboarder, but translation problems hung it up. Usability wise YES 100% we should not allow mandatory ones to be unticked. But you (or somebody) can do that on another bug if you like. :) I'll test it again, with that not in the test plan and update the commit message if it looks ok. Liz -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21651 Hayley Mapley <hayleymapley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hayleymapley@catalyst.net.n | |z --- Comment #8 from Hayley Mapley <hayleymapley@catalyst.net.nz> --- Created attachment 89196 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89196&action=edit Screenshot of error trace Hi Jonathan, When testing this and installing all Optional data in English, I got to the end of the onboarding with no issues and then logged in which led me straight into an error trace. The issue was with DateUtils, it looked like it was an issue with the sample news items. I took a screenshot of the Error trace which I'm attaching. This didn't happen when I tried the same process on master. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21651 Hayley Mapley <hayleymapley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21651 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21651 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81175|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 89318 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89318&action=edit Bug 21651: Always insert notice templates related tables The 3 following files must be mandatory and insert during the install process: - message_transport_types.sql - sample_notices_message_attributes.sql - sample_notices_message_transports.sql They insert data for - message_transport_types - message_attributes - message_transport_type Otherwise the notice templates (table letter) will fail. Moreover these 3 files are identical and are put in several places (1 per language) to make the description translatable (using the related .txt file) Test plan: - Install Koha in English and in another language - Select all the sample data => They all should be inserted correctly Note that you cannot select/unselect the checkbox for these 3 tables -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21651 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89318|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 89319 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89319&action=edit Bug 21651: Always insert notice templates related tables The 3 following files must be mandatory and insert during the install process: - message_transport_types.sql - sample_notices_message_attributes.sql - sample_notices_message_transports.sql They insert data for - message_transport_types - message_attributes - message_transport_type Otherwise the notice templates (table letter) will fail. Moreover these 3 files are identical and are put in several places (1 per language) to make the description translatable (using the related .txt file) Test plan: - Install Koha in English and in another language - Select all the sample data => They all should be inserted correctly -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21651 --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I am terribly sorry, Hayley, the path to sysprefs.sql was wrong! It's now fixed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21651 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22840 --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Liz Rea from comment #7)
This was a thing I wanted Alex to do along with the onboarder, but translation problems hung it up. Usability wise YES 100% we should not allow mandatory ones to be unticked.
But you (or somebody) can do that on another bug if you like. :)
Thanks for the answer, Liz. I have opened bug 22840. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21651 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22841 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21651 Hayley Mapley <hayleymapley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21651 Hayley Mapley <hayleymapley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89319|0 |1 is obsolete| | --- Comment #13 from Hayley Mapley <hayleymapley@catalyst.net.nz> --- Created attachment 89367 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89367&action=edit Bug 21651: Always insert notice templates related tables The 3 following files must be mandatory and insert during the install process: - message_transport_types.sql - sample_notices_message_attributes.sql - sample_notices_message_transports.sql They insert data for - message_transport_types - message_attributes - message_transport_type Otherwise the notice templates (table letter) will fail. Moreover these 3 files are identical and are put in several places (1 per language) to make the description translatable (using the related .txt file) Test plan: - Install Koha in English and in another language - Select all the sample data => They all should be inserted correctly Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21651 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21651 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81174|0 |1 is obsolete| | --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 89599 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89599&action=edit Bug 21651: Remove language specific sql file for notice templates related tables This patch removes the 3 following files for the different languages - message_transport_types.sql - sample_notices_message_attributes.sql - sample_notices_message_transports.sql They were all identical, only one version is kept in installer/data/mysql/mandatory .txt files are removed as well They inserted data for - message_transport_types - message_attributes - message_transport_type Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21651 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89367|0 |1 is obsolete| | --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 89600 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89600&action=edit Bug 21651: Always insert notice templates related tables The 3 following files must be mandatory and insert during the install process: - message_transport_types.sql - sample_notices_message_attributes.sql - sample_notices_message_transports.sql They insert data for - message_transport_types - message_attributes - message_transport_type Otherwise the notice templates (table letter) will fail. Moreover these 3 files are identical and are put in several places (1 per language) to make the description translatable (using the related .txt file) Test plan: - Install Koha in English and in another language - Select all the sample data => They all should be inserted correctly Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21651 --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 89601 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89601&action=edit Bug 21651: (QA follow-up) Remove remaining obsolete file from German web installer Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21651 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick@bywatersolutions.com --- Comment #17 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21651 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable Version(s)| |19.05.00, 18.11.06 released in| | CC| |martin.renvoize@ptfs-europe | |.com --- Comment #18 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.11.x for 18.11.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21651 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED --- Comment #19 from Liz Rea <wizzyrea@gmail.com> --- I'm declining this one for 18.05 because hopefully new Koha users won't be clean installing, and I don't want to take the backport risk. Cheers, Liz -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org