[Bug 9380] New: branch not recording right on writeoff
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9380 Bug ID: 9380 Summary: branch not recording right on writeoff Classification: Unclassified Change sponsored?: --- Product: Koha Version: 3.8 Hardware: All OS: All Status: NEW Severity: critical Priority: P1 - high Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: nengard@gmail.com CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com This happens in 3.8.5 and maybe later versions as well. Do this on your DB: select distinct branch from statistics where type='writeoff'; There is only ever 1 branch in there. Even if you have 2,5,40 branches doing writeoffs all writeoffs get the same branch - it's not the first alphabetical either, I'm not sure where it's coming from and haven't had time to test much more thoroughly. I did however test on 4 library systems running 3.8.5 and got the same results on all - one branch only recorded when writing off. Nicole -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9380 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 14666 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14666&action=edit Bug 9380 - branch not recording right on writeoff Test Plan: 1) Write off fines as various branches 2) Observe the stats lines include the wrong branchcode 3) Apply patch 4) Repeate step 1 5) Observe the stats lines include the correct branchcode -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9380 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |kyle@bywatersolutions.com Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9380 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9380 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14666|0 |1 is obsolete| | --- Comment #2 from Nicole C. Engard <nengard@gmail.com> --- Created attachment 14820 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14820&action=edit [SIGNED-OFF] Bug 9380 - branch not recording right on writeoff Test Plan: 1) Write off fines as various branches 2) Observe the stats lines include the wrong branchcode 3) Apply patch 4) Repeate step 1 5) Observe the stats lines include the correct branchcode Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> Also tested by changing branch and writing off again - all tests pass. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9380 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9380 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14820|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 14901 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14901&action=edit [SIGNED-OFF] Bug 9380 - branch not recording right on writeoff Test Plan: 1) Write off fines as various branches 2) Observe the stats lines include the wrong branchcode 3) Apply patch 4) Repeate step 1 5) Observe the stats lines include the correct branchcode Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> Also tested by changing branch and writing off again - all tests pass. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9380 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.8 |master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9380 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9380 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14901|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 15185 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15185&action=edit [SIGNED-OFF] Bug 9380 - branch not recording right on writeoff Test Plan: 1) Write off fines as various branches 2) Observe the stats lines include the wrong branchcode 3) Apply patch 4) Repeate step 1 5) Observe the stats lines include the correct branchcode Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> Also tested by changing branch and writing off again - all tests pass. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Checked individual and complete write off for different branches. Write offs were always recorded correctly for the logged in branch. All tests and QA script pas. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9380 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9380 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #6 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.10.x will be in 3.10.3, does not apply to 3.8.x please resubmit for 3.8.x if needed -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org