[Bug 9583] New: OPAC cart button display problem in Chromium
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9583 Bug ID: 9583 Summary: OPAC cart button display problem in Chromium Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: katrin.fischer@bsz-bw.de Created attachment 15211 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15211&action=edit screenshot In chromium the cart button is node wide enough for the icon and the text. (see screenshot) This appeared in Chromium 0.88.1 in Ubuntu. In Firefox 18.0.2 on the same system the display is correct. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9583 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #1 from David Cook <dcook@prosentient.com.au> --- (In reply to comment #0)
Created attachment 15211 [details] screenshot
In chromium the cart button is node wide enough for the icon and the text. (see screenshot)
This appeared in Chromium 0.88.1 in Ubuntu. In Firefox 18.0.2 on the same system the display is correct.
I've had the same problem with Chrome 24.0.1312.57 m on Windows Vista and Windows 8. IE 9 and Firefox 18.0.2 were fine. Last I checked, 8 Feb 2013, 3.10.x was displaying the cart fine. It was just not working on the most recent master. Using the Chrome dev tool, I noticed that one of the <i> elements in the cart span had a height of 18px (for reasons I cannot explain), and that seemed to be messing things up. If I deleted that element, it looked perfect again. The height doesn't seem to come from any CSS that I can see though, so I assume there was an update to the Javascript at some point recently, and that had an impact on Chrome/Chromium, although I'm not sure why. I wonder if this happened before or after the Jquery libraries were moved? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9583 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel@gmail.com --- Comment #2 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- All is normal if you go back before Bug 9265 were pushed (git reset --hard a8355ce), so is something on it. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9583 --- Comment #3 from David Cook <dcook@prosentient.com.au> --- (In reply to comment #2)
All is normal if you go back before Bug 9265 were pushed (git reset --hard a8355ce), so is something on it.
Agreed, Bernardo. I found the same thing when I did some trial and error in master. When I change the DOCTYPE back to the XHTML transitional, the OPAC cart button displays correctly again. When I revert it back to the HTML5 short doctype, it creates the display problem again. I tried the <!DOCTYPE html SYSTEM "about:legacy-compat"> doctype as well in case Chrome might be happier with that, but the display problem still occurs. In the "HTML5 differences from HTML4", I noticed the following bit of text: "The i element now represents a span of text in an alternate voice or mood, or otherwise offset from the normal prose in a manner indicating a different quality of text, such as a taxonomic designation, a technical term, an idiomatic phrase from another language, a thought, or a ship name in Western texts." While I assumed this was more of a "policy" difference, I wonder if it's possible that Chrome treats the i element differently because of the different doctype? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9583 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- The extra markup added by JavaScript in doc-head-close.inc is extraneous and should have been removed when we changed the way the buttons are constructed. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9583 --- Comment #5 from David Cook <dcook@prosentient.com.au> --- (In reply to comment #4)
The extra markup added by JavaScript in doc-head-close.inc is extraneous and should have been removed when we changed the way the buttons are constructed.
Owen, is the extra mark-up the 2 empty "i" elements, and 2 empty span elements (one with an id of "carticon")? If so, I'll submit a patch to remove them. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9583 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9583 --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 15235 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15235&action=edit Bug 9583 - OPAC cart button display problem in Chromium Legacy markup in the script which generates the OPAC's Cart button causes display problems in Chrome under the new HTML5 doctype. This patch removes the extra markup, which has been unnecessary since we changed the way the Cart and Lists buttons are displayed in Bug 7584. To test, view the OPAC in several browsers, including a Chromium-based browser (Specifically Chromium-based. It is not a WebKit-related bug). The Cart button should display correctly with and without items in the cart. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9583 --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- (In reply to comment #5)
If so, I'll submit a patch to remove them.
Thanks David. I felt responsible for the bug, so I went ahead and submitted a patch. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9583 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15235|0 |1 is obsolete| | --- Comment #8 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 15249 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15249&action=edit Bug 9583 - OPAC cart button display problem in Chromium Legacy markup in the script which generates the OPAC's Cart button causes display problems in Chrome under the new HTML5 doctype. This patch removes the extra markup, which has been unnecessary since we changed the way the Cart and Lists buttons are displayed in Bug 7584. To test, view the OPAC in several browsers, including a Chromium-based browser (Specifically Chromium-based. It is not a WebKit-related bug). The Cart button should display correctly with and without items in the cart. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Works great, back to normal. Tested in windows (chrome, firefox, opera) and linux (chrome, chromium) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9583 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9583 --- Comment #9 from David Cook <dcook@prosentient.com.au> --- (In reply to comment #7)
(In reply to comment #5)
If so, I'll submit a patch to remove them.
Thanks David. I felt responsible for the bug, so I went ahead and submitted a patch.
Thanks for the patch, Owen! Thanks to Bernardo too for such a fast turnaround time on the sign off! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9583 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9583 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15249|0 |1 is obsolete| | --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 15267 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15267&action=edit Bug 9583 - OPAC cart button display problem in Chromium Legacy markup in the script which generates the OPAC's Cart button causes display problems in Chrome under the new HTML5 doctype. This patch removes the extra markup, which has been unnecessary since we changed the way the Cart and Lists buttons are displayed in Bug 7584. To test, view the OPAC in several browsers, including a Chromium-based browser (Specifically Chromium-based. It is not a WebKit-related bug). The Cart button should display correctly with and without items in the cart. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Works great, back to normal. Tested in windows (chrome, firefox, opera) and linux (chrome, chromium) Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Tested with Chromium and Firefox in Ubuntu. No regression found and display is correct now. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9583 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9583 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #11 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9583 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #12 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.10.x and 3.8.x will be in 3.10.3 and 3.8.10 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org