[Bug 29695] New: Centralize columns' descriptions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29695 Bug ID: 29695 Summary: Centralize columns' descriptions Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart+koha@gmail.com Reporter: jonathan.druart+koha@gmail.com QA Contact: testopia@bugs.koha-community.org We have columns.def that contains the descriptions for DB columns and some json files that are used for syspref's values selection. 1. We duplicate them 2. columns.def is translatable but json files are not 3. columns.def is a XML file we are parsing with regexs We should have a single and better way to deal with those descriptions. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29695 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |26296 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26296 [Bug 26296] Use new table column selection modal for OPAC suggestion fields -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29695 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=25441 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29695 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29695 --- Comment #1 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 128522 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128522&action=edit Bug 29695: Remove GetColumnDefs C4::Templates::GetColumnDefs can easily be replaced using the new Koha::Database::Columns module. Test plan: Go to the import patron tool and confirm that you see the same list of patron's attribute on the import patron form. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29695 --- Comment #2 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 128523 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128523&action=edit Bug 29695: Remove C4::Reports::Guided::_get_column_defs This subroutine was mostly the same as GetColumnDefs, we replace it identically as in the previous patch. Test plan: Translate some strings in another language % gulp po:update --lang es-ES % cd misc/translate # Translate the relevant strings in po/es-ES-messages.po # For instance "Alternate contact: Surname" % perl translate install es-ES Select the language for the interface (enable it in the 'language' syspref first) Create a new guided report and confirm that the columns for the borrowers table are translated -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29695 --- Comment #3 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 128524 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128524&action=edit Bug 29695: (follow-up) Remove C4::Reports::Guided::_get_column_defs Same as the previous patch but for the inventory. Test plan: Same as before but test the inventory tool -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29695 --- Comment #4 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 128525 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128525&action=edit Bug 29695: Make "modalselect" syspref's values translatable We are using json files to retrieve the list of the DB columns. We can reuse what we have done in the previous patch and display translated strings. Test plan: Search for "unwanted" in the sysprefs -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29695 --- Comment #5 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 128526 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128526&action=edit Bug 29695: Remove json files We do no longer need them. Test plan: Confirm that their content are in Koha::Database::Columns -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29695 --- Comment #6 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 128527 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128527&action=edit Bug 29695: Remove columns.def No longer in use Test plan: % git grep 'columns.def' does not return relevant occurrences -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29695 --- Comment #7 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 128528 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128528&action=edit Bug 29695: Add new module Koha::Database::Columns This module will contain new strings and make them translatable using Koha::I18N. We will need to improve this module to prevent the dozens of __ calls each time we retrieve the column list. We could either use memcached or add a method to only retrieve columns for a given table. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29695 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128527|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 128529 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128529&action=edit Bug 29695: Remove columns.def No longer in use Test plan: % git grep 'columns.def' does not return relevant occurrences -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29695 --- Comment #9 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Note that we could reuse this to remove the different includes/csv_headers files. We are generating the CSVs using TT to make the headers translatable, but it would be better to generate them using Text::CSV. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29695 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29591 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29695 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128522|0 |1 is obsolete| | Attachment #128523|0 |1 is obsolete| | Attachment #128524|0 |1 is obsolete| | Attachment #128525|0 |1 is obsolete| | Attachment #128526|0 |1 is obsolete| | Attachment #128528|0 |1 is obsolete| | Attachment #128529|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 128559 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128559&action=edit Bug 29695: Add new module Koha::Database::Columns This module will contain new strings and make them translatable using Koha::I18N. We will need to improve this module to prevent the dozens of __ calls each time we retrieve the column list. We could either use memcached or add a method to only retrieve columns for a given table. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29695 --- Comment #11 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 128560 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128560&action=edit Bug 29695: Remove GetColumnDefs C4::Templates::GetColumnDefs can easily be replaced using the new Koha::Database::Columns module. Test plan: Go to the import patron tool and confirm that you see the same list of patron's attribute on the import patron form. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29695 --- Comment #12 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 128561 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128561&action=edit Bug 29695: Remove C4::Reports::Guided::_get_column_defs This subroutine was mostly the same as GetColumnDefs, we replace it identically as in the previous patch. Test plan: Translate some strings in another language % gulp po:update --lang es-ES % cd misc/translate # Translate the relevant strings in po/es-ES-messages.po # For instance "Alternate contact: Surname" % perl translate install es-ES Select the language for the interface (enable it in the 'language' syspref first) Create a new guided report and confirm that the columns for the borrowers table are translated -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29695 --- Comment #13 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 128562 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128562&action=edit Bug 29695: (follow-up) Remove C4::Reports::Guided::_get_column_defs Same as the previous patch but for the inventory. Test plan: Same as before but test the inventory tool -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29695 --- Comment #14 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 128563 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128563&action=edit Bug 29695: Make "modalselect" syspref's values translatable We are using json files to retrieve the list of the DB columns. We can reuse what we have done in the previous patch and display translated strings. Test plan: Search for "unwanted" in the sysprefs -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29695 --- Comment #15 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 128564 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128564&action=edit Bug 29695: Remove json files We do no longer need them. Test plan: Confirm that their content are in Koha::Database::Columns -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29695 --- Comment #16 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 128565 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128565&action=edit Bug 29695: Remove columns.def No longer in use Test plan: % git grep 'columns.def' does not return relevant occurrences -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29695 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29591 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29591 [Bug 29591] Add autorenew_checkouts to BorrowerMandatory/Unwanted fields system preferences -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29695 Bug 29695 depends on bug 26296, which changed state. Bug 26296 Summary: Use new table column selection modal for OPAC suggestion fields https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26296 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29695 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128559|0 |1 is obsolete| | Attachment #128560|0 |1 is obsolete| | Attachment #128561|0 |1 is obsolete| | Attachment #128562|0 |1 is obsolete| | Attachment #128563|0 |1 is obsolete| | Attachment #128564|0 |1 is obsolete| | Attachment #128565|0 |1 is obsolete| | --- Comment #17 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 130065 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130065&action=edit Bug 29695: Add new module Koha::Database::Columns This module will contain new strings and make them translatable using Koha::I18N. We will need to improve this module to prevent the dozens of __ calls each time we retrieve the column list. We could either use memcached or add a method to only retrieve columns for a given table. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29695 --- Comment #18 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 130066 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130066&action=edit Bug 29695: Remove GetColumnDefs C4::Templates::GetColumnDefs can easily be replaced using the new Koha::Database::Columns module. Test plan: Go to the import patron tool and confirm that you see the same list of patron's attribute on the import patron form. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29695 --- Comment #19 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 130067 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130067&action=edit Bug 29695: Remove C4::Reports::Guided::_get_column_defs This subroutine was mostly the same as GetColumnDefs, we replace it identically as in the previous patch. Test plan: Translate some strings in another language % gulp po:update --lang es-ES % cd misc/translate # Translate the relevant strings in po/es-ES-messages.po # For instance "Alternate contact: Surname" % perl translate install es-ES Select the language for the interface (enable it in the 'language' syspref first) Create a new guided report and confirm that the columns for the borrowers table are translated -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29695 --- Comment #20 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 130068 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130068&action=edit Bug 29695: (follow-up) Remove C4::Reports::Guided::_get_column_defs Same as the previous patch but for the inventory. Test plan: Same as before but test the inventory tool -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29695 --- Comment #21 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 130069 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130069&action=edit Bug 29695: Make "modalselect" syspref's values translatable We are using json files to retrieve the list of the DB columns. We can reuse what we have done in the previous patch and display translated strings. Test plan: Search for "unwanted" in the sysprefs -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29695 --- Comment #22 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 130070 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130070&action=edit Bug 29695: Remove json files We do no longer need them. Test plan: Confirm that their content are in Koha::Database::Columns -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29695 --- Comment #23 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 130071 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130071&action=edit Bug 29695: Remove columns.def No longer in use Test plan: % git grep 'columns.def' does not return relevant occurrences -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29695 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de, | |martin.renvoize@ptfs-europe | |.com, oleonard@myacpl.org, | |tomascohen@gmail.com --- Comment #24 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- I think this change is great, could you have a look? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29695 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29695 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130065|0 |1 is obsolete| | Attachment #130066|0 |1 is obsolete| | Attachment #130067|0 |1 is obsolete| | Attachment #130068|0 |1 is obsolete| | Attachment #130069|0 |1 is obsolete| | Attachment #130070|0 |1 is obsolete| | Attachment #130071|0 |1 is obsolete| | --- Comment #25 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 130107 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130107&action=edit Bug 29695: Add new module Koha::Database::Columns This module will contain new strings and make them translatable using Koha::I18N. We will need to improve this module to prevent the dozens of __ calls each time we retrieve the column list. We could either use memcached or add a method to only retrieve columns for a given table. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29695 --- Comment #26 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 130108 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130108&action=edit Bug 29695: Remove GetColumnDefs C4::Templates::GetColumnDefs can easily be replaced using the new Koha::Database::Columns module. Test plan: Go to the import patron tool and confirm that you see the same list of patron's attribute on the import patron form. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29695 --- Comment #27 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 130109 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130109&action=edit Bug 29695: Remove C4::Reports::Guided::_get_column_defs This subroutine was mostly the same as GetColumnDefs, we replace it identically as in the previous patch. Test plan: Translate some strings in another language % gulp po:update --lang es-ES % cd misc/translate # Translate the relevant strings in po/es-ES-messages.po # For instance "Alternate contact: Surname" % perl translate install es-ES Select the language for the interface (enable it in the 'language' syspref first) Create a new guided report and confirm that the columns for the borrowers table are translated Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29695 --- Comment #28 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 130110 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130110&action=edit Bug 29695: (follow-up) Remove C4::Reports::Guided::_get_column_defs Same as the previous patch but for the inventory. Test plan: Same as before but test the inventory tool Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29695 --- Comment #29 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 130111 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130111&action=edit Bug 29695: Make "modalselect" syspref's values translatable We are using json files to retrieve the list of the DB columns. We can reuse what we have done in the previous patch and display translated strings. Test plan: Search for "unwanted" in the sysprefs Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29695 --- Comment #30 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 130112 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130112&action=edit Bug 29695: Remove json files We do no longer need them. Test plan: Confirm that their content are in Koha::Database::Columns Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29695 --- Comment #31 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 130113 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130113&action=edit Bug 29695: Remove columns.def No longer in use Test plan: % git grep 'columns.def' does not return relevant occurrences Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29695 Bug 29695 depends on bug 29591, which changed state. Bug 29591 Summary: Add autorenew_checkouts to BorrowerMandatory/Unwanted fields system preferences https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29591 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29695 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |tomascohen@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29695 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130112|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29695 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130113|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29695 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130107|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29695 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130108|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29695 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130109|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29695 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130110|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29695 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130111|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29695 --- Comment #32 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 131918 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131918&action=edit Bug 29695: Add new module Koha::Database::Columns This module will contain new strings and make them translatable using Koha::I18N. We will need to improve this module to prevent the dozens of __ calls each time we retrieve the column list. We could either use memcached or add a method to only retrieve columns for a given table. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29695 --- Comment #33 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 131919 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131919&action=edit Bug 29695: Remove GetColumnDefs C4::Templates::GetColumnDefs can easily be replaced using the new Koha::Database::Columns module. Test plan: Go to the import patron tool and confirm that you see the same list of patron's attribute on the import patron form. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29695 --- Comment #34 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 131920 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131920&action=edit Bug 29695: Remove C4::Reports::Guided::_get_column_defs This subroutine was mostly the same as GetColumnDefs, we replace it identically as in the previous patch. Test plan: Translate some strings in another language % gulp po:update --lang es-ES % cd misc/translate # Translate the relevant strings in po/es-ES-messages.po # For instance "Alternate contact: Surname" % perl translate install es-ES Select the language for the interface (enable it in the 'language' syspref first) Create a new guided report and confirm that the columns for the borrowers table are translated Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29695 --- Comment #35 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 131921 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131921&action=edit Bug 29695: (follow-up) Remove C4::Reports::Guided::_get_column_defs Same as the previous patch but for the inventory. Test plan: Same as before but test the inventory tool Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29695 --- Comment #36 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 131922 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131922&action=edit Bug 29695: Make "modalselect" syspref's values translatable We are using json files to retrieve the list of the DB columns. We can reuse what we have done in the previous patch and display translated strings. Test plan: Search for "unwanted" in the sysprefs Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29695 --- Comment #37 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 131923 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131923&action=edit Bug 29695: Remove json files We do no longer need them. Test plan: Confirm that their content are in Koha::Database::Columns Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29695 --- Comment #38 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 131924 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131924&action=edit Bug 29695: Remove columns.def No longer in use Test plan: % git grep 'columns.def' does not return relevant occurrences Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29695 --- Comment #39 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 131925 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131925&action=edit Bug 29695: Add missing POD Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29695 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion --- Comment #40 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Ok, it works. Tests pass. The question is: is this what we want? We are basically moving column descriptions handling into a better place (i.e. a Koha class that is more normal that what we had before), we are getting rid of a mix XML (columns.def) or json where those descriptions lived. But on doing so we are: - Moving translatable strings to Koha::* - Adding some overhead by the way we use __. It feels like overall is ok, but the descriptions should live in an external per-language file that is translated 'the usual way' and loaded only once when the class is instantiated (class?, it should be a proper class, so each process that instantiates it can initialize it with the current language). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29695 --- Comment #41 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Tomás Cohen Arazi from comment #40)
Ok, it works. Tests pass.
The question is: is this what we want?
We are basically moving column descriptions handling into a better place (i.e. a Koha class that is more normal that what we had before), we are getting rid of a mix XML (columns.def) or json where those descriptions lived.
But on doing so we are: - Moving translatable strings to Koha::* - Adding some overhead by the way we use __.
It feels like overall is ok, but the descriptions should live in an external per-language file that is translated 'the usual way' and loaded only once when the class is instantiated (class?, it should be a proper class, so each process that instantiates it can initialize it with the current language).
Why is it bad to use __()? It will get translated the usual way by translators. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29695 --- Comment #42 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Jonathan Druart from comment #41)
Why is it bad to use __()? It will get translated the usual way by translators.
I might be wrong, but have the feeling that any place in which all (say) borrower table columns need to be displayed, will imply N file accesses if there's no caching of the file. I tested it to work correctly and didn't notice any drawbacks, but got me thinking of the approach. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29695 --- Comment #43 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Tomás Cohen Arazi from comment #42)
(In reply to Jonathan Druart from comment #41)
Why is it bad to use __()? It will get translated the usual way by translators.
I might be wrong, but have the feeling that any place in which all (say) borrower table columns need to be displayed, will imply N file accesses if there's no caching of the file.
You are wrong. Translations are cached, see Koha::I18N->init
I tested it to work correctly and didn't notice any drawbacks, but got me thinking of the approach.
This is the correct way, we need to let perl code access the translation of columns. Think CSV headers for instance, now we have to use TT for that, and build the CSV manually when we could use a dedicated library (Text::CSV_XS in our case). See also the code for reports to see how easy it is now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29695 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29695 --- Comment #44 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Jonathan Druart from comment #43)
(In reply to Tomás Cohen Arazi from comment #42)
(In reply to Jonathan Druart from comment #41)
Why is it bad to use __()? It will get translated the usual way by translators.
I might be wrong, but have the feeling that any place in which all (say) borrower table columns need to be displayed, will imply N file accesses if there's no caching of the file.
You are wrong. Translations are cached, see Koha::I18N->init
Thanks for explaining!
I tested it to work correctly and didn't notice any drawbacks, but got me thinking of the approach.
This is the correct way, we need to let perl code access the translation of columns. Think CSV headers for instance, now we have to use TT for that, and build the CSV manually when we could use a dedicated library (Text::CSV_XS in our case). See also the code for reports to see how easy it is now.
Gotcha. This is ready then :-D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29695 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29695 --- Comment #45 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29695 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29695 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32292 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32292 [Bug 32292] suggestions in Columns.pm are not translated to real labels -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29695 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32312 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32312 [Bug 32312] Complete database column descriptions for serials module in guided reports -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29695 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32313 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32313 [Bug 32313] Complete database column descriptions for cataloguing module in guided reports -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29695 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32314 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32314 [Bug 32314] Complete database column descriptions for accounts module in guided reports -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29695 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32315 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32315 [Bug 32315] Complete database column descriptions for serials module in guided reports -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org