[Bug 34325] New: Add option on debit types to show barcode field or not on manual invoice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34325 Bug ID: 34325 Summary: Add option on debit types to show barcode field or not on manual invoice Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Fines and fees Assignee: koha-bugs@lists.koha-community.org Reporter: lisette.scheer@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org It would be great if we could specify if a manual invoice debit type would show the barcode field. Right now staff may be confused by the barcode field showing and not validating when doing new cards if they try to put a patron card in and also the message not being helpful that the barcode is invalid because it doesn't let us know that it's looking at items only. An alternative could be to make the "Barcode" field "Item Barcode" Lisette -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34325 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think renaming the field to "Item barcode" sounds like a good idea. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34325 Lisette Scheer <lisette.scheer@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add option on debit types |On Manual Invoice form |to show barcode field or |rename "Barcode" to "Item |not on manual invoice |Barcode" for clarity -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34325 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |david@davidnind.com |ity.org | Keywords| |Academy, Sandbox Summary|On Manual Invoice form |On the manual invoice and |rename "Barcode" to "Item |credit forms rename |Barcode" for clarity |"Barcode" to "Item Barcode" | |for clarity Version|unspecified |Main CC| |david@davidnind.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34325 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34325 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34325 --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 168579 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168579&action=edit Bug 34325: Rename "Barcode" to "Item barcode" on manual invoice and credit forms The forms for adding a manual invoice and credit for patrons (in the accounting section) have a field for entering a barcode. This can cause confusion, as it is not clear if it is for an item barcode or the patron card number. This patch changes the form labels and error message for the manual invoice to clarify that this is for an item barcode. Table column headings are left as "Barcode". Test plan: 1. Go to a patron's record: Patrons > search for a patron > select a patron. 2. Go to Accounting > Create manual invoice. 3. Note that there is a label "Barcode:" 4. Enter details for a manual invoice and 'Save': - Type: Manual fee - Barcode: an item barcode, for example 39999000011418 - Amount: 15 ==> Result: Manual invoice saved 5. Repeat step 4, but enter a patron card number for the barcode. For example: 23529000651225. ==> Result: You get an error message "Error: Invalid barcode entered, please try again". 6. Enter details for a manual credit and 'Save': - Credit type: Credit - Barcode: an item barcode, for example 39999000011418 - Amount: 5 ==> Result: Manual credit saved. 7. Check the tables listing transactions - note that the column heading is "Barcode". (Tables are Transactions, Make a payment, and Transactions > Details (under the Actions column). 8. Apply the patch. 9. Repeat steps 4 to 7. Note that: - The label is now "Item barcode:" for the manual invoice and manual credit forms. - The error message in step 5 is now "Error: Invalid item barcode entered, please try again". - For the tables in step 8, the column headings remain as "Barcode" - there is generally enough context that it doesn't need to be changed. 10. Sign off D: Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34325 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement changes release notes| |the form labels and error | |message for the manual | |invoice and credit forms | |for patrons (in the | |accounting section). This | |is to clarify that this | |field is for an item | |barcode, and not a patron | |card number barcode. --- Comment #3 from David Nind <david@davidnind.com> --- I have only changed the manual invoice and credit forms to change "Barcode" to "Item barcode". Note that: 1. The manual invoice form generates an error message if you enter a patron card number. 2. The manual credit form doesn't generate an error message - it is beyond my skills to add an error message to the manual credit form. 3. I have also left the table headings under transactions, details, and make a payment as "Barcode" - I think there is enough context to know that this is an item barcode. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34325 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168579|0 |1 is obsolete| | --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 168580 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168580&action=edit Bug 34325: Rename "Barcode" to "Item barcode" on manual invoice and credit forms The forms for adding a manual invoice and credit for patrons (in the accounting section) have a field for entering a barcode. This can cause confusion, as it is not clear if it is for an item barcode or the patron card number. This patch changes the form labels and error message for the manual invoice and credit forms to clarify that this is for an item barcode. Related table column headings are left as "Barcode". Test plan: 1. Go to a patron's record: Patrons > search for a patron > select a patron. 2. Go to Accounting > Create manual invoice. 3. Note that there is a label "Barcode:" 4. Enter details for a manual invoice and 'Save': - Type: Manual fee - Barcode: an item barcode, for example 39999000011418 - Amount: 15 ==> Result: Manual invoice saved 5. Repeat step 4, but enter a patron card number for the barcode. For example: 23529000651225. ==> Result: You get an error message "Error: Invalid barcode entered, please try again". 6. Enter details for a manual credit and 'Save': - Credit type: Credit - Barcode: an item barcode, for example 39999000011418 - Amount: 5 ==> Result: Manual credit saved. 7. Check the tables listing transactions - note that the column heading is "Barcode". (Tables are Transactions, Make a payment, and Transactions > Details (under the Actions column). 8. Apply the patch. 9. Repeat steps 4 to 7. Note that: - The label is now "Item barcode:" for the manual invoice and manual credit forms. - The error message in step 5 is now "Error: Invalid item barcode entered, please try again". - For the tables in step 8, the column headings remain as "Barcode" - there is generally enough context that it doesn't need to be changed. 10. Sign off D: Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34325 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|On the manual invoice and |On the manual invoice and |credit forms rename |credit forms rename |"Barcode" to "Item Barcode" |"Barcode" to "Item barcode" |for clarity |for clarity -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34325 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Nice one :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34325 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34325 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168580|0 |1 is obsolete| | --- Comment #6 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 169043 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169043&action=edit Bug 34325: Rename "Barcode" to "Item barcode" on manual invoice and credit forms The forms for adding a manual invoice and credit for patrons (in the accounting section) have a field for entering a barcode. This can cause confusion, as it is not clear if it is for an item barcode or the patron card number. This patch changes the form labels and error message for the manual invoice and credit forms to clarify that this is for an item barcode. Related table column headings are left as "Barcode". Test plan: 1. Go to a patron's record: Patrons > search for a patron > select a patron. 2. Go to Accounting > Create manual invoice. 3. Note that there is a label "Barcode:" 4. Enter details for a manual invoice and 'Save': - Type: Manual fee - Barcode: an item barcode, for example 39999000011418 - Amount: 15 ==> Result: Manual invoice saved 5. Repeat step 4, but enter a patron card number for the barcode. For example: 23529000651225. ==> Result: You get an error message "Error: Invalid barcode entered, please try again". 6. Enter details for a manual credit and 'Save': - Credit type: Credit - Barcode: an item barcode, for example 39999000011418 - Amount: 5 ==> Result: Manual credit saved. 7. Check the tables listing transactions - note that the column heading is "Barcode". (Tables are Transactions, Make a payment, and Transactions > Details (under the Actions column). 8. Apply the patch. 9. Repeat steps 4 to 7. Note that: - The label is now "Item barcode:" for the manual invoice and manual credit forms. - The error message in step 5 is now "Error: Invalid item barcode entered, please try again". - For the tables in step 8, the column headings remain as "Barcode" - there is generally enough context that it doesn't need to be changed. 10. Sign off D: Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34325 --- Comment #7 from David Nind <david@davidnind.com> --- Thanks for the sign-off Brendan! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34325 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | Keywords|Academy, Sandbox | --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- String change, QA'd by RM :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34325 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34325 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34325 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |lucas@bywatersolutions.com Status|Pushed to main |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34325 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|FIXED |--- Status|RESOLVED |Needs documenting --- Comment #10 from David Nind <david@davidnind.com> --- Changed status to needs documenting. This change includes user interface changes - the screenshots and field descriptions need updating in the manual https://koha-community.org/manual/latest/en/html/patrons.html#accounting -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org