[Bug 33907] New: Improve translation of title tags: OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33907 Bug ID: 33907 Summary: Improve translation of title tags: OPAC Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: testopia@bugs.koha-community.org Blocks: 33906 This patch will modify OPAC templates, including self checkout and self checkin, so that translatable strings in the <title> tag are wrapped in the correct translation function, e.g. [% t('Translate me') %] Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33906 [Bug 33906] [OMNIBUS] Improve translation of title tags -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33907 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33907 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 152065 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152065&action=edit Bug 33913: Improve translation of title tags: Circulation, holds, and ILL This patch updates circulation, holds, and ILL templates so that title tags can be more easily translated. To test, apply the patch and confirm that the following pages have the correct title tags: - Circulation -> Article requests - Catalog -> Bibliographic record -> Items -> View item's checkout history - Circulation -> Overdues with fines - Circulation -> Transfers - Circulation -> Checkout notes - Circulation -> Circulation home - Circulation -> Check out - Circulation -> Batch checkouts - Circulation -> Curbside pickups - Circulation -> On-site checkouts - Circulation -> Overdues - Circulation -> Holds to pull - Circulation -> Checkout to patron -> Print slip - Circulation -> Renew - Catalog -> Bibliographic record -> Request article - Circulation -> Hold ratios - Circulation -> Check in - Circulation -> Set library - Circulation -> Transfers to receive - Circulation -> Transfers to send - Circulation -> Holds queue - Circulation -> Holds awaiting pickup - ILL requests - Catalog -> Bibliographic record -> Holds -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33907 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152065|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33907 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33907 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33907 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Improve translation of |Improve translation of |title tags: OPAC |title tags: OPAC part 1 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33907 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33907 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 162157 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162157&action=edit Bug 33907: Improve translation of title tags: OPAC part 1 This patch updates a batch of OPAC templates so that title tags can be more easily translated. Some templates have been updated for consistency as well: Harmonizing page title, breaddrumb navigation, and page headers. To test, apply the patch and confirm that the following pages have correct title tags: - Log in to the OPAC by navigating directly to a user page like /cgi-bin/koha/opac-user.pl - From your user summary page, click "Charges." - Check the advanced search page. - Search for a bibliographic record and view the details, and then click "MARC view" and "ISBD view." - From this page click "Save to your lists" and check the title in the popup window." - Still on a detail page, click "Add to your cart." Open the cart and check that page. - Go to authority search (must have OpacAuthorities enabled). - Perform an authority search which will return results. - View the detail page for one of the results, and check the MARC view as well. - With UseCourseReserves enabled, view the course reserves page, then the course reserve detail page. - Search for a subscription which has patron notification enabled. - View the detail page, then open the "Subscriptions" tab. Click "More details." - On this page you should see a "Subscribe to email notification" button. Click it to open the subscription page. - Check both /cgi-bin/koha/opac-browse.pl and /cgi-bin/koha/opac-browser.pl. Whether or not the features are enabled you should be able to check the title. - Check /cgi-bin/koha/ilsdi.pl as well as one or more views linked to on that page. - Navigate to a page in the OPAC which doesn't exist to test the error page template. - Go to Administration -> System preferences and enable the OpacMaintenance preference. - Go to the OPAC and check the system maintenance page. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33907 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |36095 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36095 [Bug 36095] Improve translation of title tags: OPAC part 2 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33907 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33907 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162157|0 |1 is obsolete| | --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 165720 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165720&action=edit Bug 33907: Improve translation of title tags: OPAC part 1 This patch updates a batch of OPAC templates so that title tags can be more easily translated. Some templates have been updated for consistency as well: Harmonizing page title, breaddrumb navigation, and page headers. To test, apply the patch and confirm that the following pages have correct title tags: - Log in to the OPAC by navigating directly to a user page like /cgi-bin/koha/opac-user.pl - From your user summary page, click "Charges." - Check the advanced search page. - Search for a bibliographic record and view the details, and then click "MARC view" and "ISBD view." - From this page click "Save to your lists" and check the title in the popup window." - Still on a detail page, click "Add to your cart." Open the cart and check that page. - Go to authority search (must have OpacAuthorities enabled). - Perform an authority search which will return results. - View the detail page for one of the results, and check the MARC view as well. - With UseCourseReserves enabled, view the course reserves page, then the course reserve detail page. - Search for a subscription which has patron notification enabled. - View the detail page, then open the "Subscriptions" tab. Click "More details." - On this page you should see a "Subscribe to email notification" button. Click it to open the subscription page. - Check both /cgi-bin/koha/opac-browse.pl and /cgi-bin/koha/opac-browser.pl. Whether or not the features are enabled you should be able to check the title. - Check /cgi-bin/koha/ilsdi.pl as well as one or more views linked to on that page. - Navigate to a page in the OPAC which doesn't exist to test the error page template. - Go to Administration -> System preferences and enable the OpacMaintenance preference. - Go to the OPAC and check the system maintenance page. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33907 --- Comment #4 from David Nind <david@davidnind.com> --- I've listed below the updated breadcrumb, page title, and browser page title information after the patch is applied. I've noted a couple of minor things - I'll leave it up to you whether these are warranted or not. Advanced search results page - Maybe the browser page title should include 'Advanced search': . Current breadcrumb: Home > Advanced search > Results of search for 'perl' . Current browser page title: Results of search for 'perl' > Koha online catalog . Suggestion: Results of search for 'perl' > Advanced search > Koha online catalog Detail views for a record - minor changes for more consistency - Suggested changes are: . Breadcrumb (add for): Home > MARC view for: <title> . Breadcrumb (add colon): Home > ISBD view for: <title> - Current wording with the patch: . Breadcrumb: Home > Details for: <title> . Breadcrumb: Home > MARC view: <title> . Breadcrumb: Home > ISBD view for <title> . Browser page title: Details for: <title> > Koha online catalog . Browser page title: MARC view for: <title> > Koha online catalog . Browser page title: ISBD view for: <title> > Koha online catalog Authority search details page - MARC view - Maybe the browser page title should include 'Authority search': . Current breadcrumb: Home > Authority search > <authority term title> (Type of term) > MARC view . Current browser page title: MARC view > <authority term title> (Type of term) > Koha online catalog . Suggestion: MARC view > <authority term title> (Type of term) > Authority search > Koha online catalog Course reserves detail page - Maybe the browser page title should include 'Course reserves': . Current breadcrumb: Home > Course reserves > Course reserves for '<course reserves title>' . Current browser page title: Course reserves for '<course reserves title>' > Koha online catalog . Suggestion: Course reserves for '<course reserves title>' > Course reserves
Koha online catalog
Subscription which has patron notification - Not sure that it needs the 'Subscription alerts' heading, but not bothered either way . Current breadcrumb: Home > Details for <title> > Subscribe to a subscription alert . Current page title: Subscription alerts Subscribe to a subscription alert . Current browser page title: Subscribe to a subscription alert > <title> > Koha online catalog I didn't test any translation things. Breadcrumb, page titles, and browser title information after patch applied ========================================================================== User account charges section: - Breadcrumb: Home > <username> > Your charges - Page title: Your charges - Browser page title: Your charges > Koha online catalog Advanced search: - Breadcrumb: Home > Advanced search - Page title: Advanced search - Browser page title: Advanced search > Koha online catalog Search results (from the advanced search page): - Breadcrumb: Home > Advanced search > Results of search for 'perl' - Page title: Your search returned XX results. Atom/RSS icon to subscribe - Browser page title: Results of search for 'perl' > Koha online catalog Normal view: - Breadcrumb: Home > Details for: <title> - Page title: <title> <author(s)/contributer(s)> - Browser page title: Details for: <title> > Koha online catalog MARC view: - Breadcrumb: Home > MARC view: <title> - Page title: <title> (Record no. XXXX) - Browser page title: MARC view for: <title> > Koha online catalog ISBD view: - Breadcrumb: Home > ISBD view for <title> - Page title: <title> - Browser page title: ISBD view for: <title> > Koha online catalog Cart (pop-up window): - Breadcrumb: None - Page title: Your cart - Browser page title: Your cart > Koha online catalog Authorty search: - Breadcrumb: Home > Authority search - Page title: Authority search - Browser page title: Authority search > Koha online catalog Authority search results: - Breadcrumb: Home > Authority search > Results - Page title: Authority search results - Browser page title: Results > Authority search > Koha online catalog Authority search details page: - Breadcrumb: Home > Authority search > <authority term title> (Type of term) - Page title: <authority term title> (Type of term)* - Browser page title: <authority term title> (Type of term) > Authority search
Koha online catalog
Authority search details page - MARC view: - Breadcrumb: Home > Authority search > <authority term title> (Type of term) > MARC view - Page title: Entry <Type of term>* - Browser page title: MARC view > <authority term title> (Type of term) > Koha online catalog * Term type, such as Topical Term, Personal Name Course reserves: - Breadcrumb: Home > Course reserves - Page title: Courses reserves - Browser page title: Course reserves > Koha online catalog Course reserves detail page: - Breadcrumb: Home > Course reserves > Course reserves for '<course reserves title>' - Page title: Course reserves for '<course reserves title>' - Browser page title: Course reserves for '<course reserves title>' > Koha online catalog Subscription which has patron notification (created a new serial and added some new issues): - Breadcrumb: Home > Details for <title> > Subscribe to a subscription alert - Page title: Subscription alerts Subscribe to a subscription alert - Browser page title: Subscribe to a subscription alert > <title> > Koha online catalog Browse search (/cgi-bin/koha/opac-browse.pl): - Breadcrumb: Home > Browse search - Page title: Browse search - Browser page title: Browse search > Koha online catalog OPAC browser (/cgi-bin/koha/opac-browser.pl): - Breadcrumb: Home > Browse our catalog - Page title: Browse our catalog - Browser page title: Browse our catalog > Koha online catalog ILS-DI (/cgi-bin/koha/ilsdi.pl): - Breadcrumb: Home > ILS-DI - Page title: ILS-DI - Browser page title: ILS-DI > Koha online catalog ILS-DI detail, using GetAvailability (/cgi-bin/koha/ilsdi.pl?service=Describe&verb=GetAvailability): - Breadcrumb: Home > ILS-DI > GetAvailability - Page title: ILS-DI GetAvailability - Browser page title: GetAvailability > ILS-DI > Koha online catalog Page not found: - Breadcrumb: Home > An error has occurred - Page title: Sorry, the requested page is not available Error 404 - Browser page title: An error has occurred > Koha online catalog System maintenance: - Breadcrumb: None - Page title: System maintenace (and message in a box with rounded corners) - Browser page title: System maintenace > Koha online catalog -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33907 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #165720|0 |1 is obsolete| | --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 167488 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167488&action=edit Bug 33907: Improve translation of title tags: OPAC part 1 This patch updates a batch of OPAC templates so that title tags can be more easily translated. Some templates have been updated for consistency as well: Harmonizing page title, breaddrumb navigation, and page headers. To test, apply the patch and confirm that the following pages have correct title tags: - Log in to the OPAC by navigating directly to a user page like /cgi-bin/koha/opac-user.pl - From your user summary page, click "Charges." - Check the advanced search page. - Search for a bibliographic record and view the details, and then click "MARC view" and "ISBD view." - From this page click "Save to your lists" and check the title in the popup window." - Still on a detail page, click "Add to your cart." Open the cart and check that page. - Go to authority search (must have OpacAuthorities enabled). - Perform an authority search which will return results. - View the detail page for one of the results, and check the MARC view as well. - With UseCourseReserves enabled, view the course reserves page, then the course reserve detail page. - Search for a subscription which has patron notification enabled. - View the detail page, then open the "Subscriptions" tab. Click "More details." - On this page you should see a "Subscribe to email notification" button. Click it to open the subscription page. - Check both /cgi-bin/koha/opac-browse.pl and /cgi-bin/koha/opac-browser.pl. Whether or not the features are enabled you should be able to check the title. - Check /cgi-bin/koha/ilsdi.pl as well as one or more views linked to on that page. - Navigate to a page in the OPAC which doesn't exist to test the error page template. - Go to Administration -> System preferences and enable the OpacMaintenance preference. - Go to the OPAC and check the system maintenance page. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33907 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167488|0 |1 is obsolete| | --- Comment #6 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 170824 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170824&action=edit Bug 33907: Improve translation of title tags: OPAC part 1 This patch updates a batch of OPAC templates so that title tags can be more easily translated. Some templates have been updated for consistency as well: Harmonizing page title, breaddrumb navigation, and page headers. To test, apply the patch and confirm that the following pages have correct title tags: - Log in to the OPAC by navigating directly to a user page like /cgi-bin/koha/opac-user.pl - From your user summary page, click "Charges." - Check the advanced search page. - Search for a bibliographic record and view the details, and then click "MARC view" and "ISBD view." - From this page click "Save to your lists" and check the title in the popup window." - Still on a detail page, click "Add to your cart." Open the cart and check that page. - Go to authority search (must have OpacAuthorities enabled). - Perform an authority search which will return results. - View the detail page for one of the results, and check the MARC view as well. - With UseCourseReserves enabled, view the course reserves page, then the course reserve detail page. - Search for a subscription which has patron notification enabled. - View the detail page, then open the "Subscriptions" tab. Click "More details." - On this page you should see a "Subscribe to email notification" button. Click it to open the subscription page. - Check both /cgi-bin/koha/opac-browse.pl and /cgi-bin/koha/opac-browser.pl. Whether or not the features are enabled you should be able to check the title. - Check /cgi-bin/koha/ilsdi.pl as well as one or more views linked to on that page. - Navigate to a page in the OPAC which doesn't exist to test the error page template. - Go to Administration -> System preferences and enable the OpacMaintenance preference. - Go to the OPAC and check the system maintenance page. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33907 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #7 from Lucas Gass <lucas@bywatersolutions.com> --- Rebased for current main. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33907 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Another project to finish for sure - thanks for all the work Owen! QA'd by RM. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33907 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33907 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33907 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33907 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement makes release notes| |structural changes to the | |way OPAC pages are built in | |order to make it easier for | |translators to translate | |the text in the page's | |<title> tag. | | | |Some pages | |have been updated for | |consistency as well: | |Harmonizing page title, | |breadcrumb navigation, and | |page headers. Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33907 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This enhancement makes |This enhancement makes release notes|structural changes to the |structural changes to the |way OPAC pages are built in |way OPAC pages are built to |order to make it easier for |make it easier for |translators to translate |translators to translate |the text in the page's |the text in the page's |<title> tag. |<title> tag. | | |Some pages |Some pages |have been updated for |were also updated for |consistency as well: |consistency: harmonizing |Harmonizing page title, |page title, breadcrumb |breadcrumb navigation, and |navigation, and page |page headers. |headers. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33907 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to main |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org