https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17968 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17968 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com --- Comment #2 from M. Tompsett <mtompset@hotmail.com> --- (In reply to Jonathan Druart from comment #1)

Moreover it the letter parameter, but it is never sent to this subroutine. letter_code is expected instead.

Right, $params->{letter}->{content} is never used, so while the logic actually does something, it isn't actually used at all.

Test plan: No test plan, just read the code and `git grep `

Oh, and there is just the letter_code sent and expected. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17968 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59410|0 |1 is obsolete| | --- Comment #3 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 59484 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59484&action=edit Bug 17968: Remove useless variable $item_format in C4::Overdues::parse_overdues_letter The variable $item_format is not used and should be removed from this subroutine. Moreover it the letter parameter, but it is never sent to this subroutine. letter_code is expected instead. Test plan: No test plan, just read the code and `git grep ` Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17968 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59484|0 |1 is obsolete| | --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 59602 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59602&action=edit Bug 17968: Remove useless variable $item_format in C4::Overdues::parse_overdues_letter The variable $item_format is not used and should be removed from this subroutine. Moreover it the letter parameter, but it is never sent to this subroutine. letter_code is expected instead. Test plan: No test plan, just read the code and `git grep ` Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17968 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle@bywatersolutions.com --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 17.05, thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.