https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17846 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17846 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58587|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 58588 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58588&action=edit Bug 17846: Remove C4::Koha::get_infos_of This subroutine does not longer make any senses. The call to get_infos_of can be replaced with $dbh->selectall_hashref. The third argument of this subroutine was never used. Test plan (for developer only): Compare the 2 codes and confirm that they are equivalent -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17846 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58588|0 |1 is obsolete| | --- Comment #4 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 58596 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58596&action=edit [SIGNED-OFF] Bug 17846: Remove C4::Koha::get_infos_of This subroutine does not longer make any senses. The call to get_infos_of can be replaced with $dbh->selectall_hashref. The third argument of this subroutine was never used. Test plan (for developer only): Compare the 2 codes and confirm that they are equivalent Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17846 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch CC| |mtompset@hotmail.com --- Comment #6 from M. Tompsett <mtompset@hotmail.com> --- Test plan for my patch amendment: apply patch 1 git grep get_infos_of -- still one line apply patch 2 git grep get_infos_of -- no lines Left as needs sign off, because of my amendment. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17846 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17846 --- Comment #8 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 59611 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59611&action=edit Bug 17846: Remove get_infos_of declaration The function which was removed was still being exported. This removes it completely. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17846 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #9 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 17.05, thanks Jonathan, Mark! -- You are receiving this mail because: You are watching all bug changes.