https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24336 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24341 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24341 [Bug 24341] Allow for more complex markup in OPAC confirmation dialogs -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24336 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 96798 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96798&action=edit Bug 24336: Ask for confirmation before deleting a suggestion in the OPAC This patch modifies the OPAC suggestions interface so that patrons will be asked for confirmation before deleting suggestions. The patch also makes some minor markup changes to improve consistency between this interface and others in the OPAC. To test, apply the patch and log in to the OPAC as a user who has submitted multiple suggestions. - From the list of your suggestions, confirm that the "New purchase suggestion" and "Delete" links have Font Awesome icons. - Check the checkbox corresponding to one of your suggestions. You can also now click the title of the suggestions to control the checkbox. - When you check a box the "Delete" link at the top of the page should activate. - Clicking the delete link should trigger a confirmation modal showing the title(s) you selected. - The message and button labels should reflect whether one or multiple titles are being deleted. - Test that the confirm and cancel controls work correctly. - Also test this process via the delete button at the bottom of the table of suggestions. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24336 Maryse Simard <maryse.simard@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96798|0 |1 is obsolete| | --- Comment #3 from Maryse Simard <maryse.simard@inlibro.com> --- Created attachment 96809 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96809&action=edit Bug 24336: Ask for confirmation before deleting a suggestion in the OPAC This patch modifies the OPAC suggestions interface so that patrons will be asked for confirmation before deleting suggestions. The patch also makes some minor markup changes to improve consistency between this interface and others in the OPAC. To test, apply the patch and log in to the OPAC as a user who has submitted multiple suggestions. - From the list of your suggestions, confirm that the "New purchase suggestion" and "Delete" links have Font Awesome icons. - Check the checkbox corresponding to one of your suggestions. You can also now click the title of the suggestions to control the checkbox. - When you check a box the "Delete" link at the top of the page should activate. - Clicking the delete link should trigger a confirmation modal showing the title(s) you selected. - The message and button labels should reflect whether one or multiple titles are being deleted. - Test that the confirm and cancel controls work correctly. - Also test this process via the delete button at the bottom of the table of suggestions. Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24336 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED CC| |katrin.fischer@bsz-bw.de --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- We'll need a sign-off on the dependency bug - Maryse, as you have tested both together, could you have a look? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24336 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Signed Off --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Maryse Simard from comment #6)

I was sure I had signed the dependency while testing... sorry for that. I just did now.

Great, thank you! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24336 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96809|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 97649 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97649&action=edit Bug 24336: Ask for confirmation before deleting a suggestion in the OPAC This patch modifies the OPAC suggestions interface so that patrons will be asked for confirmation before deleting suggestions. The patch also makes some minor markup changes to improve consistency between this interface and others in the OPAC. To test, apply the patch and log in to the OPAC as a user who has submitted multiple suggestions. - From the list of your suggestions, confirm that the "New purchase suggestion" and "Delete" links have Font Awesome icons. - Check the checkbox corresponding to one of your suggestions. You can also now click the title of the suggestions to control the checkbox. - When you check a box the "Delete" link at the top of the page should activate. - Clicking the delete link should trigger a confirmation modal showing the title(s) you selected. - The message and button labels should reflect whether one or multiple titles are being deleted. - Test that the confirm and cancel controls work correctly. - Also test this process via the delete button at the bottom of the table of suggestions. Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24336 --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24336 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy@bywatersolutions.com Resolution|--- |FIXED Status|Pushed to master |RESOLVED --- Comment #10 from Joy Nelson <joy@bywatersolutions.com> --- Enhancement not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes.