[Bug 24433] New: OPAC account page no longer asks for confirmation before deleting hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24433 Bug ID: 24433 Summary: OPAC account page no longer asks for confirmation before deleting hold Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: katrin.fischer@bsz-bw.de, testopia@bugs.koha-community.org Depends on: 24341, 21772 Bug 21772, when adding holds-table.inc, used an older version of opac-detail.tt to create the include. This broke the hold confirmation modal. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21772 [Bug 21772] Add holds and account information tab to the SCO module https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24341 [Bug 24341] Allow for more complex markup in OPAC confirmation dialogs -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24433 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24433 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 97445 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97445&action=edit Bug 24433: OPAC account page no longer asks for confirmation before deleting hold This patch restores markup added by Bug 21870 and subsequently removed accidentally by Bug 21772. This allows the OPAC user summary page to display a confirmation dialog before deleting a hold. To test, apply the patch and log in to the OPAC as a user with holds. - On the "Your summary" page, click the "Holds" tab. - Click the "Cancel" button next to any hold. - You should see a modal dialog asking for confirmation, showing the correct title. - Test both the "Yes" and "No" actions. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24433 Maryse Simard <maryse.simard@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97445|0 |1 is obsolete| | --- Comment #2 from Maryse Simard <maryse.simard@inlibro.com> --- Created attachment 97570 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97570&action=edit Bug 24433: OPAC account page no longer asks for confirmation before deleting hold This patch restores markup added by Bug 21870 and subsequently removed accidentally by Bug 21772. This allows the OPAC user summary page to display a confirmation dialog before deleting a hold. To test, apply the patch and log in to the OPAC as a user with holds. - On the "Your summary" page, click the "Holds" tab. - Click the "Cancel" button next to any hold. - You should see a modal dialog asking for confirmation, showing the correct title. - Test both the "Yes" and "No" actions. Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24433 Maryse Simard <maryse.simard@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |maryse.simard@inlibro.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24433 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24433 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97570|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 97592 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97592&action=edit Bug 24433: OPAC account page no longer asks for confirmation before deleting hold This patch restores markup added by Bug 21870 and subsequently removed accidentally by Bug 21772. This allows the OPAC user summary page to display a confirmation dialog before deleting a hold. To test, apply the patch and log in to the OPAC as a user with holds. - On the "Your summary" page, click the "Holds" tab. - Click the "Cancel" button next to any hold. - You should see a modal dialog asking for confirmation, showing the correct title. - Test both the "Yes" and "No" actions. Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> https://bugs.koha-community.org/show_bug.cgi?id=24341 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24433 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24433 --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24433 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- *** Bug 24095 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24433 Bug 24433 depends on bug 24341, which changed state. Bug 24341 Summary: Allow for more complex markup in OPAC confirmation dialogs https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24341 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24433 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED CC| |joy@bywatersolutions.com --- Comment #6 from Joy Nelson <joy@bywatersolutions.com> --- Not backported to 19.11.x due to dependencies -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org