[Bug 37662] New: Library information - text inconsistencies between the table, edit form, and display page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37662 Bug ID: 37662 Summary: Library information - text inconsistencies between the table, edit form, and display page Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: david@davidnind.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com There are some text inconsistencies between the staff interface table listing the library information, the library edit form, and the library display page (Administration > Basic parameters > Libraries): 1. If no library opening and closing times are set, it displays as "Library hours not set" in the library hours column. However, if you view the library details (selecting the library name in the name column), the text is "No opening hours have been set." 2. The column name in the list of libraries is "Library hours". However: 2.1 If you view the library details (selecting the library name in the name column), the field label is "Opening hours". 2.2 If you add a library, or edit a library's details, the field label is "Opening hours". 3. The "MARC organization code" field is missing the colon (:) on the library edit form and display page. 4. The "OPAC info" field name should be spelt in full as "OPAC information". Also, ideally, the address information should be displayed similar to how a patron's address is displayed. That is, as an address block without the individual fields (as it does in the table listing all libraries). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37662 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Assignee|koha-bugs@lists.koha-commun |david@davidnind.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37662 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Depends on| |36594 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36594 [Bug 36594] Library hours display issues -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37662 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37662 --- Comment #1 from David Nind <david@davidnind.com> --- Created attachment 170461 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170461&action=edit Bug 37662: Improve library information text consistency This improves the consistency of the text between the staff interface library information listing page, and the add, view, and modify library pages. It also improves the text for some field hints. Test plan: 1. Go to Koha administration > Basic parameters > Libraries. 2. Note these inconsistencies: 2.1 Library hours - the text if no hours are set: - For the table, the text is "Library hours not set" - For the view, add, and modify library pages the text is "No opening hours have been set." 2.2 The column and field names for library hours: - For the table, the column name in the list of libraries is "Library hours". - For the view, add, and modify library pages the field label is "Opening hours". 2.3 For the "MARC organization code" field, there is no colon (:) on the view, add, and modify library pages. 2.4 For the "OPAC info" field name, "info" is not spelt in full. 2.5 The hints for the Reply-To and Return-Path fields use this format "Default: <SystemPreferenceName> system preference" pattern, but the MARC organization code field doesn't. 3. Leave tabs open for the library listing, view, and modify library pages. 4. Apply the patch, then duplicate and refresh the tabs for the library listing, view, and modify library pages (so you can compare the differences). 5. Note that the inconsistencies in step 2 are now fixed. 6. Note that the hint text for these fields is changed: 6.1 IP field: active voice 6.2 MARC organization code: follows the pattern used for the Reply-To and Return-Path fields. 6.3 Public: 'yes' to 'Yes' 7. Sign off D: Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37662 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes some release notes| |inconsistencies for the | |library information listing | |page, and the add, view and | |modify library pages. This | |includes: | |1. Using the | |message "Library hours not | |set" for the text if no | |hours are set. | |2. Using | |"Library hours" for the | |column and field name for | |library hours. | |3. Adding a | |missing colon (:) for the | |"MARC organization code" | |field. | |4. Spelling | |"information" in full for | |the previously labelled | |"OPAC info" field. | |5. | |Updating the hint text for | |the IP, MARC organization | |code, and Public fields. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37662 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=36594 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37662 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This fixes some |This fixes some text release notes|inconsistencies for the |inconsistencies for the |library information listing |library information listing |page, and the add, view and |page, and the add, view and |modify library pages. This |modify library pages. This |includes: |includes: |1. Using the |1. Using the |message "Library hours not |message "Library hours not |set" for the text if no |set" for the text if no |hours are set. |hours are set. |2. Using |2. Using |"Library hours" for the |"Library hours" for the |column and field name for |column and field name for |library hours. |library hours. |3. Adding a |3. Adding a |missing colon (:) for the |missing colon (:) for the |"MARC organization code" |"MARC organization code" |field. |field. |4. Spelling |4. Spelling |"information" in full for |"information" in full for |the previously labelled |the previously labelled |"OPAC info" field. |"OPAC info" field. |5. |5. |Updating the hint text for |Updating the hint text for |the IP, MARC organization |the IP, MARC organization |code, and Public fields. |code, and Public fields. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37662 Olivier V <ovezina@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170461|0 |1 is obsolete| | --- Comment #2 from Olivier V <ovezina@inlibro.com> --- Created attachment 171231 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171231&action=edit Bug 37662: Improve library information text consistency This improves the consistency of the text between the staff interface library information listing page, and the add, view, and modify library pages. It also improves the text for some field hints. Test plan: 1. Go to Koha administration > Basic parameters > Libraries. 2. Note these inconsistencies: 2.1 Library hours - the text if no hours are set: - For the table, the text is "Library hours not set" - For the view, add, and modify library pages the text is "No opening hours have been set." 2.2 The column and field names for library hours: - For the table, the column name in the list of libraries is "Library hours". - For the view, add, and modify library pages the field label is "Opening hours". 2.3 For the "MARC organization code" field, there is no colon (:) on the view, add, and modify library pages. 2.4 For the "OPAC info" field name, "info" is not spelt in full. 2.5 The hints for the Reply-To and Return-Path fields use this format "Default: <SystemPreferenceName> system preference" pattern, but the MARC organization code field doesn't. 3. Leave tabs open for the library listing, view, and modify library pages. 4. Apply the patch, then duplicate and refresh the tabs for the library listing, view, and modify library pages (so you can compare the differences). 5. Note that the inconsistencies in step 2 are now fixed. 6. Note that the hint text for these fields is changed: 6.1 IP field: active voice 6.2 MARC organization code: follows the pattern used for the Reply-To and Return-Path fields. 6.3 Public: 'yes' to 'Yes' 7. Sign off D: Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Olivier V <olivier.vezina@inLibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37662 Olivier V <ovezina@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |ovezina@inlibro.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37662 --- Comment #3 from David Nind <david@davidnind.com> --- Thanks for the sign off Olivier V! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37662 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37662 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171231|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 173542 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173542&action=edit Bug 37662: Improve library information text consistency This improves the consistency of the text between the staff interface library information listing page, and the add, view, and modify library pages. It also improves the text for some field hints. Test plan: 1. Go to Koha administration > Basic parameters > Libraries. 2. Note these inconsistencies: 2.1 Library hours - the text if no hours are set: - For the table, the text is "Library hours not set" - For the view, add, and modify library pages the text is "No opening hours have been set." 2.2 The column and field names for library hours: - For the table, the column name in the list of libraries is "Library hours". - For the view, add, and modify library pages the field label is "Opening hours". 2.3 For the "MARC organization code" field, there is no colon (:) on the view, add, and modify library pages. 2.4 For the "OPAC info" field name, "info" is not spelt in full. 2.5 The hints for the Reply-To and Return-Path fields use this format "Default: <SystemPreferenceName> system preference" pattern, but the MARC organization code field doesn't. 3. Leave tabs open for the library listing, view, and modify library pages. 4. Apply the patch, then duplicate and refresh the tabs for the library listing, view, and modify library pages (so you can compare the differences). 5. Note that the inconsistencies in step 2 are now fixed. 6. Note that the hint text for these fields is changed: 6.1 IP field: active voice 6.2 MARC organization code: follows the pattern used for the Reply-To and Return-Path fields. 6.3 Public: 'yes' to 'Yes' 7. Sign off D: Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Olivier Vezina <olivier.vezina@inLibro.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37662 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37662 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37662 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37662 Bug 37662 depends on bug 36594, which changed state. Bug 36594 Summary: Library hours display issues https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36594 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37662 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to main |RESOLVED CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org