[Bug 38243] New: DT's header_filter is unused
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38243 Bug ID: 38243 Summary: DT's header_filter is unused Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Staff interface Assignee: jonathan.druart@gmail.com Reporter: jonathan.druart@gmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Depends on: 32401 It seems to be a leftover from bug 32401, the code does not make sense: 569 if(options.header_filter) { 570 options.query_parameters = query_parameters; 571 } else { 572 dataSet.q = query_parameters; 573 delete options.query_parameters; 574 } Then options.query_parameters is never used. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32401 [Bug 32401] x-koha-query cannot contain non-ISO-8859-1 values -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38243 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38243 --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 173221 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173221&action=edit Bug 38243: Remove DT's header_filter custom param It seems to be a leftover from bug 32401, the code does not make sense: 569 if(options.header_filter) { 570 options.query_parameters = query_parameters; 571 } else { 572 dataSet.q = query_parameters; 573 delete options.query_parameters; 574 } Then options.query_parameters is never used. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38243 --- Comment #2 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 173222 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173222&action=edit Bug 38243: Remove options.query_parameters This is never passed: `git grep query_parameters` -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38243 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com, tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38243 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Staff interface |Architecture, internals, | |and plumbing -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38243 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38243 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173221|0 |1 is obsolete| | --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 173234 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173234&action=edit Bug 38243: Remove DT's header_filter custom param It seems to be a leftover from bug 32401, the code does not make sense: 569 if(options.header_filter) { 570 options.query_parameters = query_parameters; 571 } else { 572 dataSet.q = query_parameters; 573 delete options.query_parameters; 574 } Then options.query_parameters is never used. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38243 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173222|0 |1 is obsolete| | --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 173235 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173235&action=edit Bug 38243: Remove options.query_parameters This is never passed: `git grep query_parameters` Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38243 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #5 from David Nind <david@davidnind.com> --- Not sure exactly how to test, but after the patch is applied a 'git grep options.query_parameters' returns no results. Feel free to change back to 'Needs Signoff' if that is not sufficient. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38243 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173234|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 173513 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173513&action=edit Bug 38243: Remove DT's header_filter custom param It seems to be a leftover from bug 32401, the code does not make sense: 569 if(options.header_filter) { 570 options.query_parameters = query_parameters; 571 } else { 572 dataSet.q = query_parameters; 573 delete options.query_parameters; 574 } Then options.query_parameters is never used. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38243 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173235|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 173514 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173514&action=edit Bug 38243: Remove options.query_parameters This is never passed: `git grep query_parameters` Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38243 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com --- Comment #8 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Confirmed, working, Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38243 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|DT's header_filter is |Datatable's header_filter |unused |is unused -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38243 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38243 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38243 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Resolution|--- |FIXED Status|Pushed to main |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org