[Bug 33490] New: Agreements - Filter by expired results in error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33490 Bug ID: 33490 Summary: Agreements - Filter by expired results in error Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ERM Assignee: jonathan.druart+koha@gmail.com Reporter: pedro.amorim@ptfs-europe.com CC: jonathan.druart+koha@gmail.com, jonathan.field@ptfs-europe.com, martin.renvoize@ptfs-europe.com, pedro.amorim@ptfs-europe.com Depends on: 32030 [ERROR] GET /api/v1/erm/agreements: unhandled exception (DBIx::Class::Exception)<<DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Column 'agreement_id' in where clause is ambiguous at /kohadevbox/koha/Koha/Objects.pm line 394 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32030 [Bug 32030] Electronic resource management (ERM) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33490 --- Comment #1 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- I don't recreate this one, can you provide more details please? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33490 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33490 --- Comment #2 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 149519 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149519&action=edit /cgi-bin/koha/erm/agreements?by_expired=true -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33490 --- Comment #3 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 149521 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149521&action=edit Bug 33490: Prevent 400 because agreements?by_expired=true is missing date We need to update the filter THEN update the current route -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33490 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149521|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 149522 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149522&action=edit Bug 33490: Prevent 400 on agreements?by_expired=true We need to update the filter THEN update the current route -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33490 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149519|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33490 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33490 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33490 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149522|0 |1 is obsolete| | --- Comment #5 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 149523 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149523&action=edit Bug 33490: Prevent 400 on agreements?by_expired=true We need to update the filter THEN update the current route Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33490 --- Comment #6 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Turns out the error I was experiencing was caused by an outdated schema on my end. However, in the process, Joubu discovered this error 400 and provided the fix. The problem can be reproduced by visiting: /cgi-bin/koha/erm/agreements?by_expired=true Apply the patch and visit the URL again. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33490 --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- This works great.. but I think we need a cyrpess test to prevent a future regression here.. I'm going to look at using this one to learn how to write such a test :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33490 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33490 --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 149603 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149603&action=edit Bug 33490: Unit tests This patch adds cypress tests for the filter by expired functionality in the ERM Agreements page. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33490 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149523|0 |1 is obsolete| | --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 149604 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149604&action=edit Bug 33490: Prevent 400 on agreements?by_expired=true We need to update the filter THEN update the current route Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33490 --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- OK, that was a nice distraction for a few hours and I feel like I've wrapped my brain around Cypress testing much better now. I've added tests that I believe catch this particular issue, though I'd love a review if anyone fancies it. * I test for the existence of the filter options when there are any agreements in the system. * I then test for the default date of today being filled after filtering when the 'Filter by expired' checkbox is checked. * This tests: a) that the xhr includes the correct max_expiration_date b) that the window url is updated to reflect the filtering c) the input box value is set and displayed * We then reload the page using the url as defined in step b) above and test that the xhr and input box value get correctly filled again * We then add a user selected date in the input box and check a) that the xhr includes the new correct max_expiration_date b) the window url is updated to reflect the filtering (including the new date) c) the input box value is set and displaying the new date too * Finally, we reload the page again in b) above and confirm all the changes stuck. I added a note that we should also really be testing the other filter too.. but I felt that was out of scope for this particular patch (and I was running low on tuits) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33490 --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- PS.. I'm happy to PQA on the bug as a whole if someone wants to just feedback/verify my cypress test addition here is sane. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33490 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #12 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- I've noticed when reading the tests that something is not totally correct. + cy.url().should('include', "/cgi-bin/koha/erm/agreements?by_expired=true"); // Browser url also updated It should contain max_expiration_date here. The problem is the following: Go to /cgi-bin/koha/erm/agreements Tick "Filter by expired" Click "Filter" New route is "/cgi-bin/koha/erm/agreements?by_expired=true" Input date is filled with today Click "Filter" again New route is "/cgi-bin/koha/erm/agreements?by_expired=true&max_expiration_date=2023-04-13" The date should be in the URL directly. Anybody who'd take a look at it? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33490 --- Comment #13 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 149615 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149615&action=edit Bug 33490: Make url consistent This ensures we populate the max_expiration_date param on the browser url for consistency with selected dates. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33490 --- Comment #14 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- That last patch does the trick, but I don't like it.. we're repeating code with it.. but for the life of me I couldn't work out where to move it to get it to work for both cases. Remaining Failed QA seeking more eyes. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33490 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149615|0 |1 is obsolete| | --- Comment #15 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 149643 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149643&action=edit Bug 33490: Make url consistent This ensures we populate the max_expiration_date param on the browser url for consistency with selected dates. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33490 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #16 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- OK.. I'm happy with that last patch now. However, it does mean that the old url of `/agreements?by_expired=true` leads to a datatables error as we no longer autofill table_url with a default max_expiration_date when it's not passed in the url. The url you'll see in the address bar will include max_expiration_date however, so as long as someone isn't manually typing their url and leaving out the date we're OK.. Does this seem reasonable to you Jonathan.. or should we have belt and braces and autofill for both cases as my last patch did? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33490 --- Comment #17 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Two things do not work with this last patch: 1. As said by Martin already /agreements?by_expired=true will explode (400) 2. The date is not filled in with today's date when you click "filter", empty the date, click "filter" again. New patch coming... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33490 --- Comment #18 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 149652 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149652&action=edit Bug 33490: Improve max date handling It fixes: 1. /agreements?by_expired=true do no longer explode 2. Fill date with today's date when we setup the component and when we hit "filter" However there are a couple of things totally wrong: 1. We should not need is_fp_disabled, we could be able to use :disabled="!filters.by_expired" in the template, but it does not work 2. We should not need to deal with filters.max_expiration_date the "old JS way", but should use a Vue computed value instead. I've failed at that I think those 2 problems have the same root, the way we deal with filters in data() is wrong, and we may be loosing the ref at some point. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33490 --- Comment #19 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- This last patch (and the current code and difficulty we have in fixing this) highlight a problem with the way we handle the filters object. I am really not sure how to deal with it properly, but I think we should spend time on it now, or we are going to carry that and it makes the code too complicated. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33490 --- Comment #20 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Note that this last patch adds an new behaviour, the input is disabled when the checkbox is not ticked. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33490 --- Comment #21 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 149661 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149661&action=edit Bug 33490: Use computed values -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33490 --- Comment #22 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- I am almost there. I think the only problem is that the input is not filled in with today's date when we click "filter". The last patch gets rid of the unnecessary is_fp_disabled and updateMaxExpirationDate() I was referring to in my previous comment. I won't have more time for this today, please have a look! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33490 --- Comment #23 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Sorry Jonathan, I can't get those patches to apply.. sha1 issues :(. That looks reasonable to me though. This can wait for Monday and fresher brains though, so no hurry. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33490 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149603|0 |1 is obsolete| | Attachment #149604|0 |1 is obsolete| | Attachment #149643|0 |1 is obsolete| | Attachment #149652|0 |1 is obsolete| | Attachment #149661|0 |1 is obsolete| | --- Comment #24 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 149672 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149672&action=edit Bug 33490: Unit tests This patch adds cypress tests for the filter by expired functionality in the ERM Agreements page. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33490 --- Comment #25 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 149673 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149673&action=edit Bug 33490: Prevent 400 on agreements?by_expired=true We need to update the filter THEN update the current route Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33490 --- Comment #26 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 149674 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149674&action=edit Bug 33490: Make url consistent This ensures we populate the max_expiration_date param on the browser url for consistency with selected dates. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33490 --- Comment #27 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 149675 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149675&action=edit Bug 33490: Improve max date handling It fixes: 1. /agreements?by_expired=true do no longer explode 2. Fill date with today's date when we setup the component and when we hit "filter" However there are a couple of things totally wrong: 1. We should not need is_fp_disabled, we could be able to use :disabled="!filters.by_expired" in the template, but it does not work 2. We should not need to deal with filters.max_expiration_date the "old JS way", but should use a Vue computed value instead. I've failed at that I think those 2 problems have the same root, the way we deal with filters in data() is wrong, and we may be loosing the ref at some point. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33490 --- Comment #28 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 149676 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149676&action=edit Bug 33490: Use computed values -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33490 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |33483 Status|Signed Off |ASSIGNED --- Comment #29 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Rebased on top of bug 33483. But that's not enough IMO, there are some tiny bugs in the behaviours, see comment 22. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33483 [Bug 33483] Cannot link EBSCO's package with local agreement -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33490 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33490 --- Comment #30 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 150038 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150038&action=edit Bug 33490: Rollback computed Use a watch instead -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33490 --- Comment #31 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 150039 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150039&action=edit Bug 33490: Fix ambiguous query error Doing actual testing with some agreements with expired periods, this was returning a 500 error -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33490 --- Comment #32 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 150040 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150040&action=edit Bug 33490: Add test -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33490 --- Comment #33 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Getting 400 when hitting /erm/agreements?by_expired=true But I don't think it's blocker now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33490 --- Comment #34 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Tests are using 'today_us' that was not used. That means that the tests will fail if dateformat is not the value from the sample data. Not ideal but better to have a test. + cy.url().should('include', "/cgi-bin/koha/erm/agreements?by_expired=true"); // Browser url also updated Should not we adjust this test? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33490 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150040|0 |1 is obsolete| | --- Comment #35 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 150048 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150048&action=edit Bug 33490: Add test -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33490 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #36 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- (In reply to Jonathan Druart from comment #34)
Tests are using 'today_us' that was not used. That means that the tests will fail if dateformat is not the value from the sample data.
Not ideal but better to have a test.
+ cy.url().should('include', "/cgi-bin/koha/erm/agreements?by_expired=true"); // Browser url also updated
Should not we adjust this test?
The flatpickr input in the UI is using today_us e.g. 04/20/2023 The flatpickr element attribute that stores the date is today_iso e.g. 2023-04-20 The URL dateformat is today_iso e.g. 2023-04-20 There was a slight difference in the selector ("+input") of my test. Adjusted now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33490 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33490 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149672|0 |1 is obsolete| | Attachment #149673|0 |1 is obsolete| | Attachment #149674|0 |1 is obsolete| | Attachment #149675|0 |1 is obsolete| | Attachment #149676|0 |1 is obsolete| | Attachment #150038|0 |1 is obsolete| | Attachment #150039|0 |1 is obsolete| | Attachment #150048|0 |1 is obsolete| | --- Comment #37 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 150194 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150194&action=edit Bug 33490: Unit tests This patch adds cypress tests for the filter by expired functionality in the ERM Agreements page. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33490 --- Comment #38 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 150195 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150195&action=edit Bug 33490: Prevent 400 on agreements?by_expired=true We need to update the filter THEN update the current route Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33490 --- Comment #39 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 150196 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150196&action=edit Bug 33490: Make url consistent This ensures we populate the max_expiration_date param on the browser url for consistency with selected dates. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33490 --- Comment #40 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 150197 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150197&action=edit Bug 33490: Improve max date handling It fixes: 1. /agreements?by_expired=true do no longer explode 2. Fill date with today's date when we setup the component and when we hit "filter" However there are a couple of things totally wrong: 1. We should not need is_fp_disabled, we could be able to use :disabled="!filters.by_expired" in the template, but it does not work 2. We should not need to deal with filters.max_expiration_date the "old JS way", but should use a Vue computed value instead. I've failed at that I think those 2 problems have the same root, the way we deal with filters in data() is wrong, and we may be loosing the ref at some point. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33490 --- Comment #41 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 150198 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150198&action=edit Bug 33490: Use computed values Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33490 --- Comment #42 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 150199 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150199&action=edit Bug 33490: Rollback computed Use a watch instead Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33490 --- Comment #43 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 150200 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150200&action=edit Bug 33490: Fix ambiguous query error Doing actual testing with some agreements with expired periods, this was returning a 500 error Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33490 --- Comment #44 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 150201 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150201&action=edit Bug 33490: Add test Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33490 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #45 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- This is good to go now! Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33490 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33490 --- Comment #46 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33490 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.06 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33490 --- Comment #47 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33490 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Pushed to stable |RESOLVED Resolution|--- |FIXED --- Comment #48 from Lucas Gass <lucas@bywatersolutions.com> --- Missing dependencies for 22.05.x, no backport -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33490 Bug 33490 depends on bug 33483, which changed state. Bug 33483 Summary: Cannot link EBSCO's package with local agreement https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33483 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org