[Bug 38509] New: Displayed transfer destination is incorrect when a reservation has been found
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38509 Bug ID: 38509 Summary: Displayed transfer destination is incorrect when a reservation has been found Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: baptiste.wojtkowski@biblibre.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com TEST PLAN FOR 24.05 (transfers appear to be broken on main atm, code is still invalid on main) 1 - Place a hold for Henry Acevedo on "39999000001334" (item level), ask for a pickup at centerville 2 - At centerville, transfer the document to fairfield. There will be a pop-up giving you three choices. The first one is "transfer to centerville", which is not the behaviour or the button. The correct text is "transfer to fairfield". The button must display the branch selected for the transfer and not the pickup location for the reservation (which is the branch at which we are located.) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38509 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |baptiste.wojtkowski@biblibr |ity.org |e.com Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38509 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38509 --- Comment #1 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 174889 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174889&action=edit Bug 38509 - Displayed transfer destination is incorrect when a reservation has been found TEST PLAN FOR 24.05 (transfers appear to be broken on main atm, code is still invalid on main) 1 - Place a hold for Henry Acevedo on "39999000001334" (item level), ask for a pickup at centerville 2 - At centerville, transfer the document to fairfield. There will be a pop-up giving you three choices. The first one is "transfer to centerville", which is not the behaviour of the button (the behaviour is correct, we want to perform the transfer and ignore the reservation). The last element of the pop-up is "transfer to: Centerville", which is incorrect too APPLY PATCH 3 - At centerville, transfer the document to fairfield. There will be a pop-up giving you three choices. The first one is "transfer to fairfield", which is not the behaviour or the button. The last element of the pop-up is "transfer to: Centerville". -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38509 --- Comment #2 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 174890 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174890&action=edit Bug 38509: [22.11] Displayed transfer destination is incorrect when a reservation has been found TEST PLAN FOR 22.11 1 - Place a hold for Henry Acevedo on "39999000001334" (item level), ask for a pickup at centerville 2 - At centerville, transfer the document to fairfield. There will be an array giving you three choices. The first one is "transfer to centerville", which is not the behaviour of the button (the behaviour is correct, we want to perform the transfer and ignore the reservation). APPLY PATCH 3 - At centerville, transfer the document to fairfield. There will be a pop-up giving you three choices. The first one is "transfer to fairfield", which is not the behaviour or the button. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38509 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174889|0 |1 is obsolete| | --- Comment #3 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 174891 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174891&action=edit Bug 38509: Displayed transfer destination is incorrect when a reservation has been found TEST PLAN FOR 24.05 (transfers appear to be broken on main atm, code is still invalid on main) 1 - Place a hold for Henry Acevedo on "39999000001334" (item level), ask for a pickup at centerville 2 - At centerville, transfer the document to fairfield. There will be a pop-up giving you three choices. The first one is "transfer to centerville", which is not the behaviour of the button (the behaviour is correct, we want to perform the transfer and ignore the reservation). The last element of the pop-up is "transfer to: Centerville", which is incorrect too APPLY PATCH 3 - At centerville, transfer the document to fairfield. There will be a pop-up giving you three choices. The first one is "transfer to fairfield", which is not the behaviour or the button. The last element of the pop-up is "transfer to: Centerville". -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38509 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38509 --- Comment #4 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Removing status needs signoff: there is a bug with the behaviour of the first button ; no transfer is created however there is a feedback for transfer creation. I need to investigate. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38509 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|baptiste.wojtkowski@biblibr |koha-bugs@lists.koha-commun |e.com |ity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38509 Rebecca Coert <rcoert@arlingtonva.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rcoert@arlingtonva.us -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38509 --- Comment #5 from Thibaud Guillot (thibaud_g) <thibaud.guillot@biblibre.com> --- Created attachment 185882 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185882&action=edit Bug 38509: Set correct transfer when a hold exists When you transfer a reserved item, a pop up appears. Depending on your action, if you choose to transfer the item anyway, the flow is not normal afterwards: - Item is not added to branchtransfers sql tables (so neither in "Transfer to receive" section) - It does not appear in the list under the transfer action - Its homebranch is immediately that of destination site Test plan: 1) Place hold on item specific or not, with pickup library different than current library for a real case 2) Transfer this item to another library (library choose for pickup for example) 3) You will see a pop up (with incorrect label destination) 4) After confirm it, pop up disappears and none transfer is saved in branchtransfers table (neither in 'transfer to receive' section) 5) On biblio page you will already see item with new homebranch 6) Apply this patch and restart_all 7) Perform the same action, place a hold then transfer item 8) Pop up shows now the correct label destination 9) Transfer will be correctly performed, appears in branchtransfers sql table and 'transfer to receive' section (for destination site). Also item homebranch does not changes until the destination site check in it. Sponsored-by: BibLibre Co-authored-by: bwoj - baptiste.wojtkowski@biblibre.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38509 Thibaud Guillot (thibaud_g) <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |thibaud.guillot@biblibre.co | |m Attachment #174891|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38509 Thibaud Guillot (thibaud_g) <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174890|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38509 Thibaud Guillot (thibaud_g) <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Displayed transfer |Set correct transfer when a |destination is incorrect |hold exists |when a reservation has been | |found | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38509 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38509 Anneli Österman <anneli.osterman@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |anneli.osterman@koha-suomi. | |fi --- Comment #6 from Anneli Österman <anneli.osterman@koha-suomi.fi> --- I tested this in a sandbox and with the item all went according to the test plan. But the hold gets trapped when you transfer the item. So the item says it's being transferred to library A but the hold says it's being transferred to library B. When you checkin the item in library A, it immediately want's to be transferred to library B because it is trapped to a hold. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org