https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nicole@bywatersolutions.com | |, rhilliker@hotchkiss.org Assignee|gmcharlt@gmail.com |nick@bywatersolutions.com Status|NEW |ASSIGNED Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 53323 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53323&action=edit Bug 15986 - Add a script for sending hold waiting reminder notices This patch adds a script for sending holds reminder notice to patrons. Essentially it is a modification of the overdue_notices.pl script To test: 1 - Create a hold reminder notice (Koha module: Holds) 2 - Set some waiting holds for patrons 3 - Run the script with various options and verify correct data is generated -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53323|0 |1 is obsolete| | --- Comment #2 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 53354 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53354&action=edit Bug 15986 - Add a script for sending hold waiting reminder notices This patch adds a script for sending holds reminder notice to patrons. Essentially it is a modification of the overdue_notices.pl script To test: 1 - Create a hold reminder notice (Koha module: Holds) 2 - Set some waiting holds for patrons 3 - Run the script with various options and verify correct data is generated Sponsored by: The Hotchkiss School (http://www.hotchkiss.org/) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion CC| |chris@bigballofwax.co.nz --- Comment #4 from Chris Cormack <chris@bigballofwax.co.nz> --- Just a general comment, we have a setting where borrowers can opt in/out of holds filled notices. Should this script respect that preference, IE if they don't get a hold filled notice will they be happy getting one saying it's waiting. Annoying patrons is something libraries generally like to avoid :) It should be easy enough to use the check we have for holds filled in circulation I hope -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986 --- Comment #6 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Chris Cormack from comment #4)

Just a general comment, we have a setting where borrowers can opt in/out of holds filled notices. Should this script respect that preference, IE if they don't get a hold filled notice will they be happy getting one saying it's waiting. Annoying patrons is something libraries generally like to avoid :)

Good point, I added it as a switch, some libraries charge fines for holds not picked up etc, so they may want to force the notification, I figure this way makes it flexible -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986 Sally Healey <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey@cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53594|0 |1 is obsolete| | --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 55723 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55723&action=edit [SIGNED-OFF] Bug 15986 - Add a script for sending hold waiting reminder notices This patch adds a script for sending holds reminder notice to patrons. Essentially it is a modification of the overdue_notices.pl script To test: 1 - Create a hold reminder notice (Koha module: Holds) 2 - Set some waiting holds for patrons 3 - Run the script with various options and verify correct data is generated 4 - Verify that with 'optout' switch set only patrons who have email hold filled notices specified will recieve a reminder Sponsored by: The Hotchkiss School (http://www.hotchkiss.org/) Signed-off-by: Robert <rhilliker@hotchkiss.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I love the amount of documentation for this script! I didn't get to test this yet, but while reading through it I wondered: There is a lot of work done in order to allow exporting in different formats. I was wondering if it might be better to leave the job of creating a printable version to gather_print_notices.pl working towards a more unified workflow for all the printed letters. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion CC| |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |ASSIGNED --- Comment #12 from Chris Cormack <chris@bigballofwax.co.nz> --- (In reply to Sally Healey from comment #11)

This is a really exciting feature.

I know it's been sent back to discussion from being signed off - what's the next step for moving it forward? We think this would make a fantastic addition to Koha.

To move it forward it needs comment 10 addressed, and a lot of the code moved out of the .pl file into a module, with unit tests written. This shouldn't be a big job, but will mean way less chance of breakage/maintenance in the future. As well as a signoff from outside of the sponsoring library. I think comment 9 could be a future enhancement. But mostly comment 10 (moving the code to a module and writing tests) and an independent sign off are what are need -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986 George Williams (NEKLS) <george@nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |george@nekls.org -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986 --- Comment #15 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Chris Cormack from comment #12)

I think comment 9 could be a future enhancement. But mostly comment 10 (moving the code to a module and writing tests) and an independent sign off are what are need

Code for sending moved to Koha::Patron::send_notice -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91767|0 |1 is obsolete| | --- Comment #17 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 91768 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91768&action=edit Bug 15986: Add a script for sending hold waiting reminder notices This patch adds a script for sending holds reminder notice to patrons. We add a 'send_notice' routine to Koha::Patrons - this will either send using the patron's email prefs, or allow forcing of a single method via the cron To test: 1 - Create an email hold reminder notice for a single library (Koha module: Holds, code HOLDREMINDER, branch: CPL) 2 - Set some waiting holds today for patrons at CPL, ensure those patrons have 'email' as the transport for hold filled notices 3 - perl misc/cronjobs/holds_reminder.pl -v -lettercode HOLDREMINDER -n -li CPL 4 - You should see the patrons here would have received emails 5 - perl misc/cronjobs/holds_reminder.pl -v -lettercode HOLDREMINDER -li CPL 6 - You should see the emails that were sent 7 - Check the patron notices tab to confirm 8 - Note a ptron with two holds waiting receives only one notice 9 - perl misc/cronjobs/holds_reminder.pl -v -lettercode HOLDREMINDER -li CPL -days 3 10 - No notices are sent 11 - Adjust the waiting date for the holds: UPDATE reserves SET waitingdate=DATE_SUB(CURDATE(), INTERVAL 3 DAYS) WHERE waitingdate = CURDATE(); 12 - perl misc/cronjobs/holds_reminder.pl -v -lettercode HOLDREMINDER -li CPL -days 3 13 - Confirm the holds are now reminded 14 - Set yesterday as a holiday for CPL 15 - perl misc/cronjobs/holds_reminder.pl -v -lettercode HOLDREMINDER -n -li CPL -holidays -days 3 16 - Notices should not be sent 17 - perl misc/cronjobs/holds_reminder.pl -v -lettercode HOLDREMINDER -n -li CPL -holidays -days 4 18 - Notices should be sent again 19 - perl misc/cronjobs/holds_reminder.pl -v -lettercode HOLDREMINDER -n -holidays -days 4 20 - Should get feedback that notice was not found for other libraries 21 - perl misc/cronjobs/holds_reminder.pl -v -lettercode HOLDREMINDER -n -holidays -days 4 -mtt sms 22 - Notice is not found 23 - Add the notice for sms 24 - perl misc/cronjobs/holds_reminder.pl -v -lettercode HOLDREMINDER -n -holidays -days 4 -mtt sms 25 - The notice should be sent 26 - Check patrons messaging tab to confirm 27 - prove -v t/db_dependent/Koha/Patrons.t Sponsored by: The Hotchkiss School (http://www.hotchkiss.org/) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |david@davidnind.com --- Comment #18 from David Nind <david@davidnind.com> --- Patch no longer applies -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91768|0 |1 is obsolete| | --- Comment #19 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 99919 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99919&action=edit Bug 15986: Add a script for sending hold waiting reminder notices This patch adds a script for sending holds reminder notice to patrons. We add a 'send_notice' routine to Koha::Patrons - this will either send using the patron's email prefs, or allow forcing of a single method via the cron To test: 1 - Create an email hold reminder notice for a single library (Koha module: Holds, code HOLDREMINDER, branch: CPL) 2 - Set some waiting holds today for patrons at CPL, ensure those patrons have 'email' as the transport for hold filled notices 3 - perl misc/cronjobs/holds_reminder.pl -v -lettercode HOLDREMINDER -n -li CPL 4 - You should see the patrons here would have received emails 5 - perl misc/cronjobs/holds_reminder.pl -v -lettercode HOLDREMINDER -li CPL 6 - You should see the emails that were sent 7 - Check the patron notices tab to confirm 8 - Note a ptron with two holds waiting receives only one notice 9 - perl misc/cronjobs/holds_reminder.pl -v -lettercode HOLDREMINDER -li CPL -days 3 10 - No notices are sent 11 - Adjust the waiting date for the holds: UPDATE reserves SET waitingdate=DATE_SUB(CURDATE(), INTERVAL 3 DAYS) WHERE waitingdate = CURDATE(); 12 - perl misc/cronjobs/holds_reminder.pl -v -lettercode HOLDREMINDER -li CPL -days 3 13 - Confirm the holds are now reminded 14 - Set yesterday as a holiday for CPL 15 - perl misc/cronjobs/holds_reminder.pl -v -lettercode HOLDREMINDER -n -li CPL -holidays -days 3 16 - Notices should not be sent 17 - perl misc/cronjobs/holds_reminder.pl -v -lettercode HOLDREMINDER -n -li CPL -holidays -days 4 18 - Notices should be sent again 19 - perl misc/cronjobs/holds_reminder.pl -v -lettercode HOLDREMINDER -n -holidays -days 4 20 - Should get feedback that notice was not found for other libraries 21 - perl misc/cronjobs/holds_reminder.pl -v -lettercode HOLDREMINDER -n -holidays -days 4 -mtt sms 22 - Notice is not found 23 - Add the notice for sms 24 - perl misc/cronjobs/holds_reminder.pl -v -lettercode HOLDREMINDER -n -holidays -days 4 -mtt sms 25 - The notice should be sent 26 - Check patrons messaging tab to confirm 27 - prove -v t/db_dependent/Koha/Patrons.t Sponsored by: The Hotchkiss School (http://www.hotchkiss.org/) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986 --- Comment #21 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #20)

Is the test_mode parameter of the method really useful?

Yes. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #22 from David Nind <david@davidnind.com> --- Things move too fast 8-) - patch no longer applies: root@5e1d1195a414:koha(bz15986)$ git bz apply 15986 Bug 15986 - Add a script for sending hold waiting reminder notices 99919 - Bug 15986: Add a script for sending hold waiting reminder notices Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 15986: Add a script for sending hold waiting reminder notices Using index info to reconstruct a base tree... M C4/Letters.pm M Koha/Patron.pm M t/db_dependent/Koha/Patrons.t Falling back to patching base and 3-way merge... Auto-merging t/db_dependent/Koha/Patrons.t CONFLICT (content): Merge conflict in t/db_dependent/Koha/Patrons.t Auto-merging Koha/Patron.pm CONFLICT (content): Merge conflict in Koha/Patron.pm Auto-merging C4/Letters.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 15986: Add a script for sending hold waiting reminder notices Also noticed that there is a holds subfolder in misc/cronjobs - should the script go in that? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99919|0 |1 is obsolete| | --- Comment #23 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 102723 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102723&action=edit Bug 15986: Add a script for sending hold waiting reminder notices This patch adds a script for sending holds reminder notice to patrons. We add a 'send_notice' routine to Koha::Patrons - this will either send using the patron's email prefs, or allow forcing of a single method via the cron To test: 1 - Create an email hold reminder notice for a single library (Koha module: Holds, code HOLDREMINDER, branch: CPL) 2 - Set some waiting holds today for patrons at CPL, ensure those patrons have 'email' as the transport for hold filled notices 3 - perl misc/cronjobs/holds_reminder.pl -v -lettercode HOLDREMINDER -n -li CPL 4 - You should see the patrons here would have received emails 5 - perl misc/cronjobs/holds_reminder.pl -v -lettercode HOLDREMINDER -li CPL 6 - You should see the emails that were sent 7 - Check the patron notices tab to confirm 8 - Note a ptron with two holds waiting receives only one notice 9 - perl misc/cronjobs/holds_reminder.pl -v -lettercode HOLDREMINDER -li CPL -days 3 10 - No notices are sent 11 - Adjust the waiting date for the holds: UPDATE reserves SET waitingdate=DATE_SUB(CURDATE(), INTERVAL 3 DAYS) WHERE waitingdate = CURDATE(); 12 - perl misc/cronjobs/holds_reminder.pl -v -lettercode HOLDREMINDER -li CPL -days 3 13 - Confirm the holds are now reminded 14 - Set yesterday as a holiday for CPL 15 - perl misc/cronjobs/holds_reminder.pl -v -lettercode HOLDREMINDER -n -li CPL -holidays -days 3 16 - Notices should not be sent 17 - perl misc/cronjobs/holds_reminder.pl -v -lettercode HOLDREMINDER -n -li CPL -holidays -days 4 18 - Notices should be sent again 19 - perl misc/cronjobs/holds_reminder.pl -v -lettercode HOLDREMINDER -n -holidays -days 4 20 - Should get feedback that notice was not found for other libraries 21 - perl misc/cronjobs/holds_reminder.pl -v -lettercode HOLDREMINDER -n -holidays -days 4 -mtt sms 22 - Notice is not found 23 - Add the notice for sms 24 - perl misc/cronjobs/holds_reminder.pl -v -lettercode HOLDREMINDER -n -holidays -days 4 -mtt sms 25 - The notice should be sent 26 - Check patrons messaging tab to confirm 27 - prove -v t/db_dependent/Koha/Patrons.t Sponsored by: The Hotchkiss School (http://www.hotchkiss.org/) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986 --- Comment #25 from David Nind <david@davidnind.com> --- Also, in step 11 '..INTERVAL 3 DAYS)..' should be '..INTERVAL 3 DAY)..' (that is, DAYS should be DAY). -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986 --- Comment #27 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to David Nind from comment #24)

For step 17, 19, 21, and 24 I'm getting an error message when running the script:

perl misc/cronjobs/holds_reminder.pl -v -lettercode HOLDREMINDER -n -li CPL -holidays -days 3 branch CPL passed on parameter Can't locate object method "in_units" via package "-3" (perhaps you forgot to load "-3"?) at /kohadevbox/koha/Koha/Calendar.pm line 193.

Fixed, thanks David! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |andrew@bywatersolutions.com --- Comment #31 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- I'm also getting stuck at step 17. I have my reserves with waiting date set to curdate-3. They properly trigger a notice when not worrying about holidays. But once I set the -holidays flag in the command I cannot get notices to generate, no matter how many days I give it. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986 --- Comment #33 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 106963 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106963&action=edit Bug 15986: Update for bug 24159 The job is concerned with holds waiting and takes days, I think using days_mode 'Calendar' makes sense as we are not calculating due dates -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986 --- Comment #35 from Nick Clemens <nick@bywatersolutions.com> --- Adding a holiday means the holds are waiting 1-less day, not 1 more :-) Fixed the math in the test plan :-) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #106963|0 |1 is obsolete| | --- Comment #38 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 113000 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113000&action=edit Bug 15986: Update for bug 24159 The job is concerned with holds waiting and takes days, I think using days_mode 'Calendar' makes sense as we are not calculating due dates Signed-off-by: Kim Gnerre <kgnerre@hotchkiss.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986 Kim Gnerre <kgnerre@hotchkiss.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kgnerre@hotchkiss.org -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986 --- Comment #40 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Séverine Queune from comment #36)

This patch works fine ! But I won't sign it because of 2 points : - I can't test the sms part, I don't know how it works and how to use the feature - I've got a question about the content of the message : when there several holds, only the informations about the oldest reserve (for what I saw) are displayed. Fields coming from the items or biblio tables can't be used. I know it's happening for some other notices so don't Failed the patch because of this point, but I regret I couldn't use the <<count>> or <<items.content>> datas as it is recommended for some other notices, I think it could be useful for patron to have some details about the waiting holds.

- sms part works exactly like email up to the sending of the message, so testing is the same, just need to confirm it makes it into the queue - the notice supports template toolkit, so you can get other holds information like: Dear [% borrower.firstname %] [% borrower.surname %], Your hold for [% hold.biblio.title %] is waiting since [% hold.waitingdate %] [% IF borrower.holds.count > 0 %] You also have other holds: [% FOREACH hold IN borrower.holds %] [% hold.biblio.title %] : [% hold.found %] [% END %] [% END %] That could be cleaned up and made fancier, but just to give an idea -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net --- Comment #42 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Can't QA this one but got a question about -holidays, why is it better to not take them into account by default? I don't have much functional experience so I might miss something obvious ^^ -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986 --- Comment #44 from Victor Grousset/tuxayo <victor@tuxayo.net> ---

The various sysprefs that determine whether or not to consult the calendar for various tasks are inconsistent in a new install

:o

However, ExcludeHolidaysFromMaxPickUpDelay defaults to off. That's not exactly the same as the --holiday flag here, but seems close enough that I'm happy to make this new feature keep the same default choice.

Thanks for the analysis. Is there an obviously less surprising default choice there? Or does it depend too much? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986 --- Comment #46 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Good, there doesn't seem to be a bad choice. Thanks for the info Andrew, that was my 2 cents, I'll leave the rest to more knowledgeable people ^^" -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986 Barbara Johnson <barbara.johnson@bedfordtx.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barbara.johnson@bedfordtx.g | |ov -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112999|0 |1 is obsolete| | --- Comment #47 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 118733 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118733&action=edit Bug 15986: Add a script for sending hold waiting reminder notices This patch adds a script for sending holds reminder notice to patrons. We add a 'send_notice' routine to Koha::Patrons - this will either send using the patron's email prefs, or allow forcing of a single method via the cron To test: 1 - Create an email hold reminder notice for a single library (Koha module: Holds, code HOLDREMINDER, branch: CPL) 2 - Set some waiting holds today for patrons at CPL, ensure those patrons have 'email' as the transport for hold filled notices 3 - perl misc/cronjobs/holds_reminder.pl -v -lettercode HOLDREMINDER -n -li CPL 4 - You should see the patrons here would have received emails 5 - perl misc/cronjobs/holds_reminder.pl -v -lettercode HOLDREMINDER -li CPL 6 - You should see the emails that were sent 7 - Check the patron notices tab to confirm 8 - Note a ptron with two holds waiting receives only one notice 9 - perl misc/cronjobs/holds_reminder.pl -v -lettercode HOLDREMINDER -li CPL -days 3 10 - No notices are sent 11 - Adjust the waiting date for the holds: UPDATE reserves SET waitingdate=DATE_SUB(CURDATE(), INTERVAL 3 DAY) WHERE waitingdate = CURDATE(); 12 - perl misc/cronjobs/holds_reminder.pl -v -lettercode HOLDREMINDER -li CPL -days 3 13 - Confirm the holds are now reminded 14 - Set yesterday as a holiday for CPL 15 - perl misc/cronjobs/holds_reminder.pl -v -lettercode HOLDREMINDER -n -li CPL -holidays -days 3 16 - Notices should not be sent 17 - perl misc/cronjobs/holds_reminder.pl -v -lettercode HOLDREMINDER -n -li CPL -holidays -days 2 18 - Notices should be sent again 19 - perl misc/cronjobs/holds_reminder.pl -v -lettercode HOLDREMINDER -n -holidays -days 2 20 - Should get feedback that notice was not found for other libraries 21 - perl misc/cronjobs/holds_reminder.pl -v -lettercode HOLDREMINDER -n -holidays -days 2 -mtt sms 22 - Notice is not found 23 - Add the notice for sms 24 - perl misc/cronjobs/holds_reminder.pl -v -lettercode HOLDREMINDER -n -holidays -days 2 -mtt sms 25 - The notice should be sent 26 - Check patrons messaging tab to confirm 27 - prove -v t/db_dependent/Koha/Patrons.t Sponsored by: The Hotchkiss School (http://www.hotchkiss.org/) Signed-off-by: Kim Gnerre <kgnerre@hotchkiss.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113001|0 |1 is obsolete| | --- Comment #49 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 118735 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118735&action=edit Bug 15986: Rename send_notice to queue_notice and update test count Signed-off-by: Kim Gnerre <kgnerre@hotchkiss.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize@ptfs-europe | |.com --- Comment #51 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Whilst I feel we could continue to iterate on this and make improvements, I think this enhancement has waited long enough and those iterations can come in the future as the queue_notice method starts to get more widely adopted. It all works as expected, contained tests for the new Patron method and causes no regressions. Passing QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986 --- Comment #53 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 119277 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119277&action=edit Bug 15986: (follow-up) Fix usage statement -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #54 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- 1. 1824 my $admin_email_address = $library->{branchemail} || C4::Context->preference('KohaAdminEmailAddress'); Shouldn't it be $library->inbound_email_address instead? 2. 1844 next if ($mtt eq 'phone' and C4::Context->preference('TalkingTechItivaPhoneNotification') ); There are now 2 mtt, phone and itiva. Here you need to compare with 'itiva', and add a new condition for 'phone'. 3. Shouldn't we rename "send_notice" to "enqueue_notice" as we don't actually send it right away? 4. Why don't we insert a sample notice template and use it as the default for the script? 5. + # If passed message transports we force use those, otherwise we will use the patrons preferences + # for the 'Hold_Filled' notice + my $sending_params = @mtts ? { message_transports => \@mtts } : { message_name => "Hold_Filled" }; We should add that to the POD 6. + # Skip if we already dealt with this borrower + next if ( $done{$patron->borrowernumber} ); What if a patron has more than one hold? We won't be able to send a notice like "You have X holds waiting" 7. (not blocker) please don't forget to perltidy new files and blocks of code. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986 --- Comment #55 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 119308 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119308&action=edit Bug 15986: (follow-up) Use inbound_email_address for library -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986 --- Comment #57 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to Nick Clemens from comment #55)

Created attachment 119308 [details] [review] Bug 15986: (follow-up) Use inbound_email_address for library

Damn, Shame on me for missing that one.. I agree the others should already be fixed by my followups. A sample notice would be nice, I agree here with Jonathan really... Especially given the chance sample here where you iterate through holds to construct a digest. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986 --- Comment #59 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 119327 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119327&action=edit Bug 15986: (follow-up) Add all holds per patron This changes the code to loop through all the holds and group by patron, we then send the holds to the letter using the 'loops' option -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986 --- Comment #61 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 119329 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119329&action=edit Bug 15986: Add sample notice to translated notices -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986 --- Comment #63 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 119384 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119384&action=edit Bug 15986: Use KohaDates filter to correctly format the waitingdate -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986 --- Comment #65 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Few more questions, (sorry!) 1. 58 -n No email will be sent shouldn't be replaced with a --confirm flag? 2. Shouldn't we add a new message preference to let patrons a choice to opt-out if they wish? That could be done on a separate bug report but needed for 21.05 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986 --- Comment #66 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 119624 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119624&action=edit Bug 15986: (follow-up) Switch nomail to confirm -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986 --- Comment #69 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 119748 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119748&action=edit Bug 15986: Add missing notice template for it-IT -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #71 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 20.11.x -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986 --- Comment #72 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 120224 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120224&action=edit Bug 15986: Remove \r from HOLD_REMINDER in the yml To prevent the following errors on `gulp po:update` misc/translator/Koha-installer.pot:952: warning: internationalized messages should not contain the '\r' escape sequence -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986 --- Comment #74 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 20.11.x -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This patch adds a script |This patch adds a new release notes|for sending holds reminder |script (holds_reminder.pl) |notices to patrons. The |for sending holds reminder |script is intended to be |notices to patrons. The |run as a cronjob and takes |script is intended to be |several parameters: |run as a cronjob and takes |days - |several parameters: |after how many days waiting |days - |to send the notice |after how many days waiting |lettercode - to specify |to send the notice |which notice is used |lettercode - to specify |library - (repeatable) to |which notice is used |specify which branches to |library - (repeatable) to |send notices from |specify which branches to |holidays |send notices from |- to specify that holidays |holidays |should not be counted as |- to specify that holidays |waiting days |should not be counted as |mtt - (message |waiting days |transport type) to specify |mtt - (message |which notice format to use, |transport type) to specify |i.e. print, email, etc. |which notice format to use, |date - to run the script as |i.e. print, email, etc. |it would have been on a |date - to run the script as |specific date |it would have been on a |n - no |specific date |emails - test mode, report |n - no |only, do not send notices |emails - test mode, report | |only, do not send notices -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Manual -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29801 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29801 [Bug 29801] Holds reminder cron not finding notice for all libraries -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31011 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31011 [Bug 31011] Make hold reminders respect patron's language -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |43111 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43111 [Bug 43111] Add --itemtype parameter to holds_reminder cron -- You are receiving this mail because: You are watching all bug changes.