[Bug 39720] New: Search for system preferences call errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39720 Bug ID: 39720 Summary: Search for system preferences call errors Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: fridolin.somers@biblibre.com QA Contact: testopia@bugs.koha-community.org Since Bug 38772 found a typo in system preference 'minPasswordPreference' call, we could try to grep any call to compare with system preferences file. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39720 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |fridolin.somers@biblibre.co |ity.org |m Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39720 --- Comment #1 from Fridolin Somers <fridolin.somers@biblibre.com> --- git grep can not exclude so I use grep directly : We need not exclude test suite and installer (updatedatabase.pl and dbrevs) grep -r --exclude-dir=.git --exclude-dir=t --exclude-dir=installer -o 'C4::Context->preference(.*)' | awk -F 'preference\(|\)' '{print $2}' | tr -d '"' | tr -d "'" | tr -d ' ' | sort -u | grep -v '^\$' | tee patches/sysprefs_calls.txt Then : for i in $(cat patches/sysprefs_calls.txt); do echo "### $i" ; grep -i -c "'$i'" installer/data/mysql/mandatory/sysprefs.sql ; done | grep -B1 ^0 | grep ^# ### ($interfaceeqopac ### automatic_item_modification_by_age_configuration ### delimiter ### IntranetmainUserblock ### marcflavour ### MarcFlavour ### MARCFLAVOUR ### OPACFineNoRenewalsIncludeCredit ### OPACResultsSidebar ### PatronSelfRegistrationAdditionalInstructions ### PREF_008 ### preference ### SelfCheckHelpMessage ### some_variable ### version ### Version Those are normal cases : automatic_item_modification_by_age_configuration MarcFlavour version some_variable/preference => commes from POD ;) PREF_008 => Is a constant for "MARCAuthorityControlField008" So : for i in $(cat patches/sysprefs_missing.txt); do echo "## $i"; git grep "C4::Context->preference(.$i" ; echo ; done ## delimiter misc/cronjobs/staticfines.pl: $delim = "\t"; # ? C4::Context->preference('delimiter') || "\t"; ## IntranetmainUserblock C4/Auth.pm: IntranetmainUserblock => C4::Context->preference("IntranetmainUserblock"), ## OPACFineNoRenewalsIncludeCredit C4/Circulation.pm: C4::Context->preference("OPACFineNoRenewalsIncludeCredit") opac/opac-user.pl: C4::Context->preference("OPACFineNoRenewalsIncludeCredit") ## OPACResultsSidebar opac/opac-search.pl:$template->param( OPACResultsSidebar => C4::Context->preference('OPACResultsSidebar') ); ## PatronSelfRegistrationAdditionalInstructions opac/opac-memberentry.pl: C4::Context->preference('PatronSelfRegistrationAdditionalInstructions') ); opac/opac-registration-verify.pl: C4::Context->preference('PatronSelfRegistrationAdditionalInstructions') ); ## SelfCheckHelpMessage opac/sco/help.pl:if ( C4::Context->preference('SelfCheckHelpMessage') ) { opac/sco/help.pl: $template->param( SelfCheckHelpMessage => C4::Context->preference('SelfCheckHelpMessage') ); -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39720 --- Comment #2 from Fridolin Somers <fridolin.somers@biblibre.com> --- I will create new bug reports for each : ### delimiter : In misc/cronjobs/staticfines.pl : Bug 27486 renamed "delimiter" into "CSVDelimiter" => Patch to fix ### IntranetmainUserblock : Bug 35153 moved to additional contents. => Patch to remove call ### OPACFineNoRenewalsIncludeCredit A typo : installer/data/mysql/mandatory/sysprefs.sql:('OPACFineNoRenewalsIncludeCredits','1',NULL,'If enabled the value specified in OPACFineNoRenewals should include any unapplied account credits in the calculation','YesNo'), => Patch to fix calls (ending 's') ### OPACResultsSidebar Bug 34869 moved additional contents. => Patch to remove call ### PatronSelfRegistrationAdditionalInstructions Bug 34889 moved to additional contents. => Patch to remove call ### SelfCheckHelpMessage Bug 35065 moved to additional contents. => Patch to remove call So some catches, maybe missed some of them ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39720 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=38772 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39720 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |39733 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39733 [Bug 39733] Wrong system preference delimiter call in misc/cronjobs/staticfines.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39720 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |39734 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39734 [Bug 39734] Obsolete call of system preference IntranetmainUserblock -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39720 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |39735 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39735 [Bug 39735] Typo in system preference call 'OPACFineNoRenewalsIncludeCredit' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39720 --- Comment #3 from Fridolin Somers <fridolin.somers@biblibre.com> --- We may grep in test suite and in templates -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39720 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |39736 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39736 [Bug 39736] Obsolete call on system preference 'OPACResultsSidebar' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39720 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |39737 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39737 [Bug 39737] Obsolete call on system preference 'PatronSelfRegistrationAdditionalInstructions' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39720 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |39738 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39738 [Bug 39738] Obsolete call on system preference 'SelfCheckHelpMessage' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39720 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39720 --- Comment #4 from Fridolin Somers <fridolin.somers@biblibre.com> --- Searching in t/ gives : ### IDoNotExist ### marcflavour ### MARCFlavour ### SillyPreference ### testpreference ### TestPreference ### Version marcflavour => OK Version => OK Other are normal cases of test suite playing with false preferences ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39720 --- Comment #5 from Fridolin Somers <fridolin.somers@biblibre.com> --- Searching t/ for C4::Context->set_preference( ### IDoNotExist ### language ### OPACFineNoRenewalsIncludeCredit ### SillyPreference ### testpreference ### TestPreference language => Bug 27490 changed to "StaffInterfaceLanguages" OPACFineNoRenewalsIncludeCredit => already fixed by Bug 39735 Other are normal cases of test suite -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39720 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |39745 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39745 [Bug 39745] Wrong system preference 'language' in test suite -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39720 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |39746 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39746 [Bug 39746] Wrong system preference 'AutoLocation' in test suite -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39720 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |39747 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39747 [Bug 39747] Wrong system preference 'DefaultHoldExpirationUnitOfTime' in test suite -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39720 --- Comment #6 from Fridolin Somers <fridolin.somers@biblibre.com> --- Searching t/ for mock_preference( ### AutoLocation ### DefaultHoldExpirationUnitOfTime ### language ### marcflavour ### MultiValuedSyspref ### Version AutoLocation => renamed by Bug 26176 Opened Bug 39746 DefaultHoldExpirationUnitOfTime => Correct pref is DefaultHoldExpiration[date]UnitOfTime Opened Bug 39747 language => Added to Bug 39745 MultiValuedSyspref => No problem, its test suite playing ;) Other are OK -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39720 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|ASSIGNED |RESOLVED --- Comment #7 from Fridolin Somers <fridolin.somers@biblibre.com> --- Dependancies are pushed, I mark as resolved. Until next time :D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39720 Bug 39720 depends on bug 39746, which changed state. Bug 39746 Summary: Wrong system preference 'AutoLocation' in test suite https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39746 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39720 Bug 39720 depends on bug 39747, which changed state. Bug 39747 Summary: Wrong system preference 'DefaultHoldExpirationUnitOfTime' in test suite https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39747 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39720 Bug 39720 depends on bug 39733, which changed state. Bug 39733 Summary: Update code comment with a TODO in misc/cronjobs/staticfines.pl https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39733 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39720 Bug 39720 depends on bug 39745, which changed state. Bug 39745 Summary: Wrong system preference 'language' in test suite https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39745 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org