https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41216 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |41217 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41217 [Bug 41217] Missing class on body tag for reserve/hold-group.tt -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41216 --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 189316 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189316&action=edit Bug 41216: Restore tt_valid.t HTML1 is gone. Almost... The previous rule said that we could not have TT tags within HTML tags because it caused problems with the translation. It was incorrect. Bug 38720 removed that rule, and stated that the only problematic use was a IF with ">". It was also incorrect. This one bug states that we cannot have TT tags to construct HTML tags IF one of the attribute contains a translatable string. The list of translatable attributes are listed in tmpl_process3.pl. This patch restores xt/tt_valid.t (and move it to xt/author) and adjust slightly the test to take into account this last statement. Test plan: 0. Apply only this first patch 1. Run xt/author/tt_valid.t => It fails on mana-subscription-search-result.inc 2. Update po for your prefered language => The string "This resource has been reported more than" is not in the po files 3. Apply the second patch, repeat 1 and 2 => It still fails: adding a space between the TT tag and the attribute is not enough here => The string is picked now! but... install the template and open the translated version => 4. Apply the third patch, repeat 1 and 2 => The tests pass! => The string is still picked, install => The template looks good! Now if you are familiar with Mana you can try to see the translated string on the UI -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41216 --- Comment #3 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 189318 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189318&action=edit Bug 41216: Correctly fix the translation using I18N -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41216 --- Comment #4 from Julian Maurice <julian.maurice@biblibre.com> --- You added a singular version of the text but I don't think it makes sense here, as the warning is displayed only if tr_warning is > 5 (lowWarned) Other than that, I followed the test plan and it works well. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41216 --- Comment #6 from Julian Maurice <julian.maurice@biblibre.com> --- (In reply to Jonathan Druart from comment #5)

Yes but I don't know what else we can do. We still want to support languages with multiple plurals.

I forgot about that. So it does make sense, even if the singular version is not used -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41216 --- Comment #8 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 189329 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189329&action=edit Bug 41216: Try to fix by adding a space between TT tag and attribute Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41216 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189316|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41216 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189318|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41216 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|Signed Off |Failed QA --- Comment #10 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Some are false positives (french words treated like english typos), but I think we need to address them. [FAIL] koha-tmpl/intranet-tmpl/prog/en/includes/mana/mana-subscription-search-result.inc FAIL valid_template parse error - /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/includes/mana/mana-subscription-search-result.inc line 43: unexpected end of directive [% SET tr_title = I18N.tnx('This resource has already been reported', 'This resource has been reported more than {count} times, take care!', tr_warning, { count = tr_warning } %] [WARN] t/db_dependent/misc/translator/xgettext.pl.t WARN spelling attribut ==> attribute attribut ==> attribute [FAIL] xt/author/tt_valid.t FAIL file_permissions File must have the exec flag FAIL forbidden_patterns forbidden pattern: Use https:// instead of http:// for URLs (line 16) WARN spelling attibutes ==> attributes -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41216 --- Comment #11 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 190046 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190046&action=edit Bug 41216: Correctly fix the translation using I18N Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Amended-by: Add missing closing parenthesis -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41216 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41216 --- Comment #13 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Tomás Cohen Arazi (tcohen) from comment #10)

Some are false positives (french words treated like english typos), but I think we need to address them.

Oops, sorry about that! -- You are receiving this mail because: You are watching all bug changes.

=> The string is picked now! but... install the template and open the

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41216 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net --- Comment #14 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Thanks to keep refining this. translated version => I see nothing suspicious. I'm on commit "Try to fix by adding a space between TT tag and attribute" (restarted all), switch language and I'm doing a search of reports in Mana. I have in po files: fr-FR-staff-prog.po 12632:msgid "This resource has been reported more than %s times, take care!" Anything else to do to have the expected UI issues (how should the issues look?) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41216 --- Comment #16 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Ok, it's not about opening the page in the UI and it blows up. I have the same template translated line as you. So back on track :) ----- testing notes:

4. Apply the third patch, repeat 1 and 2 => The tests pass!

It will still fail but it's because it picks the fr-FR versions. It's a false positive. After installing the language, the test passes on mana-subscription-search-result.inc But it still fails on koha-tmpl/opac-tmpl/bootstrap/fr-FR/modules/opac-detail.tt Just pointing to in case that's suspicious. -------------

Now if you are familiar with Mana you can try to see the translated string on the UI

Since it's using I18N, is there and additional step to see a translated string? - gulp po:update --lang fr-FR - find the string in fr-FR-messages.po and fill the translated part (ensure it's not fuzzy) - misc/translator/translate install fr-FR - restart_all But the translated template still has the original string >_< (while the rest is using the existing translations) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41216 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #18 from Victor Grousset/tuxayo <victor@tuxayo.net> ---

The translation is done on the fly/at runtime, you won't see the translated version in the template.

Thanks Jonathan. I managed to display the string and the translation works :) In the mean time, a file was introduced that make the test fail: # Failed test at xt/author/tt_valid.t line 93. # got: '1' # expected: '0' # t/lib/plugins/Koha/Plugin/TestValuebuilder/test_valuebuilder_popup.tt: 8 content of the file: ================= <!DOCTYPE html> <!-- prettier-ignore-start --> <html> <head> <title>[% plugin_name | html %] - Valuebuilder</title> <meta charset="UTF-8" /> </head> <body> <h1>[% plugin_name | html %]</h1> <p>This is a test valuebuilder popup for field: [% field_id | html %]</p> <form> <label for="test_value">Enter a value:</label> <input type="text" id="test_value" value="Test Value from Plugin" /> [...] ================= hmmm, where would the "we cannot have TT tags to construct HTML tags IF one of the attribute contains a translatable string." be? ---------- I think this part of the POD is obsolete: ``` [1] Test if TT files contain TT directive within HTML tag. For example: <li[% IF This kind of construction MUST be avoided because it breaks Koha translation process. ``` -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41216 --- Comment #20 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 192744 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192744&action=edit Bug 41216: Fix failing test Patch from commit 00348d4 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41216 --- Comment #22 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 192746 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192746&action=edit Bug 41216: Adjust POD Patch from commit 1ec69a6 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41216 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189329|0 |1 is obsolete| | --- Comment #24 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 192956 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192956&action=edit Bug 41216: Try to fix by adding a space between TT tag and attribute Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41216 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190047|0 |1 is obsolete| | --- Comment #26 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 192958 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192958&action=edit Bug 41216: Fix QA failures Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41216 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192745|0 |1 is obsolete| | --- Comment #28 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 192960 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192960&action=edit Bug 41216: Remove confusion in test output Clearly show the check's description in the test's failure Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41216 --- Comment #30 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 192962 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192962&action=edit Bug 41216: (QA follow-up): fix path of xt/author/tt_valid.t in comment Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41216 --- Comment #32 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Victor Grousset/tuxayo from comment #31)

It just remains mostly the changes between the old and new versions of tt_valid.t.

What do you mean? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41216 --- Comment #34 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Victor Grousset/tuxayo from comment #33)

Reviewing the diff between the old version of tt_valid removed in 685e8a and the current version.

We are now allowing more than before. So yes there are some changes, it's expected. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41216 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192955|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41216 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192957|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41216 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192959|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41216 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192961|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41216 --- Comment #35 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 197049 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197049&action=edit Bug 41216: Restore tt_valid.t HTML1 is gone. Almost... The previous rule said that we could not have TT tags within HTML tags because it caused problems with the translation. It was incorrect. Bug 38720 removed that rule, and stated that the only problematic use was a IF with ">". It was also incorrect. This one bug states that we cannot have TT tags to construct HTML tags IF one of the attribute contains a translatable string. The list of translatable attributes are listed in tmpl_process3.pl. This patch restores xt/tt_valid.t (and move it to xt/author) and adjust slightly the test to take into account this last statement. Test plan: 0. Apply only this first patch 1. Run xt/author/tt_valid.t => It fails on mana-subscription-search-result.inc 2. Update po for your prefered language => The string "This resource has been reported more than" is not in the po files 3. Apply the second patch, repeat 1 and 2 => It still fails: adding a space between the TT tag and the attribute is not enough here => The string is picked now! but... install the template and open the translated version => 4. Apply the third patch, repeat 1 and 2 => The tests pass! => The string is still picked, install => The template looks good! Now if you are familiar with Mana you can try to see the translated string on the UI Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41216 --- Comment #37 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 197051 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197051&action=edit Bug 41216: Correctly fix the translation using I18N Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Amended-by: Add missing closing parenthesis Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41216 --- Comment #39 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 197053 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197053&action=edit Bug 41216: Fix failing test Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41216 --- Comment #41 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 197055 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197055&action=edit Bug 41216: Adjust POD Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41216 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |26.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41216 --- Comment #44 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 197154 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197154&action=edit Bug 41216: (follow-up) Fix path to sample.tt in xgettext-tt2.t Bug 41216 moved sample.tt into tt/en/ but the test still referenced the old path, causing xgettext-tt2.t to fail. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41216 --- Comment #45 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Thanks all, pushed to 25.11.x -- You are receiving this mail because: You are watching all bug changes.