[Bug 17652] New: opac-account.pl does not include login branchcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17652 Bug ID: 17652 Summary: opac-account.pl does not include login branchcode Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: chris.kirby@ilsleypubliclibrary.org QA Contact: testopia@bugs.koha-community.org opac-account.pl does not include login branchcode, whereas the other pages (opac-user, opac-memberentry, opac-passwd, opac-readingrecord, opac-suggestions, opac-messaging, opac-shelves)available to users on login DO provide the login branchode. Having the login branchcode available on opac-account.pl would facilitate customization of the OPAC for individual branches. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17652 Chris Kirby <chris.kirby@ilsleypubliclibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |chris.kirby@ilsleypubliclib | |rary.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17652 Viktor Sarge <viktor.sarge@regionhalland.se> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |viktor.sarge@regionhalland. | |se --- Comment #1 from Viktor Sarge <viktor.sarge@regionhalland.se> --- Got a fix for this but it's on a kohadevbox that I'm not really friends with yet :) I'll see if I can get the patch up on monday. It seems to only be an issue of removing the hardcoded line to get the correct class. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17652 --- Comment #2 from Chris Kirby <chris.kirby@ilsleypubliclibrary.org> --- Created attachment 57782 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57782&action=edit Bug 17652: opac-account.pl does not include login branchcode opac-account.pl does not include the login branchcode, whereas the other pages available to users (opac-user, opac-memberentry, opac-passwd, opac-readingrecord, opac-suggestions, opac-messaging, opac-shelves, etc.) on login DO provide the login branchcode. Having the login branchcode available on opac-account.pl would facilitate customization of the OPAC for individual branches. To test: 1) Login to the OPAC and open /cgi-bin/koha/opac-account.pl 2) Inspect the body tag and observe the class attribute does not include the login branchcode. 3) Apply the patch. 4) Repeat step 2. 5) Observe that the login branchcode is present. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17652 Chris Kirby <chris.kirby@ilsleypubliclibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17652 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17652 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57782|0 |1 is obsolete| | --- Comment #3 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 57816 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57816&action=edit Attachment to Bug 17652 - opac-account.pl does not include login branchcode Bug 17652: opac-account.pl does not include login branchcode opac-account.pl does not include the login branchcode, whereas the other pages available to users (opac-user, opac-memberentry, opac-passwd, opac-readingrecord, opac-suggestions, opac-messaging, opac-shelves, etc.) on login DO provide the login branchcode. Having the login branchcode available on opac-account.pl would facilitate customization of the OPAC for individual branches. To test: 1) Login to the OPAC and open /cgi-bin/koha/opac-account.pl 2) Inspect the body tag and observe the class attribute does not include the login branchcode. 3) Apply the patch. 4) Repeat step 2. 5) Observe that the login branchcode is present. Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17652 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17652 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57816|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 57907 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57907&action=edit Bug 17652: opac-account.pl does not include login branchcode opac-account.pl does not include the login branchcode, whereas the other pages available to users (opac-user, opac-memberentry, opac-passwd, opac-readingrecord, opac-suggestions, opac-messaging, opac-shelves, etc.) on login DO provide the login branchcode. Having the login branchcode available on opac-account.pl would facilitate customization of the OPAC for individual branches. To test: 1) Login to the OPAC and open /cgi-bin/koha/opac-account.pl 2) Inspect the body tag and observe the class attribute does not include the login branchcode. 3) Apply the patch. 4) Repeat step 2. 5) Observe that the login branchcode is present. Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17652 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12162 CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Certainly caused by bug 12162. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12162 [Bug 12162] Add class="branchcode" to body tag to make OPAC CSS-styleable per branch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17652 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 17.05, thanks Chris! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17652 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |trivial CC| |katrin.fischer@bsz-bw.de --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This patch has been pushed to 16.11.x, will be in 16.11.01. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17652 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17652 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com --- Comment #8 from Julian Maurice <julian.maurice@biblibre.com> --- Pushed to 3.22.x for 3.22.14 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17652 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com --- Comment #9 from Mason James <mtj@kohaaloha.com> --- Pushed to 16.05.x, for 16.05.07 release -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org