[Bug 17761] New: Renewing or returning item via the checkouts table causes lost and damaged statuses to disappear
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17761 Bug ID: 17761 Summary: Renewing or returning item via the checkouts table causes lost and damaged statuses to disappear Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Due to the fact that the lost and damaged status are contained within the due_due span, when the item is renewed or returned these statuses disappear. Some librarians find this disconcerting and it seems that it would be better to keep the visible. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17761 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17761 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17761 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 58112 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58112&action=edit Bug 17761 - Renewing or returning item via the checkouts table causes lost and damaged statuses to disappear Due to the fact that the lost and damaged status are contained within the due_due span, when the item is renewed or returned these statuses disappear. Some librarians find this disconcerting and it seems that it would be better to keep the visible. Test Plan: 1) Find a lost item checked out to a patron 2) Renew that lost item via the checkouts table 3) Notice the lost status disappears from that row 4) Apply this patch 5) Refresh the page ( you may want to clear your browser cache as well ) 6) Renew the item again 7) The lost status should remain visible! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17761 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17761 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17761 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58112|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 58160 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58160&action=edit Bug 17761 - Renewing or returning item via the checkouts table causes lost and damaged statuses to disappear Due to the fact that the lost and damaged status are contained within the due_due span, when the item is renewed or returned these statuses disappear. Some librarians find this disconcerting and it seems that it would be better to keep the visible. Test Plan: 1) Find a lost item checked out to a patron 2) Renew that lost item via the checkouts table 3) Notice the lost status disappears from that row 4) Apply this patch 5) Refresh the page ( you may want to clear your browser cache as well ) 6) Renew the item again 7) The lost status should remain visible! Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Edie Discher <edischer@cityoffargo.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17761 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17761 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58160|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 58162 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58162&action=edit Bug 17761 - Renewing or returning item via the checkouts table causes lost and damaged statuses to disappear Due to the fact that the lost and damaged status are contained within the due_due span, when the item is renewed or returned these statuses disappear. Some librarians find this disconcerting and it seems that it would be better to keep the visible. Test Plan: 1) Find a lost item checked out to a patron 2) Renew that lost item via the checkouts table 3) Notice the lost status disappears from that row 4) Apply this patch 5) Refresh the page ( you may want to clear your browser cache as well ) 6) Renew the item again 7) The lost status should remain visible! Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Edie Discher <edischer@cityoffargo.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17761 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 17.05! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17761 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Severity|enhancement |minor --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I feel like we can change this from enhancement to a bug as the renewal should not make data disappear. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17761 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This won't get backported to 16.11.x as it is an enhancement. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17761 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com --- Comment #7 from Julian Maurice <julian.maurice@biblibre.com> --- (In reply to Katrin Fischer from comment #6)
This won't get backported to 16.11.x as it is an enhancement.
This is actually a bug and was backported to 16.11.x http://git.koha-community.org/gitweb/?p=koha.git;a=commit;h=75c3cda017e49989... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17761 --- Comment #8 from Julian Maurice <julian.maurice@biblibre.com> --- Pushed to 3.22.x for 3.22.14 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17761 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Julian, you are right - sorry for the mistake! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17761 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com --- Comment #10 from Mason James <mtj@kohaaloha.com> --- Pushed to 16.05.x, for 16.05.07 release -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org