https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38122 Michelle Spinney <mspinney@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mspinney@clamsnet.org -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38122 Kris <kbecker@jcls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kbecker@jcls.org -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38122 Kristi <kkrueger@cuyahogalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kkrueger@cuyahogalibrary.or | |g --- Comment #1 from Kristi <kkrueger@cuyahogalibrary.org> --- Our staff are anxious to have this restored! They use the sort on bibs that have more than 20 items, some that have over 100. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38122 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|DUPLICATE |--- -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38122 --- Comment #4 from Kristi <kkrueger@cuyahogalibrary.org> --- We have several use cases: 1.Branch staff sort by status to see if they can identify an available copy and the branch it’s located at. 2. Our acquisitions team uses it to see how many viable (not missing, lost, withdrawn) copies are left on something that has high holds. Popular titles can have over 100 items. 3. Technical services uses it when looking at items that need to be called in to see if they are checked out, marked missing, etc. 4. We have wi-fi hotspots that are very popular and have several hundred items on the bib for each model. A lot of them are marked damaged, others are long overdue (Lost), some are Missing. These different statuses can make it confusing to know what should be circulating, so our staff use the status sort to eye up what is damaged, missing, etc. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38122 --- Comment #6 from Kristi <kkrueger@cuyahogalibrary.org> --- For use cases 1 and 2 especially, the sort rather than the filter would be the preferred method. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38122 SamSowanick <sam.sowanick@corvallisoregon.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sam.sowanick@corvallisorego | |n.gov --- Comment #7 from SamSowanick <sam.sowanick@corvallisoregon.gov> --- Our staff would love this feature back too. They find it easier to quickly scan the items over filtering. But ideally there is room for both :). Upvoting. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38122 --- Comment #9 from SamSowanick <sam.sowanick@corvallisoregon.gov> --- The sort function is a way to group the items allowing scanning over all the items at one time, allowing seeing proportions of items status on one bib. Filtering accomplishes this but requires you to know what status you are looking for; while also hiding other items not in the searched status. I also just realized that you can SHIFT + CLICK to sort two fields at the same time, so it is fully possible that I am missing an alternate something. I will see if I can get more context from our staff. Thank you for highlighting the context to the limitations for this bug. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38122 --- Comment #11 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Donna from comment #10)

Sorry - I'm not fluent in all the tech stuff, so it might be something obvious. But if all the other columns on the holdings table are sortable, why is status the only one that is not?

Because it's calculated, not stored in DB like other attributes. If you want to sort by status you will need to calculate the status for all the items then display the 20 you want to display. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38122 --- Comment #13 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- I can work on this after we get Bug 37334 pushed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38122 Marie-Luce Laflamme <marie-luce.laflamme@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marie-luce.laflamme@inlibro | |.com --- Comment #15 from Marie-Luce Laflamme <marie-luce.laflamme@inlibro.com> --- Please bring back the "sort by statuses" option. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38122 mreid <mreid@batestech.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mreid@batestech.edu --- Comment #16 from mreid <mreid@batestech.edu> --- Please restore ability to sort the holdings table by status. This is particularly an issue for our bibs with large holdings (up to 150 items) across multiple branches. Staff appreciated being able to sort by status to quickly eyeball the list and determine which branch has available items; we also have use cases similar to those listed by Kristi on 11/8/24, particularly with our hotspots and laptops. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38122 Koha collecto <koha@collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha@collecto.ca -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38122 --- Comment #18 from Kristi <kkrueger@cuyahogalibrary.org> --- While filtering will be welcome, sorting is needed when staff are reviewing more than one status at a time. For example, to see how many copies on a bib are checked out or available to determine how many "live" copies there are as opposed to missing, damaged, etc. Our branch staff were accustomed to using the sort and continue to ask when this functionality will be restored. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38122 --- Comment #20 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 183789 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183789&action=edit Bug 38122: Add the ability to group holdings by status This is a quite ugly solution, but that may answer end-user needs. It add the option the group items by status on the bibliographic record detail page. However it will have VERY bad impact on performances for record with a lot of items, as we are going to determine the status of each items of the record. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38122 --- Comment #22 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Using k-t-d, I tested some performance using the "Group by status" button, I created items with various status's set: 80 items - 1348ms 200 items - 1463ms 500 items - 1995ms 1000 items - 2635ms -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38122 --- Comment #24 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Baptiste Wojtkowski (bwoj) from comment #23)

Hi, Is the provided patch supposed to be working or is is just an illustration of what we should do ? I had to tweak a lot to have it working, and I still cannot have it working well I think.

It is supposed to work. Which problems did you face?

I can provide my changes but there is one point I don't get, why do we order by Id at the end of the group search ? I cannot find the place where it is ordered by group after this.

...

order_by => [ \[ sprintf( "field(me.itemnumber, %s)", join( ', ', map { qq{'$_'} } @item_ids ) ) ] ]

We are ordering by itemnumbers, but using the array @item_ids that defines a specific order. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38122 --- Comment #26 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Oh wait, I might just have resolved a conflict improperly -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38122 --- Comment #27 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 184550 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184550&action=edit Bug 38122: Sort holdings table by status To test: 1. Apply the patch 2. Go to a record details page Example: http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=285 3. Add several items to the record (with different statuses) 3. Click the Status column header in the holdings table to sort ---> items are correctly sorted by status (ascending and descending on repeated clicks) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38122 --- Comment #28 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Hammat wele from comment #27)

Created attachment 184550 [details] [review] Bug 38122: Sort holdings table by status

To test:

1. Apply the patch 2. Go to a record details page Example: http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=285 3. Add several items to the record (with different statuses) 3. Click the Status column header in the holdings table to sort ---> items are correctly sorted by status (ascending and descending on repeated clicks)

Please explain because I don't understand what this patch is supposed to do. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38122 --- Comment #30 from Jonathan Druart <jonathan.druart@gmail.com> --- The initial patch is far from perfect and not ready for inclusion (at the minimum tests are missing). If you want to move this forward I would suggest to first help this first patch being pushed, then we can iterate on top of it. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38122 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38122 Miranda Nero <mnero@oslri.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mnero@oslri.net -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38122 --- Comment #33 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Mathieu Saby from comment #32)

We are currently upgrading to Koha 24.11 and have discovered this regression. It must be fixed.

(In reply to Jonathan Druart from comment #30)

If you want to move this forward I would suggest to first help this first patch being pushed, then we can iterate on top of it.

-- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38122 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184550|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38122 --- Comment #35 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 187410 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187410&action=edit Bug 38122: (follow-up) Make "Group by status" and "Ungroup by status" translatable -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38122 --- Comment #37 from Mathieu Saby <mathsabypro@gmail.com> --- Is that bug ready to be sign off, or still "in discussion"? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38122 --- Comment #39 from Mathieu Saby <mathsabypro@gmail.com> --- I'm testing it out. Two related ideas came to me while playing around with the copy table: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41023 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41022 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38122 --- Comment #41 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Mathieu Saby from comment #40)

I tested on a sandbox, and it seems to work. But honestly, I'm not sure that it really meets the needs of libraries—maybe, maybe not... Other people should test it.

What are your needs?

As this is not specified in your test plan, could you please clarify how sorting is supposed to be performed by your patch? Based on the value of "_status" returned by the API? Will "available" items appear first (it seems so from my test)?

available, checked_out, local_use, in_transit, lost, withdrawn, damaged, not_for_loan, on_hold, recalled, in_bundle, restricted

From a librarian's point of view, this "grouping" does not seem very different from a "sort", except that you can't reverse the order. But if I understand correctly, it would be really technically complicated to control this feature with an arrow in the column header like for the other columns?

It can eventually be implemented later, but it's not within the scope of this bug. Any other changes must be on separate bug reports. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38122 --- Comment #43 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Jess from comment #42)

I work in a school Librabry and sorting by status is very helpful for me as I can see all the students who still have copies out under their name at the top of the list. This is helpful because we have many copies of the same manuel. Seeing all the names of the kids who still have their copy all together makes it easier for me to see who i need to chase down.... hope that makes sense

Please test the patch and tell us if it works for you. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38122 Brenda <bowens@washoecounty.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bowens@washoecounty.us -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38122 --- Comment #45 from Ayoub Glizi-Vicioso <ayoub.glizi-vicioso@inLibro.com> --- Created attachment 191419 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191419&action=edit Bug 38122: Add the ability to group holdings by status Merge conflict resolved. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38122 Ayoub Glizi-Vicioso <ayoub.glizi-vicioso@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187410|0 |1 is obsolete| | --- Comment #47 from Ayoub Glizi-Vicioso <ayoub.glizi-vicioso@inLibro.com> --- Created attachment 191421 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191421&action=edit Bug 38122: (follow-up) Make "Group by status" and "Ungroup by status" translatable -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38122 Ayoub Glizi-Vicioso <ayoub.glizi-vicioso@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183789|0 |1 is obsolete| | Attachment #191419|0 |1 is obsolete| | --- Comment #49 from Ayoub Glizi-Vicioso <ayoub.glizi-vicioso@inLibro.com> --- Created attachment 191424 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191424&action=edit Bug 38122: Add the ability to group holdings by status This is a quite ugly solution, but that may answer end-user needs. It add the option the group items by status on the bibliographic record detail page. However it will have VERY bad impact on performances for record with a lot of items, as we are going to determine the status of each items of the record. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38122 Ayoub Glizi-Vicioso <ayoub.glizi-vicioso@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191421|0 |1 is obsolete| | --- Comment #51 from Ayoub Glizi-Vicioso <ayoub.glizi-vicioso@inLibro.com> --- Created attachment 191426 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191426&action=edit Bug 38122: (follow-up) Make "Group by status" and "Ungroup by status" translatable -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38122 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #52 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- With these patches applied I don't have any items showing in the holdings table on cgi-bin/koha/catalogue/detail.pl -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38122 Ayoub Glizi-Vicioso <ayoub.glizi-vicioso@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38122 --- Comment #55 from Ayoub Glizi-Vicioso <ayoub.glizi-vicioso@inLibro.com> --- Created attachment 191530 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191530&action=edit Bug 38122: Add the ability to group holdings by status This is a quite ugly solution, but that may answer end-user needs. It add the option the group items by status on the bibliographic record detail page. However it will have VERY bad impact on performances for record with a lot of items, as we are going to determine the status of each items of the record. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38122 Ayoub Glizi-Vicioso <ayoub.glizi-vicioso@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191426|0 |1 is obsolete| | --- Comment #57 from Ayoub Glizi-Vicioso <ayoub.glizi-vicioso@inLibro.com> --- Created attachment 191532 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191532&action=edit Bug 38122: (follow-up) Make "Group by status" and "Ungroup by status" translatable -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38122 Ayoub Glizi-Vicioso <ayoub.glizi-vicioso@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38122 --- Comment #59 from Ayoub Glizi-Vicioso <ayoub.glizi-vicioso@inLibro.com> --- (In reply to Jonathan Druart from comment #58)

Why is this Failed QA?

Hi! I did some testing and found a few points: 1- Grouping: I noticed that in a few cases some identical statuses aren't grouping together propraly. 2- Sorting: Currently, the groups aren't in alphabetical order. it becomes a bit difficult to navigate. 3- Translations: I spotted a few strings that are currently not translatable. We'll need to wrap those so our international community can use the feature too. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38122 Ayoub Glizi-Vicioso <ayoub.glizi-vicioso@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191529|0 |1 is obsolete| | --- Comment #61 from Ayoub Glizi-Vicioso <ayoub.glizi-vicioso@inLibro.com> --- Created attachment 192992 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192992&action=edit Bug 38122: Add the ability to group holdings by status This is a quite ugly solution, but that may answer end-user needs. It add the option the group items by status on the bibliographic record detail page. However it will have VERY bad impact on performances for record with a lot of items, as we are going to determine the status of each items of the record. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38122 Ayoub Glizi-Vicioso <ayoub.glizi-vicioso@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191532|0 |1 is obsolete| | --- Comment #63 from Ayoub Glizi-Vicioso <ayoub.glizi-vicioso@inLibro.com> --- Created attachment 192994 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192994&action=edit Bug 38122: (follow-up) Make "Group by status" and "Ungroup by status" translatable -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38122 --- Comment #65 from Ayoub Glizi-Vicioso <ayoub.glizi-vicioso@inLibro.com> --- (In reply to Ayoub Glizi-Vicioso from comment #60)

(In reply to Jonathan Druart from comment #58)

...

Why is this Failed QA?

Hi!

I did some testing and found a few points:

1- Grouping: I noticed that in a few cases some identical statuses aren't grouping together properly.

2- Sorting: Currently, the groups aren't in alphabetical order. When there is a lot of data, it becomes a bit difficult to navigate for the user

3- Translations: I spotted a few strings that are currently not translatable. We'll need to wrap those so our international community can use the feature too.

After reconsidering my previous comment about sorting the statuses alphabetically, I think it would actually make more sense to order them by availability priority instead of alphabetical order. Since this concerns item statuses in Koha, a logical progression based on availability would likely be more useful for staff.(In reply to Ayoub Glizi-Vicioso from comment #60)

(In reply to Jonathan Druart from comment #58)

...

Why is this Failed QA?

Hi!

I did some testing and found a few points:

1- Grouping: I noticed that in a few cases some identical statuses aren't grouping together properly.

2- Sorting: Currently, the groups aren't in alphabetical order. When there is a lot of data, it becomes a bit difficult to navigate for the user

3- Translations: I spotted a few strings that are currently not translatable. We'll need to wrap those so our international community can use the feature too.

After reconsidering my previous comment about sorting the statuses alphabetically, I think it would actually make more sense to order them by availability priority instead of alphabetical order. Since this concerns item statuses in Koha, a logical progression based on availability would likely be more useful for staff. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38122 Ayoub Glizi-Vicioso <ayoub.glizi-vicioso@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192995|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38122 Ayoub Glizi-Vicioso <ayoub.glizi-vicioso@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192995|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38122 Ayoub Glizi-Vicioso <ayoub.glizi-vicioso@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192992|0 |1 is obsolete| | --- Comment #67 from Ayoub Glizi-Vicioso <ayoub.glizi-vicioso@inLibro.com> --- Created attachment 193149 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193149&action=edit Bug 38122: Add the ability to group holdings by status This is a quite ugly solution, but that may answer end-user needs. It add the option the group items by status on the bibliographic record detail page. However it will have VERY bad impact on performances for record with a lot of items, as we are going to determine the status of each items of the record. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38122 Ayoub Glizi-Vicioso <ayoub.glizi-vicioso@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192994|0 |1 is obsolete| | --- Comment #69 from Ayoub Glizi-Vicioso <ayoub.glizi-vicioso@inLibro.com> --- Created attachment 193151 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193151&action=edit Bug 38122: (follow-up) Make "Group by status" and "Ungroup by status" translatable -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38122 --- Comment #71 from Ayoub Glizi-Vicioso <ayoub.glizi-vicioso@inLibro.com> --- Created attachment 193153 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193153&action=edit Bug 38122: Fix server error when handling malformed request parameters -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38122 Bug 38122 depends on bug 37334, which changed state. Bug 37334 Summary: Cannot filter holdings table by status https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38122 Ayoub Glizi-Vicioso <ayoub.glizi-vicioso@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193150|0 |1 is obsolete| | --- Comment #74 from Ayoub Glizi-Vicioso <ayoub.glizi-vicioso@inLibro.com> --- Created attachment 195228 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195228&action=edit Bug 38122: (follow-up) Fix grouping of holdings by status when sorting When 'Group by status' is enabled, sorting on other columns is ignored to ensure that items remain correctly grouped by status. To test: 1. Apply the patch 2. Run yarn build 3. Create a record with multiple itemss having different statuses. 4. Click on «Group by status» button ---> items are grouped by status 5. Sort on other colunms ---> items are still grouped by status 6. Click on «Ungroup by status» button ---> items are no more grouped by status -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38122 Ayoub Glizi-Vicioso <ayoub.glizi-vicioso@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193152|0 |1 is obsolete| | --- Comment #76 from Ayoub Glizi-Vicioso <ayoub.glizi-vicioso@inLibro.com> --- Created attachment 195230 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195230&action=edit Bug 38122: (follow-up) Correct item regrouping behavior -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38122 --- Comment #78 from Ayoub Glizi-Vicioso <ayoub.glizi-vicioso@inLibro.com> --- Created attachment 195232 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195232&action=edit Bug 38122: Improve items sorting logic in bibliographic details -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38122 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Status|Needs Signoff |Patch doesn't apply --- Comment #80 from David Nind <david@davidnind.com> --- The patch no longer applies 8-(... /kohadevbox/perl-git-bz/bin/git-bz apply 38122 📋 Bug 38122 - Cannot sort holdings table by status • 195227 - Bug 38122: Add the ability to group holdings by status • 195228 - Bug 38122: (follow-up) Fix grouping of holdings by status when sorting • 195229 - Bug 38122: (follow-up) Make "Group by status" and "Ungroup by status" translatable • 195230 - Bug 38122: (follow-up) Correct item regrouping behavior • 195231 - Bug 38122: Fix server error when handling malformed request parameters • 195232 - Bug 38122: Improve items sorting logic in bibliographic details Apply? [(y)es, (n)o, (i)nteractive] y Preparing 6 patch(es): ✓ Prepared 6 patch(es) Applying 6 patch(es): Patch application failed for attachment 195227 - Bug 38122: Add the ability to group holdings by status -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38122 Ayoub Glizi-Vicioso <ayoub.glizi-vicioso@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #195227|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38122 Ayoub Glizi-Vicioso <ayoub.glizi-vicioso@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #195229|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38122 Ayoub Glizi-Vicioso <ayoub.glizi-vicioso@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #195231|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38122 --- Comment #81 from Ayoub Glizi-Vicioso <ayoub.glizi-vicioso@inLibro.com> --- Created attachment 195868 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195868&action=edit Bug 38122: Add the ability to group holdings by status This is a quite ugly solution, but that may answer end-user needs. It add the option the group items by status on the bibliographic record detail page. However it will have VERY bad impact on performances for record with a lot of items, as we are going to determine the status of each items of the record. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38122 --- Comment #83 from Ayoub Glizi-Vicioso <ayoub.glizi-vicioso@inLibro.com> --- Created attachment 195870 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195870&action=edit Bug 38122: (follow-up) Make "Group by status" and "Ungroup by status" translatable Patch from commit eda77f1 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38122 --- Comment #85 from Ayoub Glizi-Vicioso <ayoub.glizi-vicioso@inLibro.com> --- Created attachment 195872 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195872&action=edit Bug 38122: Fix server error when handling malformed request parameters Patch from commit 2b4f439 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38122 --- Comment #87 from Ayoub Glizi-Vicioso <ayoub.glizi-vicioso@inLibro.com> --- Created attachment 195874 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195874&action=edit Bug 38122: Improve column filtering and grouping logic Patch from commit f700460 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38122 --- Comment #89 from Ayoub Glizi-Vicioso <ayoub.glizi-vicioso@inLibro.com> --- (In reply to Ayoub Glizi-Vicioso from comment #79)

Note: If you encounter a 400 error during status grouping, you might need to run 'yarn api:bundle' to update the API documentation or/and restart plack (if installed).

This still stands. The note remains valid: running 'yarn api:bundle' and/or restarting Plack may be required to avoid the 400 error when grouping by status. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38122 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38122 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #195869|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38122 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #195871|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38122 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #195873|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38122 --- Comment #91 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 196593 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196593&action=edit Bug 38122: Add the ability to group holdings by status This is a quite ugly solution, but that may answer end-user needs. It add the option the group items by status on the bibliographic record detail page. However it will have VERY bad impact on performances for record with a lot of items, as we are going to determine the status of each items of the record. Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38122 --- Comment #93 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 196595 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196595&action=edit Bug 38122: (follow-up) Make "Group by status" and "Ungroup by status" translatable Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38122 --- Comment #95 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 196597 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196597&action=edit Bug 38122: Fix server error when handling malformed request parameters Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38122 --- Comment #97 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 196599 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196599&action=edit Bug 38122: Improve column filtering and grouping logic Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38122 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #98 from Jonathan Druart <jonathan.druart@gmail.com> --- 1. I like the UI, but the code seems too complicated IMO. a. Duplicating the status logic at the DB level (order by) is a bad idea. b. The coded value (01 for On hold, 00 for Available) it not a good pattern c. Before following up on the other remarks, please explain why the first patch is not working correctly. I feel like we should do baby steps here instead of massive changes not covered by tests. 2. prove xt/tt_kohaTable_tidy.t xt/tt_kohaTable_tidy.t .. 1/879 # Failed test 'koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers/tables/items/catalogue_detail.inc has 'kohaTable' instances in a <script> tag with Template::Toolkit tags. You have reverted most of the changes done on bug 41566. 3. Missing tests 4. I don't think we need to group_by_status in the global swagger.yaml. What's the reason? api/v1/swagger/swagger.yaml + group_by_status: 5. - ajax: { url: item_table_url }, + ajax: { url: "/api/v1/biblios/[% biblio.biblionumber | uri %]/items?" + group_by_status() }, => Then the item_table_url is not longer used and can be removed at 303 let item_table_url = `/api/v1/biblios/${biblionumber}/items?`; 6. Performances - did you benchmark this approach on a biblio with lot of items? 7. Why is filter_out_restricted ordering items? I don't think it should. 8. You removed a FIXME, did you fix it? - # FIXME We need to order_by serial.publisheddate if we have _order_by=+me.serial_issue_number 9. Did you see bug 41254 and bug 41602? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38122 --- Comment #99 from Ayoub Glizi-Vicioso <ayoub.glizi-vicioso@inLibro.com> --- Thanks for the feedback. About the initial patch: the issue I ran into was that the grouping wasn’t always working correctly. For example, some statuses were properly grouped, but then the same status could appear again later on its own. I also noticed filtering issues — for instance, when filtering on “recalled” (if I remember correctly), all statuses were shown, and when filtering on “available”, nothing was returned. Regarding group_by_status in swagger.yaml, you’re right — I can move it back to where it was. I was just trying to align it with the other parameters. For bug 41566, the revert was likely caused while resolving a merge conflict. I hadn’t seen bugs 41254 and 41602, sorry about that. I’ll check them. I just noticed that I was trying to fix everything in this patch, sorry again about that. I can revert the changes I made here and focus this patch only on the grouping issue, then handle the filtering bug in an existing Bugzilla or a new one, and open another Bugzilla for the UI changes if that makes more sense. I’ll go over all the points you mentioned, but it might take some time before I can come back with an updated version. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38122 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196593|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38122 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196595|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38122 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196597|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38122 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196599|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38122 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|ayoub.glizi-vicioso@inLibro |jonathan.druart@gmail.com |.com | QA Contact|jonathan.druart@gmail.com |testopia@bugs.koha-communit | |y.org --- Comment #101 from Jonathan Druart <jonathan.druart@gmail.com> --- I have rebased my original patch, and it still seems to work as expected. Please test and let me know if it is not working correctly. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38122 --- Comment #102 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 197185 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197185&action=edit Bug 38122: Add the ability to group holdings by status This is a quite ugly solution, but that may answer end-user needs. It add the option the group items by status on the bibliographic record detail page. However it will have VERY bad impact on performances for record with a lot of items, as we are going to determine the status of each items of the record. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38122 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=42349 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38122 Ayoub Glizi-Vicioso <ayoub.glizi-vicioso@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #197185|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38122 --- Comment #105 from Ayoub Glizi-Vicioso <ayoub.glizi-vicioso@inLibro.com> --- Created attachment 197534 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197534&action=edit Bug 38122: Tidy and Minor cleanup in catalogue_detail.inc (replace Template Toolkit leftovers) 1- perl `misc/devel/tidy.pl` executed. 2- Fixes xt/tt_kohaTable_tidy.t failure triggered by catalogue_detail.inc. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38122 --- Comment #107 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Ayoub Glizi-Vicioso from comment #106)

If this addition is considered relevant, it can be included; otherwise, it is not necessary.

As stated previously already, I think we should go with this simple implementation first, then iterate on top of it. 26.05 is coming soon. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38122 --- Comment #109 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to David Nind from comment #108)

Could we get a consolidated test plan for this?

There are so many comments etc, that I'm being lazy - not sure what to test or how.

Thanks!

On the holdings table it's not possible to sort by status. The patches proposes to have a new "group by status" button at the top of the table, to group items by their status. The idea is to have a bibliographic record with some items having different status. If you use the new "group by status" button the items will then be grouped together in the table. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38122 --- Comment #111 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 197777 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197777&action=edit Bug 38122: Keep filters visibility Patch from commit 76d06f8 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38122 --- Comment #113 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to David Nind from comment #110)

Had a go at testing, some questions and observations:

Thanks, David!

1. How is the grouping by status expected to work - alphabetical? (Can't really work out how it is ordered.)

This is the order: available checked_out local_use in_transit lost withdrawn damaged not_for_loan on_hold recalled in_bundle restricted Can be adjusted if we need something better.

2. When you click on "Group by status": - Filters are shown, but the link above the table is still "Show filters" - "Group by status" changes to "Ungroup by status" - Additional space is needed between the icon and "Ungroup by status"

3. If I click "Ungroup by status": - Filters are still shown for columns - Additional space is needed between the icon and "Group by status"

Fixed in "Keep filters visibility" and "Add space before the Group/Ungroup links" -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38122 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #197533|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38122 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #197777|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38122 --- Comment #114 from David Nind <david@davidnind.com> --- Created attachment 197813 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197813&action=edit Bug 38122: Add the ability to group holdings by status This is a quite ugly solution, but that may answer end-user needs. It add the option the group items by status on the bibliographic record detail page. However it will have VERY bad impact on performances for record with a lot of items, as we are going to determine the status of each items of the record. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38122 --- Comment #116 from David Nind <david@davidnind.com> --- Created attachment 197815 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197815&action=edit Bug 38122: Keep filters visibility Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38122 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This restores the "Group by release notes| |status" option to the | |holdings table for a record | |in the staff interface | |(after the Show filters, | |Select all, and Clear all | |options). | | | |Clicking "Group by status" | |sorts the items by the | |status column.^ | | | |Clicking "Ungroup by | |status" resets the holdings | |table. | | | |In combination with the | |filters option this | |provides several ways for | |staff to quickly scan and | |organize the items by | |status. | | | |+ Order for grouping items | |is: | | | |* Available (available) | |* Checked out (checked_out) | |* Local use (local_use) | |* In transit (in_transit) | |* Lost (lost) | |* Withdrawn (withdrawn) | |* Damaged (damaged) | |* Not for loan | |(not_for_loan) | |* On hold (on_hold) | |* Recalled (recalled) | |* In bundle (in_bundle) | |* Restricted (restricted) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38122 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #197813|0 |1 is obsolete| | Attachment #197814|0 |1 is obsolete| | Attachment #197815|0 |1 is obsolete| | Attachment #197816|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38122 --- Comment #119 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 199779 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199779&action=edit Bug 38122: Tidy and Minor cleanup in catalogue_detail.inc (replace Template Toolkit leftovers) 1- perl `misc/devel/tidy.pl` executed. 2- Fixes xt/tt_kohaTable_tidy.t failure triggered by catalogue_detail.inc. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38122 --- Comment #121 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 199781 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199781&action=edit Bug 38122: Add space before the Group/Ungroup links Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38122 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA CC| |pedro.amorim@openfifth.co.u | |k --- Comment #122 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- I stand with Joubu, and would prefer to not push this, not as is anyway, but understand the real world need for it (especially as it was something that existed before). Regardless, I'm failing QA for now because I feel like we at least need tests written for Biblios::get_items. The 'ideal' dev plan here I believe would be something like: 1) Identify all use cases where an item's computed status needs to be updated (AddIssue, AddReturn, Transfer::transit, Transfer::receive, and more) 2)Store it in the database 3) Get sorting for free and a multitude of other performance improvements -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38122 --- Comment #123 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 200046 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200046&action=edit Bug 38122: Add tests Patch from commit b0aea14 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38122 --- Comment #124 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Thanks everyone! Pushed to main for 26.11! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38122 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |42979 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42979 [Bug 42979] api/v1/biblios.t on MySQL 8 -- You are receiving this mail because: You are watching all bug changes.