[Bug 13656] New: "Change" button for linking a member to an organisation not translatable
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13656 Bug ID: 13656 Summary: "Change" button for linking a member to an organisation not translatable Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org CC: frederic@tamil.fr "Change" button for linking a member to an organisation on patron edit form is not translatable. To test: - install and activate an additional langauge - create a organisation type patron - create a member of organisation type patron - link second patron to your created organisation patron - verfiy the "change" button is not translatable -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13656 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel@gmail.com --- Comment #1 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Sorry but... how you do this
- create a member of organisation type patron - link second patron to your created organisation patron
-- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13656 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13656 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch --- Comment #2 from Marc Véron <veron@veron.ch> --- http://manual.koha-community.org/3.18/en/patscirc.html Organizational Organizational patrons are organizations. Organizations can be used as guarantors for Professional patrons. Professional Professional patrons can be linked to Organizational patrons I tested with a School (Category School (SC)) and a Teacher (Category Teacher (T)) As far as I understand it's the same functionality as for Garantors? - But there the button seems to translate to "Ändern" in German. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13656 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think the untranslated text only appeared after I had linked the guarantor/parent, but appeared translated in the beginning. I suspected a Javascript problem. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13656 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I have retested this. With the sample data: - Search for an existing 'Kid' patron - buttons display as 'Ändern' and 'Löschen' - click 'Ändern' - Search for an adult patron to link to and confirm - Suddenly instead of 'Ändern', there is 'Change' -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13656 --- Comment #5 from Josef Moravec <josef.moravec@gmail.com> --- Strange, I see the similar behavior but with "set to patron" string... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13656 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13656 --- Comment #6 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 39208 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39208&action=edit Bug 13656: "Change"/"Set to patron" button for linking a member to an organisation (or child to guarantor) not translatable Test plan: 1. install and activate an additional language 2. create patron in organization category 3. create professional patron 4. try to add this patron to an organization (Guarantor information section) 5. note that the left button text changed to "Change" - untranslated english string 6. push the "Delete" button, the guarantor patron field is cleared and the left button text changed to "Set to patron" - again original english text 7. apply the patch 8. repeat 4-6, note, that button text are still translated in all sitations 9. sign off ;) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13656 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|"Change" button for linking |"Change"/"Set to patron" |a member to an organisation |button for linking a member |not translatable |to an organisation (or | |child to guarantor) not | |translatable -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13656 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39208|0 |1 is obsolete| | --- Comment #7 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 39209 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39209&action=edit Bug 13656: "Change"/"Set to patron" button for linking a member to an organisation (or child to guarantor) not translatable Test plan: 1. install and activate an additional language 2. create patron in organization category 3. create professional patron 4. try to add this patron to an organization (Guarantor information section) 5. note that the left button text changed to "Change" - untranslated english string 6. push the "Delete" button, the guarantor patron field is cleared and the left button text changed to "Set to patron" - again original english text 7. apply the patch 7.1. update translation (koha-translate -u language_code) 8. repeat 4-6, note, that button text are still translated in all sitations 9. sign off ;) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13656 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13656 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39209|0 |1 is obsolete| | --- Comment #8 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 39215 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39215&action=edit Bug 13656: "Change"/"Set to patron" button for linking a member to an organisation (or child to guarantor) not translatable Test plan: 1. install and activate an additional language 2. create patron in organization category 3. create professional patron 4. try to add this patron to an organization (Guarantor information section) 5. note that the left button text changed to "Change" - untranslated english string 6. push the "Delete" button, the guarantor patron field is cleared and the left button text changed to "Set to patron" - again original english text 7. apply the patch 7.1. update translation (koha-translate -u language_code) 8. repeat 4-6, note, that button text are still translated in all sitations 9. sign off ;) Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Work as described, no errors Fixed message capitalization -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13656 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39215|0 |1 is obsolete| | --- Comment #9 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 39216 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39216&action=edit [SIGNED-OFF] Bug 13656: "Change"/"Set to patron" button for linking a member to an organisation (or child to guarantor) not translatable Test plan: 1. install and activate an additional language 2. create patron in organization category 3. create professional patron 4. try to add this patron to an organization (Guarantor information section) 5. note that the left button text changed to "Change" - untranslated english string 6. push the "Delete" button, the guarantor patron field is cleared and the left button text changed to "Set to patron" - again original english text 7. apply the patch 7.1. update translation (koha-translate -u language_code) 8. repeat 4-6, note, that button text are still translated in all sitations 9. sign off ;) Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Work as described, no errors Fixed message capitalization -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13656 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13656 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39216|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 39534 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39534&action=edit Bug 13656: "Change"/"Set to patron" button for linking a member to an organisation (or child to guarantor) not translatable Test plan: 1. install and activate an additional language 2. create patron in organization category 3. create professional patron 4. try to add this patron to an organization (Guarantor information section) 5. note that the left button text changed to "Change" - untranslated english string 6. push the "Delete" button, the guarantor patron field is cleared and the left button text changed to "Set to patron" - again original english text 7. apply the patch 7.1. update translation (koha-translate -u language_code) 8. repeat 4-6, note, that button text are still translated in all sitations 9. sign off ;) Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Work as described, no errors Fixed message capitalization Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13656 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Assignee|koha-bugs@lists.koha-commun |josef.moravec@gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13656 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #11 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Josef! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13656 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #12 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.20.x will be in 3.20.1 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13656 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea@gmail.com --- Comment #13 from Liz Rea <wizzyrea@gmail.com> --- Hi, This patch doesn't apply for 3.18. If you feel that it should be included, please resolve any issues and resubmit a patch for inclusion in 3.18.x. Liz -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13656 --- Comment #14 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 40160 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40160&action=edit Bug 13656: "Set to patron" button for linking a member to an organisation (or child to guarantor) not translatable - 3.18.x -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13656 --- Comment #15 from Josef Moravec <josef.moravec@gmail.com> --- The 3.18.x code does not content the javascript for updating button string to 'Change', so I made the 3.18.x version of this patch just for 'Set to patron' string. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13656 --- Comment #16 from Josef Moravec <josef.moravec@gmail.com> --- The non translatable 'Change' string was added by bug 13021 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org