http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14392 Bug ID: 14392 Summary: Inventory.pl contains call to internal sub C4::Reports::Guided::_get_column_defs Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: gmcharlt@gmail.com Reporter: dcook@prosentient.com.au QA Contact: testopia@bugs.koha-community.org I was just poking through inventory.pl and noticed the use of C4::Reports::Guided::_get_column_defs. I believe that one prefixes subs with "_" when they're meant to be only used internally, so this isn't a good look. If this sub is more universal than its current use in C4::Reports::Guided, it should be broken out into a different helper object. -- You are receiving this mail because: You are watching all bug changes.