[Bug 18050] New: Missing constraint foreign key on table aqbudget
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18050 Bug ID: 18050 Summary: Missing constraint foreign key on table aqbudget Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Database Assignee: gmcharlt@gmail.com Reporter: baptiste.wojtkowski@biblibre.com QA Contact: testopia@bugs.koha-community.org There is not foreign key constraint on the column budget_parent_id in the table aqbudget. It is so possible to delete a budget without deleting the associated fund. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18050 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |5334 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5334 [Bug 5334] Omnibus: Add explicit foreign key constraints -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18050 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Baptiste from comment #0)
There is not foreign key constraint on the column budget_parent_id in the table aqbudget. It is so possible to delete a budget without deleting the associated fund.
2835 DROP TABLE IF EXISTS `aqbudgets`; 2836 CREATE TABLE `aqbudgets` ( -- information related to Funds 2837 `budget_id` int(11) NOT NULL auto_increment, -- primary key and unique number assigned to each fund by Koha 2838 `budget_parent_id` int(11) default NULL, -- if this fund is a child of another this will include the parent id (aqbudgets.budget_id) ... 2850 `budget_owner_id` int(11) default NULL, -- borrowernumber of the person who owns this fund (borrowers.borrowernumber) 2851 `budget_permission` int(1) default '0', -- level of permission for this fund (used only by the owner, only by the library, or anyone) 2852 PRIMARY KEY (`budget_id`), 2853 KEY `budget_parent_id` (`budget_parent_id`), 2854 KEY `budget_code` (`budget_code`), 2855 KEY `budget_branchcode` (`budget_branchcode`), 2856 KEY `budget_period_id` (`budget_period_id`), 2857 KEY `budget_owner_id` (`budget_owner_id`) 2858 ) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_unicode_ci; budget_parent_id could have a constraint on aqbudgetperiods.budget_period_id budget_owner_id should probably be an FK on borrowers.borrowernumber Both should be still allowed to be empty (NULL), as they don't need to always be set. Then we got: budget_id = fund ID budget_parent_id = used for child/sub funds to link them to the parent. I am not sure if you can have a FK constraint on another column in the same table? I can add the changes to the kohastructure and via updatedatabase, but not sure what 'false' date we might expect to clean up here. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18050 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Missing constraint foreign |Missing constraint on |key on table aqbudget |aqbudgets.budget_period_id | |in aqbudgets -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18050 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18050 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15329 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15329 [Bug 15329] Show budget in addition to fund for late orders in acquisition -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18050 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18050 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18050 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 110076 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110076&action=edit Bug 18050: Add FK constraint on aqbudgets.budget_period_id This adds a FK constraint on aqbudgets.budget_period_id so that a fund cannot be added with an invalid aqbudget.budget_period_id. We should not have funds that belong to no budget. In case we have, the update will be skipped and a note displayed. Part1: - Before applying the patch - Make sure you have a budget with some funds linked to it - You will have to change one of the funds to link to an invalid budget with SQL: UPDATE aqbudgets SET budget_period_id = 999 WHERE budget_id = max(budget_id); - Apply patch - Run updatedatabase - verify that you see the hint about 1 existing fund with invalid budget. - Repair your fund with SQL UPDATE aqbudgets SET budget_period_id = ... WHERE budget_id = max(budget_id); (... needs to be your existing budget_period_id) - Run updatedatabase again - verify it runs successfully now. - If you try to change the budget_period_id to a non-existing now with SQL, you will get a database error. The new FK doesn't permit it. Part 2: - Start fresh with the web installer, verify there are no errors on creating the database tables -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18050 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110076|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 110078 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110078&action=edit Bug 18050: Add FK constraint on aqbudgets.budget_period_id This adds a FK constraint on aqbudgets.budget_period_id so that a fund cannot be added with an invalid aqbudget.budget_period_id. We should not have funds that belong to no budget. In case we have, the update will be skipped and a note displayed. Part1: - Before applying the patch - Make sure you have a budget with some funds linked to it - You will have to change one of the funds to link to an invalid budget with SQL: UPDATE aqbudgets SET budget_period_id = 999 WHERE budget_id = max(budget_id); - Apply patch - Run updatedatabase - verify that you see the hint about 1 existing fund with invalid budget. - Repair your fund with SQL UPDATE aqbudgets SET budget_period_id = ... WHERE budget_id = max(budget_id); (... needs to be your existing budget_period_id) - Run updatedatabase again - verify it runs successfully now. - If you try to change the budget_period_id to a non-existing now with SQL, you will get a database error. The new FK doesn't permit it. Part 2: - Start fresh with the web installer, verify there are no errors on creating the database tables -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18050 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 110079 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110079&action=edit Bug 18050: [Do not push] Schema update -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18050 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 110080 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110080&action=edit Bug 18050: Add relation alias to schema -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18050 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110078|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 110169 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110169&action=edit Bug 18050: Add FK constraint on aqbudgets.budget_period_id This adds a FK constraint on aqbudgets.budget_period_id so that a fund cannot be added with an invalid aqbudget.budget_period_id. We should not have funds that belong to no budget. In case we have, the update will be skipped and a note displayed. Part1: - Before applying the patch - Make sure you have a budget with some funds linked to it - You will have to change one of the funds to link to an invalid budget with SQL: UPDATE aqbudgets SET budget_period_id = 999 WHERE budget_id = max(budget_id); - Apply patch - Run updatedatabase - verify that you see the hint about 1 existing fund with invalid budget. - Repair your fund with SQL UPDATE aqbudgets SET budget_period_id = ... WHERE budget_id = max(budget_id); (... needs to be your existing budget_period_id) - Run updatedatabase again - verify it runs successfully now. - If you try to change the budget_period_id to a non-existing now with SQL, you will get a database error. The new FK doesn't permit it. Part 2: - Start fresh with the web installer, verify there are no errors on creating the database tables Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18050 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110079|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 110170 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110170&action=edit Bug 18050: [Do not push] Schema update Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18050 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110080|0 |1 is obsolete| | --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 110171 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110171&action=edit Bug 18050: Add relation alias to schema Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18050 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- You've done a really nice comprehensive job here Katrin, thanks. Signing off, it all looks good and works as expected from my perspective. Minor point however.. this bug used to cover lots of other FK issues around this table too.. I agree with narrowing the scope, but it would be good to open bugs for the other parts, especially as you've taken the time to understand them a bit as shown by your first comment (not expecting you to take on adding them however.. just would be good to have them recorded somewhere before they get lost when this bug is pushed ;) ) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18050 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26493 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26493 [Bug 26493] Add missing FK constraints to aqbudgets -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18050 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com --- Comment #10 from Julian Maurice <julian.maurice@biblibre.com> --- I think there is something wrong here: if database contains orphan budget, the updatedatabase will warn about it and go on. One can see the warning and fix it, but there will be no easy way to re-run the update, or one can miss the warning and continue using koha with a wrong schema. That's not the first time I see this pattern, and I think there is a problem with that. What's the point of updatedatabase if it doesn't ensure that the schema is correct at the end ? I think the updatedatabase should just die here, let the admin fix the problem and re-run the updatedatabase process. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18050 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Julian Maurice from comment #10)
I think there is something wrong here: if database contains orphan budget, the updatedatabase will warn about it and go on. One can see the warning and fix it, but there will be no easy way to re-run the update, or one can miss the warning and continue using koha with a wrong schema.
That's not the first time I see this pattern, and I think there is a problem with that. What's the point of updatedatabase if it doesn't ensure that the schema is correct at the end ? I think the updatedatabase should just die here, let the admin fix the problem and re-run the updatedatabase process.
We cannot do anything else in this case. When there are orphan funds (not budget here), then there might be orders linked to this fund - we cannot just delete them. We need to leave it up to the library to fix this. Our updatedatabase mechanism doesn't allow to stop and rerun (as far as I know?) and I think using the existing pattern with a warn is the best we can do here right now and it should not be put on this bug report to fix the underlying issue :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18050 --- Comment #12 from Julian Maurice <julian.maurice@biblibre.com> --- (In reply to Katrin Fischer from comment #11)
(In reply to Julian Maurice from comment #10)
I think there is something wrong here: if database contains orphan budget, the updatedatabase will warn about it and go on. One can see the warning and fix it, but there will be no easy way to re-run the update, or one can miss the warning and continue using koha with a wrong schema.
That's not the first time I see this pattern, and I think there is a problem with that. What's the point of updatedatabase if it doesn't ensure that the schema is correct at the end ? I think the updatedatabase should just die here, let the admin fix the problem and re-run the updatedatabase process.
We cannot do anything else in this case. When there are orphan funds (not budget here), then there might be orders linked to this fund - we cannot just delete them. We need to leave it up to the library to fix this.
Our updatedatabase mechanism doesn't allow to stop and rerun (as far as I know?) and I think using the existing pattern with a warn is the best we can do here right now and it should not be put on this bug report to fix the underlying issue :)
Can't we just die ? In an atomic update file it won't stop the process because the file is eval'd, but once it is in updatedatabase.pl it can stop the process. And if we die before changing the Version in systempreferences, next time updatedatabase is run it will restart from where it died. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18050 --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I cannot attend the dev meeting this week, but I hope we can find a way to move forward with these kind of fixes. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18050 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=25078 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18050 --- Comment #14 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- As discussed in the dev meeting I think this bug should be unblocked whilst we work on the issues with updatedatabse discussed on bug 25078. We should sort out all the existing warn cases that fall into this category at the same time on that bug and not hold up an important improvement for many. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18050 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |agustinmoyano@theke.io --- Comment #15 from Agustín Moyano <agustinmoyano@theke.io> --- Great job Katrin.. if I may add a comment, in the atomic update, if there are some budget periods that were not found, instead of not adding the FK constraint, I would: 1. Create a temporary table.. something like _bug_18050_aqbudgets where I would copy the offending rows 2. Update aqbudgets.budget_period_id to null, add the FK constraint 3. Emit the warning that some budget periods where not found, and a copy of those rows where preserved in _bug_18050_aqbudgets table If it's ok to you, I can add a follow-up with those steps -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18050 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |8179 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 [Bug 8179] Receiving multiple order lines at once -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18050 --- Comment #16 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 111429 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111429&action=edit Bug 18050: (follow-up) Force adding FK constraint When there are inconsistent budget_period_id in aqbudgets this patch creates the table _bug_18050_aqbudgets with the original data, then sets the column to null and warns the user that there is inconsistent data. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18050 --- Comment #17 from Agustín Moyano <agustinmoyano@theke.io> --- Hi Katrin, I added the follow-up just in case you'd like to check it out when you've got time. Please feel free to remove it if you feel it's not ok. Thanks -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18050 --- Comment #18 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Agustín Moyano from comment #15)
Great job Katrin.. if I may add a comment, in the atomic update, if there are some budget periods that were not found, instead of not adding the FK constraint, I would:
1. Create a temporary table.. something like _bug_18050_aqbudgets where I would copy the offending rows
2. Update aqbudgets.budget_period_id to null, add the FK constraint
3. Emit the warning that some budget periods where not found, and a copy of those rows where preserved in _bug_18050_aqbudgets table
If it's ok to you, I can add a follow-up with those steps
Hi Augustin, it's not as simple as that I am afraid. If there are orphan aqbudgets, there could also be orders attached to them. And if there are orders, there could be linked items... the rabbit hole is deeper. Maybe another better approach could be to go the other direction: We add a aqbudgetperiods entry - this would also allow the library to deal with things in the GUI. I am not sure I am able to write that one, so if anyone beats me to it I'd be more than happy. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18050 --- Comment #19 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Augustin, I think I misunderstood initially what you are trying to do. I thought we were copying the data out and then removing it from the original table - but instead we set the id to NULL and just keep the former information. I will give this a test run. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18050 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18050 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111429|0 |1 is obsolete| | --- Comment #20 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 111712 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111712&action=edit Bug 18050: (follow-up) Force adding FK constraint When there are inconsistent budget_period_id in aqbudgets this patch creates the table _bug_18050_aqbudgets with the original data, then sets the column to null and warns the user that there is inconsistent data. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18050 --- Comment #21 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 111713 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111713&action=edit Bug 18050: (QA follow-up) Adjust conditions and make use of message text - When we run into invalid data, we use Augustin's suggested solution and copy the data into a separate table, setting the budget_period_id to NULL. - We amend the output using the new $message. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18050 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18050 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110169|0 |1 is obsolete| | Attachment #110170|0 |1 is obsolete| | Attachment #110171|0 |1 is obsolete| | Attachment #111712|0 |1 is obsolete| | Attachment #111713|0 |1 is obsolete| | --- Comment #22 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 111751 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111751&action=edit Bug 18050: Add FK constraint on aqbudgets.budget_period_id This adds a FK constraint on aqbudgets.budget_period_id so that a fund cannot be added with an invalid aqbudget.budget_period_id. We should not have funds that belong to no budget. In case we have, the update will be skipped and a note displayed. Part1: - Before applying the patch - Make sure you have a budget with some funds linked to it - You will have to change one of the funds to link to an invalid budget with SQL: UPDATE aqbudgets SET budget_period_id = 999 WHERE budget_id = max(budget_id); - Apply patch - Run updatedatabase - verify that you see the hint about 1 existing fund with invalid budget. - Repair your fund with SQL UPDATE aqbudgets SET budget_period_id = ... WHERE budget_id = max(budget_id); (... needs to be your existing budget_period_id) - Run updatedatabase again - verify it runs successfully now. - If you try to change the budget_period_id to a non-existing now with SQL, you will get a database error. The new FK doesn't permit it. Part 2: - Start fresh with the web installer, verify there are no errors on creating the database tables Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18050 --- Comment #23 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 111752 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111752&action=edit Bug 18050: [Do not push] Schema update Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18050 --- Comment #24 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 111753 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111753&action=edit Bug 18050: Add relation alias to schema Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18050 --- Comment #25 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 111754 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111754&action=edit Bug 18050: (follow-up) Force adding FK constraint When there are inconsistent budget_period_id in aqbudgets this patch creates the table _bug_18050_aqbudgets with the original data, then sets the column to null and warns the user that there is inconsistent data. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18050 --- Comment #26 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 111755 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111755&action=edit Bug 18050: (QA follow-up) Adjust conditions and make use of message text - When we run into invalid data, we use Augustin's suggested solution and copy the data into a separate table, setting the budget_period_id to NULL. - We amend the output using the new $message. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18050 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18050 --- Comment #27 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18050 --- Comment #28 from Mason James <mtj@kohaaloha.com> --- Created attachment 112529 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112529&action=edit Bug 18050: move aqbudgetperiods table before aqbudgets, to fix sql error 00:02:16.310 koha_1 | DBD::mysql::st execute failed: Can't create table `koha_kohadev`.`aqbudgets` (errno: 150 "Foreign key constraint is incorrectly formed") at /usr/share/perl5/DBIx/RunSQL.pm line 278, <$args{...}> line 1. 00:02:16.310 koha_1 | Something went wrong loading file /kohadevbox/koha/installer/data/mysql/kohastructure.sql ([SQL ERROR]: CREATE TABLE `aqbudgets` ( -- information related to Funds -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18050 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com Priority|P5 - low |P1 - high Severity|minor |blocker -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18050 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112529|0 |1 is obsolete| | --- Comment #29 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 112530 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112530&action=edit follow-up pushed to master. Thanks ! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18050 --- Comment #30 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Sorry for missing this and thx for the fix! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18050 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Version(s)|20.11.00 |20.11.00, 20.05.06 released in| | Status|Pushed to master |Pushed to stable --- Comment #31 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 20.05.x for 20.05.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18050 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha@catalyst.net.nz Version(s)|20.11.00, 20.05.06 |20.11.00, 20.05.06, released in| |19.11.12 Status|Pushed to stable |Pushed to oldstable --- Comment #32 from Aleisha Amohia <aleisha@catalyst.net.nz> --- backported to 19.11.x for 19.11.12 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18050 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Pushed to oldoldstable CC| |victor@tuxayo.net Version(s)|20.11.00, 20.05.06, |20.11.00, 20.05.06, released in|19.11.12 |19.11.12, 19.05.17 --- Comment #33 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Backported to 19.05.x branch for 19.05.17 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org