https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26601 Mark Hofstetter <koha@trust-box.at> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |koha@trust-box.at |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26601 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Mark, this already looks good! Some small things: - the subject line should always start with Bug XXXX: description of fix - a description of the problem should be included - and a step by step test plan Finally, once a patch is uploaded, make sure to switch the status to "Needs Signoff" as this will be the queue/search testers are looking at. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26601 Mark Hofstetter <koha@trust-box.at> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored Patch complexity|--- |Trivial patch --- Comment #3 from Mark Hofstetter <koha@trust-box.at> --- Hi, thanks for the feedback - do you mean the subject line of the patch I guess - or some other? Subject: [PATCH] Bug [26601]: [add utf8 output to text output of overdue_notices.pl] Shall I change anything now or is it OK for this one - I'll try to improve next time -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26601 --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 112112 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112112&action=edit Bug 26601: Add utf8 encoding to text output of overdue_notices.pl This patch sets the UTF8 encoding for output of overdue_notices.pl when outputting to txt. To test: 1/ Create ODUE text with a utf8 encoded characher, eg german umlauts <url>/cgi-bin/koha/tools/letter.pl?op=add_form&module=circulation&code=ODUE 2/ Run perl overdue_notices.pl -text [-library <library-name>] -test 3/ Confirm text now inludes properly encoded umlauts Sponsored-by: Styrian State Library Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26601 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- This works great, thanks Mark. I've signed off and updated the commit message to adhere to current guidelines for you.. now Katrin to finish the process by QAing :) Great to have you aboard. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26601 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112112|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 112124 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112124&action=edit Bug 26601: Add utf8 encoding to text output of overdue_notices.pl This patch sets the UTF8 encoding for output of overdue_notices.pl when outputting to txt. To test: 0/ Check out an item with due date yesterday (use specify due date) 1/ Create ODUE text with utf8 encoded characters, chinese characters, umlauts etc <url>/cgi-bin/koha/tools/letter.pl?op=add_form&module=circulation&code=ODUE 2/ Run perl overdue_notices.pl -text ./ 3/ Verify encoding in the generated text file is incorrect 4/ Apply patch and repeat 2/ 3/ Confirm text now inludes properly encoded characters Sponsored-by: Styrian State Library Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> With German umlauts on my system the editor still showed the characters correctly (probably guessing the right encoding). Using Chinese made the problem visible. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26601 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26601 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Congratulations Mark for your first patch pushed! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26601 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|20.11.00, 20.05.06 |20.11.00, 20.05.06, released in| |19.11.12 CC| |aleisha@catalyst.net.nz --- Comment #11 from Aleisha Amohia <aleisha@catalyst.net.nz> --- backported to 19.11.x for 19.11.12 -- You are receiving this mail because: You are watching all bug changes.