[Bug 38532] New: Show both credits and debits in patron_messages.inc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38532 Bug ID: 38532 Summary: Show both credits and debits in patron_messages.inc Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: andrew@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Currently patron_messages.inc gives an accurate but misleading overview of the patron's account in the patron overview. If the patron has at least 1 debit on their account with an amountoutstanding > 0, we show a message "Patron has outstanding charges of X," where X is the total of all outstanding debits. If the patron has no outstanding debits and at least 1 credit with an amountoutstanding < 0, we show a message of "Patron has a credit of X," where X is the total of all outstanding credits. If a patron has 1 debit of $1 and 2 credits of $1,000,000 each, Koha only tells you about the $1 debit. I suggest we reword the credit message to "Patron has outstanding credits of X" and make it show whenever there is one or more credit with an outstanding amount on the account. So patrons with both credits and debits on their account will show both messages. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38532 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |andrew@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38532 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38532 --- Comment #1 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 174992 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174992&action=edit Bug 38532: show both debits and credits in patron_messages To test: 1: Have patrons with a variety of credit/debit combinations 2: Confirm Koha shows the total debit amount in patron_messages if any debits exist 3: Confirm Koha does not show anything about creditd in patron_messages if any debits exist 4: Apply patch, restart_all 5: Confirm all patrons show both debit total and credit total -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38532 --- Comment #2 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- To be a bit more clear, these changes are to the messages marked with Attention on the patron checkout (/cgi-bin/koha/circ/circulation.pl) and details (/cgi-bin/koha/members/moremember.pl) screens. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38532 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38532 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@openfifth.c | |o.uk QA Contact|testopia@bugs.koha-communit |martin.renvoize@openfifth.c |y.org |o.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38532 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174992|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 181296 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181296&action=edit Bug 38532: show both debits and credits in patron_messages To test: 1: Have patrons with a variety of credit/debit combinations 2: Confirm Koha shows the total debit amount in patron_messages if any debits exist 3: Confirm Koha does not show anything about creditd in patron_messages if any debits exist 4: Apply patch, restart_all 5: Confirm all patrons show both debit total and credit total Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38532 --- Comment #4 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 181297 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181297&action=edit Bug 38532: (follow-up) Use Koha::Patron->account methods Update the patch to use Koha::Account and it's associated 'outstanding' methods to ensure we accurately portray outstanding amounts rather than 'all credits' totals. I also remove the unused `$balance` variable from the members/moremember.pl controller. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38532 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181297|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 181298 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181298&action=edit Bug 38532: (follow-up) Use Koha::Patron->account methods Update the patch to use Koha::Account and it's associated 'outstanding' methods to ensure we accurately portray outstanding amounts rather than 'all credits' totals. I also remove the unused `$balance` variable from the members/moremember.pl controller. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38532 --- Comment #6 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- You'll want to ensure AccountAutoReconcile is set to not reconcile to test these and ensure partial application of some credits against debts.. that way you'll get an accurate test of all combinations. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38532 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38532 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38532 --- Comment #7 from David Nind <david@davidnind.com> --- Created attachment 181562 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181562&action=edit Bug 38532: Show both debits and credits on patron's check out and details pages To test: 1: Have patrons with a variety of credit/debit combinations 2: Confirm Koha shows the total debit amount in patron_messages if any debits exist 3: Confirm Koha does not show anything about creditd in patron_messages if any debits exist 4: Apply patch, restart_all 5: Confirm all patrons show both debit total and credit total Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38532 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181298|0 |1 is obsolete| | --- Comment #8 from David Nind <david@davidnind.com> --- Created attachment 181563 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181563&action=edit Bug 38532: (follow-up) Use Koha::Patron->account methods Update the patch to use Koha::Account and it's associated 'outstanding' methods to ensure we accurately portray outstanding amounts rather than 'all credits' totals. I also remove the unused `$balance` variable from the members/moremember.pl controller. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38532 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181296|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38532 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes the patron check release notes| |out and details pages. They | |now show both charges and | |credits, for example: | |- | |Charges: Patron has | |outstanding charges of | |10.00. | |- Credits: Patron | |has outstanding credits of | |35.00 | | | |Previously, the | |pages only listed the | |charges - which could be | |misleading. --- Comment #9 from David Nind <david@davidnind.com> --- I edited the title of the first commit message. How I tested (using KTD): 1. Used Mary Burton as the patron. 2. Added some manual debits and credits: - Manual invoice 1: $5.00 - Manual invoice 2: $5.00 - Manual credit 1: $15.00 - Manual credit 2: $15.00 3. If you look at the patron's check out and details pages, they only show the total charges ($10 in this case): ==> Charges: Patron has outstanding charges of 10.00. 4. Apply the patches. 5. Re-check the pages, they now show: ==> Charges: Patron has outstanding charges of 10.00. Credits: Patron has outstanding creditsof 35.00 I'll add a follow-up to add a space for the credits message. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38532 --- Comment #10 from David Nind <david@davidnind.com> --- Created attachment 181564 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181564&action=edit Bug 38532: (follow-up) Add missing space for credits message Fix credit message to add a missing space: - Previously: Credits: Patron has outstanding creditsof - Now: Credits: Patron has outstanding credits of Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38532 --- Comment #11 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Nice one David, thanks for the thorough testing and follow-up. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38532 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181562|0 |1 is obsolete| | --- Comment #12 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 182011 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182011&action=edit Bug 38532: Show both debits and credits on patron's check out and details pages To test: 1: Have patrons with a variety of credit/debit combinations 2: Confirm Koha shows the total debit amount in patron_messages if any debits exist 3: Confirm Koha does not show anything about creditd in patron_messages if any debits exist 4: Apply patch, restart_all 5: Confirm all patrons show both debit total and credit total Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38532 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181563|0 |1 is obsolete| | --- Comment #13 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 182012 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182012&action=edit Bug 38532: (follow-up) Use Koha::Patron->account methods Update the patch to use Koha::Account and it's associated 'outstanding' methods to ensure we accurately portray outstanding amounts rather than 'all credits' totals. I also remove the unused `$balance` variable from the members/moremember.pl controller. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38532 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181564|0 |1 is obsolete| | --- Comment #14 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 182013 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182013&action=edit Bug 38532: (follow-up) Add missing space for credits message Fix credit message to add a missing space: - Previously: Credits: Patron has outstanding creditsof - Now: Credits: Patron has outstanding credits of Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38532 --- Comment #15 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- (In reply to David Nind from comment #10)
Created attachment 181564 [details] [review] Bug 38532: (follow-up) Add missing space for credits message
Fix credit message to add a missing space: - Previously: Credits: Patron has outstanding creditsof - Now: Credits: Patron has outstanding credits of
Signed-off-by: David Nind <david@davidnind.com>
Oh.. this is an odd one.. the tidy script nukes the space.. I've reworked your patch to add the space before the template toolkit condition and that appeases the QA script and tidy... little odd though.. I'll raise it with Jonathan. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38532 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38532 --- Comment #16 from David Nind <david@davidnind.com> --- (In reply to Martin Renvoize (ashimema) from comment #15)
(In reply to David Nind from comment #10)
Created attachment 181564 [details] [review] [review] Bug 38532: (follow-up) Add missing space for credits message
Fix credit message to add a missing space: - Previously: Credits: Patron has outstanding creditsof - Now: Credits: Patron has outstanding credits of
Signed-off-by: David Nind <david@davidnind.com>
Oh.. this is an odd one.. the tidy script nukes the space.. I've reworked your patch to add the space before the template toolkit condition and that appeases the QA script and tidy... little odd though.. I'll raise it with Jonathan.
THanks Martin! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38532 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Show both credits and |Show both credits and |debits in |debits on checkouts and |patron_messages.inc |details tabs in staff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38532 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38532 --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38532 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to main |Needs documenting --- Comment #18 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 24.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38532 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33228 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org