[Bug 35028] New: Add pre-registrations alert on staff interface main page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35028 Bug ID: 35028 Summary: Add pre-registrations alert on staff interface main page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Patrons Assignee: julian.maurice@biblibre.com Reporter: julian.maurice@biblibre.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35028 --- Comment #1 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 156820 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156820&action=edit Bug 35028: Add pre-registrations alert on staff interface main page Test plan: 1. Create patron category SELFREG 2. Enable PatronSelfRegistration and set PatronSelfRegistrationDefaultCategory to SELFREG 3. Go to OPAC, logout if needed, and create a new account. Remember the value you set for home library. 4. Go to staff interface, set the current library to the one you set in step 3. 5. Go to the staff interface main page. You should see at the bottom a message saying "Pre-registered patron(s) from: All libraries: 1 / <CURRENT LIBRARY>: 1" (numbers can vary if you already had self-registered patrons) 6. Click on both links and verify that it shows the correct patrons (or redirect to the patron detail page if there is only one) 7. Set the current library to another one (one that doesn't have self-registered patrons) 8. Go to the staff interface main page. You should see at the bottom a message saying "Pre-registered patron(s) from: All libraries: 1" (numbers can vary if you already had self-registered patrons) 9. Click on the link and verify that it shows the correct patrons (or redirect to the patron detail page if there is only one) Co-authored-by: Fridolin Somers <fridolin.somers@biblibre.com> Co-authored-by: Julian Maurice <julian.maurice@biblibre.com> Sponsored-by: Écoles nationales supérieures d'architecture (ENSA) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35028 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35028 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- This looks like it works well but it assumes a procedure for self-registrations which is not necessarily universal. It sounds like the sponsoring library's workflow requires that self-registrations are reviewed by staff, and perhaps the patron category is updated after review? By contrast, in my library we don't do a review of self-registrations which involves a category change. In our case these registrations are not "pre-registered" patrons, they're just patrons. Having a constantly increasing number displayed on the staff home page wouldn't be helpful. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35028 --- Comment #3 from Julian Maurice <julian.maurice@biblibre.com> --- Should I add a syspref then ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35028 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think a system preference sounds good in that case. I'd also change the terminology. We call the feature "self registration" and it's never appearing as pre-registered. - I'd suggest not to use a new term but stick to what we have already. Maybe: Self registrations: OPAC self registrations: -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35028 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35028 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add pre-registrations alert |Add OPAC self registrations |on staff interface main |alert on staff interface |page |main page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35028 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156820|0 |1 is obsolete| | --- Comment #5 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 175390 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175390&action=edit Bug 35028: Add pre-registrations alert on staff interface main page Test plan: 1. Create patron category SELFREG 2. Enable PatronSelfRegistration and set PatronSelfRegistrationDefaultCategory to SELFREG 3. Go to OPAC, logout if needed, and create a new account. Remember the value you set for home library. 4. Go to staff interface, set the current library to the one you set in step 3. 5. Go to the staff interface main page. You should see at the bottom a message saying "Pre-registered patron(s) from: All libraries: 1 / <CURRENT LIBRARY>: 1" (numbers can vary if you already had self-registered patrons) 6. Click on both links and verify that it shows the correct patrons (or redirect to the patron detail page if there is only one) 7. Set the current library to another one (one that doesn't have self-registered patrons) 8. Go to the staff interface main page. You should see at the bottom a message saying "Pre-registered patron(s) from: All libraries: 1" (numbers can vary if you already had self-registered patrons) 9. Click on the link and verify that it shows the correct patrons (or redirect to the patron detail page if there is only one) Co-authored-by: Fridolin Somers <fridolin.somers@biblibre.com> Co-authored-by: Julian Maurice <julian.maurice@biblibre.com> Sponsored-by: Écoles nationales supérieures d'architecture (ENSA) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35028 --- Comment #6 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 175391 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175391&action=edit Bug 35028: Add self-registrations alert on staff interface main page This adds a new system preference PatronSelfRegistrationAlert to enable or disable alerts (disabled by default) Test plan: 1. Create patron category SELFREG 2. Enable PatronSelfRegistration and set PatronSelfRegistrationDefaultCategory to SELFREG and PatronSelfRegistrationAlert to "Show" 3. Go to OPAC, logout if needed, and create a new account. Remember the value you set for home library. 4. Go to staff interface, set the current library to the one you set in step 3. 5. Go to the staff interface main page. You should see at the bottom a message saying "Self-registrations from: All libraries: 1 / <CURRENT LIBRARY>: 1" (numbers can vary if you already had self-registered patrons) 6. Click on both links and verify that it shows the correct patrons (or redirect to the patron detail page if there is only one) 7. Set the current library to another one (one that doesn't have self-registered patrons) 8. Go to the staff interface main page. You should see at the bottom a message saying "Self-registrations from: All libraries: 1" (numbers can vary if you already had self-registered patrons) 9. Click on the link and verify that it shows the correct patrons (or redirect to the patron detail page if there is only one) Co-authored-by: Fridolin Somers <fridolin.somers@biblibre.com> Co-authored-by: Julian Maurice <julian.maurice@biblibre.com> Sponsored-by: Écoles nationales supérieures d'architecture (ENSA) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35028 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #7 from Julian Maurice <julian.maurice@biblibre.com> --- Patch rebased + added a new system preference as suggested -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35028 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35028 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175390|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35028 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175391|0 |1 is obsolete| | --- Comment #8 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 175392 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175392&action=edit Bug 35028: Add self-registrations alert on staff interface main page This adds a new system preference PatronSelfRegistrationAlert to enable or disable alerts (disabled by default) Test plan: 1. Create patron category SELFREG 2. Enable PatronSelfRegistration and set PatronSelfRegistrationDefaultCategory to SELFREG and PatronSelfRegistrationAlert to "Show" 3. Go to OPAC, logout if needed, and create a new account. Remember the value you set for home library. 4. Go to staff interface, set the current library to the one you set in step 3. 5. Go to the staff interface main page. You should see at the bottom a message saying "Self-registrations from: All libraries: 1 / <CURRENT LIBRARY>: 1" (numbers can vary if you already had self-registered patrons) 6. Click on both links and verify that it shows the correct patrons (or redirect to the patron detail page if there is only one) 7. Set the current library to another one (one that doesn't have self-registered patrons) 8. Go to the staff interface main page. You should see at the bottom a message saying "Self-registrations from: All libraries: 1" (numbers can vary if you already had self-registered patrons) 9. Click on the link and verify that it shows the correct patrons (or redirect to the patron detail page if there is only one) Co-authored-by: Fridolin Somers <fridolin.somers@biblibre.com> Co-authored-by: Julian Maurice <julian.maurice@biblibre.com> Sponsored-by: Écoles nationales supérieures d'architecture (ENSA) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35028 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175392|0 |1 is obsolete| | --- Comment #9 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 175393 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175393&action=edit Bug 35028: Add self-registrations alert on staff interface main page This adds a new system preference PatronSelfRegistrationAlert to enable or disable alerts (disabled by default) Test plan: 1. Create patron category SELFREG 2. Enable PatronSelfRegistration and set PatronSelfRegistrationDefaultCategory to SELFREG and PatronSelfRegistrationAlert to "Show" 3. Go to OPAC, logout if needed, and create a new account. Remember the value you set for home library. 4. Go to staff interface, set the current library to the one you set in step 3. 5. Go to the staff interface main page. You should see at the bottom a message saying "Self-registrations from: All libraries: 1 / <CURRENT LIBRARY>: 1" (numbers can vary if you already had self-registered patrons) 6. Click on both links and verify that it shows the correct patrons (or redirect to the patron detail page if there is only one) 7. Set the current library to another one (one that doesn't have self-registered patrons) 8. Go to the staff interface main page. You should see at the bottom a message saying "Self-registrations from: All libraries: 1" (numbers can vary if you already had self-registered patrons) 9. Click on the link and verify that it shows the correct patrons (or redirect to the patron detail page if there is only one) Co-authored-by: Fridolin Somers <fridolin.somers@biblibre.com> Co-authored-by: Julian Maurice <julian.maurice@biblibre.com> Sponsored-by: Écoles nationales supérieures d'architecture (ENSA) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35028 William Lavoie <william.lavoie@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35028 William Lavoie <william.lavoie@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175393|0 |1 is obsolete| | --- Comment #10 from William Lavoie <william.lavoie@inLibro.com> --- Created attachment 176399 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176399&action=edit Bug 35028: Add self-registrations alert on staff interface main page This adds a new system preference PatronSelfRegistrationAlert to enable or disable alerts (disabled by default) Test plan: 1. Create patron category SELFREG 2. Enable PatronSelfRegistration and set PatronSelfRegistrationDefaultCategory to SELFREG and PatronSelfRegistrationAlert to "Show" 3. Go to OPAC, logout if needed, and create a new account. Remember the value you set for home library. 4. Go to staff interface, set the current library to the one you set in step 3. 5. Go to the staff interface main page. You should see at the bottom a message saying "Self-registrations from: All libraries: 1 / <CURRENT LIBRARY>: 1" (numbers can vary if you already had self-registered patrons) 6. Click on both links and verify that it shows the correct patrons (or redirect to the patron detail page if there is only one) 7. Set the current library to another one (one that doesn't have self-registered patrons) 8. Go to the staff interface main page. You should see at the bottom a message saying "Self-registrations from: All libraries: 1" (numbers can vary if you already had self-registered patrons) 9. Click on the link and verify that it shows the correct patrons (or redirect to the patron detail page if there is only one) Co-authored-by: Fridolin Somers <fridolin.somers@biblibre.com> Co-authored-by: Julian Maurice <julian.maurice@biblibre.com> Sponsored-by: Écoles nationales supérieures d'architecture (ENSA) Signed-off-by: William Lavoie <william.lavoie@inLibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35028 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #11 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Was using JS to do something like this previously. Nice to see it added for real. :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35028 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35028 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176399|0 |1 is obsolete| | --- Comment #12 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 176522 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176522&action=edit Bug 35028: Add self-registrations alert on staff interface main page This adds a new system preference PatronSelfRegistrationAlert to enable or disable alerts (disabled by default) Test plan: 1. Create patron category SELFREG 2. Enable PatronSelfRegistration and set PatronSelfRegistrationDefaultCategory to SELFREG and PatronSelfRegistrationAlert to "Show" 3. Go to OPAC, logout if needed, and create a new account. Remember the value you set for home library. 4. Go to staff interface, set the current library to the one you set in step 3. 5. Go to the staff interface main page. You should see at the bottom a message saying "Self-registrations from: All libraries: 1 / <CURRENT LIBRARY>: 1" (numbers can vary if you already had self-registered patrons) 6. Click on both links and verify that it shows the correct patrons (or redirect to the patron detail page if there is only one) 7. Set the current library to another one (one that doesn't have self-registered patrons) 8. Go to the staff interface main page. You should see at the bottom a message saying "Self-registrations from: All libraries: 1" (numbers can vary if you already had self-registered patrons) 9. Click on the link and verify that it shows the correct patrons (or redirect to the patron detail page if there is only one) Co-authored-by: Fridolin Somers <fridolin.somers@biblibre.com> Co-authored-by: Julian Maurice <julian.maurice@biblibre.com> Sponsored-by: Écoles nationales supérieures d'architecture (ENSA) Signed-off-by: William Lavoie <william.lavoie@inLibro.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35028 --- Comment #13 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 176523 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176523&action=edit Bug 35028: (QA follow-up) Fix file permission for DB update Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35028 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed QA Contact|testopia@bugs.koha-communit |lucas@bywatersolutions.com |y.org | --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Overall: I really like the idea of this and it's something libraries have definitely asked us about! Since there is a system preference to completely turn this off, I am going to push, but some questions remain: 1) Permission check We don't have a permission check. I feel that could lead to the situation where a staff user tries to resolve, but is then faced with a permission error trying to access the patron page as they are not allowed to view patron accounts of this library. Could we do better here? 2) New vs. updated installations Right now this feature has to always be explicitly activated. Should we install new installation with the feature defaulting to "Show"? 3) Database update Please check the updated skeleton.pl for future database atomicupdates. Also: this was missing any success message. Fixed before push. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35028 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35028 --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35028 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add OPAC self registrations |Add OPAC self-registration |alert on staff interface |alert on staff interface |main page |main page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35028 --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Please have a look at comment#15. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35028 --- Comment #17 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Katrin Fischer from comment #14)
Right now this feature has to always be explicitly activated. Should we install new installation with the feature defaulting to "Show"?
In my opinion the feature is only relevant if the library needs to take actions with new online registrations. My library's practice is to have online registrations be permanent, without an additional approval step. For us the link would be superfluous. My vote would be to leave it off by default. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35028 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |39927 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39927 [Bug 39927] Add permissions check to PatronSelfRegistrationAlert on home page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35028 --- Comment #18 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Katrin Fischer from comment #14)
1) Permission check
I have submitted a patch on Bug 39927 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35028 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed |Academy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35028 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting CC| |fridolin.somers@biblibre.co | |m --- Comment #19 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 24.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35028 Michelle Spinney <mspinney@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mspinney@clamsnet.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35028 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |Caroline Cyr La Rose contact| | Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/1148 Resolution|--- |FIXED CC| |caroline.cyr-la-rose@inlibr | |o.com Status|Needs documenting |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org